[00:01:16] (PS2) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [00:03:36] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [00:19:10] (PS2) Eileen: Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 [00:21:18] (CR) jerkins-bot: [V: -1] Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 (owner: Eileen) [00:51:16] (PS3) Eileen: Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 [00:53:19] (CR) jerkins-bot: [V: -1] Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 (owner: Eileen) [00:56:40] (PS4) Eileen: Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 [00:58:03] (PS3) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [00:58:43] (CR) jerkins-bot: [V: -1] Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 (owner: Eileen) [01:00:12] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:04:11] (PS4) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [01:04:40] hi folks! [01:05:12] ejegg: taking a break to eat soon - I'm pretty sure Jack's patch is correct but was trying to add custom field locally (via install) but struggling with some issue in the script [01:05:29] ok, i'll take a look [01:05:46] I have only been converting existing so far - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/518864/ [01:06:06] but on new install it borks - I think it's passing locally was a few tweaks ago [01:06:22] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:09:55] (PS5) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [01:10:10] ejegg: yeah I think I need to eat something & then look again [01:10:33] but this isn't really blocking Jack's patch - just my preferred method of testing it [01:11:18] hmm, that exception is pretty useless without a stack trace, huh? [01:11:59] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:19:00] bizarre [01:19:24] only difference I can see is that the new patch has 'weight' in the fields [01:20:27] ok, and the custom index logic [01:21:27] hmm, I think we might be getting 'weight' collisions since the weight is calculated independently in the outer loop [01:21:52] but it would be really weird to see the missing custom_group_id error for that [01:32:32] back [01:33:22] ok - I'm gonna db_update is_searchable [01:34:51] (PS6) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [01:36:57] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:39:16] (PS7) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [01:41:33] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:45:01] (PS8) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [01:47:13] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [02:05:44] jeez, this is kinda crazy-making, huh? [02:12:35] (CR) Ejegg: [C: +2] Adding India support with dlocal. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/518762 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [02:13:00] (Merged) jenkins-bot: Adding India support with dlocal. [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/518762 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [02:23:12] ejegg: yep [02:23:27] but I'll get there [03:15:28] (CR) Ejegg: [C: +1] "Looks fine to me! Eileen, want to confirm?" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [03:22:16] Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (Ejegg) @CCogdill_WMF your mentioning 'on hold' makes me think of one more thing. Since that can be a temporary status in Civi, we might want to drop it from the list of fiel... [04:03:18] (PS9) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [04:12:07] (PS10) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [04:52:28] (PS2) Fomafix: Remove redundant closure for all modules with packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) [04:55:40] (PS1) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [04:55:42] (PS1) Eileen: Add new employer name field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519174 (https://phabricator.wikimedia.org/T219558) [04:56:11] (PS5) Fomafix: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485514 [05:00:55] (CR) jerkins-bot: [V: -1] Add new employer name field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519174 (https://phabricator.wikimedia.org/T219558) (owner: Eileen) [05:00:58] (CR) jerkins-bot: [V: -1] Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen) [05:04:03] (PS2) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [05:09:22] (CR) jerkins-bot: [V: -1] Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen) [05:12:54] (PS3) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [05:19:20] (PS4) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [05:22:45] (Abandoned) Eileen: Add new employer name field [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519174 (https://phabricator.wikimedia.org/T219558) (owner: Eileen) [05:40:43] (CR) Eileen: [C: +2] "Yes +2 from me. I had a bit of a nightmare trying to add the field to test - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [05:41:55] (PS4) Eileen: Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [05:41:57] (PS1) Eileen: WIP -not yet working - reinstate test for [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 [05:43:08] (CR) jerkins-bot: [V: -1] Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [05:43:15] (PS5) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [05:44:33] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [05:47:35] (CR) jerkins-bot: [V: -1] WIP -not yet working - reinstate test for [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 (owner: Eileen) [05:50:27] (PS5) Eileen: Added support for mapping 'employer' value to civicrm custom field 'Employer_Name' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [10:15:13] Fundraising-Backlog, Wikimedia-Fundraising: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (jrobell) [10:29:38] (CR) Jgleeson: "it looks like jenkins won't merge this until we fix the missing PHP extension issue introduced here https://gerrit.wikimedia.org/r/#/c/wik" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519151 (https://phabricator.wikimedia.org/T219558) (owner: Jgleeson) [12:39:18] jgleeson I can submit that patch [13:19:58] hey ejegg|away, the custom field patch or the php-intl patch? [13:29:23] Fundraising-Backlog, Wikimedia-Fundraising, LDAP-Access-Requests: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (Pcoombe) I added the LDAP access tag which should alert the right people. `Cdenes` needs to be added to the `wmf` group please :) [13:44:57] Fundraising Sprint Greps of Wrath, Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, and 6 others: Payments wiki form variant with employer field - https://phabricator.wikimedia.org/T219558 (Jgreen) >>! In T21955... [13:57:11] Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (CCogdill_WMF) Sounds great, thank you! :) [14:20:06] ejegg|away, I just realised you merged the patch manually [14:20:15] I wasn't aware we could do that but I guess it makes sense now [14:58:04] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, and 2 others: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (DStrine) [14:59:54] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, and 2 others: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (DStrine) I added SRE access and analytics tags as I think one of them is appropriate for this task. Please let us... [15:03:07] cstone: any interest in a meeting about the TY email process? [15:03:28] like how they are created? [15:03:42] yeah, we're just starting: https://meet.google.com/cbo-fitj-zqs [15:30:51] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, Operations: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (RobH) [15:31:38] fr-tech any news for scrum of scrums? [15:31:49] ejegg: hey nothing here, thanks! [15:32:17] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, Operations: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (RobH) LDAP requests are in #ldap-access-requests not #sre-access-requests (which is for shell), so just cleanin... [15:32:32] oh well, that was a fun exercise. xDebug stopped working and throwing some new error I've never seen before which took me here https://bugs.xdebug.org/bug_view_page.php?bug_id=00001401 which suggested that the IDE port was blocked so I looked at what was currently listening on the xDebug client port as it was '22226/java' which is running from PHPStorm... I added rust support to PHPStorm recently to play with libracoin locally [15:32:32] but it looks like java has since snatched by xdebug client port! [15:32:37] non from me ejegg [15:33:26] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, Operations: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (Nuria) The only thing needed for turnilo access is to be in nda group (if Camile is an employee she can be adde... [15:57:58] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (AndyRussG) a:AndyRussG [16:00:14] Fundraising-Backlog, Wikimedia-Fundraising, Analytics, LDAP-Access-Requests, Operations: Turnilo access for Camille de Nes (Advancement) - https://phabricator.wikimedia.org/T226614 (jrobell) thank you for clarifying that @Nuria . I can confirm that Camille is a staff number with a req number.... [16:17:44] (CR) AndyRussG: Fix mistaken opt-out of records created during export (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg) [16:24:51] (PS5) Ejegg: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) [16:26:52] (CR) Ejegg: "Thanks for the CR AndyRussG. Fixed in PS5." (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg) [16:48:50] ejegg: so the update_table.sql is what runs to perform all the steps mentioned here? https://phabricator.wikimedia.org/T223935#5283109 Or is there more to it? [16:49:30] AndyRussG: yep! [16:49:37] There's a python wrapper [16:49:48] that basically just reads that file and runs the queries one at a time [16:50:08] then does one big select from the export view to a mailing list file [16:50:32] and another big select from the _excluded table to the unsubscribes file [16:51:30] ejegg: ah ok where is the rapper? [16:51:45] *wrapper [16:51:57] update.py in that same directory [16:52:10] okok thx! [16:52:12] runs the queries from the sql file [16:52:25] and then export.py dumps the stuff to files [16:53:33] hmmm ok [16:56:57] ejegg: why is the python wrapper needed? just wondering... couldn't we just execute the SQL as SQL? [17:02:44] AndyRussG: we like the logging of timing that the python wrapper gives us [17:21:14] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches 2019-06 and 2019-07 - https://phabricator.wikimedia.org/T226655 (AndyRussG) [17:39:04] Fundraising-Backlog: Re-issue Civi cert for guillaume - https://phabricator.wikimedia.org/T226656 (gpaumier) [17:39:45] Fundraising-Backlog, fundraising-tech-ops: Re-issue Civi cert for guillaume - https://phabricator.wikimedia.org/T226656 (DStrine) [18:47:37] Fundraising Sprint Hansel and grep -l, Fundraising Sprint It Came From Out of Scope, Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, and 3 others: Civi dedupe: merge screen upgrades - https://phabricator.wikimedia.org/T217903 (MBeat33) Thank you [18:48:35] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: Upgrade permissions level for DS agent - https://phabricator.wikimedia.org/T224314 (MBeat33) So far so good w/permissions, thank you. [18:48:58] (PS2) Cstone: Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) [18:50:17] (CR) jerkins-bot: [V: -1] Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [19:52:44] jgleeson: would you have a chance to take a look at the silverpop export patch? https://gerrit.wikimedia.org/r/519079 [19:53:55] sure will take a look now [19:54:12] thank you! [19:54:44] np, sorry for not jumping on that sooner [20:02:02] (CR) Ejegg: "wat... PHP Fatal error: require(): Failed opening required '/workspace/src/vendor/composer/../jetbrains/phpstorm-stubs/PhpStormStubsMap.p" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:02:31] cstone looks like the CI goofiness has spread to DonationInterface tests [20:02:42] Fundraising-Backlog: Zendesk API Research - https://phabricator.wikimedia.org/T226425 (MBeat33) Some considerations from fr-tech/DS checkin today: * what specific info would come into Civi from ZD? * how to handle attachments (useful: error triage screenshots or not: suspicious executables) * how to handle... [20:02:44] oh yeah I was going to ask if that was related ejegg [20:03:06] want to ask release engineering for help over in #wikimedia-releng? [20:04:23] was there a way to rerun them too? [20:04:41] yep, you can just add a gerrit comment with the word 'recheck' [20:05:06] Fundraising-Backlog, fundraising-tech-ops: Re-issue Civi cert for guillaume - https://phabricator.wikimedia.org/T226656 (Jgreen) a:Jeff_G→Jgreen [20:05:36] ooh, mediawiki core composer.json does have a dev requirement for jetbrains/phpstorm-stubs [20:06:10] we could get rid of that for our branch, i guess [20:07:58] (CR) Cstone: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:09:16] (CR) jerkins-bot: [V: -1] Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:09:55] hah well guess that wasnt a one time thing [20:10:36] time to pester releng, i guess [20:11:22] fwiw, that patch looks good to me [20:13:10] ok [20:14:01] (PS3) Ejegg: Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:14:07] (rebase) [20:14:11] (CR) Ejegg: [C: +2] Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:15:07] (Merged) jenkins-bot: Adding India support with dlocal. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/518746 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:16:20] why did that test suite skip over the failing one? [20:26:39] cstone: so there are (at least) two different sets of tests for each repo [20:26:55] the normal test suite, which runs when a new patch set gets pushed or updated [20:27:15] and the gate-and-submit suite, which runs when someone gives the patch a C+2 [20:27:31] looks like we don't have the docker test in our gate-and-submit set [20:28:09] and because I C+2'ed it immediately after I rebased it, the other test suite didn't have a change to fail it first [20:29:58] ah i see [20:32:04] cstone: want to try your hand at getting rid of the stubs dev-dependency in our mediawiki branch? [20:32:44] sure [20:39:51] ejegg is it just removing them from the composer.json or are there other steps? [20:40:40] oh hey, it's just composer.json [20:40:58] I forgot we're ignoring composer.lock now [20:48:19] (CR) XenoRyet: [C: +2] Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [20:48:59] actually, should I bother +2ing all these if our CI is borked right now? [20:49:15] (Merged) jenkins-bot: Variants starting with 'upsell' mean recurrable payment [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514344 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [20:49:28] or it could just merge [20:50:00] (CR) XenoRyet: [C: +2] Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [20:50:55] (Merged) jenkins-bot: Add supportsRecurringUpsell and showRecurringUpsell [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/514351 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [20:52:44] (CR) XenoRyet: [C: +2] Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:54:03] (Merged) jenkins-bot: Common base for result pages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515246 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:55:47] (CR) XenoRyet: [C: +2] Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:55:57] Rockin! [20:56:15] Yea, the whole patch string looks good, and everything is rendering right. [20:56:26] (Merged) jenkins-bot: Add 'variant' to session fields, add test [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516454 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:57:03] (CR) XenoRyet: [C: +2] Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:58:46] (Merged) jenkins-bot: Consult session for variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517149 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:58:56] (CR) XenoRyet: [C: +2] Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:59:10] (CR) XenoRyet: [C: +2] Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [20:59:54] (Merged) jenkins-bot: Move ui_modules handling to Mustache class [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517150 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [21:00:07] (Merged) jenkins-bot: Render recurring upsell (USD only) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/515114 (https://phabricator.wikimedia.org/T216562) (owner: Ejegg) [21:00:36] There you go ejegg, merged all the way up to the rendering patch. [21:00:43] Imma go get some lunch. [21:00:45] ejegg, did you have any issues running tox on vagrant? [21:01:19] SQL looks good but when trying to check out the text, realised tox isn't in $PATH and when added doesn't run as expected [21:01:48] jgleeson: ahh, two silly things [21:02:01] so, I just run nosetests-2.7 [21:02:18] and then there's the db - need to have a db called 'test' set up [21:02:34] I think with user 'test' and no pw [21:03:24] or locally change the connection details in the test file [21:03:54] oh jeez, Jenkins detection? [21:04:04] well that's fun [21:04:39] ?? [21:04:59] line 22-25 of test_update.py [21:05:08] if 'EXECUTOR_NUMBER' in os.environ: [21:05:13] # We're running under Jenkins. Assume things. [21:05:17] ah [21:05:32] ok so just skip getting tox to work? [21:05:39] I'm getting some weird lock errors [21:05:42] lock file /vagrant/srv/fundraising-tools/.tox/discover/log/.lock present, will block until released [21:05:59] weird [21:06:15] lemme see if I can run under tox [21:06:27] checking perms to see if that's an issue [21:06:29] still doing things like a caveman, installing needed libs globally [21:06:37] and running nosetests in the bare dir [21:07:53] hmm problem installing mysql-python [21:07:58] EnvironmentError: mysql_config not found [21:08:13] but it seems to barrel ahead [21:08:42] ok, then glake8 seems to complain about its own formatting :P [21:09:25] why do I have flake8 on the top level there? that's not in the repo... [21:09:51] tidying up a bit... [21:11:03] (PS1) Cstone: Remove jetbrains/phpstorm-stubs from dev dependencies. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/519288 [21:11:25] ejegg did I put that on the right branch [21:12:03] looks like it from the wikibugs summary up there [21:12:40] ok cool [21:12:47] (CR) Ejegg: [C: +2] "Thanks!" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/519288 (owner: Cstone) [21:14:18] (Merged) jenkins-bot: Remove jetbrains/phpstorm-stubs from dev dependencies. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/519288 (owner: Cstone) [21:14:56] jgleeson shoot, I still can't run tox locally [21:15:08] dying trying to build the mysql extension [21:15:12] ah no worries, I'll just use nose directly [21:17:07] going to go see a bit more of this city, folks. I'll keep an eye out for IRC pings and will have the computer with me. [21:17:21] enjoy! [21:19:51] (CR) jenkins-bot: Remove jetbrains/phpstorm-stubs from dev dependencies. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/519288 (owner: Cstone) [21:28:49] (CR) jenkins-bot: Remove jetbrains/phpstorm-stubs from dev dependencies. [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/519288 (owner: Cstone) [21:38:01] if anyone has review space it would be good to get this merged - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/518864/ it re-orgs the adding of custom fields in the import & then the add of the new employer name field builds off that [21:39:58] (CR) Eileen: Move remaining wmf_donor fields over to update_custom_fields (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [21:42:11] jgleeson: you haven't done more on the test for the new field? I can finish up on https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/519176/ [21:50:53] eileen, I started looking at it but my xdebug setup is broken so got distracted trying to fix that [21:51:36] sigh - I spend much of yesterday fixing the fact debugging didn't work via drush (now using xdebug.remote_autostart) [21:51:47] anyway I think I can fix this fairly easily [21:55:18] yeah I have a demo of xdebug with ndubuisui tomorrow so I really need to fix it lol! [21:55:49] I also need to install vscode [21:56:02] as I suggested testing that out as he uses it [22:01:51] (CR) XenoRyet: [C: +2] Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517153 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg) [22:03:05] (Merged) jenkins-bot: Disable personal info fields when opening iframes [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/517153 (https://phabricator.wikimedia.org/T201962) (owner: Ejegg) [22:03:34] (CR) XenoRyet: [C: +2] Remove traces of old tracker [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516453 (owner: Ejegg) [22:04:29] (Merged) jenkins-bot: Remove traces of old tracker [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/516453 (owner: Ejegg) [22:12:17] (CR) Jgleeson: [C: +2] "Looks good to me. SQL looks ok and tests are passing." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg) [22:12:55] (Merged) jenkins-bot: Fix mistaken opt-out of records created during export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/519079 (https://phabricator.wikimedia.org/T223935) (owner: Ejegg) [22:18:14] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/519302 [22:32:27] (PS11) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [22:32:29] (PS6) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [22:32:31] (PS2) Eileen: Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 [22:37:15] Fundraising-Backlog: Fix fundraising-tools local setup issues for vagrant - https://phabricator.wikimedia.org/T226674 (jgleeson) [22:56:12] (PS2) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [22:57:28] (CR) jerkins-bot: [V: -1] Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [23:08:02] I got the test working for the new Employer Name field [23:09:37] (Abandoned) Eileen: Add calculated fields to update script [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518870 (owner: Eileen) [23:10:51] (PS3) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [23:24:00] (PS2) Eileen: Add new fields for calendar year totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972)