[06:01:49] (PS1) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [06:02:06] (CR) jerkins-bot: [V: -1] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:02:16] (CR) jerkins-bot: [V: -1] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:02:22] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1148 processes [07:07:22] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 410 processes [07:18:35] fundraising-tech-ops: Prometheus/Grafana snapshots for long term storage - https://phabricator.wikimedia.org/T198876 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:37] Fundraising-Backlog, fundraising-tech-ops, Epic: Overhaul /srv/br - https://phabricator.wikimedia.org/T178953 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:39] Fundraising-Backlog: Get composer.json in crm deployable - https://phabricator.wikimedia.org/T117898 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:41] Fundraising Sprint Snoop (Dogg|Lion), Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Move shared client-side functions to an mw.something module - https://phabricator.wikimedia.org/T111436 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:43] Fundraising-Backlog, fundraising-tech-ops, Patch-For-Review: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:45] Fundraising-Backlog, Fundraising-Backlog-Old: Create Appeal option group and link to Direct Mail Appeal on dev - https://phabricator.wikimedia.org/T106105 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:47] fundraising-tech-ops, Operations: Authentication for grafana - https://phabricator.wikimedia.org/T198648 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:49] fundraising-tech-ops, Operations: Long term storage for frack prometheus data - https://phabricator.wikimedia.org/T175738 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:52] fundraising-tech-ops, Operations: rack/setup/install Prometeuse/Grafana host frmon2001 for fr-tech - https://phabricator.wikimedia.org/T196476 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:55] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use Milkshake for DonationInterface translations - https://phabricator.wikimedia.org/T138375 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:18:58] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Use symfony/http-foundation in DonationInterface - https://phabricator.wikimedia.org/T138374 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:01] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Epic: EPIC: mediawikiless-donationinterface - https://phabricator.wikimedia.org/T137586 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:04] Fundraising Dash, Fundraising Sprint Miles Davis, Fundraising-Backlog: Create "A/B testing" board in Dash - https://phabricator.wikimedia.org/T98927 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:06] Fundraising Dash, Fundraising Sprint Miles Davis: "Get Test" in A/B testing header - https://phabricator.wikimedia.org/T89990 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:08] Fundraising Sprint William Shatner, Fundraising Sprint X-Ray Spex, Fundraising Sprint Yo La Tengo, Fundraising Sprint Zapp, and 3 others: [EPIC] Build Frig: tools to help update our deployment branches - https://phabricator.wikimedia.org/T116820 (Aklapper) a:cwdent→None (Resetting assigne... [07:19:10] Fundraising Dash, Fundraising-Backlog, Fundraising-Backlog-Old: Create sandbox site for Dash - https://phabricator.wikimedia.org/T87809 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:12] Fundraising Dash, Fundraising-Backlog: Search and return results for Campaign name - https://phabricator.wikimedia.org/T89980 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:19:14] fundraising-tech-ops, observability, Epic: [Epic] overhaul fundraising cluster monitoring - https://phabricator.wikimedia.org/T91508 (Aklapper) a:cwdent→None (Resetting assignee as @cwdent has left WMF) [07:22:53] (PS1) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [07:23:06] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:23:10] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:23:26] (PS22) AndyRussG: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [07:29:19] (PS16) AndyRussG: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [07:30:12] (CR) AndyRussG: "PS16: Manually rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [07:32:42] (PS9) AndyRussG: Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) [07:33:12] (CR) AndyRussG: "PS9: Manually rebased" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:33:27] (PS2) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [07:35:25] (CR) jerkins-bot: [V: -1] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:35:29] (CR) jerkins-bot: [V: -1] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:43:34] (PS3) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [07:51:06] (PS2) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [07:53:06] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:54:25] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:57:52] (PS3) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [08:14:30] (PS1) AndyRussG: Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) [08:26:56] (PS1) AndyRussG: Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) [08:29:59] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner preview: don't show live preview section for users without CN rights - https://phabricator.wikimedia.org/T226961 (AndyRussG) [08:30:11] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice banner preview: don't show live preview section for users without CN rights - https://phabricator.wikimedia.org/T226961 (AndyRussG) [08:32:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Don't show live preview section for users without CN rights - https://phabricator.wikimedia.org/T226961 (AndyRussG) [08:37:36] Hello gentlemen [08:37:50] Can I have a review on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/519750/ ? [08:38:01] thanks [08:39:20] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (AndyRussG) [08:41:29] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog, and 3 others: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) Patches submitted to fix almost every... [08:44:15] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog, and 2 others: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) [09:15:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Error handling for banner preview background calls - https://phabricator.wikimedia.org/T226967 (AndyRussG) [11:37:16] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1006 processes [11:47:22] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1033 processes [11:52:20] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1301 processes [12:12:22] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 454 processes [12:30:47] Fundraising-Backlog, fundraising-tech-ops: fix silverpop database updater not to crush the master database with long queries - https://phabricator.wikimedia.org/T157600 (Jgreen) Open→Resolved a:Jgreen [12:32:22] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1101 processes [12:37:22] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1054 processes [12:52:22] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1325 processes [13:07:20] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 212 processes [13:16:48] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change in payments form styling, broken on mobile - https://phabricator.wikimedia.org/T226991 (Pcoombe) p:Triage→Unbreak! [13:19:27] fr-tech - just making sure you see the above UBN. I think it just needs a recent change reverting [13:32:53] thanks pcoombe! I just tried reverting the commit you pointed out locally and it doesn't seem to be fixing the issue for me (using an iphone user agent) [13:33:56] but i'm not seeing any other recent css changes so i can see what commit would make the most sense as the one to cause it.. [13:41:00] hmm trying to make sure the commit applied it's changes [13:45:39] oh shoot, i should have tested that one more [13:48:34] hey ejegg|away i'm trying to test the revert locally but i'm not seeing removing those changes fix the problem [13:48:40] ejegg i mean ^^ [13:49:27] just getting situated here, will test it too in a few min [13:49:34] ok [14:00:30] mepps ahh, when pcoombe says 'on-wiki styles' in the ticket he may be referring to the prod-specific css delivered by the appeal [14:00:53] ahhhhh ejegg [14:00:53] gotcha [14:01:16] although i can see the bug locally too [14:01:25] oh? [14:01:27] at least i think i see the bug [14:01:32] ok, looking now [14:01:44] yep, me too [14:01:54] mepps: Did the revert fix the issue on desktop at all? [14:01:55] gonna try a 'git bisect' [14:02:14] (i.e. remove the blue border) [14:03:42] There is some oddness with the CSS which makes it tricky to test on mobile, you need to test with the correct "device-width". Just changing the UA won't work. Way I normally do it is the Chrome device toolbar [14:04:38] yep, pcoombe git bisect points to that same commit [14:04:44] reverting [14:05:30] ejegg when you revert locally do you stop seeing the bug? i'm stilling seeing but i could be doing something wrong [14:05:43] ejegg: I did think there might be something delivered with the appeal on-wiki, but have been looking for it and struggling to find the source [14:05:46] mepps reverting locally fixes it for me [14:05:53] okay cool ejegg [14:05:57] are you doing a force-reload? [14:06:01] browsers love caching css [14:06:20] in FF, i need to do ctrl-F5 to get the new css [14:06:45] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) Hey @AndyRussG - did you want the #security-team to have a look at this? If so, we should get a request into [[ https://p... [14:10:05] yeah i'm doing a private browser ejegg [14:10:09] (PS1) Ejegg: Revert "Reduce selector specificity" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520020 [14:10:32] (CR) Mepps: [C: +2] Revert "Reduce selector specificity" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520020 (owner: Ejegg) [14:11:30] (Merged) jenkins-bot: Revert "Reduce selector specificity" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520020 (owner: Ejegg) [14:11:52] whew, gerrit connection from down here is super slow. I typed git review and it took 4 minutes to submit [14:12:04] guess I'd better run tests locally :) [14:16:10] hmm if i +2 before the build it doesn't build first? i didn't realize that [14:17:02] how's that? [14:17:29] i may have been confused by your comment ejegg [14:19:13] Oh, I just meant it took 4 minutes to post the PS to gerrit [14:20:45] (PS4) Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [14:22:00] (CR) Ejegg: "PS4: Rebased from Montevideo :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) (owner: Ejegg) [14:22:26] from here ^^^ [14:23:59] though connection to my vps seems fast - lemme try reaching gerrit via that [14:29:47] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/520022 [14:29:54] definitely better [14:30:01] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/520022 (owner: Ejegg) [14:36:02] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/520022 (owner: Ejegg) [14:38:44] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520023 [14:41:30] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520023 (owner: Ejegg) [14:42:57] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520023 (owner: Ejegg) [14:45:45] !log updated payments-wiki from 86381aeeff to 5f974d2386 [14:45:49] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:45:55] pcoombe ok, that's rolled back [14:47:03] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520023 (owner: Ejegg) [14:50:06] Wonderful, thanks ejegg ! [14:50:28] Looks good to me now [14:51:57] great. sorry for not testing that one thoroughly before deploying [14:57:56] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Change in payments form styling, broken on mobile - https://phabricator.wikimedia.org/T226991 (Ejegg) Open→Resolved a:Ejegg Sorry, we should have tested that patch more. It's rolled back now. [14:59:21] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520023 (owner: Ejegg) [16:16:43] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (AndyRussG) [16:18:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (AndyRussG) >>! In T226963#5296429, @sbassett wrote: > Hey @AndyRussG - did you want the #security-team to have a look a... [16:19:55] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (AndyRussG) [16:22:35] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog, and 2 others: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (AndyRussG) Also: {T226967} [17:57:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, and 2 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (Jdlrobson) Having this bug open with the title "Banner/CentralNotice should be child of... [19:19:48] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) p:Triage→Normal [19:39:59] Fundraising-Backlog: Turn off failmail for silverpop timeouts. - https://phabricator.wikimedia.org/T226747 (XenoRyet) [19:51:36] Fundraising Sprint Men In Slack, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Adding fields to Activity Search page - https://phabricator.wikimedia.org/T226560 (XenoRyet) [19:55:32] Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog, FR-dlocal, Epic: Create form for India in dlocal using new required fields - https://phabricator.wikimedia.org/T225639 (XenoRyet) [20:00:17] Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising-Backlog: Rename Field in IBM export - https://phabricator.wikimedia.org/T225544 (XenoRyet) [20:05:38] Fundraising Sprint Men In Slack, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Turn on Redis, Functional locks - https://phabricator.wikimedia.org/T222002 (XenoRyet) [20:57:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) Just to confirm, these patch sets: `Rename and move update preview button (519974) Rename link to preview sav... [22:34:20] (PS3) Ejegg: Recurring conversion: wire up close and 'no' buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519544 (https://phabricator.wikimedia.org/T216560) [22:34:22] (PS3) Ejegg: Log line for showing recurring conversion ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) [22:35:20] (PS5) Ejegg: Base class for Donation APIs: step one [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519582 (https://phabricator.wikimedia.org/T216560) [22:35:22] (PS5) Ejegg: Donation API base: make $adapter a class property [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519583 (https://phabricator.wikimedia.org/T216560) [22:35:25] (PS6) Ejegg: Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) [22:51:16] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate turning off smarty pre-compile - https://phabricator.wikimedia.org/T227039 (Reedy)