[01:19:39] (PS5) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [01:20:21] (CR) jerkins-bot: [V: -1] Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [01:31:26] (PS6) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [01:32:05] (CR) jerkins-bot: [V: -1] Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [02:12:15] (PS7) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [02:36:12] (PS1) Ejegg: Fix NOT NULL warnings in silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520664 [02:42:20] (PS1) Eileen: Port additional functions to create multiple custom fields efficiently (ish) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 [02:42:22] (PS1) Eileen: e-notice fix & unit test [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520666 [02:55:10] (PS4) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [02:55:12] (PS3) Eileen: Add new fields for calendar year totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972) [02:55:14] (PS1) Eileen: Update field add [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 [02:58:17] (CR) jerkins-bot: [V: -1] Update field add [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (owner: Eileen) [03:39:01] (PS1) Ejegg: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) [03:40:11] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Ejegg) [03:40:46] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (Ejegg) [03:41:44] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Ejegg) a:Ejegg [03:42:05] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (Ejegg) p:Triage→Normal a:Ejegg [03:43:58] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (Ejegg) Turned out not to be so bad with the 2to3 utility. Not everything has been tested yet! Silverpop export and paypal... [05:19:51] (Abandoned) Eileen: [REF] extraction of a function to build the sql for changing a custom field. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/519321 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:20:25] (Abandoned) AndyRussG: [WIP] Update regex for new timestamp format in log lines [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/520476 (https://phabricator.wikimedia.org/T227203) (owner: AndyRussG) [05:26:13] (PS2) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) [05:26:15] (PS7) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) [05:27:20] (PS3) Eileen: Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 [05:28:13] (CR) jerkins-bot: [V: -1] Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen) [05:28:15] (CR) jerkins-bot: [V: -1] Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 (owner: Eileen) [05:28:26] (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:30:35] (PS12) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) [05:32:57] (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:41:08] (CR) AndyRussG: [C: +2] flake8 fixes [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/520345 (owner: Ejegg) [05:41:26] (Merged) jenkins-bot: flake8 fixes [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/520345 (owner: Ejegg) [05:41:37] (CR) AndyRussG: [C: +2] Allow 'Z' at end of timestamp [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/520344 (https://phabricator.wikimedia.org/T227203) (owner: Ejegg) [05:41:54] (Merged) jenkins-bot: Allow 'Z' at end of timestamp [wikimedia/fundraising/tools/DjangoBannerStats] - https://gerrit.wikimedia.org/r/520344 (https://phabricator.wikimedia.org/T227203) (owner: Ejegg) [05:42:29] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: banner and landing page data ingress (pgehres) is broken - https://phabricator.wikimedia.org/T227203 (AndyRussG) a:Ejegg [07:28:58] (CR) Hashar: [C: +1] "Thank you Ejegg! That slightly speed up the test run :-]" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/517397 (https://phabricator.wikimedia.org/T225496) (owner: Hashar) [15:56:41] !log temporarily disabled banner impressions loader job [15:56:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:02:02] !log DjangoBannerStats revision changed from 02be6cbb74 to 8965666e17 [16:02:06] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:55:31] (CR) Krinkle: "Hm. how come that ESLint is passing and yet we have not yet told ESLint to parse these as module scope (instead of script scope). In other" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) (owner: Fomafix) [17:03:04] !log re-enabled banner impressions loader job [17:03:08] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:07:55] ejegg|afk: ^ done! (I think....) [19:17:04] thanks AndyRussG ! [19:18:37] ejegg thank u!! [19:35:34] (CR) Ejegg: [C: -1] "Looks good, and should work for the use case at hand." (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 (owner: Eileen) [19:36:07] (CR) Ejegg: [C: +2] e-notice fix & unit test [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520666 (owner: Eileen) [19:36:54] Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface, Recurring-Donations: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585 (aaron) Can this be closed now? [19:40:28] (CR) Ejegg: [C: -1] "Let's have the consumer be able to deal with messages missing one or more of the utm_ fields. Also, might be a bit less repetitive to use " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520315 (owner: XenoRyet) [19:46:47] (CR) Fomafix: "Yes, this is strange. I prepared already .eslintrc.json files per directory, but did not include it in PS1 to test ESLint." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) (owner: Fomafix) [19:49:03] (CR) Ejegg: [C: +2] Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [19:50:46] (CR) Ejegg: [C: +2] Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [19:58:30] ejegg: thanks ^ ! Yee there's a lot of other stuff below that, too... You can refer to the bug (especially some of the older comments) for more details, too https://phabricator.wikimedia.org/T225101 [19:58:45] pls lmk if you have questions :) [19:59:06] yep yep, for whatever reason i'm looking through them from the top down [20:17:07] Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface, Recurring-Donations: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585 (awight) Open→Resolved a:awight I'd say we can just reopen it if this ever happens a... [20:22:08] AndyRussG: at the end of Special:BannerLoader you've removed the bannerName, campaign, and category from the json-encoded array [20:22:34] guessing you determined those to be unused by the JS? [20:22:56] ejegg: yeah probably makes sense to review in that order [20:23:11] ejegg: ah no, they're just unused! [20:23:26] Aaaah I think I forgot to document that in the commit message, probably should do so [20:23:28] if so, it looks like you can also delete lines 205-210 since those are just to get the category [20:44:21] ejegg: ahhh ooops thanks! missed that bit, nice catch! [20:44:56] the patch looks really good. must have been satisfying to write! [20:52:12] ejegg: ahhrgh thanks it was kinda like ripping of a band-aid that's been there for years [20:52:32] Also took a while to decide just how to do it [20:52:50] thx also! [20:56:00] brr, this cafe is super cold. might relocate again soon [22:09:08] (PS2) Eileen: Port additional functions to create multiple custom fields efficiently (ish) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 [22:09:42] (CR) Eileen: "thanks ejegg - I've made chances in response to your comments" (2 comments) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 (owner: Eileen) [22:52:01] (CR) Ejegg: [C: +2] "This looks great!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 (owner: Eileen) [22:57:19] (Merged) jenkins-bot: Port additional functions to create multiple custom fields efficiently (ish) [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520665 (owner: Eileen) [23:19:59] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: banner and landing page data ingress (pgehres) is broken - https://phabricator.wikimedia.org/T227203 (AndyRussG) The job should be processing correctly now. We also backfilled the files that weren't processed properly due to this...