[00:34:53] (PS2) Ejegg: e-notice fix & unit test [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/520666 (owner: Eileen) [01:04:51] (CR) Ejegg: [C: +2] "Thanks, Ed! Tested locally and all the bugs exist with or without this patch." [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/493229 (owner: Esanders) [01:05:31] (Merged) jenkins-bot: build: Switch from jshint/jscs to eslint [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/493229 (owner: Esanders) [01:10:43] Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Ingenico: possible text edit to new ingenico form error message - https://phabricator.wikimedia.org/T212168 (Ejegg) [01:18:51] Fundraising Sprint Window dressing is mostly olive oil, Fundraising-Backlog: Send Endowment receipts through regular thank you email system - https://phabricator.wikimedia.org/T211230 (Ejegg) I was asked to go back and estimate this. Just wanted to update it with the current situation - as of May 14th 20... [01:23:03] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint XML ate my homework, Fundraising-Backlog, Fr-Ingenico-integration_2017-18, Patch-For-Review: currency mismatch between Ingenico Connect & Civi - https://phabricator.wikimedia.org/T211024 (Ejegg) [01:24:38] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, and 3 others: CentralNotice protects CentralN... - https://phabricator.wikimedia.org/T210983 [01:27:12] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: test ext.centralNotice.kvStore fails sometimes - https://phabricator.wikimedia.org/T208570 (Ejegg) [01:28:43] Fundraising Sprint Sasquatches can't find us either, Fundraising-Backlog, Patch-For-Review: Deploy new English thank you email content and subject line - https://phabricator.wikimedia.org/T205880 (Ejegg) [01:29:46] Fundraising Sprint Dinosaur Cookies co-existed with Gingerbread People, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Prefer Express Checkout for payment_method paypal in gateway form chooser - https://phabricator.wikimedia.org/T187512 (Ejegg) [01:30:21] ohh estimation [01:33:06] heh, yep [01:33:12] a walk down memory lane! [01:33:45] jeez, have i really only done 20 min of it? [01:33:52] makes me really antsy for some reason [01:44:17] hhmmm [01:44:43] I haven't tried it beyond what we did in meetings [01:54:12] g'night! [14:14:14] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (mepps) Notes from tech-talk review: We like tests! The Global variable isn't necessarily needed, or a good idea. Good comments. Why filtered... [14:14:47] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (mepps) @AndyRussG @Ejegg Above is what I remembered offhand today. [14:56:46] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (Ejegg) I think the most important bit is to get the recordImpression calls right, so each page load only has one beacon request. Besides th... [15:21:11] PROBLEM - check_puppetrun on frbast1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 5 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:23:17] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:25:11] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:25:11] PROBLEM - check_puppetrun on frdata1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:26:07] RECOVERY - check_puppetrun on frbast1001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [15:28:11] PROBLEM - check_puppetrun on frbast2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 12 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:30:11] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 14 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:30:11] PROBLEM - check_puppetrun on frdata1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 58 seconds ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:33:11] RECOVERY - check_puppetrun on frbast2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [15:35:11] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [15:35:11] PROBLEM - check_puppetrun on frdata1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 4 minutes ago with 1 failures. Failed resources (up to 3 shown): User[mshaver] [15:40:11] RECOVERY - check_puppetrun on frdata1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [16:14:17] (PS4) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [16:15:30] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (mepps) Thanks @Ejegg! @AndyRussG anything to add? @DStrine I assume we don't have hours left to fix this. Should we be doing it ourselves? [16:23:31] Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (AndyRussG) >>! In T226344#5309308, @mepps wrote: > Thanks @Ejegg! @AndyRussG anything to add? @DStrine I assume we don't have hours left to f... [16:25:56] (PS2) AndyRussG: Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) [16:28:26] (PS2) AndyRussG: Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) [16:29:04] ejegg: ^ updated and rebased banner preview patches as per your suggestion [16:50:20] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (mepps) @Ejegg What is the best way to test this change? [18:30:02] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Ejegg) The silverpop unit tests exercise the database connection. The only trick there is that you need a db named 'test... [19:17:04] (PS8) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [19:17:07] (PS2) Ejegg: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) [19:17:36] (CR) jerkins-bot: [V: -1] Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [19:17:39] (CR) jerkins-bot: [V: -1] SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [19:19:31] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Ejegg) You can also just plain run the silverpop update and export. Copy the silverpop_export.yaml.example to ~/.fundrai... [19:20:21] weird: 19:17:33 fatal: remote error: access denied or repository not exported: /wikimedia/fundraising/tools [19:21:27] (CR) Ejegg: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [19:22:37] ok, guess that's transitory [19:23:44] Fundraising Sprint Men In Slack, Fundraising-Backlog, Patch-For-Review: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (Ejegg) Tested the audit downloader, and it seems to work too. [19:23:55] (CR) Ejegg: "recheck" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [19:31:11] (CR) Ejegg: [C: +2] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [19:48:00] ejegg: thanks! ^ [19:48:11] sure thing! [19:48:35] just updating my local master-branch wiki to smoke test the 'refactor' patch [19:48:56] but just looking at the code I can't see anything to comment on [19:49:32] ejegg: hmmmm there must be at least some nits sprinkled about.......... [19:49:59] ejegg: also I guess let's hold off on a final +2 that merges it all until the security review is performed? [19:50:53] yep, for sure, i wasn't planning to +2 the underlying contractor-written ones [19:51:12] ooh, what's this error? Call to undefined method LanguageEn::truncate() [19:51:24] trying to load SpecialCentralNoticeBanners [19:52:26] lemme see, i must not have something updated [19:52:59] ohh, old extensions [20:02:33] Fundraising-Backlog: Mysql Pgehres query not rendering Unique Clicks for Japan - https://phabricator.wikimedia.org/T227210 (KHaggard) Update: Looks like mysql pgehres is able to pull the clicks data today. Not sure what has changed, but the query no longer produces an empty set. If it helps any, the issue... [20:13:17] oh yeah that's the ULS I think [20:15:01] Fundraising-Backlog: Mysql Pgehres query not rendering Unique Clicks for Japan - https://phabricator.wikimedia.org/T227210 (Ejegg) Open→Resolved a:Ejegg Hi @KHaggard, It wasn't just the Japan email send - pgehres didn't get any updates for about 3 days (see T227203). We fill that database using... [20:15:37] got it working now, just need to disable the non-working geoip module [20:15:50] or rather, got it all updated now [20:24:01] ok, yeah, still serving banners [20:24:31] sequence looks good [20:59:31] preview stuff works well [21:04:35] (CR) Ejegg: [C: +2] "A definite improvement!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [21:27:08] Fundraising-Backlog: Add more silverpop data to Civi (query names, segment data) - https://phabricator.wikimedia.org/T227363 (CCogdill_WMF) p:Triage→High [21:28:19] Fundraising-Backlog: Add more silverpop data to Civi (query names, query criteria, segment data) - https://phabricator.wikimedia.org/T227363 (CCogdill_WMF)