[08:15:17] <wikibugs>	 (CR) AndyRussG: "Here are some initial review notes!" (8 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka)
[08:19:01] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (AndyRussG) Hi! I just posted the following on the Gerrit change (includes the above plus a few more thoughts):   > Here are some initial revi...
[15:16:43] <cstone>	 hey fr-tech has anyone ran the civi smashpig unit tests lately? I'm getting a bunch of errors locally
[15:17:26] <jgleeson>	 cstone, are you using a filter within phpunit to run those tests?
[15:19:20] <cstone>	 yeah the --group SmashPig
[15:19:43] <jgleeson>	 I'll give them a try at my end
[15:21:07] <jgleeson>	 hmm for me, those tests pass
[15:21:11] <jgleeson>	 12 tests right?
[15:21:28] <cstone>	 yep 12
[15:22:08] <cstone>	 ok thanks for the sanity check
[15:23:00] <jgleeson>	 do the failures share a common issue? sometimes civi tests fail in the vagrant space due to missing dependencies on the VM. It's on our todo list to fix those
[15:24:39] <cstone>	 yeah I think they are all related to the queue->pop and its returning null
[15:28:29] <cstone>	 jgleeson: do you think rebuilding the box would fix it?
[15:28:58] <jgleeson>	 I'm just looking over the tests which interact with the queues to see if there's anything obvious
[15:29:28] <jgleeson>	 ummm, maybe but feels like it might be a change related to your queue setup
[15:29:42] <jgleeson>	 from what I can see, the tests check that queue is empty
[15:31:57] <jgleeson>	 I wonder if manually clearing the queue will help
[15:32:14] <jgleeson>	 cstone, have you done much with `redis-cli` on the vagrant vm?
[15:32:57] <cstone>	 I have a little
[15:33:07] <jgleeson>	 once you're in the redis-cli, you can run `keys *` to see the lists present
[15:33:59] <jgleeson>	 if you see 'donations', and you don't have any pending donations locally you want to keep, you can issue `del donations`
[15:37:03] <jgleeson>	 or, if you wanna keep any donations you can issue `rename donations donations_bk`
[15:40:09] <cstone>	 hmm yeah I don't see anything weird in there
[15:40:41] <cstone>	 and I think my original response of queue->pop was off a line, I see those null checks now
[15:42:17] <cstone>	 my tests are failing on $contributionMessage checks after that null queue check
[15:43:25] <jgleeson>	 SourceFields::removeFromMessage($contributionMessage);
[15:43:27] <jgleeson>	 that line?
[15:44:31] <cstone>	 yeah im looking into that one now, the errors are either that the $contributionMessage is null or that the [date] from it is wrong
[15:54:42] <ejegg|away>	 hmm, i thought we set those tests up to use the sqlite in-memory queue backend
[15:54:57] <ejegg|away>	 is sqlite installed?
[16:00:46] <wikibugs>	 Fundraising-Backlog: Communication: Employer Name field is returning blank values - https://phabricator.wikimedia.org/T227091 (DStrine) @NNichols Please let us know if the last comment works. If you have a method to search, I feel we can close this.
[16:14:28] <jgleeson>	 ah, I'd forgotten that ejegg|away !
[16:14:44] <jgleeson>	 I didn't see anything in the setup method
[16:17:27] <jgleeson>	 I see now that we call $globalConfig = TestingGlobalConfiguration::create();
[16:17:39] <jgleeson>	 within setup which I'm guessng wires up our test queue backend
[16:19:36] <jgleeson>	 yup connection_string: 'sqlite::memory:'
[16:49:05] <wikibugs>	 (CR) XenoRyet: "The civi API is able to handle missing fields on it's own.  The current code behaves properly with some or all of the fields missing." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520315 (owner: XenoRyet)
[16:50:56] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: list communication fields in civi - https://phabricator.wikimedia.org/T227498 (DStrine)
[16:53:02] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all data types in the email export to IBM - https://phabricator.wikimedia.org/T227499 (DStrine)
[16:53:50] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: List all data types in the import from IBM to civi - https://phabricator.wikimedia.org/T227500 (DStrine)
[18:28:08] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: TargetSmart Civi import - https://phabricator.wikimedia.org/T227513 (LeanneS)
[18:39:18] <wikibugs>	 Fundraising-Backlog, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (DStrine) @CCogdill_WMF if you get this email to like 80% of the way we could start. We basically only need to know which numbers you wish to show...
[18:45:13] <wikibugs>	 Fundraising-Backlog, Epic: [EPIC] Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (DStrine) @jrobell @Ppena @CCogdill_WMF  This is a massive change that might not be doable in the foreseeable future. Depending on scope it might be m...
[18:55:36] <wikibugs>	 Fundraising-Backlog, Epic: [EPIC] Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (CCogdill_WMF) Cool, when would it make sense to discuss this further? Happy to outline our expectations and see what might work within the constraint...
[19:44:16] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: TargetSmart Civi import - https://phabricator.wikimedia.org/T227513 (DStrine)
[19:45:43] <wikibugs>	 Fundraising-Backlog: Investigate: Add more silverpop data to Civi (query names, query criteria, segment data) - https://phabricator.wikimedia.org/T227363 (DStrine)
[19:46:26] <wikibugs>	 (CR) Aaron Schulz: [C: +2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521044 (owner: D3r1ck01)
[19:49:37] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: list communication fields in civi - https://phabricator.wikimedia.org/T227498 (DStrine)
[19:50:38] <wikibugs>	 (Merged) jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521044 (owner: D3r1ck01)
[19:56:54] <wikibugs>	 (CR) jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521044 (owner: D3r1ck01)
[20:03:10] <wikibugs>	 (PS1) Eileen: Civi submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521344
[20:04:55] <wikibugs>	 (CR) Eileen: [C: +2] Civi submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521344 (owner: Eileen)
[20:10:14] <wikibugs>	 (Merged) jenkins-bot: Civi submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521344 (owner: Eileen)
[20:12:44] <wikibugs>	 (PS4) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[20:14:43] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[20:18:35] <wikibugs>	 (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/521096 (owner: L10n-bot)
[20:23:13] <wikibugs>	 (PS5) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[20:24:28] <wikibugs>	 (PS8) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558)
[20:24:30] <wikibugs>	 (PS13) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972)
[20:24:32] <wikibugs>	 (PS4) Eileen: Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176
[20:25:16] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[20:26:50] <wikibugs>	 (CR) jerkins-bot: [V: -1] Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen)
[20:26:54] <wikibugs>	 (CR) jerkins-bot: [V: -1] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[20:26:57] <wikibugs>	 (CR) jerkins-bot: [V: -1] Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 (owner: Eileen)
[20:31:14] <eileen>	 XenoRyet: hmm - the tests are failing on that row of field add patches but I'll sort it in next coupla hours
[20:31:46] <XenoRyet>	 Cool, thanks for the heads up.  I've got some stuff I can do in the meantime.
[20:52:33] <wikibugs>	 (PS6) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[20:54:38] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[21:11:20] <wikibugs>	 (CR) Krinkle: "Could you try to update eslint/grunt and rebuild package-lock, and see if it makes more sense after that?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) (owner: Fomafix)
[21:18:00] <wikibugs>	 (PS7) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[21:20:05] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[21:49:50] <wikibugs>	 (PS8) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[21:51:57] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[22:06:19] <wikibugs>	 (PS9) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[22:06:42] <wikibugs>	 (PS10) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[22:07:43] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[22:11:55] <eileen>	 XenoRyet: looks like CI has a problem - https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/119/console
[22:12:30] <XenoRyet>	 Well that's unfortunate
[22:16:34] <wikibugs>	 (PS11) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[22:17:36] <eileen>	 @XenoRyet I feel like Elliott has some tricks when CI borks but not sure what - I think he logs into it
[22:17:54] <XenoRyet>	 Yea, I'm not sure what he does with that either.
[22:18:03] <XenoRyet>	 Heh, guess we should do a tech-talk on it when he gets back.
[22:18:27] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[22:19:50] <eileen>	 it got further this time - yay
[22:20:47] <wikibugs>	 Fundraising-Backlog, fundraising-tech-ops: Request Civi CRM certificate for new user Evelyn Martin - https://phabricator.wikimedia.org/T227528 (Aklapper) @Emartin-ctr: Assuming this task is about #Fundraising-Backlog or #fundraising-tech-ops hence adding project tags, so others can find this task under t...
[22:26:16] <wikibugs>	 (PS1) Eileen: Fix check on currentOptionGroupID leading to failure in install [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/521365
[22:27:10] <eileen>	 XenoRyet: I think this will fix the test fails on the custom field stuff https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/521365/ - pretty simple - just don't try to do the query if you don't have data
[22:27:24] <XenoRyet>	 looking
[22:35:41] <ejegg|away>	 the login trock only works for the old php 5 tests
[22:35:56] <ejegg|away>	 the docker tests are a bit trickier to debug
[22:36:53] <ejegg|away>	 you have to log im to the host box and clone the docker image before it gets destroyed, then log into the clone
[22:37:19] <wikibugs>	 (CR) XenoRyet: [C: +2] Fix check on currentOptionGroupID leading to failure in install [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/521365 (owner: Eileen)
[22:37:22] <eileen>	 well it's kinda working again now - but yeah maybe tech talk & we can document it
[22:45:19] <wikibugs>	 (Merged) jenkins-bot: Fix check on currentOptionGroupID leading to failure in install [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/521365 (owner: Eileen)
[22:52:49] <wikibugs>	 (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521369
[22:53:01] <wikibugs>	 (CR) Eileen: [C: +2] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521369 (owner: Eileen)
[22:53:57] <wikibugs>	 (CR) jerkins-bot: [V: -1] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521369 (owner: Eileen)
[22:54:32] <wikibugs>	 (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521369 (owner: Eileen)
[23:01:39] <wikibugs>	 (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521369 (owner: Eileen)
[23:09:38] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:14:23] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:14:46] <wikibugs>	 (PS12) Eileen: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972)
[23:26:06] <eileen>	 XenoRyet: woot - it passed https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/520667/
[23:26:16] <wikibugs>	 (PS9) Eileen: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558)
[23:26:52] <wikibugs>	 (PS14) Eileen: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972)
[23:27:11] <wikibugs>	 (PS5) Eileen: Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176
[23:33:07] <eileen>	 XenoRyet: ok - when you are ready to add your field that chain of custom field add commits should set the scene for you to add yours in
[23:33:37] <XenoRyet>	 Cool.  I'll try to get some review in on those and get mine written.  Thanks
[23:33:52] <eileen>	 basically add onto the array at the bottom here -https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/519173/9/sites/all/modules/wmf_civicrm/update_custom_fields.php
[23:34:11] <XenoRyet>	 Good times, should be easy enough.
[23:41:56] <wikibugs>	 Fundraising-Backlog: Communication: Employer Name field is returning blank values - https://phabricator.wikimedia.org/T227091 (NNichols) @mepps Not Empty is really slow but thank you for giving me the option!   @DStrine good to close.
[23:44:28] <wikibugs>	 (CR) XenoRyet: [C: +2] Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:44:59] <wikibugs>	 (CR) XenoRyet: [C: +2] Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen)
[23:46:19] <wikibugs>	 (CR) XenoRyet: [C: +2] Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:46:57] <wikibugs>	 (CR) XenoRyet: [C: +2] Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 (owner: Eileen)
[23:48:44] <wikibugs>	 Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, and 2 others: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (CCogdill_WMF)...
[23:50:13] <wikibugs>	 (Merged) jenkins-bot: Update field add mechanism [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520667 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:50:50] <wikibugs>	 (Merged) jenkins-bot: Partial convert of Communications custom group to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519173 (https://phabricator.wikimedia.org/T219558) (owner: Eileen)
[23:51:52] <wikibugs>	 (Merged) jenkins-bot: Move remaining wmf_donor fields over to update_custom_fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518864 (https://phabricator.wikimedia.org/T170972) (owner: Eileen)
[23:52:22] <wikibugs>	 (Merged) jenkins-bot: Unit test for writing employer name to custom field. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/519176 (owner: Eileen)
[23:57:42] <wikibugs>	 Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (CCogdill_WMF) Ah, duplicating my comment from T223935 here:  Last week, we performed the process I outlined above in silverpop and purged anyone from our Master Suppression...