[00:59:09] (PS4) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [01:00:23] (PS4) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [01:00:25] (PS1) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [01:03:46] (CR) jerkins-bot: [V: -1] Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:06:16] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:06:37] (CR) jerkins-bot: [V: -1] Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [01:46:32] (PS5) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [01:50:08] (CR) MaxSem: [C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/521669 (owner: Jforrester) [01:51:13] (CR) MaxSem: [C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/521643 (owner: Jforrester) [01:51:20] (CR) MaxSem: [C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/521642 (owner: Jforrester) [01:52:30] (CR) MaxSem: [C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/521620 (owner: Jforrester) [01:52:44] (PS6) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [01:53:08] (PS5) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [02:04:10] (Merged) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/521669 (owner: Jforrester) [02:04:24] (Merged) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/521643 (owner: Jforrester) [02:04:26] (Merged) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/521642 (owner: Jforrester) [02:17:06] (Merged) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ContributionTracking] - https://gerrit.wikimedia.org/r/521620 (owner: Jforrester) [02:21:51] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [02:25:11] (PS2) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [02:25:39] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [02:31:03] (CR) jerkins-bot: [V: -1] Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:03:24] (PS6) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [03:03:26] (PS1) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) [03:05:44] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:05:46] (CR) jerkins-bot: [V: -1] Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:11:18] (PS2) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) [03:13:33] (CR) jerkins-bot: [V: -1] Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:18:25] (PS3) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) [03:23:07] (CR) jerkins-bot: [V: -1] Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:30:43] (PS4) Eileen: Add new fields for calendar year totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972) [03:34:30] (PS4) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) [03:38:27] (PS4) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 [03:42:02] (PS7) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [03:42:36] (PS7) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [03:47:45] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [04:16:05] (PS8) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [04:21:03] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [04:54:51] (PS9) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [05:00:26] (CR) jerkins-bot: [V: -1] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:02:13] (PS10) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [05:05:12] (PS11) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) [05:06:27] (PS1) Eileen: Get rid of history on do_not_solicit, simplify [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521807 [05:09:04] (CR) jerkins-bot: [V: -1] Get rid of history on do_not_solicit, simplify [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521807 (owner: Eileen) [05:18:07] (PS7) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [05:18:08] (PS3) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [05:23:56] (CR) jerkins-bot: [V: -1] Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:24:43] (PS2) Eileen: Get rid of history on do_not_solicit, simplify [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521807 [05:25:13] (Abandoned) Eileen: Add new fields for calendar year totals [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518867 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [05:27:29] (PS8) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [05:27:31] (PS4) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [05:27:33] (PS1) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [05:37:22] (PS2) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [05:39:13] (CR) AndyRussG: Banner preview: JS improvements (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [05:42:47] (PS6) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [05:48:01] (PS9) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [05:48:02] (PS5) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [05:48:04] (PS1) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [05:53:39] (CR) jerkins-bot: [V: -1] Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 (owner: Eileen) [05:56:59] (CR) AndyRussG: Banner preview: JS improvements (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [05:57:37] (PS11) AndyRussG: Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) [06:00:27] (CR) AndyRussG: Banner preview: JS improvements (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:02:01] (PS5) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [06:15:41] (PS2) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [06:17:41] (PS12) AndyRussG: Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) [06:20:31] (PS6) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [06:20:49] (PS7) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [06:21:01] (PS4) AndyRussG: Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) [06:21:08] (PS4) AndyRussG: Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) [06:24:40] (CR) AndyRussG: Banner preview: JS improvements (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:26:05] (CR) AndyRussG: "Overview of recent new PSs: 12 is the same as 10, since the comments on 10 were already taken care of further down the chain of Gerrit cha" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:28:43] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) I added the first donation amount fields - which was... [06:31:48] (PS3) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [06:53:01] (PS10) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [06:53:03] (PS6) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [06:53:05] (PS4) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [06:53:08] (PS1) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [07:01:08] (PS5) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) [07:01:10] (PS5) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 [07:01:12] (PS8) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [07:01:14] (PS3) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [07:01:16] (PS11) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [07:01:18] (PS7) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) [07:01:20] (PS5) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [07:01:22] (PS2) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [07:09:36] (PS6) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 [07:09:38] (PS9) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [07:09:40] (PS4) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [07:09:42] (PS12) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [07:09:44] (PS6) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [07:09:46] (PS3) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [07:09:48] (PS1) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521824 (https://phabricator.wikimedia.org/T170972) [07:09:50] (PS1) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521825 (https://phabricator.wikimedia.org/T170972) [07:09:55] (Abandoned) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521393 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [07:10:33] (Abandoned) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521802 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [07:19:53] (PS2) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521825 (https://phabricator.wikimedia.org/T170972) [07:19:55] (PS7) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [07:19:57] (PS4) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [07:21:23] (PS2) Eileen: testing only - do not merge - civicase [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/517175 [07:21:34] (PS3) Eileen: WIP ptp reeports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/517916 [10:28:18] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Release-Engineering-Team-TODO, Browser-Tests, Release-Engineering-Team (Unit & Int & System Tooling): Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955 (zeljkofilipin) [14:50:24] (PS1) Zfilipin: Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) [14:54:26] hi fr-tech! [14:54:38] hey ejegg :) [14:54:56] (CR) jerkins-bot: [V: -1] Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [14:55:22] ejegg jgleeson hi...! [14:55:32] hi AndyRussG jgleeson_ [14:55:51] brb coffee! [15:06:52] (CR) Ejegg: [C: +2] "Oops, I should have noticed that since I'm reviewing in reverse order. Thanks, this looks great now!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [15:10:24] cstone: want to do that SmashPig composer package version bump? [15:12:08] sure [15:12:37] oh, we don't have that documented anywhere, do we? [15:14:38] hmm yeah if it is I don't know where [15:15:08] I'll add a section at https://www.mediawiki.org/wiki/Fundraising_tech/SmashPig [15:17:30] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (mepps) @AndyRussG @DStrine Maybe we should take this off the board until we get a new patch? [15:25:33] fr-tech, what news for scrum of scrums? [15:25:57] what news from the riddermark! [15:26:01] cstone ok, new section added! Want to see if it works? [15:26:21] :) [15:26:23] hah ok [15:28:00] (CR) Jgleeson: [C: +2] Move object cache to separate submodule [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/516062 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [15:31:13] ejegg nothing here, thanks!! [15:34:33] sorry, nothing from me eithe ejegg [15:43:58] (CR) Jgleeson: [C: +2] "I was wondering whether is_valid_language_code() could be moved to within the language class but I can see it's also called outside of the" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/516061 (owner: AndyRussG) [15:47:41] AndyRussG, quick question regards https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/FRUEC/+/515382/ [15:48:12] jgleeson mmmm? [15:48:30] sorry trying to find the code online to show [15:48:53] (not that patch specifically, but the config regex value it relates to) [15:49:55] AndyRussG, https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/FRUEC/+/455869/6/config_example.yaml@25 [15:50:13] that pattern is looking for 'sampled' I think? [15:51:10] is that pattern searching WITHIN the contents of the log files? [15:52:47] jgleeson on sec [15:52:51] sorry [15:52:56] this might be a better way to ask, https://regex101.com/r/STBasB/1 [15:53:01] *one sec [15:58:29] ahhhh AndyRussG I've worked it out [15:58:32] it's in the filename itself [15:58:45] that you capture the sampled rate [15:58:55] and only for CN events [15:58:59] sorry for the confusion! [15:59:12] jgleeson_: oh yeah right [15:59:14] yes [15:59:26] and it's a config setting in case the filename format changes [15:59:31] and yes, only for CN events [15:59:37] yup, nice touch! [15:59:59] (Sorry, I had misplaced my glasses and needed my glasses to find them.) [16:00:07] (CR) Jgleeson: [C: +2] Fix inline doc [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515382 (owner: AndyRussG) [16:00:11] ha! [16:00:18] Thanks for digging in so thoroughly!!! [16:01:23] (CR) Jgleeson: [C: +2] Tweak README.md and config_example.yaml [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515376 (owner: AndyRussG) [16:02:20] (CR) Jgleeson: [C: +2] Fix logic for finding config file [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515373 (owner: AndyRussG) [16:02:35] (CR) Jgleeson: [C: +2] Remove unused import in controller.py [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/469251 (owner: AndyRussG) [16:05:46] (CR) Jgleeson: [C: +2] Minor improvements in create_tables.sql [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/458565 (owner: AndyRussG) [16:06:17] popping out to pick up oscar! [16:11:08] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (DStrine) They have been able to turn around patches within a week. I feel like we'd just be pullin... [16:14:37] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (DStrine) p:Low→High Hi all, We would like to deploy this as soon as possible. Does anyone in security need mor... [16:24:00] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) @DStrine @AndyRussG - I don't think anyone's been able to look at this as the #security-team is currently ver... [16:43:20] (CR) SBassett: [C: +1] "This particular patch set seems fine from a security standpoint, though not much to see here unless I'm missing something. Looks to be mo" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [16:51:18] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) **Update:** Comment and +1 added to [[ https://gerrit.wikimedia.org/r/519974 | r519974 ]]. Still having a lo... [17:10:07] (CR) Jgleeson: [C: +2] Remove testing field (for banner previews) from CNEvents [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/463110 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [17:15:32] cstone what was missing from the composer version instructions? [17:15:59] just the origin in the push I added it in [17:16:19] or i didnt publish it hah its there now [17:16:24] Fundraising-Backlog: Create new custom fields on Prospect Tab - https://phabricator.wikimedia.org/T227687 (NNichols) [17:16:27] oh huh, I don't see it yet. unsaved? [17:16:43] oh now i see it [17:16:45] yeah it was unsaved it should be there now [17:16:46] thanks! [17:29:08] Fundraising-Backlog, FR-Email: List all emails that may have been mistakenly opted out - https://phabricator.wikimedia.org/T226571 (Ejegg) Open→Resolved a:Ejegg Sounds good to me! Let's make a new task for finding the old opt-outs and getting them into Civi. [17:29:43] Fundraising Sprint James Bond: Licensed to Share, Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, and 3 others: SPIKE: Unsubscribes import decreasing in size over 2 days - https://phabricator.wikimedia.org/T223935 (Ejegg) Open... [17:48:03] (CR) SBassett: Banner live preview (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [17:48:33] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (DStrine) Thanks so much. I understand having to balance priorities. CentralNotice had a few vulnerabilities that were f... [17:54:16] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Re-create automatic browser tests on node selenium - https://phabricator.wikimedia.org/T223634 (Jdforrester-WMF) [17:56:34] (CR) Jforrester: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [18:12:13] (PS4) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:12:21] (CR) jerkins-bot: [V: -1] Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [18:12:23] (CR) jerkins-bot: [V: -1] Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [18:18:11] (CR) SBassett: Refactor BannerRenderer and SpecialBannerLoader (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [18:22:19] (PS5) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:28:25] (CR) SBassett: Banner preview: JS improvements (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [18:31:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Re-create automatic browser tests on node selenium - https://phabricator.wikimedia.org/T223634 (AndyRussG) @Jdforrester-WMF Thanks!!! [18:34:30] (CR) Jforrester: [C: +1] Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [19:41:35] (PS1) Eileen: reverse main & other donors in deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521932 [20:00:38] (PS1) Ejegg: Fix missing spaces in recurring TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521937 [20:00:50] cstone: I think that'll fix the ty text ^^^ [20:01:21] just a copyedit, doesn't actually change the regexes to output things that way [20:01:43] yeah i was looking at that was it the regex that put it on the new line? [20:02:01] i think maybe the regexes always did that [20:02:20] because before we only had whole paragraphs inside the recurring conditional [20:02:56] anyway, lemme test that [20:03:37] hmm, also i'm not sure what cancelation text is missing for krobinson [20:04:09] it sure looks like it's still there in the template [20:04:15] ok, a test should clear that up [20:04:17] i was looking at that too the link is still there just moved to the end of the sentence [20:19:35] cstone ok, i tested that one on staging and all look good so far [20:24:02] hmm - have my things been posting on here [20:25:44] hah I had an old one from may that had the space too, at least in the English version [20:26:59] so did the post I put " I think this is the change to deduper screen from our call https://gerrit.wikimedia.org/r/#/c/521932/" show for you? [20:28:49] (CR) Cstone: [C: +2] Fix missing spaces in recurring TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521937 (owner: Ejegg) [20:29:20] (CR) SBassett: Refactor BannerRenderer and SpecialBannerLoader (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [20:31:52] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (sbassett) @DStrine @AndyRussG - ok, a few more comments with minor issues added to the other three patch sets from T226... [20:33:08] ejegg is that smashpig version change tied to a task? [20:34:03] (Merged) jenkins-bot: Fix missing spaces in recurring TY mails [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521937 (owner: Ejegg) [20:37:27] (CR) Jgleeson: [C: +1] "Great documentation! it really helps explain the usage and flow of the application." (3 comments) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457275 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [20:38:10] cstone you could tie it to 'add india payment methods' [20:38:18] ok thanks [20:40:44] (CR) Jgleeson: [C: +2] Flag SQL template constants as private [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457691 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [20:44:53] (PS1) Cstone: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) [20:49:52] (CR) jerkins-bot: [V: -1] Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [20:55:32] (PS2) Cstone: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) [21:00:26] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: bannerHistoryLogger not present when banner history mixin enabled - https://phabricator.wikimedia.org/T227711 (Pcoombe) [21:00:52] (CR) jerkins-bot: [V: -1] Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [21:02:52] hmm, that's odd [21:03:04] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (MBeat33) After today's checkin, @KHaggard looked up 16 of the oldest Forget Me email addresses at IBM, and all but 4 were still active (i.e. we are set to email th... [21:04:36] ejegg I think I'm usererroring this do we want to update all the dependencies in the lock? [21:04:58] cstone no, we should be able to just update smashpig, i think! [21:05:48] oh, that lock file change looks suspiciously small [21:05:59] there's a hash and a couple of timestamps that should be updated too [21:06:07] are you editing that file by hand? [21:06:19] or selectively checking in just some lines? [21:06:32] i swore the hashes changed maybe I did the wrong file somehow [21:06:37] but yeah i dont see them up there [21:06:48] k, that must be it [21:07:04] relocating, back soonish (i hope) [21:10:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (Eileenmcnaughton) @MBeat33 I would re-add their email in civi & re-forget them - then get @KHaggard to re-check in a few days It looks like I committed the fix ba... [21:14:37] (PS3) Cstone: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) [21:15:01] (PS4) Cstone: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) [21:18:02] (CR) Jgleeson: [C: +2] "works as expected for me!" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457272 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [21:20:15] (CR) Jgleeson: [C: +2] Rename package fr_user_event_consumer -> fruec [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457091 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [21:21:56] (CR) Jgleeson: [C: +2] Print a friendly message confirming config [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456672 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [21:41:04] https://www.irccloud.com/pastebin/q4secVPh/ [21:41:17] does someone want to review https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/510288/ [21:41:23] it's JUST an enotice fix - https://github.com/eileenmcnaughton/omnimail-silverpop/compare/84ef15edf7fc24e226360fbd2296867f589e3980..62c0c7d6aa972d9440fe5a40d99410496c8f029f [21:41:36] (fighting irccloud a little here) [22:37:55] (PS5) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [22:43:18] (CR) jerkins-bot: [V: -1] Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 (owner: Eileen) [23:12:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: make sure Forget Me requests reach IBM - https://phabricator.wikimedia.org/T222287 (MBeat33) Thank you @Eileenmcnaughton we'll restore and re-forget the ones still showing at IBM, and check to make sure they transmit from Civi. [23:18:08] (PS3) Ejegg: Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [23:18:20] (CR) Ejegg: [C: +2] Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [23:23:27] (Merged) jenkins-bot: Suppress e-notice when opted_out_timestamp is not set. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510288 (https://phabricator.wikimedia.org/T160949) (owner: Eileen) [23:25:19] XenoRyet: I think that previous patch creating the new optin_source etc fields needs another entry in wmf_civicrm.install [23:25:30] drush updb isn't creating anything new [23:25:54] just a copy-rename of wmf_civicrm_update_7022 should do it [23:26:41] I was originally going to piggyback on eileen's adding new fields, so I figured it would it would get it's update then, but yea, I'll add one to this patch since we're ok doing this one without an outage. [23:27:01] thanks! [23:27:59] (PS5) Ejegg: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [23:28:51] (PS1) Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 [23:30:12] (CR) Ejegg: [C: +2] Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [23:30:29] (PS1) Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/521990 [23:32:53] ejegg|semi: Wait, since that's already merged, does CI just figure it out if I add a new patch set and it gets remerged? [23:33:17] (CR) jerkins-bot: [V: -1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester) [23:35:52] (Merged) jenkins-bot: Update SmashPig version to 0.5.10 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521952 (https://phabricator.wikimedia.org/T224514) (owner: Cstone) [23:37:43] (PS6) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 [23:38:46] Yea, I guess not. I'll do a new patch for that. [23:43:35] (PS1) XenoRyet: Add the actual update to .install to add the opt-in fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522009 [23:43:53] (CR) jerkins-bot: [V: -1] Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 (owner: Eileen) [23:43:59] ejegg|semi: ^ there's the update [23:44:20] Now I'm off to pick up the kids. Later everyone. [23:49:30] (CR) Eileen: [C: +2] Add the actual update to .install to add the opt-in fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522009 (owner: XenoRyet) [23:54:26] (Merged) jenkins-bot: Add the actual update to .install to add the opt-in fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522009 (owner: XenoRyet)