[00:04:03] <wikibugs>	 (CR) Catrope: [C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/521990 (owner: Jforrester)
[00:19:49] <wikibugs>	 (Merged) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FundraisingEmailUnsubscribe] - https://gerrit.wikimedia.org/r/521990 (owner: Jforrester)
[00:40:12] <wikibugs>	 (PS7) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820
[00:41:24] <wikibugs>	 (CR) jerkins-bot: [V: -1] Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 (owner: Eileen)
[00:52:51] <wikibugs>	 (PS2) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521824 (https://phabricator.wikimedia.org/T170972)
[00:52:53] <wikibugs>	 (PS7) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392
[00:52:55] <wikibugs>	 (PS10) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868
[00:52:57] <wikibugs>	 (PS5) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972)
[00:52:59] <wikibugs>	 (PS13) Eileen: Add new calculated fields.  *  * Bug: T170972  * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972)
[00:53:01] <wikibugs>	 (PS3) Eileen: Remove old calculated fields.  *  * Bug: T170972  * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521825 (https://phabricator.wikimedia.org/T170972)
[00:53:03] <wikibugs>	 (PS8) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813
[00:53:05] <wikibugs>	 (PS8) Eileen: Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820
[01:00:29] <wikibugs>	 (CR) jerkins-bot: [V: -1] Experimental, add fields I feel like might be wanted for endowment [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521820 (owner: Eileen)
[01:16:31] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) I just tested adding a LOT more fields with triggers...
[02:03:16] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) @DStrine @Ejegg I have some concern that once we add...
[02:03:54] <wikibugs>	 (PS10) Ejegg: Add traking fields to opt-in consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520315 (owner: XenoRyet)
[02:04:26] <wikibugs>	 (CR) Ejegg: [C: +2] "Looking good, smoketest creates the right records!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520315 (owner: XenoRyet)
[02:05:38] <eileen>	 wow writing that table in markdown took a while...
[02:09:34] <wikibugs>	 (Merged) jenkins-bot: Add traking fields to opt-in consumer [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/520315 (owner: XenoRyet)
[02:10:20] <wikibugs>	 (CR) Ejegg: [C: +2] Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520955 (owner: Ejegg)
[02:12:48] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520955 (owner: Ejegg)
[02:27:55] <ejegg>	 !log updated payments-wiki from 4c1261fe5d to 59ace50d66
[02:28:01] <stashbot>	 Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log
[03:05:26] <wikibugs>	 (CR) jenkins-bot: Merge branch 'REL1_31' into fundraising/REL1_31 [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/520955 (owner: Ejegg)
[03:28:01] <wikibugs>	 (PS9) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813
[03:28:03] <wikibugs>	 (PS1) Eileen: Remove old calculated fields.  *  * Bug: T170972  * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972)
[05:34:22] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Make testing banner display (saved and unsaved preview) run more JS similar to a real campaign. - https://phabricator.wikimedia.org/T227732 (AndyRussG)
[05:46:48] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: bannerHistoryLogger not present when banner history mixin enabled - https://phabricator.wikimedia.org/T227711 (AndyRussG) Hi! I'm getting a different result here...  Looking at the banners via the [[ https://aa.wikipedia.org/wiki/Main_Page?country=...
[07:33:08] <wikibugs>	 (PS2) Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[07:36:40] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[07:37:41] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[08:09:59] <wikibugs>	 (PS3) Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[08:13:22] <wikibugs>	 (CR) jerkins-bot: [V: -1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[08:22:45] <wikibugs>	 (PS4) Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[12:34:24] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Release-Engineering-Team-TODO, Browser-Tests, Release-Engineering-Team (Unit & Int & System Tooling): Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955 (hashar) Stalled→Declined No one work...
[12:34:27] <wikibugs>	 Fundraising Sprint Kraftwerk, Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188 (hashar)
[12:34:30] <wikibugs>	 Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface: More and easier testing for DonationInterface - https://phabricator.wikimedia.org/T86247 (hashar)
[13:01:08] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (NNichols) @Eileenmcnaughton These experimental fields are really intere...
[13:35:37] <ejegg>	 hi fr-tech!
[13:36:02] <jgleeson>	 helloo ejegg, fr-tech :)
[13:36:55] <ejegg>	 hi jgleeson! Looks like you're tearing through those FRUEC patches.
[13:37:44] <jgleeson>	 I still have a bit to do ejegg, had some mortgage-related distractions again this morning but hopefully not too much longer and then I'm planning to jump on the upsell patches we discussed
[13:38:15] <jgleeson>	 I'm really impressed with what I've seen so far though on FRUEC, AndyRussG :)
[13:38:30] <ejegg>	 oh cool, hope the mortgage stuff is going in a positive direction
[13:41:02] <jgleeson>	 I'm also hoping to squeeze in a little time to play around with those selenium tests covered yesterday. The tests reminded me of using phpspec for tests a few years back when I got caught up in the beavioural driven development trends but sadly I've forgotten most of it now lol!
[13:41:28] <jgleeson>	 behavioural*
[13:44:05] <AndyRussG>	 jgleeson ejegg hi! jgleeson really glad to hear you like the FRUEC stuff, thanks... it was fun to work on, hopefully it breaks less than the other one...
[13:52:06] <jgleeson>	 AndyRussG, I had a quick question on the purge-incomplete behaviour
[13:52:32] <jgleeson>	 I wondered if you ever envisaged a scenario where that would be run at the same time as a file being processed?
[13:53:01] <jgleeson>	 I was kinda guessing that was for when something breaks, so that wouldn't happen but I'm not sure
[13:53:49] <AndyRussG>	 jgleeson oh that's a great question... The answer is no, I had just assumed no concurrent executions
[13:54:19] <AndyRussG>	 Maybe we should add a check to prevent them?
[13:55:31] <jgleeson>	 I was thinking of maybe suggesting a lock file type of thing if it was possible but then I thought about the likehood of that lock file still being present if the scenario arises where something breaks misprocess and we want to clear out incomplete stuff and reprocess, the original lock file would prevent that :\
[13:55:50] <jgleeson>	 likelihood*
[13:56:37] <jgleeson>	 feels like it would need some thought AndyRussG if that was a thing we'd need?
[13:57:44] <jgleeson>	 ah, s/misprocess/midprocess/
[13:58:12] <AndyRussG>	 jgleeson yes for sure. Maybe let's make a separate follow up task for that?
[13:58:40] <jgleeson>	 sure, I'll add some notes to the patch based on this chat so you've got a record of it
[13:58:58] <AndyRussG>	 jgleeson oh great thanks!!
[14:00:04] <AndyRussG>	 Hmmm another possible feature I'd thought of recently is purge based on files in a specified time window
[14:00:56] <jgleeson>	 yeah that sounds like it would be useful
[14:01:37] <AndyRussG>	 In case we know the data is bad for a specific period, even if processing appears to have happened normally
[14:02:15] <jgleeson>	 it would be interesting to hear what the end users think about these scenarios too as I don't know how frequent this behaviour will be used
[14:02:26] <AndyRussG>	 yeah we just had to do that manually with custom SQL for the old one
[14:02:36] <jgleeson>	 ah I see
[14:31:05] <AndyRussG>	 jgleeson: and in the case of FRUEC, it would be possible to a better purge, but the SQL would be more complex, which also makes the case for adding that feature
[14:31:08] <AndyRussG>	 we can also make a task for that
[14:48:09] <wikibugs>	 (CR) Jgleeson: [C: +2] "Working well for me, code looks good also!" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457090 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[14:49:23] <wikibugs>	 (CR) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521987 (owner: Jforrester)
[15:11:16] <wikibugs>	 (CR) Jgleeson: [C: +1] "Really like the tidy up here and encapsulation of the stats behaviour. I have one question about the increment responsibility which is mor" (1 comment) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[15:18:27] <wikibugs>	 (PS5) Mepps: Recurring conversion: wire up close and 'no' buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519544 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:18:33] <wikibugs>	 (CR) Mepps: [C: +2] Recurring conversion: wire up close and 'no' buttons (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519544 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:19:31] <wikibugs>	 (Merged) jenkins-bot: Recurring conversion: wire up close and 'no' buttons [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519544 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:21:08] <ejegg>	 mepps i'm finally diving back into how to preserve the donation info in case the donor does want to start a recurring donation
[15:21:40] <mepps>	 cool ejegg!
[15:21:54] <ejegg>	 i'm a bit reluctant to mess with the session_resetForNewAttempt or finalizeInternalStatus methods
[15:22:29] <ejegg>	 which erase from session at least the order id and in a lot of cases the rest of the donor info
[15:22:59] <ejegg>	 while we're loading the page that will show the updonate ask
[15:23:11] <wikibugs>	 (PS5) Mepps: Log line for showing recurring conversion ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:23:54] <wikibugs>	 (CR) Mepps: [C: +2] "This patch looks fine and works. One small comment but didn't make it un +2able. This may be done later but do we also want to log the res" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:24:06] <wikibugs>	 (CR) jerkins-bot: [V: -1] Log line for showing recurring conversion ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:24:36] <mepps>	 ah yeah
[15:24:39] <ejegg>	 We do keep that state around in memory while processing the request, and that lets us render all the info in the form (which should be disabled but currently isn't)
[15:24:45] <mepps>	 oh weird about the log line
[15:24:53] <ejegg>	 hmm, i'll take a look
[15:25:19] <ejegg>	 anyway, so we COULD have the recurringConversion API accept all those parameters that we'd rendered to the form
[15:25:24] <wikibugs>	 (CR) Mepps: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:25:54] <ejegg>	 but I think we're generally trying to rely on the ct_id generated server-side and stored in session
[15:25:56] <mepps>	 hmm are there any PII security risks to that?
[15:26:02] <ejegg>	 and not the one posted back
[15:26:06] <mepps>	 yeah that makes sense
[15:26:14] <wikibugs>	 (CR) jerkins-bot: [V: -1] Log line for showing recurring conversion ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:26:23] <ejegg>	 the risk would be that someone could post a recurring conversion for someone else's donation
[15:26:33] <mepps>	 hmm, how might that happen?
[15:26:56] <ejegg>	 actively manipulating the order_id / ct_id in the form before posting back
[15:27:09] <mepps>	 yikes, that seems a little concerning
[15:27:24] <ejegg>	 yeah, so I guess I do have to mess with those session reset functions
[15:29:50] <ejegg>	 huh, looks like the mediawiki setup is failing because there's a newer version of SmashPig
[15:29:59] <ejegg>	 it's trying to composer update
[15:30:39] <ejegg>	 and that's complaining because it has no .git dir in vendor/wikimedia/smash-pig
[15:31:04] <wikibugs>	 (CR) Jgleeson: [C: +2] "Looks good to me! I had to amend the test_data contents to invoke this behaviour but once added it worked as expected!" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456434 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[15:31:46] <jgleeson>	 final patch AndyRussG !!!
[15:31:58] <jgleeson>	 save the best until last ... :)
[15:32:01] <wikibugs>	 (Merged) jenkins-bot: Log line for showing recurring conversion ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519545 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[15:32:54] <ejegg>	 weird, main test failed but gate-and-submit succeeded
[15:33:39] <mepps>	 weird ejegg
[15:34:13] <AndyRussG>	 jgleeson: woohoo thanks so much!
[15:34:54] <AndyRussG>	 jgleeson: what did you have to change in test_data?
[15:35:26] <jgleeson>	 I added some values which breach the field length limits
[15:35:37] <jgleeson>	 e.g. banner name > 255 chars
[15:39:59] <jgleeson>	 (so that they are truncated!)
[16:01:32] <jgleeson>	 fr-tech, is the staff meeting youtube link working for anyone else?
[16:01:40] <XenoRyet>	 Yea, It's up for me
[16:02:13] <jgleeson>	 ahhh youtube had me logged into my personal account
[16:02:14] <jgleeson>	 fixed now
[16:02:14] <cstone>	 I had to log in again  to get it to work
[16:02:22] <cstone>	 woo
[16:02:29] <XenoRyet>	 I swear youTube never picks the account I actually want.
[16:02:40] <jgleeson>	 lol
[16:05:19] <ejegg>	 dedicated browser per account seems to be the way to go
[16:14:10] <jgleeson>	 hmm
[16:14:14] <jgleeson>	 feed cut for me
[16:14:22] <jgleeson>	 back
[16:18:21] <wikibugs>	 (CR) Jgleeson: [C: +2] "Looks great! I know this patch contains code which has been updated further up the chain so I went through the latest version of these fil" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[16:38:15] <wikibugs>	 Fundraising-Backlog: Merge Screen FY total order - https://phabricator.wikimedia.org/T227799 (NNichols)
[16:41:17] <wikibugs>	 (CR) Jgleeson: [C: +2] "Just one addition to my previous note, I noticed that we don't have any unit tests on the project. Is that something we would look to add " [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[16:56:57] <wikibugs>	 (PS1) Ejegg: Replace Ingenico Connect yaml symlinks with copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522143 (https://phabricator.wikimedia.org/T225839)
[16:57:11] <ejegg>	 fr-tech that one should be dead simple to review ^^^
[16:57:48] <wikibugs>	 (CR) Mepps: [C: +2] Replace Ingenico Connect yaml symlinks with copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522143 (https://phabricator.wikimedia.org/T225839) (owner: Ejegg)
[16:58:02] <wikibugs>	 (CR) jerkins-bot: [V: -1] Replace Ingenico Connect yaml symlinks with copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522143 (https://phabricator.wikimedia.org/T225839) (owner: Ejegg)
[16:58:16] <ejegg>	 thanks!
[16:58:29] <ejegg>	 hmm, I guess I'll update that library to stop CI complaining
[17:05:09] <wikibugs>	 (PS7) Mepps: Base class for Donation APIs: step one [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519582 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[17:05:15] <wikibugs>	 (CR) Mepps: [C: +2] Base class for Donation APIs: step one [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519582 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[17:07:11] <wikibugs>	 (CR) jerkins-bot: [V: -1] Base class for Donation APIs: step one [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519582 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[17:14:38] <wikibugs>	 (Merged) jenkins-bot: Replace Ingenico Connect yaml symlinks with copies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522143 (https://phabricator.wikimedia.org/T225839) (owner: Ejegg)
[17:15:51] <wikibugs>	 (Merged) jenkins-bot: Base class for Donation APIs: step one [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519582 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[17:37:48] <wikibugs>	 Fundraising-Backlog: Make the fraud queue consumer consume more frequently. - https://phabricator.wikimedia.org/T227803 (XenoRyet)
[17:55:34] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Break up multi-queue drush jobs - https://phabricator.wikimedia.org/T227805 (Ejegg)
[17:59:04] <wikibugs>	 Fundraising-Backlog: Make the fraud queue consumer consume more frequently. - https://phabricator.wikimedia.org/T227803 (Ejegg) @Cstone just increased the time limit for the fredge qc drush job, but it's still only possible to run the antifraud QC half-time because that drush job is split between antifraud a...
[18:00:35] <wikibugs>	 (PS7) Mepps: Donation API base: make $adapter a class property [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519583 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[18:00:40] <wikibugs>	 (CR) Mepps: [C: +2] Donation API base: make $adapter a class property [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519583 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[18:01:47] <wikibugs>	 (Merged) jenkins-bot: Donation API base: make $adapter a class property [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519583 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[18:03:50] <wikibugs>	 (CR) Mepps: [C: +1] "Looks good but I have one question about mustBePosted()" (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[18:09:40] <wikibugs>	 Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) @NNichols yes please - at this stage the outage plan...
[18:23:42] <wikibugs>	 (CR) Mepps: [C: +1] "This looks ready. Should I wait on the comments on the previous patch to +2?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[18:24:08] <mepps>	 jgleeson do you want to look at the two reviews i left as +1s? i had a question on one but you might know the answer
[18:24:13] <mepps>	 if you're still around
[18:25:06] <jgleeson>	 hey mepps, I'm still here, just on the wikimania call. I have to shoot now before my parking shuts as I thought this was a 30 minute call but was actually 1 hour but I'll check them out first thing tomorrow!
[18:25:18] <mepps>	 no worries jgleeson!
[18:25:29] <jgleeson>	 also, could I grab you for a minute before I shoot?
[18:25:39] <jgleeson>	 if you're heading out, I can catch you tomorrow
[18:25:48] <jgleeson>	 I know you're setting off
[18:25:50] <jgleeson>	 :)
[18:26:37] <jgleeson>	 mepps, ^
[18:26:46] <mepps>	 hey i'm here jgleeson
[18:26:50] <mepps>	 do you want to hop on a video call?
[18:27:00] <jgleeson>	 yeah it will likely be quicker to explain than text :)
[18:27:15] <mepps>	 okay i'm joining hte call for monday
[18:27:23] <mepps>	 jgleeson ^
[18:27:28] <mepps>	 as in our 1:1 call
[18:28:07] <jgleeson>	 this call is just wrapping up I think so will join now
[20:17:58] <wikibugs>	 (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/522179
[20:18:38] <wikibugs>	 (CR) jerkins-bot: [V: -1] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/522179 (owner: Cstone)
[20:21:18] <ejegg>	 shoot, we got swapped to php 7.2 without the intl extension
[20:22:14] <ejegg>	 want to point that out to folks in -releng?
[20:23:46] <cstone>	 hah i wasnt seeing that but its in the other tests I see now
[21:43:57] <ejegg>	 cstone it might be specific to the deploy branch. not sure
[22:23:28] <wikibugs>	 (PS8) Ejegg: Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560)
[22:26:29] <wikibugs>	 (CR) Ejegg: "Thanks for the CR mepps! It is indeed a tightening up of restrictions. PS8 commit message clarifies why." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:27:43] <wikibugs>	 (PS3) Ejegg: Add RecurringConversion interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560)
[22:27:45] <wikibugs>	 (PS4) Ejegg: WIP RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560)
[22:27:47] <wikibugs>	 (PS3) Ejegg: WIP Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560)
[22:27:49] <wikibugs>	 (PS1) Ejegg: Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198
[22:27:51] <wikibugs>	 (PS1) Ejegg: WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199
[22:44:40] <wikibugs>	 (PS1) Ejegg: Update SmashPig submodule (and regenerate lock file) [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/522205
[22:45:15] <wikibugs>	 (PS2) Ejegg: Update SmashPig lib in vendor (and regenerate lock file) [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/522205
[22:46:23] <wikibugs>	 (CR) jerkins-bot: [V: -1] Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:46:46] <wikibugs>	 (CR) jerkins-bot: [V: -1] Add RecurringConversion interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:47:13] <wikibugs>	 (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:47:39] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:47:52] <wikibugs>	 (CR) jerkins-bot: [V: -1] Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg)
[22:48:13] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg)
[22:48:24] <wikibugs>	 (CR) jerkins-bot: [V: -1] WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199 (owner: Ejegg)
[23:34:52] <wikibugs>	 (CR) Krinkle: [C: -1] Remove redundant closure for all modules with packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) (owner: Fomafix)
[23:43:13] <wikibugs>	 Fundraising-Backlog, wikimediafoundation.org, Privacy: Wikimedia Foundation website includes Wordpress tracking pixel - https://phabricator.wikimedia.org/T201422 (Varnent) Open→Resolved a:Varnent Hello - I believe this ticket has been resolved with the updated design we released this week...