[00:32:11] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [00:32:21] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [00:33:57] (CR) jerkins-bot: [V: -1] Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [00:37:51] (PS2) Ejegg: Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 [00:37:53] (PS5) Ejegg: WIP RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) [00:37:55] (PS4) Ejegg: WIP Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) [00:37:57] (PS2) Ejegg: WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199 [00:40:09] (CR) jerkins-bot: [V: -1] WIP RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [00:40:15] (CR) jerkins-bot: [V: -1] WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199 (owner: Ejegg) [00:40:21] (CR) jerkins-bot: [V: -1] Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [00:40:35] (CR) jerkins-bot: [V: -1] WIP Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [07:05:26] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/522273 (owner: L10n-bot) [09:33:18] (PS6) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [14:06:29] (PS9) Mepps: Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:06:34] (CR) Mepps: [C: +2] Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:07:06] (PS4) Mepps: Add RecurringConversion interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:07:11] (CR) Mepps: [C: +2] Add RecurringConversion interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:07:40] (Merged) jenkins-bot: Donation API Base: Bring Amazon in [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519584 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:08:18] (Merged) jenkins-bot: Add RecurringConversion interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520149 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [14:12:54] (PS7) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [14:18:00] (CR) Hashar: [C: +2] Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [14:45:15] (CR) Vedmaka Wakalaka: "> Patch Set 3:" (8 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [14:46:56] (CR) Vedmaka Wakalaka: "Btw, I think there is a problem with CentralNotice CI at the moment, it tends to report false positive CI status on tests due to https://p" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [14:54:57] (Merged) jenkins-bot: Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [14:58:25] thanks for the CR, mepps! [14:58:57] (PS3) Mepps: Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [14:59:04] sure ejegg|away! [15:08:16] Fundraising Sprint Never Ending Query, Fundraising-Backlog: Republish donor TY email - edits to ru, es - https://phabricator.wikimedia.org/T225332 (Cstone) a:Cstone [15:08:29] (PS1) Cstone: Update ru thank you email template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522497 (https://phabricator.wikimedia.org/T225332) [15:10:15] (PS2) Cstone: Update ru thank you email template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522497 (https://phabricator.wikimedia.org/T225332) [15:20:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO (201907), User-zeljkofilipin: Port CentralNotice Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180223 (zeljkofilipin) Op... [15:22:59] (CR) jenkins-bot: Delete Ruby Selenium tests [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/521884 (https://phabricator.wikimedia.org/T180223) (owner: Zfilipin) [15:26:48] hey ejegg [15:28:47] what's up mepps? [15:29:16] so i'm just curious how the resultswitchertest fits with these other patches--is this the first time we're using it? [15:29:39] also i was wondering if the "yes" button is supposed to work yet on the recurring popup [15:30:33] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (NNichols) @Eileenmcnaughton So is it possible to have ALL of them? We'r... [15:32:46] ejegg oops ^^ [15:33:24] mepps the yes button is what needs the new api [15:34:39] and the resultswitcher is what we're changing to make the new form render, so i wanted to beef up the tests [15:35:08] ejegg, mepps I don't think the display for the upsell element is showing correctly for me https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/519544/ did either of you have issues with that? [15:35:31] what are you seeing jgleeson? [15:35:31] jgleeson what kind of issues? [15:35:41] like missing css? [15:35:52] i think that needs a variant set up [15:36:15] https://pasteboard.co/InEwJ2p.png [15:36:19] ahhh [15:36:23] that might be it [15:39:00] hmm i didn't have to do any additional setup jgleeson ejegg [15:39:09] what do you mean by variant setup ejegg? [15:39:49] ah, I think he means in order to get ext.donationInterface.recurringUpsell.js to load [15:41:47] anyone else watching Federer vs Nadal??? [15:41:54] did you get it working jgleeson? [15:42:00] no what's that? [15:42:11] no not yet mepps just looking into setting up the form_variant cfg [15:42:17] tennis match mepps [15:42:20] could it just be caches jgleeson? [15:42:22] all times greats meeting again [15:42:30] ah cool [15:42:45] https://twitter.com/search?q=nadal+vs+federer&ref_src=twsrc%5Egoogle%7Ctwcamp%5Eserp%7Ctwgr%5Esearch [15:42:54] as i said, i didn't have to do anything additional to get the js working [15:43:10] hmm that's got me curious [15:43:31] clear browser caches? [15:43:38] tried that [15:44:06] hmm, weird [15:44:17] mepps you have an 'upsell' directory in the form_variants dir? [15:44:31] maybe from a previous patch? [15:44:43] where is that directory? [15:44:52] mediawiki-fr/form_variants/upsell [15:44:54] That was part of the setup listed on the commit message for the initial upsell patch [15:46:00] i do, maybe because i pulled down the latest mediawiki rel1_31 branch? [15:46:10] I don't see it ejegg is it on this chain? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/514344/ [15:46:20] (the setup) [15:46:35] jgleeson, try pulling down the latest mediawiki on that branch? [15:46:56] mepps, the form_variants are manually added I think [15:47:06] https://gerrit.wikimedia.org/r/515114 [15:47:40] jgleeson those form_variants are checked in to our mediawiki branch [15:48:00] though I guess we could just put them in the donationinterface repo [15:48:03] might make more sense [15:48:09] hmm I wonder what branch I'm running then [15:48:31] maybe you just haven't updated recently? [15:48:32] maybe just haven't pulled the latest in a while? [15:48:42] heh, great minds [15:48:44] haha ejegg jinx [15:48:44] could be [15:48:49] :) [15:49:20] but ejegg is that directory only for DonationInterface? [15:49:51] mepps yeah, the form variants are only used for the DonationInterface forms [15:50:02] is it in main mediawiki with the idea that other users of this might want different variants? [15:50:19] yeah, but... 'other users' are still theoretical [15:50:48] haha yeah [15:50:54] That would also apply to DonationInterfaceFormSettings [15:51:16] where is that located now? [15:51:25] yeah i'd suggest moving it back in the repo [15:51:25] in the root of DonationInterface [15:51:34] form_variants i mean [15:51:54] totally, will do [15:52:01] so I was missing that, and a whole load of other changes to our mw branch! [15:52:05] sorry for the confusion mepps ejegg [15:52:30] no worries jgleeson, it started this other conversation! [15:53:44] (PS1) Ejegg: Add form_variants dir to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522507 [15:54:16] awesome, working as expected! [15:56:14] oh, lemme add a deploy note to that patch [16:00:30] (PS2) Ejegg: Add form_variants dir to DonationInterface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522507 [16:05:06] mepps, looks like you've in-progress on the resultswitchedtest review? [16:05:12] you're* [16:11:19] jgleeson i just fixed the phpcs errors, if you want to review, go ahead [16:11:49] now that my name is on the commit, maybe i shouldn't +2 :P [16:12:04] :) [16:20:17] (CR) Jgleeson: [C: +2] "Test working for me. Contents looks good also! Also, thanks for the formatting fix @mepps" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [16:21:11] (Merged) jenkins-bot: Turn on Ingenico Connect ResultSwitcherTest [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522198 (owner: Ejegg) [16:23:10] (CR) Mepps: Refactor stats output (1 comment) [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [16:24:11] (CR) Mepps: "Also I thought jgleeson made a good point but I can also imagine there's an argument for organizing the code the way it is here." [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG) [16:28:09] fr-tech, will be a few mins late to standup! brb [16:32:39] AndyRussG ejegg meeting? [16:32:58] back [16:41:42] mepps hey I sent an email and also pinged... Apologies have to miss today...... [16:53:08] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (NNichols) @Eileenmcnaughton I've consolidated my last message here and... [17:03:44] (CR) Ejegg: [C: +2] Update ru thank you email template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522497 (https://phabricator.wikimedia.org/T225332) (owner: Cstone) [17:04:38] thanks ejegg! [17:05:22] ty for updating it! [17:09:07] (Merged) jenkins-bot: Update ru thank you email template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522497 (https://phabricator.wikimedia.org/T225332) (owner: Cstone) [17:31:26] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: clarify TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (MBeat33) [17:31:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (MBeat33) [17:47:02] (PS2) Jforrester: Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 [17:50:01] (CR) jerkins-bot: [V: -1] Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [17:54:21] (CR) jerkins-bot: [V: -1] Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [18:09:49] (PS1) Ejegg: Use SimpleHtmlParser instead of DomDocument in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522525 [18:11:43] (CR) jerkins-bot: [V: -1] Use SimpleHtmlParser instead of DomDocument in tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522525 (owner: Ejegg) [18:39:21] well damn, extension-specific dev dependencies seem to not work in quibble tests [18:39:53] guess I'll forget about trying to do a render test for the updonate form [18:40:26] and just do direct gateway object manipulation [18:41:34] (PS3) Mepps: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521824 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [18:41:38] (CR) Mepps: [C: +2] Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521824 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [18:45:45] (CR) Mepps: "One question. Also, that module file is getting massive. Are there any drupal conventions for breaking it up? (For a future improvement.)" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [18:46:51] (Merged) jenkins-bot: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521824 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [18:47:30] aha, legoktm suggests remex-html might do it [18:47:47] and is apparently already a core dev-dependency [19:02:14] hmm, remex seems to be difficult to adapt to our use case - just doing node selection and tests on text and simple attributes. [19:02:39] it's a big collection of lower-level functionality [19:02:52] used in mediawiki core as a replacement for tidy [19:05:36] (CR) Mepps: [C: +1] "Looks good but I had one tiny thought. Someone else is welcome to +2 though." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [19:31:33] (CR) Mepps: Update triggers for new calculated fields (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [19:35:59] (CR) Mepps: "ejegg do we want to add in-directory as the default value in extension.json?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522507 (owner: Ejegg) [20:02:11] (CR) Eileen: "mepps the intent at this stage is to remove the is_2006_donor ones but to retain total_2006_2007 and total_2006" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [20:06:46] (CR) Ejegg: "That would be nice, but unfortunately in the json we don't have access to the __DIR__ magic variable." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522507 (owner: Ejegg) [20:13:50] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) @NNichols so of the above the trickiest part is the L... [20:19:55] (Abandoned) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521825 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [20:25:27] (PS8) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 [20:27:06] (PS9) Eileen: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 [20:30:08] (CR) Eileen: "mepps you are right - I actually fixed it in a later commit in the chain but I've fixed into this commit now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [20:31:05] ejegg: has Dylan's new field gone out? I feel like maybe if it has we can start merging in the new fields - but if we merge them in now before . he runs drush updb then his field add will grab these [20:32:47] not yet, eileen [20:33:06] he and cstone ran into some problems deploying yesterday [20:33:43] ok - thanks & do you have an opinion . on how encouraging I should be about https://phabricator.wikimedia.org/T222958#5329466 [20:34:43] I kinda want to hit a balance between lets add the useful stuff & let's add everything - but TBH I didn't see much down side in my testing [20:38:16] you know my . money says it . wouldn't cost us much more to add an option value field that would look like 10010 as a key with 25 options values ie 10000 would be 'donated five years ago & not . since' and 11111 would . be 'donated every year for the last five years - that feels like the sort of thing I'm hearing they want [20:38:53] but we'd have to do it like donor_string2018 donor_string_2019 donor_string2020 etc [20:39:08] so it would be maybe 5 extra . fields & some naming convention [20:41:17] you could then construct a query of donors who donated 4 + out of the last 5 years but choosing 5 of the 25 options [20:51:43] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) I just . want to . float an idea I have about getting... [20:57:24] hmm, seems like ccogdill might have a hard time using that string in ibm [21:10:34] ejegg: I'll ping her in [21:11:15] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 (Eileenmcnaughton) @CCogdill_WMF just .pinging you to look at the above ^^ [22:06:46] oh shoot, now I can't test ingenico connect locally [22:06:55] what did i break with those last few patches? [22:07:38] something donation-api-related, i'm guessing! [22:10:16] looks like the culprit was https://gerrit.wikimedia.org/r/519584 [22:11:41] weird, how did that break stuff [22:11:42] ? [22:13:58] oh, derp, the most obvious way possible [22:14:15] we haven't actually been using POST this whole time :S [22:27:26] (PS1) Ejegg: Use POST for donation api [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522564 [22:27:43] fr-tech anyone available to review a one-word change ^^^ ? [22:28:06] DonationInterface master is currently in a broken state :( [22:39:40] (PS6) Ejegg: RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) [22:39:42] (PS5) Ejegg: WIP Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) [22:48:22] (PS3) Ejegg: WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199 [22:50:03] (CR) jerkins-bot: [V: -1] WIP add test for rendering updonate ask [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/522199 (owner: Ejegg) [22:51:42] (CR) Ejegg: [C: +2] Update SmashPig lib in vendor (and regenerate lock file) [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/522205 (owner: Ejegg) [22:53:31] (Merged) jenkins-bot: Update SmashPig lib in vendor (and regenerate lock file) [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/522205 (owner: Ejegg) [23:09:00] (CR) jenkins-bot: Update SmashPig lib in vendor (and regenerate lock file) [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/522205 (owner: Ejegg)