[03:57:37] (PS11) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [03:57:55] (CR) Eileen: Add additional requested major gift fields (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [04:00:02] (Abandoned) Eileen: Move calculated fields declaration to main module file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521804 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [04:00:38] (PS3) AndyRussG: Refactor check for choiceData staleness and add corresponding status [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) [04:04:32] (CR) AndyRussG: Refactor check for choiceData staleness and add corresponding status (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) (owner: AndyRussG) [04:04:53] (PS6) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [04:04:55] (PS10) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [04:04:57] (PS14) Eileen: Add new calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [04:11:28] (PS2) Eileen: Remove old calculated fields. * * Bug: T170972 * Bug: T222958 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) [11:05:29] (Abandoned) Awight: Don't use composer-merge-plugin for vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/514986 (owner: Awight) [13:00:14] well that was tricky.. my vagrant vm stopped workin as there was no space left on the device. Looks like the logs files got up to 5.4Gig! split between daemon.log and syslog mostly filled up with kafka and mysql entries [13:00:43] 5.4gig on an 8gig device [13:06:36] oh fun! [13:07:16] Fundraising-Backlog, Recurring-Donations: trigger a second email in recurring upsell to denote the recurring part - https://phabricator.wikimedia.org/T228162 (DStrine) [13:09:08] Fundraising-Backlog, Recurring-Donations: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (DStrine) [13:09:16] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (Jgreen) [13:10:00] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (Jgreen) Reviewing the changes, they've removed several IPv4 addresses from the list. There are no new IPv4 addresses. [13:10:34] ejegg, just playing around with your pymysql patch. looking at what's involved in getting tox working on fr-tools [13:10:46] although I'll probably just +2 that using nose [13:11:03] I've never used tox before, looks like a useful tool to have running [13:11:08] jgleeson_: heh, for me, tox started working after going to pymysql [13:11:25] oh rly? [13:11:27] hmmm [13:11:35] it was failing before trying to install the old mysql extn [13:11:44] or module, rather [13:11:55] lemme just run that again real quick [13:11:56] i tried `tox -e discover` and that fell over [13:12:12] on what step? [13:13:09] oh hmm, wait, something is going wrong with python-levenshtein when I try now (in python3) [13:13:17] it is running in CI though [13:14:33] ok, if I delete .tox and reset to the pymysql patch, it does run correctly [13:14:38] hmm looks like it's missing the Queue module [13:15:10] oh? [13:15:17] there's a 'queue' module as a part of tools [13:15:34] that gets renamed to frqueue in the next patch, actually [13:16:18] i'm just running tox, no args [13:16:27] lemme try with -e discover [13:16:58] that works too [13:18:03] so it's the queue module that urllib3 depends on which is missing for you locally? [13:18:19] something we need to add to requirements.txt? [13:18:27] so if I run `tox -vv` I can see the discover suite failing due to the missing queue module and then the flake8 suite gets blocked due to a .lock file being present [13:18:36] feels like a messed up install [13:18:56] lock file /vagrant/srv/fundraising-tools/.tox/flake8/log/.lock present, will block until released [13:19:19] and if you delete .tox and re-run? [13:19:20] actually I remember running into this previously and it might actually be something to do with file permissions [13:19:35] I seem to remember vagrant couldn't delete that file [13:19:50] maybe I ran tox originally on the host machine? [13:20:01] ohhh [13:20:03] and it's created a lock file that the guest vm can't delete [13:20:09] that might explain it [13:20:18] sounds totally plausable [13:24:22] nope not perms [13:24:26] hmm [13:24:27] (PS8) Ejegg: RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) [13:24:33] I'll try and fix the missing queue module first [13:25:07] maybe justa dding the urllib3 requirement to requirements.txt? [13:25:33] let's try that [13:45:07] cstone: want to try rebasing https://gerrit.wikimedia.org/r/490666 on your own machine? [13:45:35] Looks like something else changed the same code while we were waiting for the required month to pass :S [13:45:43] sure [13:47:14] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Da Vinci Coder, and 14 others: Reduce recurring TY emails - https://phabricator.wikimedia.org/T213209 (Ejegg) @mepps... [13:58:27] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (Jgreen) p:Triage→Normal [14:04:09] ejegg, what's your basepython val in your tox.ini? [14:04:39] jgleeson_: as of the pymysql patch, it's python2 [14:04:53] i bump it up to python3 in the patch that converts the code [14:06:28] so looks like I had set mine to python3 [14:06:55] ohh [14:06:59] that'd do it! [14:07:02] resetting that gets me passed the queue problem but then back to the .lock issue again [14:07:20] hmm, and even sudo rm -rf .tox doesn't kill it? [14:07:32] yeah tried that a few times [14:08:12] and deleting from the host os? [14:09:49] hmm [14:09:52] so if I delete it [14:09:54] it comes back [14:09:55] lol [14:10:04] lock file /vagrant/srv/fundraising-tools/.tox/discover/log/.lock present, will block until released [14:10:08] when stuck at that point^ [14:12:03] looks like it might be specific to my vagrant nfs mount https://github.com/tox-dev/tox/issues/1115 [14:19:40] ok I'll park this here and raise a ticket for it [14:19:48] and just use nose to test the patch [14:33:46] Fundraising-Backlog, Recurring-Donations: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (Pcoombe) We don't currently show any details about the transaction on the TY page, so I'm not sure what this would entail. [14:43:51] (CR) Jgleeson: [C: +2] "Updates working for me. I did notice some warnings when running tests around the db field constraints but these were present in MySQLdb al" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520352 (https://phabricator.wikimedia.org/T213757) (owner: Ejegg) [14:44:36] (Merged) jenkins-bot: Switch to pymysql [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520352 (https://phabricator.wikimedia.org/T213757) (owner: Ejegg) [14:44:58] thanks jgleeson! [14:45:32] there's another patch to deal with those not null warnings [14:54:40] Fundraising-Backlog: can't run tox test suites on vagrant due to suspects python NFS lock bug - https://phabricator.wikimedia.org/T228172 (jgleeson) [15:00:43] (CR) Jgleeson: [C: +2] "Looks good to me, tests passing also" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520457 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [15:02:18] back a little later fr-tech, got oscars parents evening! [15:08:16] Fundraising-Backlog, Recurring-Donations: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (DStrine) @spatton this was your note on recurring up sell. What do you think? [15:08:37] (Merged) jenkins-bot: Rename queue module to prepare for python 2->3 conversion [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520457 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [15:16:39] Fundraising-Backlog, Recurring-Donations: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (spatton) Lightweight implementation: if a donor is making multiple gifts (we could define that as a one-time + recurring; or even a new recurring signup?),... [15:19:39] (PS7) Cstone: Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) [15:20:59] Fundraising-Backlog: Need SSL client certificate for CiviCRM - https://phabricator.wikimedia.org/T228176 (KHaggard) [15:27:07] (PS8) Cstone: Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) [15:28:12] (PS9) Cstone: Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) [15:30:03] ok ejegg that should be good. [15:30:07] Also my thinkpad has developed the trackpad issues guess they were just delayed :( [15:33:43] argh! [15:34:57] gonna check out a museum quick [15:35:04] nice! enjoy [15:37:06] oops, there's a crazy long line. maybe later [15:46:19] Fundraising-Backlog, fundraising-tech-ops: Need SSL client certificate for CiviCRM - https://phabricator.wikimedia.org/T228176 (DStrine) a:Jgreen [16:10:16] (CR) Ejegg: [C: +2] Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [16:15:39] (Merged) jenkins-bot: Add in check to set no_thank_you field for recurring payments after the first recurring payment. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/490666 (https://phabricator.wikimedia.org/T213209) (owner: Cstone) [16:23:20] (PS2) Ejegg: Fix NOT NULL warnings in silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520664 [16:28:03] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Men In Slack, and 11 others: DB schemas (production changes and test DB) and SQL commands to ... - https://phabricator.wikimedia.org/T196564 [16:32:33] (PS1) Ejegg: Remove form_variants [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/523762 [16:53:13] (PS7) Ejegg: Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) [16:53:15] (PS3) Ejegg: WIP wire up 'yes' buttons for recurring conversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/523192 (https://phabricator.wikimedia.org/T216560) [16:56:05] Fundraising-Backlog, Recurring-Donations: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (Ejegg) On the payments-wiki side it should be easy enough to add an extra parameter to the thank you page URL when the donor has agreed to convert a one-tim... [17:04:48] (PS8) Ejegg: Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) [17:04:50] (PS4) Ejegg: WIP wire up 'yes' buttons for recurring conversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/523192 (https://phabricator.wikimedia.org/T216560) [17:22:35] Fundraising-Backlog, Recurring-Donations, donate.wikimedia.org: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (Pcoombe) Any dynamic content for the TY page is going to need both an appropriate parameter passed in the URL (fr-tech work) and c... [17:26:12] (CR) XenoRyet: [C: +2] "Doesn't break anything for me either, and looks good." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [17:27:12] thanks for the CR [17:27:56] oh, i just thought of one more change to make to the next patch in that chain [17:28:07] should do a resetForNewAttempt after a successful recurring conversion [17:29:11] ejegg on the SmshPig recurring change part of that, the idea is to pull the token info from the first non recurring donation they did to use for the future recurring donations? [17:29:50] cstone maybe the other backend ticket would be better to start with actually [17:30:11] ok! [17:30:26] the other ticket is to store the token [17:30:31] ahh [17:30:56] and I guess create the recurring record [17:31:08] and link those two [17:31:42] but i don't think we'd want to link the one-time contribution to the recurring record with contribution_recur_id [17:31:54] since it's for a different amount [17:33:45] so there's a bit to work out there [17:37:13] ejegg, do the variant tests specify an explict fixture path to the test variants to be used? I wanna make sure just before +2'ing the patch [17:37:18] (Merged) jenkins-bot: RecurringConversion API [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/519729 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [17:46:29] (CR) Jgleeson: [C: +2] "looks good. I tested out the donationinterface tests on this branch just to see if anything was hardcoded to point at the files being remo" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/523762 (owner: Ejegg) [17:48:17] (Merged) jenkins-bot: Remove form_variants [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/523762 (owner: Ejegg) [18:04:07] (CR) Jgleeson: [C: +1] "Tests passing locally." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [18:06:24] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising-Backlog, Patch-For-Review: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (jgleeson) Could you add some tips on how to test functionality of some of the c... [18:06:57] (CR) jenkins-bot: Remove form_variants [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/523762 (owner: Ejegg) [18:08:12] Fundraising Sprint Never Ending Query, Fundraising-Backlog: Make the fraud queue consumer consume more frequently. - https://phabricator.wikimedia.org/T227803 (jgleeson) a:jgleeson [18:19:25] (CR) Mepps: "Mostly looks good, a couple minor questions." (4 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [18:46:29] Fundraising-Backlog, Recurring-Donations, donate.wikimedia.org: recurring upsell: show both transaction on the thank you page - https://phabricator.wikimedia.org/T228163 (spatton) Thanks for outlining the needs @Pcoombe, that gives me opportunity to clarify that when I said 'lightweight implementatio... [18:48:34] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (Jgreen) Deployed: commit 8c2f1b2e607433ee263d8b1741145d741895ce22 (HEAD -> master, origin/master, origin/HEAD) Author: Jeff Green Date: Tue Jul 16 18:20:46 2019 +0000 adju... [19:36:32] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (Jgreen) commit 0ae3e07572d6991e7347babff96d3664ade881ac (HEAD -> master, origin/master, origin/HEAD) Author: Jeff Green Date: Tue Jul 16 19:26:45 2019 +0000 refresh MaxMind... [20:00:59] fundraising-tech-ops: refresh IP address list for maxmind API - https://phabricator.wikimedia.org/T228164 (ayounsi) [20:12:48] Fundraising-Backlog, fundraising-tech-ops: refresh CiviCRM SSL client certificate for Katie Haggard - https://phabricator.wikimedia.org/T228176 (Jgreen) [20:33:05] Wikimedia-Fundraising-CiviCRM: Can we change the default setting for batch updating Activities? - https://phabricator.wikimedia.org/T228213 (RLewis) [21:43:24] crap, forgot to eat. [21:44:00] (PS9) Ejegg: Ingenico implements RecurringConversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) [21:44:02] (PS5) Ejegg: WIP wire up 'yes' buttons for recurring conversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/523192 (https://phabricator.wikimedia.org/T216560) [21:51:34] (CR) jerkins-bot: [V: -1] WIP wire up 'yes' buttons for recurring conversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/523192 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [21:59:55] (PS6) Ejegg: Wire up 'yes' buttons for recurring conversion [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/523192 (https://phabricator.wikimedia.org/T216560) [22:13:05] (PS10) Ejegg: Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:14:11] (CR) jerkins-bot: [V: -1] Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:14:48] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:23:27] (CR) Ejegg: [C: +2] Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:28:47] (CR) jerkins-bot: [V: -1] Add calendar year fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:30:52] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521392 (owner: Eileen) [22:35:05] (PS12) Eileen: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 [22:38:29] (PS13) Ejegg: Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [22:38:36] (CR) Ejegg: [C: +2] Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [22:39:37] (CR) jerkins-bot: [V: -1] Add additional requested major gift fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/518868 (owner: Eileen) [22:43:15] (CR) XenoRyet: [C: +1] "Looks good. The resetForNewAttempt seems good and proper." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/520150 (https://phabricator.wikimedia.org/T216560) (owner: Ejegg) [22:54:03] (PS15) Ejegg: Add new calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:54:23] (CR) jerkins-bot: [V: -1] Add new calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:55:55] (PS16) Eileen: Add new calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) [23:08:36] (PS7) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [23:09:03] (PS11) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [23:18:37] (PS8) Eileen: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) [23:18:39] (PS12) Eileen: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 [23:18:42] (PS3) Eileen: Remove old calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) [23:28:24] (CR) Ejegg: [C: +2] Add new calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:28:44] (CR) Ejegg: [C: +2] Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:29:27] (CR) Ejegg: [C: +2] Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 (owner: Eileen) [23:33:28] (Merged) jenkins-bot: Add new calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521400 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:33:47] (Merged) jenkins-bot: Update triggers for new calculated fields [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521809 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:38:57] (Merged) jenkins-bot: Add triggers for first_donation_usd & first_donation_amount. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/521813 (owner: Eileen) [23:47:16] (PS4) Eileen: Remove old calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) [23:47:18] (PS1) Eileen: Add index to civicrm_activity.location [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/523830 (https://phabricator.wikimedia.org/T228106) [23:47:31] (CR) Ejegg: "looks great, I just got caught up by the install fn numbering since I'd been running each update separately" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:47:52] oh heh, you already fixed that [23:48:08] (CR) Ejegg: [C: +2] Remove old calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:53:34] (Merged) jenkins-bot: Remove old calculated fields. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/522016 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [23:53:45] (CR) Ejegg: [C: +2] Add index to civicrm_activity.location [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/523830 (https://phabricator.wikimedia.org/T228106) (owner: Eileen) [23:58:49] (Merged) jenkins-bot: Add index to civicrm_activity.location [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/523830 (https://phabricator.wikimedia.org/T228106) (owner: Eileen)