[04:03:51] (CR) AndyRussG: [V: +2 C: +2] "Thanks!!!" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525881 (owner: Jforrester) [04:11:35] (CR) jerkins-bot: [V: -1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525881 (owner: Jforrester) [04:20:03] (CR) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525881 (owner: Jforrester) [04:35:51] Fundraising-Backlog, Fr-CentralNotice-Caching: PHPUnit tests failing with "Cannot write with role DB_REPLICA" - https://phabricator.wikimedia.org/T229194 (AndyRussG) [04:36:41] Fundraising Sprint Office  , Fundraising-Backlog, Fr-CentralNotice-Caching: PHPUnit tests failing with "Cannot write with role DB_REPLICA" - https://phabricator.wikimedia.org/T229194 (AndyRussG) https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/61786/console [05:30:59] (PS1) AndyRussG: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526010 (https://phabricator.wikimedia.org/T229194) [05:51:03] Fundraising Sprint Office  , Fundraising-Backlog, Fr-CentralNotice-Caching, Patch-For-Review: PHPUnit tests failing with "Cannot write with role DB_REPLICA" - https://phabricator.wikimedia.org/T229194 (AndyRussG) a:AndyRussG [06:00:20] (CR) AndyRussG: "> Patch Set 3:" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525680 (owner: AndyRussG) [07:06:27] (CR) AndyRussG: Banner live preview (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [07:19:47] (CR) AndyRussG: Banner preview: JS improvements (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:21:09] (CR) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [07:28:55] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526043 (owner: L10n-bot) [13:38:43] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update data on staging - https://phabricator.wikimedia.org/T228710 (Jgreen) a:Eileenmcnaughton→Jgreen [13:39:06] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update data on staging - https://phabricator.wikimedia.org/T228710 (Jgreen) p:Triage→Normal [14:11:12] (PS2) Ejegg: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526010 (https://phabricator.wikimedia.org/T229194) (owner: AndyRussG) [14:11:19] (CR) Ejegg: [C: +2] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526010 (https://phabricator.wikimedia.org/T229194) (owner: AndyRussG) [14:15:39] (Merged) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526010 (https://phabricator.wikimedia.org/T229194) (owner: AndyRussG) [14:22:52] (CR) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526010 (https://phabricator.wikimedia.org/T229194) (owner: AndyRussG) [14:50:05] hey ejegg I heard that the ingenico integration may be giving us trouble with up sell? Let me know if we are really blocked and/or if we need help redesigning or something [14:56:03] dstrine looks like it's something that doesn't work in the sandbox but should in their 'pre-prod' environment [14:56:12] we just got accounts [14:56:33] and i'm trying to get it set up to test now [15:40:00] (PS1) Jforrester: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) [15:40:25] (PS2) Jforrester: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) [15:43:47] (PS4) Ejegg: Deal with gateway_txn_id in a standard way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/524535 [15:44:19] (CR) Ejegg: "Thanks for the CR mepps! I just fixed the things you indicated." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/524535 (owner: Ejegg) [15:56:14] (PS10) Ejegg: WIP: getAllValidForms uses isValidForm [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/338458 (https://phabricator.wikimedia.org/T136254) [17:11:21] ejegg: hey! ^ thanks for review! [17:11:38] thank you for the fix! [17:15:52] (PS2) Ejegg: Update Japanese thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525851 (https://phabricator.wikimedia.org/T228680) (owner: Cstone) [17:16:25] (CR) Ejegg: [C: +2] "Thanks cstone!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525851 (https://phabricator.wikimedia.org/T228680) (owner: Cstone) [17:21:28] (Merged) jenkins-bot: Update Japanese thank you email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525851 (https://phabricator.wikimedia.org/T228680) (owner: Cstone) [17:26:31] fr-tech I just pushed a patch to the settings repo for Pats's price ceiling request [17:26:41] anyone want to take a look? [17:26:47] sure [17:27:00] thanks! [17:30:19] ejegg, is that in $'s ? [17:30:26] jgleeson: yep [17:30:43] mumble mumble global hegemony mumble mumble default currency [17:31:04] indeed [17:31:19] looks good to me! I was just checking the extension.json default and the transformer where it kicks in [17:31:21] makes sense now [17:31:26] hadn't seen it before [17:31:30] cool! [17:31:37] thanks for being so thorough [17:37:24] !log updated payments-wiki config to a7dacbf8e9 [17:37:30] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:57:32] (CR) SBassett: Banner preview: JS improvements (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [18:05:11] (CR) SBassett: Banner preview: JS improvements (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [19:04:32] (CR) Ejegg: "Looks good, seems to work! We should just update some existing code to be consistent with the new norm of having trxn_id include a gateway" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [19:19:10] (CR) Ejegg: "Existing code to update:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [19:19:25] cstone: let me know if you have any questions on ^^^ [19:22:08] ok thanks ejegg! [20:06:28] Fundraising-Backlog, FR-Ingenico, Recurring-Donations: Ingenico Connect: add new parameter to recurring transactions - https://phabricator.wikimedia.org/T229059 (DStrine) Open→Invalid [20:16:46] Fundraising Sprint Office  , Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Some of Qunit tests are ignored - https://phabricator.wikimedia.org/T227879 (DStrine) [20:28:50] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Figure out crashing state - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) [20:30:32] (CR) Ejegg: [C: -1] Add 2018_2019_total & 2019_2020_total to silverpop export (1 comment) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [20:34:31] this cafe's gotten pretty smokey and noisy - gonna find another spot for civi fortnightly [21:04:20] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Figure out crashing state - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) [21:14:23] (PS5) Jgleeson: WIP: Update SmashPig recurring processor to handle making first payments. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [21:19:37] (CR) Ejegg: [C: +2] "Oh hey, this one IS a no-brainer :)" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/525175 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:26:03] (Merged) jenkins-bot: Port back Mapping api from upstream so we can use for target smart [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/525175 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:34:01] (PS4) Eileen: Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [21:43:37] (PS1) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [21:44:46] (CR) jerkins-bot: [V: -1] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [21:49:05] hello fr-tech! i have a weird result when i type "ssh frdev1001" in terminal to try to access some sql results. who would be the right person to help me out with looking into that? [21:51:07] mnoor looks like the ssh config file on your laptop got overwritten with a SQL query! [21:51:34] 😖 [21:51:43] was that my doing? [21:51:54] heh, maybe gremlins? [21:52:07] so let's see what it needs [21:53:05] mnoor this might be all you need [21:53:57] (PS1) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [21:54:38] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [21:54:45] mnoor: https://etherpad.wikimedia.org/p/sshconfigforfrdev [21:55:14] That last line (IdentityFile) depends on where you have the private key saved, but that's the default location [21:57:10] (PS1) Eileen: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 [21:57:47] (PS2) Eileen: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 [21:58:24] (CR) jerkins-bot: [V: -1] Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 (owner: Eileen) [22:00:00] ejegg do i just copy and paste that into terminal? more error messages if that is the case [22:00:09] i haven't moved the file, so it should be in its default location [22:00:31] mnoor nope, you need to replace the ssh config file [22:00:45] which is in a hidden dir in your homedir called .ssh [22:01:01] I'm afraid I'm not sure exactly what you need to do in mac to show hidden files [22:01:09] but it's a file called config in that dir [22:01:19] and it should just have those contents [22:01:54] (PS1) Eileen: Remove join to wmf_donor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526266 [22:02:35] (CR) jerkins-bot: [V: -1] Remove join to wmf_donor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526266 (owner: Eileen) [22:02:54] i see [22:03:03] I just put mine in email [22:03:04] i'll paste in the etherpad what i see [22:03:21] mnoor: check the email [22:03:54] k [22:06:35] ah found the culprit! thank you both ejegg and eileen! [22:07:09] you're welcome! [22:07:46] (PS3) Eileen: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 [22:07:48] (PS5) Eileen: Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [22:07:50] (PS2) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [22:07:52] (PS2) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [22:08:03] (CR) Jforrester: "> Patch Set 3:" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525680 (owner: AndyRussG) [22:08:25] (CR) jerkins-bot: [V: -1] Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:08:27] (CR) jerkins-bot: [V: -1] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:08:34] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:09:22] (CR) Ejegg: [C: -1] "*number_donations should be int" (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 (owner: Eileen) [22:11:34] (PS1) Eileen: Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [22:13:00] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:15:34] (PS4) Eileen: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 [22:16:07] (CR) jerkins-bot: [V: -1] Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 (owner: Eileen) [22:18:03] (PS5) Eileen: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 [22:19:26] (CR) Ejegg: [C: +2] Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 (owner: Eileen) [22:20:06] (Merged) jenkins-bot: Update test schema [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526265 (owner: Eileen) [22:20:35] (PS6) Eileen: Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [22:20:44] (PS2) Eileen: Remove join to wmf_donor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526266 [22:20:49] (Abandoned) Eileen: Remove join to wmf_donor [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526266 (owner: Eileen) [22:21:03] (PS3) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [22:21:10] (CR) jerkins-bot: [V: -1] Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:21:17] (PS3) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [22:21:26] (PS2) Eileen: Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [22:21:37] (CR) jerkins-bot: [V: -1] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:21:54] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:22:08] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:32:39] (PS7) Eileen: Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [22:33:11] (CR) jerkins-bot: [V: -1] Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:36:57] (PS8) Eileen: Add 2018_2019_total & 2019_2020_total to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [22:43:12] (PS4) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [22:43:49] (CR) jerkins-bot: [V: -1] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:47:32] (PS4) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [22:48:08] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:49:43] (PS5) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [22:50:17] (CR) jerkins-bot: [V: -1] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [22:52:27] (PS6) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [22:55:47] (PS5) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [22:56:07] (PS3) Eileen: Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [22:56:23] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [22:56:43] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [23:01:36] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: add Deduper permission for DS contractor - https://phabricator.wikimedia.org/T229289 (MBeat33) [23:06:42] (PS6) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [23:14:55] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [23:35:57] (PS7) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [23:51:42] (CR) jerkins-bot: [V: -1] Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen)