[00:36:57] (PS1) Eileen: Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) [00:37:08] (CR) jerkins-bot: [V: -1] Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [00:42:21] (PS2) Eileen: Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) [00:48:19] (CR) jerkins-bot: [V: -1] Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [00:50:49] (PS3) Eileen: Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) [00:55:12] Am trying deleing 62 donations (all the ones over $1k) on staging for our largest matching gifts donor to see if that jams it [01:04:38] Ok - this is the change we want to try re-enabling with https://gerrit.wikimedia.org/r/#/dashboard/self [01:05:21] deleting 62 donations is slow but so far in that each one takes some time - not in a server hanging way [01:05:57] but the question is what happens when there are many contenders for max donations on a contact with many donations... [01:28:43] (PS8) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [01:32:11] (PS4) Eileen: Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [01:32:45] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [01:46:38] (PS5) Eileen: Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [01:47:13] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowmnet [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [01:48:56] (PS6) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [01:49:32] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [01:51:34] (PS1) Eileen: Remove reference to log_civicrm DB [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526291 [01:52:15] (CR) jerkins-bot: [V: -1] Remove reference to log_civicrm DB [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526291 (owner: Eileen) [01:58:46] ejegg: I put up the patch to remove that join [01:59:11] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/526286/ [01:59:36] thanks eileen, taking a look now [02:00:03] still fighting tests a bit on some of the silverpop changes but I think the ones that are passing are good [02:00:33] k, I'll check those next [02:03:40] (PS7) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [02:04:16] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [02:04:30] (CR) Ejegg: [C: +2] "Thanks, this is certainly worth a shot!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [02:04:48] Also I've succeeded in jamming up staging by deleting the 62 largest of 21k donations from one donor - but the pattern is that each one is taking a while - e.g it's up to 70 seconds per donation now - but no one query is hanging [02:04:58] is that consistent? [02:05:46] my expectation is that once I delete enough that there are MANY at a level it will slow down - ie. it was quick to delete the highest ones because the next highest ones were unique [02:06:02] less so as I get rid of a whole tier [02:07:45] (PS8) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [02:08:21] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [02:09:35] (Merged) jenkins-bot: Remove largest_donation_date from calcs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526286 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [02:09:58] eileen interesting. What we saw on Wednesday looked more like a deadlock [02:10:24] or at least something hanging way longer than you'd expect [02:10:33] hmm - but it didn't give up like it would if it detected one - but a specific query hanging? [02:10:33] that one query had age 12k seconds [02:10:58] 3 hrs 20 min [02:11:22] and was preventing anything else from saving contributions [02:11:36] yeah this actually DID finish - it just too an average of 60 sec per delete - but only once it got down to the point where it has lots of equal maxes [02:11:39] The fact that it was in 'sending data' state also seems weird [02:11:44] so it's not quite the same pattern [02:12:12] hmm yeah because 'sending data' can't be 'waiting for the table to be available from something else' can it? [02:13:06] i wouldn't think so [02:13:14] also, sending data where? [02:13:39] i always thought 'sending data' meant it was pushing the response over the wire to the client [02:13:59] but since this was just a trigger, where would it be sending data? [02:14:21] into wmf_donor? [02:14:44] huh, i guess _/-0-\_ [02:15:17] * ejegg looks up how to actually make shrug emoticon [02:15:31] :-) [02:15:46] oh heh, it's with hiragana [02:15:46] all the hits on sending data wind up with explain statements [02:16:04] ¯\_(ツ)_/¯ [02:17:05] well done [02:17:52] ejegg: also this relates to a recent change by you that seemed wrong to me https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/526291/ [02:18:59] oh yeah, I guess that was over-flexible [02:19:27] so the python bit also looks for db prefixes and replaces them with stuff from settings [02:20:10] and since we always have the log_civicrm_db configured to be the same as the civicrm_db, it's unneeded [02:20:32] ah right [02:20:41] if you're deleting it there, you can delete that bit from the settings template as well, and the replace logic [02:21:22] Ok - I'll look - I'm stuck on this test fail atm https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/526268/ [02:22:56] eileen I think you still need the ORDER BY in that SELECT [02:23:36] you're getting rid of the ORDER BY receive_date DESC, total_amount DESC [02:23:50] oh that is by email [02:23:52] which is what makes the magic work with the ON DUPLICATE KEY [02:24:18] so, we rely on that order by to first insert the most recent stuff [02:24:40] then when it hits a duplicate email, we know it's trying to insert something older [02:24:46] (PS9) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [02:24:50] so our ON DUPLICATE KEY UPDATE is a no-op [02:25:22] (CR) jerkins-bot: [V: -1] Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [02:25:32] hmm, still? [02:27:41] eileen there's this patch floating around too, to clear up those 'null' warnings: https://gerrit.wikimedia.org/r/520664 [02:27:50] (PS10) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [02:29:03] (CR) Eileen: [C: +2] "Yes, I agree" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520664 (owner: Ejegg) [02:29:25] ejegg: ok - it WAS the order by - it's passing . now [02:29:40] (Merged) jenkins-bot: Fix NOT NULL warnings in silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520664 (owner: Ejegg) [02:30:33] :) [02:30:48] ejegg: [02:30:51] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526294 [02:31:01] everything in here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/526294/-1..1 [02:31:05] gtg? [02:31:19] I think I need to do some vendor composering for it [02:31:45] (then I'll re-calc triggers for Jeff to load tomorrow) [02:31:56] ah, no, no composering needed [02:32:07] there was a little snafu in the composer.lock for the last update [02:32:18] I fixed it on deploy branch [02:32:26] then I realized I needed to fix it in master too [02:33:01] but you can see in the change list that composer.lock didn't actually differ after the merge [02:33:12] the rest does look good [02:33:21] that JA thank you letter is one character [02:33:24] changed [02:35:49] ah cool - ok I'll deploy that & then get back to figuring out what is left to do after the changes already in gerrit [02:36:53] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526294 (owner: Eileen) [02:37:48] !log civicrm revision changed from 121feb5d53 to 1d57aca19c, config revision is 3f960c48f6 [02:37:55] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [02:43:38] eileen: only thing stopping me from +2ing this is the commit headline suggesting it's FY totals when it's really CY totals: https://gerrit.wikimedia.org/r/514416 [02:46:19] ejegg: will fix [02:51:53] (PS9) Eileen: Add total_2018 to total_2020 to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) [02:52:22] (PS7) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [02:53:19] (PS9) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [02:53:32] (PS11) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [02:56:09] (Abandoned) Eileen: Remove reference to log_civicrm DB [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526291 (owner: Eileen) [02:56:27] couldn't be bothered with that one since it's working :-) [02:59:21] (CR) Ejegg: [C: +2] Add total_2018 to total_2020 to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [02:59:32] heh, right on [03:00:55] ejegg: it's worth noting the reason I went for one big query in the triggers was more to do with the scenario - ie. I think it has to be a single query or a 'procedure' [03:02:01] (CR) Ejegg: [C: -1] "Couple fixes suggested inline" (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:02:47] ejegg: ouch - glad I got you checking! [03:04:29] eileen: yeah, inside a trigger the options are a lot more limited, right? [03:05:06] (PS8) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [03:05:08] I think so [03:05:16] ^^ that should be fixed now [03:06:31] (PS9) Eileen: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) [03:06:42] I guess that IFNULL means COALESCE [03:07:16] but, I found it a bit confusing - it feels like IF this is null then print that (which it is) but then I'm like 'but what if it's not null' - ohhhh [03:07:23] oh right, i'm not sure what the distinction is [03:07:40] I think they might be the same [03:08:37] OK - the difference is COALESCE can do more [03:08:39] https://stackoverflow.com/questions/18528468/what-is-the-difference-bewteen-ifnull-and-coalesce-in-mysql/43205713 [03:08:46] ie it can take more than 2 parameters [03:09:29] (CR) Ejegg: [C: +2] Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:10:38] You know when I look at this job there IS quite a strong incentive to nail that 'largest donation' because we calculate it here [03:10:47] thanks for the lookup! so we could swap those out for COALESCE and decrease the cognitive load [03:13:32] (PS1) Eileen: Commit updated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526298 (https://phabricator.wikimedia.org/T229273) [03:13:36] yeah I think we could [03:15:46] ejegg: you think just pushing . through those triggers to live will be OK for jeff to load from there? [03:16:03] I can create a cut down although it's more handling so more chance for mistakes [03:16:23] (I'm thinking he might re-load them when I'm not in but I guess he won't) [03:18:08] eileen: hmm, so live-ish reload of all triggers, or manual file-mangling [03:18:18] yep [03:18:35] jeff will prefer the latter won't he? [03:18:39] I guess either could work, or either could hit a snag [03:18:59] yeah, Jeff would probably prefer a targeted strike [03:22:11] (PS1) Eileen: WMF donor only triggers file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526299 (https://phabricator.wikimedia.org/T229273) [03:22:15] ok - I put up a targetted one too [03:23:16] ejegg: so we have the patches merged to add the fields so we can proceed with co-ordinating that with Caitlin now can't we [03:23:22] & then the others can follow [03:24:23] oh not merged - this one isn't approved https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/514416/ [03:24:45] even though you DID +2 it [03:24:52] weird, where did that go? [03:24:57] (CR) Ejegg: [C: +2] Add total_2018 to total_2020 to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:25:31] (Merged) jenkins-bot: Add total_2018 to total_2020 to silverpop export [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/514416 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:25:34] (Merged) jenkins-bot: Add endowment fields to silverpop [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526261 (https://phabricator.wikimedia.org/T170972) (owner: Eileen) [03:26:31] (PS10) Eileen: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) [03:26:44] (PS12) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [03:29:10] lol Jack just told me he is 'upgrading his grunge bot & downgrading his toy car' [03:29:34] what he means is the toy car is being pulled apart so he can take out the sensor [03:29:57] (he amended to 'permanently downgrading' when I commented) [03:32:55] hehe [03:33:07] so what is a grunge bot? [03:34:26] a home made robot made out of junk [03:34:43] (CR) Ejegg: [C: +2] "Ooh, and so close to getting rid of a join, too!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [03:35:18] (Merged) jenkins-bot: Use wmf_donor fields for stats to avoid endowment munging [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526263 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [03:35:23] sounds like a fun project! [03:36:58] https://www.google.com/search?q=reusing+rc+car+controller+board&rlz=1C5CHFA_enNZ849NZ849&oq=reusing+rc+car+controller+board&aqs=chrome..69i57j33l3.10432j0j7&sourceid=chrome&ie=UTF-8 [03:38:18] nitpicking again, but maybe add the last_donation_usd back to the ORDER BY to keep consistent with the comment above that operation? https://gerrit.wikimedia.org/r/526268 [03:42:53] OK - I think there is a bit of luck in that stuff working but no harm for now [03:45:05] (PS13) Eileen: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) [03:45:10] ejegg: ^^ [03:48:44] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, and 3 others: Add calendar year totals fields to CiviCRM & export ? some? of them to silverpop - https://phabricator.wikimedia.org/T170972 (Eil... [03:48:50] (CR) Ejegg: [C: +2] "Awesome, this one DOES get to eliminate a couple joins!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [03:49:01] gotta kill those joins [03:49:25] (Merged) jenkins-bot: Update latest calcs to avoid endowment [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526268 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [03:49:37] ejegg: I'm still working on the fields not having endowment but we can co-ordinate with Caitlin any time now as the part that needs co-ordination is done [03:50:20] (CR) Ejegg: [C: +2] Commit updated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526298 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [03:51:37] eileen: ah right, only the new fields need coordination [03:51:45] :) [03:52:10] well I pinged her on the phab so hopefully she notices - do we just deploy tools the same way as civicrm [03:52:41] almost. For some reason, the deployment branch is just known as 'deploy' in that repo [03:53:04] I'm pretty sure the fundraising_code_update project name is 'tools' [03:55:10] ok - well I'll wait for her response but once she is ready we can push out [03:55:24] & I'll keep looking at the script a little more [03:56:00] (Merged) jenkins-bot: Commit updated triggers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526298 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [03:57:02] (CR) Ejegg: [C: +2] "It's a clean excision, doctor!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526299 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [03:57:14] lol [03:57:23] OK, I'm off to bed. Have a good tomorrow! [04:02:06] (Merged) jenkins-bot: WMF donor only triggers file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526299 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [04:05:25] night [04:06:15] (PS1) Eileen: Exclude endowment donations from highest total [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) [04:06:44] (PS2) Eileen: Exclude endowment donations from highest total [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) [04:06:46] (CR) jerkins-bot: [V: -1] Exclude endowment donations from highest total [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [04:07:15] (CR) jerkins-bot: [V: -1] Exclude endowment donations from highest total [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [04:09:57] Fundraising Sprint Office  , Fundraising-Backlog: Republish Japanese Thank You email - https://phabricator.wikimedia.org/T228680 (Ejegg) @TSkaff This just went out along with some other Civi fixes. [04:39:08] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526304 [04:46:08] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526304 (owner: Eileen) [04:46:48] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526304 (owner: Eileen) [04:47:32] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Figure out crashing state - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) @Jgreen on live there is now a trigger file sites/all/modules/wmf_civicrm/scripts/contribution_trig... [04:48:14] !log civicrm revision changed from 1d57aca19c to 218328b29d, config revision is 3f960c48f6 [04:48:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [14:05:26] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: add Deduper permission for DS contractor - https://phabricator.wikimedia.org/T229289 (MBeat33) Actually, Rakhi cid=34448858 also gets this error with Deduper, could you extend the permissions to her as well? Thank you [14:07:54] Fundraising-Backlog: Jobs disabled - https://phabricator.wikimedia.org/T229331 (mepps) [16:22:23] (PS6) Jgleeson: WIP: Update SmashPig recurring processor to handle making first payments. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [16:28:08] (CR) jerkins-bot: [V: -1] WIP: Update SmashPig recurring processor to handle making first payments. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [17:06:51] (PS4) Cstone: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) [17:08:33] (CR) Cstone: "> Existing code to update:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [17:14:18] (CR) jerkins-bot: [V: -1] Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [18:05:06] (PS5) Cstone: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) [18:10:59] (CR) jerkins-bot: [V: -1] Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [20:46:21] Jeff_Green: so we have those triggers ready for you to reload [20:46:48] ok [20:47:54] I don't see any payments activity right now, that's good [20:50:44] i think (?) it's done [20:50:56] although it was rediculously fast to return which gives me some doubt [20:51:44] Jeff_Green: so you reloaded it? I'll check some donations then [20:51:59] yes [20:52:05] I think it was a cut down one - just 2 triggers [20:54:01] ah right, makes sense now [20:54:57] ok the most recent donation was a 8.45 & the summary isn't updated - but I think that's because you did it at 8.46 [20:56:12] I added & deleted a $1 donation from that contact & it updated [20:56:19] cool [20:57:20] I'll keep an eye out for more coming in [20:57:24] cool [21:20:30] (PS6) Cstone: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) [21:28:11] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526534 [21:29:00] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526534 (owner: Eileen) [21:29:33] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526534 (owner: Eileen) [21:35:39] Jeff_Green: how is the silverpop export scheduled on staging? (I just deployed some updates & want to check when it will run / maybe run now manually to test) [21:36:20] that's a really good question, lemme see if I can figure it out [21:36:54] :-) [21:39:03] i don't see anything in cron or process-control [21:40:13] hmm [21:40:29] it runs from staging box but .... [21:40:38] I know it DOES run [21:47:08] i don't even know how to tell that, I don't see anything via "grep -i silver" in logs [21:47:50] could it be that it runs on civi1001 and just uses the dev database? [21:48:45] eileen: oh that's ^^^ it I think, there's a p-c job silverpop_daily.yaml on civi1001 [21:49:05] oh - ok - interesting [21:49:49] we were talking about the read only civi connection yesterday - if we got that working it opens up some interesting options for how to get off outdated python for that job [21:53:52] nice [21:57:01] Jeff_Green: that was a conversation we thought we could have next tech talk because from our POV we need you to help us figure out how to test it / progress going live with the read only db connection [21:57:58] ok, sounds good! [21:59:01] i'm happy to bikeshed in IRC between now and then, except in the next hour b/c I've gotta interview a candidate! [22:01:15] happy interviewing :-) [22:11:06] (PS1) Eileen: Revert "Switch to pymysql" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526548 (https://phabricator.wikimedia.org/T213757) [22:11:26] (CR) Eileen: [C: +2] "merging through to deploy - will re-do once deployed" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526548 (https://phabricator.wikimedia.org/T213757) (owner: Eileen) [22:12:02] (Merged) jenkins-bot: Revert "Switch to pymysql" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526548 (https://phabricator.wikimedia.org/T213757) (owner: Eileen) [22:12:05] ok - fail mail was deploy related - backing out the commit [22:13:38] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526549 [22:13:48] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526549 (owner: Eileen) [22:14:14] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526549 (owner: Eileen) [22:15:02] !log tools revision changed from 8a464c4f0d to 4910f1507c (reverted pgmysql switch) [22:15:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:20:11] (PS7) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [22:28:13] (PS3) AndyRussG: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [22:30:41] (CR) jerkins-bot: [V: -1] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [22:34:00] (PS8) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [22:35:31] (CR) Jgleeson: [C: -1] "hmm looks like there are some tabs vs spaces issues here, will fix." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [22:37:47] (CR) AndyRussG: [V: +2 C: +2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525680 (owner: AndyRussG) [22:39:10] (PS4) AndyRussG: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [22:44:03] (CR) jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525680 (owner: AndyRussG) [22:44:47] (Restored) AndyRussG: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525677 (https://phabricator.wikimedia.org/T227711) (owner: AndyRussG) [22:45:01] (PS2) AndyRussG: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525677 (https://phabricator.wikimedia.org/T227711) [22:48:23] (CR) AndyRussG: [C: +2] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [22:52:10] (Merged) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [22:52:35] (CR) AndyRussG: [C: +2] Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525677 (https://phabricator.wikimedia.org/T227711) (owner: AndyRussG) [22:56:09] (Merged) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525677 (https://phabricator.wikimedia.org/T227711) (owner: AndyRussG) [22:57:43] (CR) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/526170 (https://phabricator.wikimedia.org/T229194) (owner: Jforrester) [23:03:32] (CR) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/525677 (https://phabricator.wikimedia.org/T227711) (owner: AndyRussG) [23:11:16] (PS1) Catrope: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 [23:11:23] (CR) Catrope: [C: +2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 (owner: Catrope) [23:14:58] (CR) jerkins-bot: [V: -1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 (owner: Catrope) [23:15:03] (CR) jerkins-bot: [V: -1] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 (owner: Catrope) [23:18:38] (PS1) Catrope: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) [23:18:44] (CR) Catrope: [C: +2] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:20:38] (CR) jerkins-bot: [V: -1] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:20:44] (CR) jerkins-bot: [V: -1] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:36:28] (CR) Catrope: [V: +2 C: +2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 (owner: Catrope) [23:37:54] (PS2) Catrope: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) [23:38:02] (CR) Catrope: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:38:06] (CR) Catrope: [C: +2] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:39:48] (CR) jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526558 (owner: Catrope) [23:41:50] (Merged) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:43:04] (PS1) Catrope: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526563 (https://phabricator.wikimedia.org/T227711) [23:44:29] (PS1) Catrope: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526564 [23:44:34] (CR) Catrope: [V: +2 C: +2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526564 (owner: Catrope) [23:44:50] (PS1) Catrope: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526565 [23:44:55] (CR) Catrope: [V: +2 C: +2] Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526565 (owner: Catrope) [23:45:23] (PS1) Catrope: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526566 (https://phabricator.wikimedia.org/T229194) [23:45:29] (CR) Catrope: [C: +2] Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526566 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:45:38] (PS1) Catrope: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526567 (https://phabricator.wikimedia.org/T227711) [23:45:45] (PS2) Catrope: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526567 (https://phabricator.wikimedia.org/T227711) [23:45:50] (CR) Catrope: [C: +2] Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526567 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [23:45:59] (CR) Catrope: [C: +2] Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526563 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [23:47:42] (CR) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526559 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:49:12] (Merged) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526566 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [23:49:29] (Merged) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526567 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [23:49:44] (Merged) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526563 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [23:53:18] (CR) jenkins-bot: Avoid usage of deprecated `ObjectCache::getMainWANInstance()` [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526565 (owner: Catrope) [23:56:09] (CR) jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526564 (owner: Catrope)