[00:01:45] (CR) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526567 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [00:07:13] (CR) jenkins-bot: Make CNDeviceTarget::addDeviceTarget() use DB_MASTER [extensions/CentralNotice] (wmf/1.34.0-wmf.15) - https://gerrit.wikimedia.org/r/526566 (https://phabricator.wikimedia.org/T229194) (owner: Catrope) [00:07:51] (PS1) Eileen: Fix missing db name on table join [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526568 (https://phabricator.wikimedia.org/T228349) [00:08:24] XenoRyet: are you still about - looking for a quick + 2 on this aising/tools/+/526568/ [00:08:33] sorry https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/526568/ [00:08:58] the silverpop job just fell over on that [00:09:12] The kids are home any moment now, but I'll try to take a quick peek. [00:09:59] Oh, sure. That's easy enough. [00:11:25] (CR) XenoRyet: [C: +2] Fix missing db name on table join [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526568 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [00:11:45] thanks [00:11:59] (Merged) jenkins-bot: Fix missing db name on table join [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526568 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [00:12:53] (CR) jenkins-bot: Banner history logger: remove loading of schema module [extensions/CentralNotice] (wmf/1.34.0-wmf.16) - https://gerrit.wikimedia.org/r/526563 (https://phabricator.wikimedia.org/T227711) (owner: Catrope) [00:18:58] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526570 [00:19:10] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526570 (owner: Eileen) [00:19:37] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526570 (owner: Eileen) [00:20:07] (PS1) Eileen: Revert "Revert "Switch to pymysql"" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526571 [00:24:30] !log tools revision changed from 4910f1507c to 2a56e5e283 [00:24:36] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:28:36] d'oh, sorry I missed that eileen [00:28:56] ejegg|away: which bit? I think it's all sorted [00:29:26] oh, it wasn't just the missing db name? [00:29:32] Ah yeah it was [00:29:40] but I backed out your change cos I deployed it & it didn't work [00:29:47] ie this one [00:29:48] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/526571/ [00:29:58] it looked like it would 'just deploy' but it didn't [00:30:13] so I reverted & will re-merge to master once the job completes [00:30:28] oh shoot, i should have been around for that deploy [00:30:43] well it was my choice to try to include that rather than cherry-picking [00:30:53] but it was the wrong choice so I adjusted :-) [00:30:57] i thought it would 'just work' too tbh [00:31:23] :-) [00:31:31] the other things in the commit seem fine - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/tools/+/526534/-1..1 [00:31:45] i did do some basic testing on it locally, with the silverpop export [00:32:05] and it looked like the python package existed on civi [00:32:23] Yeah - well when you are working again you can try to figure it out [00:32:37] will follow up on the error messages when i'm back at a computer [00:32:54] yeah - it just didn't find it [00:33:08] maybe Jeff will need to help? [00:33:21] how's the sight seeing? [00:41:26] great! [01:35:51] (PS3) Eileen: Add prospecting fields missing from dev envs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524960 (https://phabricator.wikimedia.org/T228713) [01:35:53] (PS1) Eileen: Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 [02:31:31] (PS2) Eileen: Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 [02:31:33] (PS1) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [02:33:31] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [02:43:51] (PS2) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [02:45:09] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [02:49:12] (PS3) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [02:54:42] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [04:44:25] (CR) Eileen: [C: +2] Revert "Revert "Switch to pymysql"" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526571 (owner: Eileen) [04:45:00] (Merged) jenkins-bot: Revert "Revert "Switch to pymysql"" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526571 (owner: Eileen) [05:03:19] (PS1) Eileen: Loosen permissions on deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526593 (https://phabricator.wikimedia.org/T229148) [05:08:49] (CR) jerkins-bot: [V: -1] Loosen permissions on deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526593 (https://phabricator.wikimedia.org/T229148) (owner: Eileen) [15:22:39] Jeff_Green: I just pinged you on phab asking for a deb package install as part of https://phabricator.wikimedia.org/T213757 - lmk if you want me to break that out to a separate ticket [15:23:09] ejegg: ok, looking [15:25:03] thanks! [15:25:22] fr-tech: any news for scrum of scrums? [15:30:51] ejegg: out of curiosity, why python-pymysql instead of python3-mysqldb? [15:31:15] Jeff_Green: oh, I was unaware of that one [15:31:28] I know pymysql work on python2 as well as python3 [15:31:42] so it seemed like a good candidate to use for the transition [15:31:49] this isn't something I've looked into, I just saw it in the repo for a buster box I have in virtualbox [15:31:56] and was a near-drop-in replacement for the previous one [15:32:14] i see, ok [15:33:13] (tools are still running on python2, pending review and merge of https://gerrit.wikimedia.org/r/520350) [15:35:44] hmmm. you know there's also python3-pymysql [15:35:44] nothing from mee [15:36:10] Jeff_Green: I think installing python-pymysql will pull that one in if you have python3 installed [15:36:25] ok [15:37:25] not sure exactly how those deps work, but I just had to install the one pkg [15:38:44] i'll keep an eye on that in case we need to separately add the v3 version [15:39:35] (PS9) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [15:57:57] cstone, I was just reviewing your recurring token support patch and I picked up on the points about also updating the SmashPig CiviCRM ext to be consisent with the name changes. Did you start a patch for that or would you like me to add it as a follow on to my patch ? [15:58:18] consistent* [16:02:27] jgleeson i guess I just changed them there as I thought it went with what I had been doing, would it make more sense to break it out then? [16:03:12] oh no you already did it, sorry I missed that [16:03:28] nice! [16:06:28] oh one question I had is RECURRING INGENICO vs just INGENICO in the trxn_id [16:08:31] hmm [16:08:55] looks like there is precedent for that RECURRING prefix but I can't see where it gets added [16:23:30] cstone oh shoot, yeah, that is the convention for a recurring donation [16:23:54] so let's see [16:29:01] we wouldn't want to add that to the first donation (the one that's for the higher amount), though [16:29:39] fr-tech: Be a few minutes late to standup. Marek is having a meltdown this morning. [16:30:07] :( XenoRyet [16:30:25] meltdowns are no fun! [16:30:41] (CR) AndyRussG: Campaign fallback (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [16:33:37] (CR) Jgleeson: [C: -1] "I think we need to map processor_id to the contribution processor_id field and not trxn_id. I might be wrong!!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [16:39:52] (CR) Ejegg: "This does seem like a weird hack. Can't we leave out the join to wmf_donor and just add the financial_type_id check?" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [16:40:43] fr-tech: Yea, this isn't going to resolve in time to get to the meeting. By way of update that dlocal investigation task is off our plate now, turns out that sometimes transactions just don't show up in the audit files until days or weeks later, so we're kicking back over to them to ask. Gonna try to document some of the log digging I did, then get to some code review. [16:42:14] ejegg we stopped talking about parenting if you want to rejoin :) [16:42:23] we're assuming you're having internet trouble thoguh [17:29:36] fr-tech here's the existing payment IDs doc: https://www.mediawiki.org/wiki/Fundraising_tech/Transaction_IDs [17:29:46] definitely needs a couple things added [17:31:34] fr-tech, be 1 minute! [17:51:10] hi fr-tech (cc: katers), we've got some new fields that are being imported into IBM thanks to yall! now i have a few questions before i set up the mapped fields: are the names in the phab task (T222958) the right names? the file that is being created from civi that gets uploaded into IBM each night - i would need the name of the fields in that file (and the names cannot contain any spaces) [17:51:11] T222958: New total fields needed for MG prospecting - https://phabricator.wikimedia.org/T222958 [17:51:19] is there a place that i can access that list of names inside the file? [17:53:50] Fundraising-Backlog, Wikimedia-Fundraising: When donating, "Tax deductibility information" and "Frequently asked questions" lead to a soft redirect rather than the actual pages - https://phabricator.wikimedia.org/T229457 (Deskana) [17:56:34] mnoor here's the latest version of the code that creates the file: https://phabricator.wikimedia.org/diffusion/WFTO/browse/master/silverpop_export/update_table.sql$447 [17:57:37] the field names will be that last part of each line [17:58:06] so e.g. line 449 has this: contact_id ConctactID, [17:58:22] which means ContactID is the field name in the exported file [17:58:39] the new ones are from lines 472-478 [17:58:54] thank you! [18:12:12] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: create annual $ summary TY email button - https://phabricator.wikimedia.org/T221271 (MBeat33) Ideally this would be a list of donations + a summary: "Your 2018 total was $30.00 USD June 1, 2018 $15.00 USD September 1, 2018 $15.00 USD" If the Ci... [18:18:05] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: build out TY email translations and Language Preference settings - https://phabricator.wikimedia.org/T227903 (MBeat33) Even the capacity to chose from a dropdown among available TY email translations currently in Civi, similar to the way we can ch... [18:37:57] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog: Make the fraud queue consumer consume more frequently. - https://phabricator.wikimedia.org/T227803 (Ejegg) Open→Resolved a:Ejegg We did all we could with scheduling - the next step is breaking up... [18:43:42] Fundraising Sprint Never Ending Query, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Nurse love & iterate on our targetsmart batch job - https://phabricator.wikimedia.org/T228715 (XenoRyet) [18:51:40] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421 (Ejegg) Open→Resolved a:Ejegg [19:32:57] fr-tech anyone have +2 in mediawiki-config? https://gerrit.wikimedia.org/r/526756 [19:33:06] quick win for some sprint progress ^^^ [19:33:09] i'll take a look ejegg [19:33:14] thanks! [19:34:40] (CR) XenoRyet: [C: +2] India-specific PAN error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/525545 (https://phabricator.wikimedia.org/T224506) (owner: Ejegg) [19:34:47] apparently i can't +2 ejegg :( [19:34:53] Me either [19:35:12] did get that little India patch for you though. [19:35:16] oh shoot [19:35:30] thanks for that XenoRyet [19:35:40] (Merged) jenkins-bot: India-specific PAN error messages [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/525545 (https://phabricator.wikimedia.org/T224506) (owner: Ejegg) [19:37:45] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/526758 [19:38:01] I'll just push out that and the fix for the subscr_id [19:38:20] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/526758 (owner: Ejegg) [19:39:01] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/526758 (owner: Ejegg) [19:41:56] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/526761 [19:42:02] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/526761 (owner: Ejegg) [19:43:55] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/526761 (owner: Ejegg) [19:50:24] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/526761 (owner: Ejegg) [19:52:26] Fundraising Sprint Office  , Fundraising-Backlog: Republish Japanese Thank You email - https://phabricator.wikimedia.org/T228680 (TSkaff) Thank you! [19:54:15] AndyRussG: do you have +2 in mediawiki-config? https://gerrit.wikimedia.org/r/526756 [19:55:53] !log updated payments-wiki from 70b432d309 to 9533f70fab [19:55:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:00:30] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/526761 (owner: Ejegg) [20:13:38] Fundraising-Backlog, fundraising-tech-ops: puppetize install of python-pymysql/python3-pymysql where fundraising-tools code is deployed - https://phabricator.wikimedia.org/T229439 (Jgreen) [20:14:35] Fundraising-Backlog, fundraising-tech-ops: puppetize install of python-pymysql/python3-pymysql where fundraising-tools code is deployed - https://phabricator.wikimedia.org/T229439 (Jgreen) Open→Resolved installed on civicrm and payments-listener roles where the 'tools' project is deployed [20:14:37] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Jgreen) [20:14:57] fundraising-tech-ops: Disable new wmf_donor triggers while we make them not lock the db - https://phabricator.wikimedia.org/T229076 (Jgreen) Open→Resolved [20:35:46] Fundraising-Backlog: RfC: CentralNotice backend improvements - https://phabricator.wikimedia.org/T468 (Aklapper) a:K4-713→None @K4-713: Resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that... [20:35:51] Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface: In the event that credentials for a gateway are not supplied, that gateway should go in to local development mode. - https://phabricator.wikimedia.org/T99954 (Aklapper) a:K4-713→None @K4-713: Resetting the a... [20:35:54] Fundraising Sprint Kraftwerk, Fundraising-Backlog, Fundraising-Backlog-Old, MediaWiki-extensions-DonationInterface, Epic: Hackathon idea: Make the DonationInterface extension as friendly as possible - https://phabricator.wikimedia.org/T89188 (Aklapper) a:K4-713→None @K4-713: Resetting... [20:55:42] (PS2) Eileen: Loosen permissions on deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526593 (https://phabricator.wikimedia.org/T229148) [21:05:48] we've had a few requests to open up permissions for deduping - I don't want us to be blocking this & ideally we would do it without giving them all Administer CiviCRM - I'd like to put this out & see if it is all that is needed https://gerrit.wikimedia.org/r/#/c/526593/ [21:35:31] Fundraising-Backlog, fundraising-tech-ops: puppetize install of python-pymysql/python3-pymysql where fundraising-tools code is deployed - https://phabricator.wikimedia.org/T229439 (Ejegg) thanks! [21:44:48] Fundraising-Backlog, Epic: [Epic] Revoke AWight fundraising privileges - https://phabricator.wikimedia.org/T168421 (awight) Gone but not forgotten <3 [21:51:26] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526786 [21:51:32] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526786 (owner: Ejegg) [21:51:59] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/526786 (owner: Ejegg) [21:56:50] !log updated fundraising python tools from 2a56e5e283 to 493a38f9e0 [21:56:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:00:55] fundraising-tech-ops: frpig* timing out on tools project rsync - https://phabricator.wikimedia.org/T229504 (Ejegg) [22:20:28] ejegg: can I get you to check https://gerrit.wikimedia.org/r/#/c/526593/ - it will hopefully unblock DS without us opening permissions too much [22:21:33] sure thing eileen [22:21:48] just going to take a little look into how the alterAPIPermissions hook works [22:21:59] Did I include a link? [22:22:25] not in the patch. is there a good explanation online? [22:22:29] Yes [22:22:41] well - moderate explanation [22:22:53] heh, better than nothing [22:23:07] https://docs.civicrm.org/dev/en/latest/hooks/hook_civicrm_alterAPIPermissions/ [22:23:17] thanks! [22:23:41] it defautls to administer CiviCRM if you set nothing [22:32:19] ejegg hopefully last question on this but the normal ingenico recurring payments just have the processor_id in contribution_recur.trxn_id, would we want to change that? [22:36:39] (CR) Ejegg: [C: +2] "Looks safe enough for our purposes!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526593 (https://phabricator.wikimedia.org/T229148) (owner: Eileen) [22:39:01] cstone oh really? I guess not for now [22:39:18] gotta relocate again... [22:42:51] (Merged) jenkins-bot: Loosen permissions on deduper [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526593 (https://phabricator.wikimedia.org/T229148) (owner: Eileen) [22:48:27] (PS7) Cstone: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) [23:27:49] (PS1) Eileen: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) [23:28:48] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526799 [23:29:01] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526799 (owner: Eileen) [23:29:49] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/526799 (owner: Eileen) [23:34:19] !log civicrm revision changed from 218328b29d to 857dcc9461, config revision is 84b785d41c [23:34:25] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:34:36] MBeat: I just pushed out a patch that might sort out deduper access for your staff [23:39:19] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Figure out crashing state - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) OK I'm getting good results on staging even updating 150k contacts at once -... [23:53:26] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Figure out crashing state - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) OK - so the number of rows is double there - ie select count(*) FROM civicr... [23:53:40] ejegg|afk: I think I can use the above to fill the missing data [23:54:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Extend Civi Deduper access to all Donor Services agents? - https://phabricator.wikimedia.org/T229148 (Eileenmcnaughton) @MBeat33 we pushed out a minor permissions change - see if they can access it now [23:55:17] ejegg|afk: I do have +2 there