[00:03:43] (PS2) Eileen: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) [00:08:35] (CR) jerkins-bot: [V: -1] Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [00:09:35] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [00:10:12] (PS3) Eileen: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) [00:16:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Extend Civi Deduper access to all Donor Services agents? - https://phabricator.wikimedia.org/T229148 (MBeat33) So far so good, cid=34488458 is now in Deduper - thanks, @Eileenmcnaughton [00:52:50] (CR) AndyRussG: Campaign fallback (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [02:33:52] (PS4) Eileen: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) [03:24:54] (PS5) Eileen: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) [08:01:11] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/526887 (owner: L10n-bot) [11:05:56] (CR) jenkins-bot: build: Updating lodash to 4.17.15 [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/527066 (owner: Libraryupgrader) [14:06:13] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Update data on staging - https://phabricator.wikimedia.org/T228710 (Jgreen) Open→Resolved done! [14:06:15] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: TargetSmart Civi import - https://phabricator.wikimedia.org/T227513 (Jgreen) [14:36:30] I feel like our current sprint name earns a place in our all timer hall of faller category [14:36:36] fr-tech^ [14:36:54] fundraising-tech-ops: frpig* timing out on tools project rsync - https://phabricator.wikimedia.org/T229504 (Jgreen) Open→Resolved p:Triage→Unbreak! This is fixed. I tested a deploy to frpig2001. I did not deploy to frpig1001, in case you should be around to watch behavior when the new code go... [14:37:07] comedy/smarts/relevance - has it all for me ha! [14:37:27] hall of fame* even [14:44:11] hey hey cstone [14:44:16] you around? [14:44:21] hey [14:45:27] can I use your latest rqc patch test out the fallback to invoiceid when calling the smashpig recurring job as discussed ? [14:46:30] yeah it is grabbing the contribution_trackng_id from the msg and putting it in invoice_id [14:53:53] thanks [14:54:05] also thanks for the review on the payment forms patch! [15:05:46] jgleeson: its already saved me a lot of time! [15:12:41] cstone, I'm struggling to invoke code (currently in tests) that touches on the changes you've made to recurring.inc https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/524909/7/sites/all/modules/wmf_civicrm/recurring.inc [15:13:02] did you have to put through a new recurring donation for that? [15:15:10] yeah that is the non updonate style recurring [15:17:54] ah ok thanks I'll put a recurring donation through without the variant in the URL [15:34:04] ejegg|afk, you don't happen to have a util which pretty prints our redis queue messages do you in your swiss-army knife util kit? [15:34:16] good timing! [15:34:17] jgleeson: shoot, not yet! [15:34:37] ah ok, I wanted to check before I add one [15:35:07] I've been using the `jq` utility to pretty-print json https://stedolan.github.io/jq/ [15:35:37] but not sure if it's widely used so might have to write a small process not dependant on another package [15:38:04] yes, I use it too! [15:38:42] looks like the python module `json.tool` would be more universally available? [15:38:56] echo '{"json":"obj"}' | python -mjson.tool [15:39:17] fr-tech, does the above work for you? [15:39:55] works for me [15:39:59] bootiful [15:40:11] awesome, thanks [15:40:21] yep! [15:43:09] ejegg, where does the fr-tech utils repo live again? [15:44:19] jgleeson: I put some stuff in github [15:44:21] lemme see [15:44:43] or you could put it in the fr tools repo [15:45:16] https://github.com/ejegg/binscripts [15:46:19] ah thanks. I'll fork that [15:47:07] Fundraising-Backlog, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (spatton) Hey @DStrine, copying over @MBeat33's thoughts from https://phabricator.wikimedia.org/T221271, as he has confirmed that some of the need... [15:49:52] (CR) AndyRussG: Campaign fallback (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [16:03:52] Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (spatton) Some details provided by @jgleeson: Re: ability to test multiple variants of the placeholder text: //we don't currently have a robust way to dynamically swap out placeholder text. It would require a... [16:15:48] Hi ejegg, I'm looking on https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/526756. Not sure if you know how to get it deployed, but if you want, I can help you to deploy the change in ~2 hours, if you're available by then [16:15:53] mepps, ^^ [16:16:55] hi Urbanecm! thanks for the offer. It looked like AndyRussG had some opinions on it too [16:17:34] (It's not urgent by any means) [16:18:18] ejegg, it seems to me that AndyRussG said the same thing I said, except the T225261 thing [16:18:19] T225261: CentralNotice setting a surprising content security policy in production when using &banner= URL parameter - https://phabricator.wikimedia.org/T225261 [16:18:24] (is that task related to this change anyhow?) [16:19:13] ejegg, basically, it's up to you in which window you want to deploy your change. Windows are listed on https://wikitech.wikimedia.org/wiki/Deployments [16:19:15] Urbanecm: hi! thanks so much. Yeah, I'd like us to discuss a bit more the content of the change. [16:19:36] (European SWAT, Morning SWAT and Evening SWAT are usable) [16:19:46] Urbanecm: yep! [16:20:04] AndyRussG, feel free to discuss the change, if you want :) [16:20:19] just wanted to offer a help with deploying, if you want to [16:21:01] feel free to ping me if you need my help with it :) [16:21:07] Urbanecm: thanks much appreciated!! We'll let you know... I also have deployment rights, but usually we do rely on the SWAT deploys, as you suggest [16:21:26] Really appreciate your reaching out!! :) [16:21:35] happy to help! [16:21:38] :) [16:22:02] ditto thanks Urbanecm! [16:22:08] yw! [16:33:20] (CR) AndyRussG: Campaign fallback (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [16:39:15] (CR) AndyRussG: Campaign fallback (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [16:45:00] (CR) Jgleeson: [C: +1] "Code looks good and works as expected for me! I'll give ejegg a chance to confirm before we give it the +2" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [16:53:08] (PS5) Ejegg: WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) [17:18:03] (CR) jerkins-bot: [V: -1] WIP Use new contribution tracking queue [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/510757 (https://phabricator.wikimedia.org/T215463) (owner: Ejegg) [17:41:13] yay, i can get on gerrit and phab after switching to cell data [17:54:53] woo [17:55:27] ejegg, looks like we have a convention in the tests of populating invoice_id with 0-9|string [17:56:12] for my tests checking the invoice_id fallback, I've maintained that but I'm thinking it might need to be a 0-9.0-9 convetion? [17:56:18] convention* [17:58:56] jgleeson yeah, we should update those tests! [17:59:26] ok I'll update the tests in a separate patch maybe [17:59:35] as I'll have to make sure it doesn't break the others [18:00:33] jgleeson: sounds good [18:16:14] (PS10) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [18:21:29] (CR) jerkins-bot: [V: -1] Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [18:25:29] (PS11) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [18:28:29] (PS1) Jgleeson: Update Smashpig Recurring Extension tests to use new invoice_id convention to closer reflect how it works in the real world [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527179 [18:29:07] ahhh case inconsistency senses tingling!!! [18:30:01] (PS2) Jgleeson: Update SmashPig recurring processor tests to use new invoice_id convention to closer reflect how it works in the real world [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527179 [18:49:52] Fundraising-Backlog: Look into CSP changes in core - https://phabricator.wikimedia.org/T229607 (DStrine) [19:32:43] (CR) Ejegg: "Thanks for all the tests! The try/catch and checking the error message feels a little fragile though. How about using a different API acti" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [20:02:08] (CR) Ejegg: [C: -1] "This looks great! Just one thing to change with the invoice ID - the message has an 'order_id' field that would be perfect for it." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [20:13:06] (PS8) Cstone: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) [20:13:34] Thanks ejegg! is order_id a column somewhere or is that just what we decided to call it? [20:14:49] cstone just what we decided to call it [20:36:01] (PS9) Ejegg: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [20:36:58] (CR) Ejegg: [C: +2] "Looks good! Let's watch this one very closely when we deploy it." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [20:42:42] (Merged) jenkins-bot: Add recurring token support to creating a subscription. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524909 (https://phabricator.wikimedia.org/T227048) (owner: Cstone) [21:28:17] fr-tech I'm super tired. Will make up a couple hrs either tomorrow or Mon/Tue, which I've taken off