[02:01:37] (CR) Jforrester: [C: +2] build: Updating dependencies [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/527301 (owner: Libraryupgrader) [13:47:15] PROBLEM - check_puppetrun on frdb2001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [13:52:15] RECOVERY - check_puppetrun on frdb2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [14:00:15] Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (NNichols) @spatton RE removing //Name// - I would not have thought of that but it makes sense to me to try it. [14:35:43] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Patch-For-Review, Unplanned-Sprint-Work: Bug: Trigger caused db locks - https://phabricator.wikimedia.org/T229273 (mepps) [14:43:10] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: As a drush user, I want to be able to schedule and limit queue jobs independently - https://phabricator.wikimedia.org/T227805 (mepps) [14:43:31] hey fr-tech, i'm just playing with using these naming conventions for our tasks: https://stratejos.ai/blog/naming-task-bug-user-story-titles/ [14:43:47] because personally, i often don't know what tasks mean when glancing at our phab board [14:52:08] Fundraising Sprint Office  , Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Bug: Qunit tests should not be ignored - https://phabricator.wikimedia.org/T227879 (mepps) [14:53:31] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Update our csv import library in drupal - https://phabricator.wikimedia.org/T228711 (mepps) [14:54:39] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (mepps) [14:54:54] hey mepps feels like a good idea. I've used user story language before and also slightly related is the gherkin testing BDD testing language which I find pretty useful as the tests/stories become a word in progress spec [14:55:07] work* [14:55:28] as in this jgleeson: https://cucumber.io/docs/bdd/better-gherkin/ ? [14:55:33] yeah! [14:55:41] cool! [14:55:41] I used it in behat - http://behat.org/en/latest/quick_start.html [14:56:45] thanks jgleeson! [14:58:47] is behat a lot like cucumber is for ruby? [15:00:57] yeah exactly mepps [15:01:04] I think behat is inspired from cucumber [15:01:08] or the early form of it [15:01:49] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) @DStrine Do you just want the list on the task or somewhere else? [15:02:08] mepps, Behat was heavily inspired by Ruby’s Cucumber project. Since v3.0, Behat is considered an official Cucumber implementation in PHP and is part of one big family of BDD tools. [15:02:12] from the site [15:02:22] wow that's so cool jgleeson! [15:03:23] so at a previous place I worked, we would have a standard ticket title (like we have now) and then the body of the ticket would be a User Story (like the one you added) and then a task on the ticket would be writing the test in gherkin (the given/when/then) [15:03:35] although that was a pretty slow process [15:03:40] but it did improve understanding of the work [15:04:42] we were trying to follow a BDD methodology, so behavioural test would always be first. In practice is never quite worked out that way all the time [15:05:38] but it was a cool thing to use for devs! :) [15:05:52] I think from behat I then found phpspec [15:05:58] which is spec-driven-design... [15:06:14] but that's just a fancy way of saying unit tests with nicer names [15:07:06] instead of testThingDoesAThing it was written like ItShouldDoAthingWhenConditionPresent and instead of using assertions, we'd used expectations much like with mocks [15:07:37] the added benefit being your tests then become an exportable spec document [15:08:04] so when people asking "can we do this thing" you can check the spec (tests) instead of trying to remember what goes on across a wide code base [15:08:17] people are** asking [15:08:50] that's pretty cool jgleeson [15:09:17] i'm working on improving the naming so we don't have click into the task to find out what the ticket is about [15:09:29] because i honestly get a little overwhelmed looking at our phab board [15:09:40] sounds like user stories would be perfect for that! [15:11:49] yup! i'm also working on adding project names to the titles a little bit [15:12:40] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) [15:56:08] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (DStrine) listing them here would be fine with me for now. I think... [16:28:10] (PS12) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [16:28:21] (CR) jerkins-bot: [V: -1] Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [16:30:27] (CR) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson) [16:54:02] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) a:mepps [17:09:07] hi fr-tech - i have some bad data that came out of the ibm import. i spoke with Brian (our Trilogy consultant) on what the issue could be and he said it's possibly an invalid date format (we use mm/DD/YYYY) or it could be that the "total_201x" amounts contain a comma and that would break the data as well (amounts should not contain any commas). would someone be able to check these in the file? [17:14:20] hey mnoor, is the current thinking that we supplied bad data as part of our export to the ibm system? [17:15:08] Fundraising-Backlog: New Custom Field - Endowment Site Listed as - https://phabricator.wikimedia.org/T229681 (NNichols) [17:22:51] that's what brian thinks after we ran a few queries in ibm [17:23:02] ^jgleeson [17:31:13] mnoor, could you send over some info in an email ideally with some affected records and any other supporting info I can look at (including places where to look). I will then see if I can shed any light when I come back from dinner a little later? Thanks much! [17:32:52] sure thing, enjoy your dinner [17:45:51] mnoor, could you send that to all of fr-tech in case anyone else can look into it too? [17:46:23] good shout mepps ! [17:59:03] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New civi fields possibly imported incorrectly into IBM - https://phabricator.wikimedia.org/T229684 (DStrine) [17:59:49] fr-tech mnoor I made a task^ does this have any immediate impact on your work today or monday? [18:00:12] great question dstrine [18:00:23] not today, no - next week, it will as we've got to get some endowment sends out [18:01:04] mnoor: ok cool. Eileen will be in on Monday. [18:01:36] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: New civi fields possibly imported incorrectly into IBM - https://phabricator.wikimedia.org/T229684 (DStrine) [18:01:48] mepps: is that task title ok? :) [18:03:06] Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug: "Total Bad Data" rows in IBM import should be in the correct format when exported out of Civi - https://phabricator.wikimedia.org/T229684 (mepps) [18:03:13] dstrine how's this? ^^ [18:06:32] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) Hmm, so one question. Are we just looking for the fields i... [18:59:06] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) This page: https://www.mediawiki.org/wiki/Fundraising_tech... [19:00:15] (PS13) Jgleeson: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) [19:34:08] mnoor, thanks for the email. Nothing quick and obvious stands out in your bug report so let's wait until Eileen is back around on Monday as dstrine mentioned and we can discuss on our check-in to triage/investigate further. Sorry I couldn't be more help! [20:16:59] no worries, i appreciate you looking into it on a Friday evening! have a wonderful weekend all [23:02:00] ejegg|away: mepps I wonder if the silverpop fails are not the new fields but the change to pgmysql [23:02:46] we could try reverting that & see? I thought it was the new fields at first but looking at the code I can't see how they would differ from the existing ones in formatting [23:12:15] eileen oh shoot, i tested with the option to just generate the export file after that deploy and thought it was fine [23:20:23] ejegg|away: yeah it could be the new fields but I think I'd rule out the pgmysql first [23:23:26] i'll take a peek in 15 min [23:50:24] eileen: ohh, so it's not the job failing, it's exporting with different formatting? [23:50:50] ejegg: seems so - mnoor is saying there are issues with date format & commas in thousands [23:53:13] lemme see if we can fix that while staying on pymysql