[01:04:50] <wikibugs>	 Fundraising-Backlog, Fundraising-Backlog-Old, Spike: Spike on Apple Pay - https://phabricator.wikimedia.org/T137714 (Yair_rand) Related: T212246
[07:49:30] <wikibugs>	 (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/528035 (owner: L10n-bot)
[08:06:16] <wikibugs>	 (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528016 (owner: L10n-bot)
[09:20:19] <wikibugs>	 (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/528035 (owner: L10n-bot)
[10:54:52] <wikibugs>	 Fundraising Sprint Office &nbsp;, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Fix CiviCRM import bug whereby it doesn't recognise labels - https://phabricator.wikimedia.org/T228825 (Eileenmcnaughton) Open→Resolved
[10:54:54] <wikibugs>	 Fundraising Sprint Never Ending Query, Fundraising Sprint Office &nbsp;, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: TargetSmart Civi import - https://phabricator.wikimedia.org/T227513 (Eileenmcnaughton)
[14:52:59] <wikibugs>	 Fundraising Sprint Never Ending Query, Fundraising Sprint Office &nbsp;, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: BannerHistoryLogger issue prevents users reaching payments wiki - https://phabricator.wikimedia.org/T227711 (Pcoombe) Open→Resolved Teste...
[16:12:09] <wikibugs>	 Wikimedia-Fundraising-Banners: Use semantic elements (<a>, <button>) - https://phabricator.wikimedia.org/T220528 (Pcoombe) Open→Resolved Fixed in latest banner versions.
[16:13:20] <wikibugs>	 Wikimedia-Fundraising-Banners: Navigating through desktop large form with keyboard can break it - https://phabricator.wikimedia.org/T225743 (Pcoombe) Open→Resolved Fixed in latest banner versions, by giving other steps `visibility: hidden;`
[16:15:16] <wikibugs>	 Fundraising-Backlog, Wikimedia-Fundraising-Banners: Closing donation banner breaks scrolling - https://phabricator.wikimedia.org/T212177 (Pcoombe) Open→Resolved a:Pcoombe Did a significant re-write of the desktop large banner scrolling behaviour, and this is now fixed. https://en.wikipedia.or...
[16:19:22] <wikibugs>	 Fundraising Sprint Office &nbsp;, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Bug: "Total Bad Data" rows in IBM import should be in the correct format when exported out of Civi - https://phabricator.wikimedia.org/T229684 (MNoorWMF) yes, we added them on Thursday. our consultant took a look at...
[16:22:31] <wikibugs>	 Fundraising-Backlog, Epic, Spike: Spike: Investigate potential for banner impressions rewrite - https://phabricator.wikimedia.org/T131278 (Pcoombe)
[20:06:35] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Add landingpage event processing [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/455869 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:08:44] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Truncate strings to DB column limit [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456434 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:08:53] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Refactor stats output [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456664 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:08:59] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Print a friendly message confirming config [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/456672 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:09:11] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Implement purge-incomplete for landingpage and output stats [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457090 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:09:24] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Rename package fr_user_event_consumer -> fruec [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457091 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:09:32] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Add event_type arg to log_file_mapper.get_lastest_time() [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457272 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:09:38] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Flag SQL template constants as private [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457691 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:11:33] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] "This is fixed in https://gerrit.wikimedia.org/r/#/q/Idcdfa446712c" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/457275 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:11:42] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Minor improvements in create_tables.sql [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/458565 (owner: AndyRussG)
[20:11:50] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Remove testing field (for banner previews) from CNEvents [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/463110 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:11:56] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Remove unused import in controller.py [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/469251 (owner: AndyRussG)
[20:12:04] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Fix logic for finding config file [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515373 (owner: AndyRussG)
[20:12:11] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Tweak README.md and config_example.yaml [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515376 (owner: AndyRussG)
[20:12:16] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Fix inline doc [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/515382 (owner: AndyRussG)
[20:12:22] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Fix regex to validate language code [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/516061 (owner: AndyRussG)
[20:12:28] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Move object cache to separate submodule [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/516062 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:12:36] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Rename Stat as _Stat in stats.py [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/524098 (owner: AndyRussG)
[20:12:42] <wikibugs>	 (CR) Jgleeson: [V: +2 C: +2] Fix typos in inline docs and comments [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/524101 (https://phabricator.wikimedia.org/T195594) (owner: AndyRussG)
[20:35:09] <wikibugs>	 (CR) XenoRyet: [C: +2] "Looks good to me, and I do kind of like the idea of using a try/catch structure here.  Makes sense to me to let the civi exception bubble " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson)
[20:40:35] <wikibugs>	 (Merged) jenkins-bot: Update SmashPig recurring processor to handle making first payments for upsell subscriptions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/525098 (https://phabricator.wikimedia.org/T227051) (owner: Jgleeson)
[20:40:48] <jgleeson>	 thanks XenoRyet !!
[20:41:03] <XenoRyet>	 No worries.  I did think that try/catch business was clever.
[20:42:48] <jgleeson>	 thanks man. i was inspired by the talk I saw in may on exceptions, to throw them more in __exceptional__ circumstances https://www.youtube.com/watch?v=Y2NGlSfnhZ4
[20:43:48] <XenoRyet>	 That's what I was thinking when I read the comments in the code.  Missing both things is an exceptional circumstance, let's use the exception.
[20:44:34] <XenoRyet>	 I think it probably ended up making the whole thing cleaner and more readable too.
[20:44:48] <jgleeson>	 :)
[21:01:17] <wikibugs>	 (CR) XenoRyet: "Looks good, and does what it says on the tin. Definitely an improvement on the old silly way." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/524535 (owner: Ejegg)
[21:33:18] <wikibugs>	 (PS1) Eileen: Submodule commit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528273
[21:33:58] <wikibugs>	 (PS2) Eileen: Submodule commit CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528273
[21:34:04] <wikibugs>	 (CR) Eileen: [C: +2] Submodule commit CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528273 (owner: Eileen)
[21:36:22] <eileen>	 jgleeson: I want to do a small deploy - do you know if these 2 are OK to go out ?
[21:36:22] <eileen>	 + 8954c5c0ed980469452f0c0ca79e4b91c518030d Add recurring token support to creating a subscription.
[21:36:22] <eileen>	 + fa560ade3dcf630b8c52f2c7d4f6e7f6f4213bf1 Update SmashPig recurring processor to handle making first payments for upsell subscriptions.
[21:45:04] <wikibugs>	 (PS2) Eileen: Exclude Refund contributions from calculations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527706 (https://phabricator.wikimedia.org/T229273)
[21:48:27] <jgleeson>	 checking eileen
[21:50:43] <jgleeson>	 eileen, we're gonna hold off deploying them now as they're part of the upsell chain we've been working on. Hopefully we can push these out tomorrow and watch them closely as they change a few things in our current recurring flow
[21:50:56] <eileen>	 jgleeson: thanks - I'll exclude them
[21:51:00] <jgleeson>	 thanks!
[21:51:28] <wikibugs>	 (Merged) jenkins-bot: Submodule commit CiviCRM [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528273 (owner: Eileen)
[21:51:38] <eileen>	 Hmm ejegg|away had given this +2 but it disappeared when I adjusted the test to reflect the change https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/527706/
[21:51:47] <jgleeson>	 do you need any +2'ing eileen before I jump off?
[21:52:00] <eileen>	 jgleeson: yeah I think on that one just there
[21:53:31] <jgleeson>	 cool, looking now
[21:54:31] <wikibugs>	 (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527706 (https://phabricator.wikimedia.org/T229273) (owner: Eileen)
[21:57:10] <jgleeson>	 eileen, the test on that patch is failing for me
[21:57:17] <jgleeson>	 although it appears to work on ci :|
[21:57:30] <eileen>	 jgleeson: it alters the triggers
[21:57:37] <eileen>	 so you need to reload them ....
[21:57:41] <eileen>	 ccccccknfuvhvjkltkvdhgfnjlthjnrttvgfrghhvfng
[21:57:57] <jgleeson>	 actually the test fails on ci also
[21:58:04] <eileen>	 ah dang :-(
[21:58:08] <jgleeson>	 https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-docker/436/console
[21:58:28] <eileen>	 Isn't that before the latest?
[21:58:48] <jgleeson>	 ah yes it is!
[21:58:54] <eileen>	 ie isn't that the fail from before I changed the test
[21:59:14] <eileen>	 drush cvapi setting logging_no_trigger_permission=0
[21:59:30] <eileen>	 ^^ will make it so triggers load when you turn logging off & on
[21:59:38] <eileen>	 drush cvapi setting logging=0
[21:59:50] <eileen>	 drush cvapi Setting.create logging=1
[22:00:03] <eileen>	 previous lines were missing the create
[22:00:18] <jgleeson>	 ah now I'm thinking my civi settings my be oudated
[22:00:24] <jgleeson>	 drush cvapi setting logging_no_trigger_permission=0
[22:00:24] <jgleeson>	 API (Setting, ) does not exist (join the API team and implement it!)
[22:00:39] <eileen>	 yeah - that was what I meant about missing 'create'
[22:00:54] <eileen>	 drush cvapi setting.create logging_no_trigger_permission=0
[22:01:14] <eileen>	 on live that setting is 1 - because the civicrm mysql user does not have permission to reload triggers
[22:01:20] <eileen>	 but locally it's easier if it is 0
[22:02:11] <jgleeson>	 looks like I need to create the logging setting also
[22:04:15] <jgleeson>	 hmm
[22:04:24] <jgleeson>	 drush updb is falling over on:
[22:04:25] <jgleeson>	 Wmf_civicrm  7900  Update contacts with no completed contributions
[22:06:24] <jgleeson>	 Error Code: 1054. Unknown column 'largest_donation' in 'where clause'
[22:06:55] <eileen>	 jgleeson: arg an earlier update should have added that
[22:07:32] <jgleeson>	 yeah that's strange because I can see Performed update: wmf_civicrm_update_7895                                [ok]
[22:08:14] <eileen>	 hmm
[22:08:25] <jgleeson>	 I'll run it manually
[22:09:36] <jgleeson>	 actually scrap that
[22:09:45] <jgleeson>	 that update had nothing to do with that field
[22:10:17] <jgleeson>	 I only see one mention of 'largest_donation' in wmf_civicrm.install
[22:10:21] <jgleeson>	 eileen,^
[22:11:12] <eileen>	 it gets added by   _wmf_civicrm_update_custom_fields(); - ie one of the updates with that in
[22:13:33] <eileen>	 you probably ran the last one of those before the new fields were added -
[22:17:19] <jgleeson>	 I see it sites/all/modules/wmf_civicrm/wmf_civicrm.module:4650
[22:17:24] <jgleeson>	 hmmm
[22:17:50] <jgleeson>	 I guess I could cheat and add that line to the beginning of wmf_civicrm_update_7900 locally
[22:26:20] <jgleeson>	 hmm
[22:26:23] <jgleeson>	 I tried:
[22:26:23] <jgleeson>	   require_once 'update_custom_fields.php';
[22:26:23] <jgleeson>	   _wmf_civicrm_update_custom_fields();
[22:26:34] <jgleeson>	 eileen, but then ran into another error within that
[22:26:46] <jgleeson>	 this might be vagrant weirdness
[22:26:59] <eileen>	 hmm it's late for you too huh?
[22:27:29] <jgleeson>	 yeah I was gonna say I'll debug it first thing if you can wait? if not maybe someone else could try to push it over the line fr-tech?
[22:27:33] <jgleeson>	 sorry!
[22:28:06] <eileen>	 no worries - it's only the test I changed since Elliott gave it +2
[22:28:40] <XenoRyet>	 Let me take a look real fast.
[22:28:40] <jgleeson>	 cool, I can also see it passes on CI now
[22:29:06] <XenoRyet>	 jgleeson: you can call it a night if you want, I'll look at this.
[22:29:17] <jgleeson>	 thanks man, catch you all tomorrow!
[22:32:55] <wikibugs>	 (CR) XenoRyet: [C: +2] "Yea, this still all looks fine.  Reapplying the +2." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527706 (https://phabricator.wikimedia.org/T229273) (owner: Eileen)
[22:33:07] <eileen>	 thanks XenoRyet
[22:33:14] <XenoRyet>	 No worries
[22:42:05] <wikibugs>	 (Merged) jenkins-bot: Exclude Refund contributions from calculations. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527706 (https://phabricator.wikimedia.org/T229273) (owner: Eileen)
[23:56:57] <wikibugs>	 (PS1) Eileen: Update contacts with wmf_donor information but only refunded or no contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273)
[23:57:38] <wikibugs>	 (PS2) Eileen: Update contacts with wmf_donor information but only refunded or no contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273)