[04:39:31] (PS1) Eileen: Port LocationType api from upstream so we can use for target smart [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/528616 (https://phabricator.wikimedia.org/T228712) [05:54:22] Fundraising-Backlog: Code linting and CI setup for FRUEC - https://phabricator.wikimedia.org/T229993 (AndyRussG) [08:07:26] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528659 (owner: L10n-bot) [11:02:19] Wikimedia-Fundraising, Wikimedia-Fundraising-Banners, Design: UX: display icons for accepted card types for each payment channel - https://phabricator.wikimedia.org/T58415 (Pcoombe) Open→Resolved a:Pcoombe We have this on all banners now. [11:06:39] Quick question, what's the difference between the 'fundraising' and 'payments' roles in vagrant? Which should I use? [12:07:48] pcoombe, fundraising pulls in the payments as a sub-role [12:07:52] use fundraising [12:08:12] payments sets up payments wiki specifically [12:08:34] Cool, thanks jgleeson [12:10:13] actually, pcoombe do you wanna see all the other things like civi/centralnotice/smashpig ? [12:10:24] if not, you might be able to just build using the payments role [12:10:42] although I've not tested that role in isolation so I can't confirm it works [12:11:57] It is mainly just paymentswiki that I'm interested in. But I just tried the payments role and it didn't seem to work [12:12:41] (and it still took forever to provision) [12:13:04] yeah the fundraising roll installs things like redis which payments wiki will be dependant on [12:13:09] role* [12:13:21] I'll try 'fundraising' now, that worked for me in the past. I didn't know it had centralnotice included, that might come in handy [12:13:47] yeah it installs paymentswiki, civicrm with drupal and central notice [12:13:58] along with some other stack components [13:35:31] good morning/evening/(night?) fr-tech - quick question: are there more civi fields that will be deployed into IBM anytime soon? i saw some info in a phab task but may have missed updates as there are a lot intertwined with one another and it got convoluted to follow 😅 I know we have total_2018, total_2019, and total_2020...but what about years from before 2018? [14:19:47] hi fr-tech! [14:19:51] how's everything going? [14:20:57] hmm, adyen failmail [14:21:06] that's not so common [14:21:27] helllo! [14:21:56] hi cstone! [14:22:07] hey ejegg, cstone :) [14:22:08] ah, the adyen failmail is just a chargeback reversal [14:22:13] hi jgleeson! [14:31:49] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: payment form still displays warning that we do not accept over 10K donations - https://phabricator.wikimedia.org/T229932 (Ejegg) Is this on donatewiki? On payments-wiki, if I don't specify an amount and currency in the URL, I can put in 11,00... [14:32:30] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: payment form still displays warning that we do not accept over 10K donations - https://phabricator.wikimedia.org/T229932 (Ejegg) derp, never mind, I just read the last line of the task description [14:35:13] hi mnoor! I just saw your message from an hour ago [14:35:45] I think we only planned to deploy those totals for now [14:35:55] but we can probably add more of those yearly totals [14:36:09] anthing that's in wmf_donor should be pretty simple to add [14:37:05] just catching up on my email, but I wanted to see what was up with the null rows - I think you suspected bad number and date formats? [14:44:51] (PS1) Umherirrender: Remove entry point check for files only contain classes [extensions/LandingCheck] - https://gerrit.wikimedia.org/r/528836 (https://phabricator.wikimedia.org/T230026) [14:59:04] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: document steps for fr-online to submit TY email to git - https://phabricator.wikimedia.org/T229965 (Ejegg) Let's document this here: https://www.mediawiki.org/wiki/Fundraising_tech/Update_Thank_You_Emails Currently that page has instructions for... [15:08:09] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Men In Slack, and 13 others: Write a specification for mapping banner/landing page impression... - https://phabricator.wikimedia.org/T196563 [15:08:41] exciting news about the FRUEC patches jgleeson & AndyRussG! [15:14:49] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Men In Slack, and 13 others: Write a specification for mapping banner/landing page impression... - https://phabricator.wikimedia.org/T196563 [15:18:52] fr-tech: any news for scrum of scrums? [15:29:23] ejegg, re:FRUEC, yup yup ! [15:29:46] I guess that is SoS's worthy news maybe? [15:29:51] sorry I know my reply is late! [15:29:55] jgleeson: oh yeah, definitely! [15:30:16] also maybe releasing upsell? [15:30:32] yep, that part I've got already [15:30:35] I was planning to do that now, was just waiting on XenoRyet to pop up [15:31:35] jgleeson: OK, great! I'll be in meetings for most of the next 4 hrs but I'll be watching IRC [15:34:27] awesome [15:34:53] cstone, are you around, I was gonna jump in a hangout if you are [15:35:13] hey I am [15:35:21] I'll just jump in todays standup channel if anyone wants to join [15:36:09] jgleeson: for the initial testing of the recurring charge jobs, we might need to mess with the job definition to get it to process a single donation [15:37:32] oh, let's also test to make sure a new normal (non-converted-from-one-time) recurring donation works from the front end [15:38:08] woah, cstone just made me aware we have a 3-hour test going on [15:42:53] jgleeson: yeah that is true [15:43:30] Fundraising-Backlog: Current Employer Relationship additions immediately becoming inactive - https://phabricator.wikimedia.org/T230032 (NNichols) [15:52:17] jgleeson: ahhh, yeah, let's postpone that deploy a bit, shall we? [15:56:10] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/528881 [15:57:43] ejegg, sure no problem. Me and cstone were just chatting about some of the unexpected commits in the diff between deployment and master. It looks like some of the commits Eileen released separately (possibly by cherry-pick) are still showing up in the diff with different commit hashes [15:58:20] I just pushed up the deployment branch there which contains the two recurring patches and the other 3 previously released commits [15:59:05] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: payment form still displays warning that we do not accept over 10K donations - https://phabricator.wikimedia.org/T229932 (Ejegg) So the correct fix for this is slightly more involved than just a text change - we should make that max amount a... [15:59:34] actually it looks like the civicrm submodule update is new [15:59:48] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/528273/ [16:00:44] relates to this change in civicrm https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/525175/ [16:04:47] I'm gonna break for a short while before standup, back later! [16:50:48] Wikipedia is a place to learn, not a place for advertising [16:50:52] ^^ this [16:51:15] (I just got the banner) [18:45:56] fr-tech looks like folks are out of the vidchat - are you continuning with the deploy? [18:47:07] Jack and I had to break for a little so the plan is after the DS meeting [18:47:27] cstone: sounds good [18:50:23] ejegg i did deploy that process control change does that usually get logged I was hunting for past records of it [18:50:59] cstone just to add the slow start command probably doesn't need a log beyond the git commit [18:51:08] ok [19:42:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate how to generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (DStrine) [19:43:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Paypal: Finish fixing bad contribution_recur data from PayPal October 2018 cancel-storm - https://phabricator.wikimedia.org/T217379 (Ejegg) Maybe also update the code path that imports recurring payments so that it fixes the status of any cancele... [19:50:47] back fr-tech! [19:50:57] shall I join DS call? [19:58:15] hey fr-tech, I'm gonna jump back into the tech-talk call and resume the upsell release [19:59:02] if you're all busy I will post progress in here to let you know how it goes [19:59:16] although I will need someone to just watch me when hitting the SQL parts [19:59:22] (PS1) Pcoombe: Update Tax, FAQ, and Donor privacy policy links [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/528921 (https://phabricator.wikimedia.org/T229457) [19:59:25] I'm gonna run a quck errand, maybe 10-15 minutes, then I'll jump on. [19:59:27] hey Jeff_Green did you see my ping about reloading triggers? [19:59:44] eileen: no I missed that! [19:59:48] ejegg: are you back working today? [20:00:03] eileen, are you ok with the submodule update going out in this? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/528881/-1..1 [20:00:11] Jeff_Green: yeah minor change just to reload - I'll find it [20:00:16] jgleeson: yes [20:00:50] Jeff_Green: ah this was the comment - https://phabricator.wikimedia.org/T229273#5398119 [20:01:39] ok. are banners still up? [20:01:46] ejegg: a non-brainer for + 2 - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/528616/ [20:02:25] hmm dstrine do you know if banners are up - ? Need to maybe take queues down for 5 min to reload triggers I guess [20:02:45] eileen yep, working today thru friday [20:03:01] ejegg: ok cool - I thought you were off . all week [20:03:29] Jeff_Green: banners should be down, I think it was just for 3 hrs UTC 15:00-UTC 18:00 [20:03:37] ok [20:03:40] Jeff_Green eileen : no banners up now [20:03:52] thanks pcoombe ! [20:03:54] eileen: we'll be turning off some queues and jobs for the deploy in any case [20:04:00] might as well turn 'em all off [20:04:19] ejegg: Jeff_Green yeah would be great to reload the . triggers . at the same . time [20:05:25] (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/528881 (owner: Jgleeson) [20:05:42] see those dots ^^ - my new mac has the 'butterfly keyboard' issue [20:05:52] :-( [20:07:41] eileen: mine did too, it's so annoying. I found you can at least go to System Preferences > Keyboard > Text and turn off "add full stop with double-space" [20:08:03] which I didn't even know was a "feature" until the keyboard started doing double space randomly [20:08:21] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/528881 (owner: Jgleeson) [20:11:56] pcoombe: ohh I'll try that - I'm currently running 'unshakey' https://github.com/aahung/Unshaky but I couldn't decide if the issue was my space key or my . - I guess that setting would explain it [20:13:33] I believe you can take it into the shop but it's like days without your laptop [20:15:27] Jeff_Green: if it's easier when you go to do it - triggerrs.mysql in my home dir is also the same file [20:15:49] eileen: ok, i'm in the middle of something atm, will look in a bit [20:16:05] Jeff_Green: thanks [20:18:21] (PS1) Eileen: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) [20:20:32] (PS2) Eileen: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) [20:27:13] (PS3) Eileen: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) [20:28:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate how to generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (MBeat33) If this process could encompass PayPal as well as Ingenico that would be great. Also the question of whether these automated f... [20:28:42] !log switched off fundraising process-control jobs [20:28:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:33:00] Jeff_Green: we've got all those jobs turned off [20:33:46] ok I can do the triggers now [20:34:09] !log updated civicrm from 727a2c193b to be5b5a150b [20:34:15] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:35:24] thanks Jeff_Green [20:35:35] (PS4) Eileen: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) [20:36:47] eileen: ready for triggerrs.mysql reload? [20:39:16] Jeff_Green: oops, there's still a dedupe_civicrm_contacts job running [20:39:29] ok [20:45:45] shoot, still de-duping, and process-control with no --kill option [20:50:33] Jeff_Green: ok, that job is finally done running [20:50:38] ok [20:50:39] all quiet in cron-land [20:53:08] sorry was not looking - looks all good now though? [20:53:26] ok ready to reload? [20:53:32] yep [20:53:43] yep [20:53:51] done! [20:53:58] thanks [21:05:16] I edited a contact & that worked - ejegg once your deploy is done this should clear out some of the data no longer kept from that trigger change https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/528294/ [21:06:00] eileen ejegg I've got to head out in a minute, are you guys all set? [21:06:10] Jeff_Green: yes I think so [21:07:19] ok great, have a good day! [21:29:19] ejegg: have you re-enabled the jobs etc? [21:29:33] eileen no [21:29:45] we're just testing the new recurring logic [21:29:51] Ah ok cool [21:30:05] we did run the donations queue once [21:30:17] and processed 34 messages [21:30:30] so those should have updated wmf_donor with the new trigger logic [21:38:15] ejegg: yep - which is pretty much the same for most donations [21:38:24] great [21:38:28] but I did a test on a contact with rfd [21:38:32] & it worked [22:03:55] (PS1) Eileen: Add previously ignored files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528955 (https://phabricator.wikimedia.org/T229927) [22:11:57] (CR) Ejegg: [C: +2] Add previously ignored files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528955 (https://phabricator.wikimedia.org/T229927) (owner: Eileen) [22:12:30] !log switched on all fundraising process-control except ingenico_recurring_charge [22:12:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:17:34] (Merged) jenkins-bot: Add previously ignored files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528955 (https://phabricator.wikimedia.org/T229927) (owner: Eileen) [22:42:13] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: document steps for fr-online to submit TY email to git - https://phabricator.wikimedia.org/T229965 (Ejegg) OK, added a new section here: https://www.mediawiki.org/wiki/Fundraising_tech/Update_Thank_You_Emails#Updating_Thank_You_email_templates_dir... [22:58:07] Fundraising-Backlog: Civi: deduper shows too few results sometimes - https://phabricator.wikimedia.org/T230079 (MBeat33) [22:58:24] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper shows too few results sometimes - https://phabricator.wikimedia.org/T230079 (MBeat33) [23:46:58] !log disabled newer recurring charge job to test one at a time on existing recur records [23:47:05] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log