[05:32:06] (CR) Raimond Spekking: Localisation updates from https://translatewiki.net. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529008 (owner: L10n-bot) [05:32:17] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529008 (owner: L10n-bot) [06:50:16] (CR) XenoRyet: [C: +2] Deal with gateway_txn_id in a standard way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/524535 (owner: Ejegg) [06:52:19] (Merged) jenkins-bot: Deal with gateway_txn_id in a standard way [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/524535 (owner: Ejegg) [07:40:10] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/529225 (owner: L10n-bot) [13:32:38] (PS1) Ejegg: Stop using deleted var in __toString [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529357 [13:45:23] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Look into CSP changes in core - https://phabricator.wikimedia.org/T229607 (Ejegg) The grandparent task for CSP in core is T28508 [13:54:59] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Look into CSP changes in core - https://phabricator.wikimedia.org/T229607 (Ejegg) The RFC for implementing CSP in core has a pretty clear set of steps: https://www.mediawiki.org/wiki/Requests_for_comment/Content-Security-Policy [13:58:57] ejegg, just looking a the deleted var in __toString patch https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/529357/ [13:59:11] was that var deleted recently in another patch? [14:06:13] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Look into CSP changes in core - https://phabricator.wikimedia.org/T229607 (Ejegg) That RFC leaves till the last step fully blocking 3rd party images and iframes, but the report-only CSP currently being served does report on those. So if they go to... [14:06:22] hi jgleeson ! [14:06:31] yep, that var was deleted in https://gerrit.wikimedia.org/r/524535 [14:20:45] thanks ejegg! [14:27:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 7 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:32:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:37:15] (CR) Ejegg: [C: -1] "Thanks for the cleanup! The trxn_id clause looks over-aggressive though - it would zero out checks-only donors." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [14:37:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:38:28] I'm aware of ^^^ the puppet snafu, it's harmless, fixing now. [14:42:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 11 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:47:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 1 minute ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:50:41] (CR) Jgleeson: [C: +2] Stop using deleted var in __toString [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529357 (owner: Ejegg) [14:51:26] (Merged) jenkins-bot: Stop using deleted var in __toString [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529357 (owner: Ejegg) [14:52:21] PROBLEM - check_puppetrun on frdb1001 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Service[psad] [14:57:21] RECOVERY - check_puppetrun on frdb1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [14:59:54] Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: As a drush user, I want to be able to schedule and limit queue jobs independently - https://phabricator.wikimedia.org/T227805 (jgleeson) I noticed that although there are set... [15:02:28] (PS3) Ejegg: Update contacts with wmf_donor information but only refunded or no contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:02:48] (CR) Ejegg: [C: +2] "Oops, I was reading that backwards. This DOES include checks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:07:34] (Merged) jenkins-bot: Update contacts with wmf_donor information but only refunded or no contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528294 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:34:54] fr-tech, does anyone know where the name 'fredge' came from? [15:35:04] (PS9) Ejegg: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:35:17] fundraising... edge? [15:35:20] no idea [15:36:28] Something about fraud? Or maybe that's frack [15:36:30] (CR) Ejegg: [C: +2] "Looks good, and the query works locally!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:37:05] frack is the cluster, right? [15:38:06] AndyRussG: which of your patches need review right now? [15:38:54] is this a good standalone one to start with? https://gerrit.wikimedia.org/r/523095 [15:40:24] ejegg oh hey I'd forgotten about that one! Yeah that'd be great, thanks!!! [15:40:34] cool cool [15:41:18] fundraising-tech-ops, Operations: rack/setup/install Prometeuse/Grafana host frmon2001 for fr-tech - https://phabricator.wikimedia.org/T196476 (Jgreen) [15:41:35] (Merged) jenkins-bot: Update backfill command [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526798 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [15:42:06] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install Prometeuse/Grafana host frmon2001 for fr-tech - https://phabricator.wikimedia.org/T196476 (Jgreen) Open→Resolved prometheus is up and running and collecting, there's still work to be done on the monitoring infrastructure around r... [15:43:49] ejegg, I just remembered we made a start on the migration from bower to yarn for dash https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/dash/+/512354/ it would be good to get that in before big english so maybe one to bring up in a planning meeting over the next few weeks? [15:44:29] jgleeson: sure! Actually, dash is one of the things we like to work on during the code freeze [15:44:44] since breaking it won't actually stop the donations coming in [15:44:54] thanks for that initiative [16:01:06] (PS1) Cstone: WIP: Add failure amount to getNextInvoiceID generation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529390 (https://phabricator.wikimedia.org/T218120) [16:03:20] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Look into CSP changes in core - https://phabricator.wikimedia.org/T229607 (DStrine) Thanks for looking into this @Ejegg. How does this impact our us and our projects? [16:06:13] ejegg, ah cool, yes that makes sense then [16:26:23] Fundraising-Backlog, FR-Email: Meet with fr-online to discuss security and CSP changes around RML - https://phabricator.wikimedia.org/T230212 (DStrine) [16:26:25] (PS1) Ejegg: Update MXN symbol for TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529397 (https://phabricator.wikimedia.org/T220636) [16:41:21] (PS4) Ejegg: Refactor check for choiceData staleness and add corresponding status [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) (owner: AndyRussG) [16:42:09] (CR) Ejegg: [C: +2] "Thanks for the cleanup! Separates concerns, and now we'll get some data on whether this is actually happening for users." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) (owner: AndyRussG) [16:47:42] (Merged) jenkins-bot: Refactor check for choiceData staleness and add corresponding status [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) (owner: AndyRussG) [16:53:40] (CR) jenkins-bot: Refactor check for choiceData staleness and add corresponding status [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/523095 (https://phabricator.wikimedia.org/T226344) (owner: AndyRussG) [17:46:06] Fundraising-Backlog: Team Coordination: review backlog and compile list of critical bugs to be fixed before Holidays - https://phabricator.wikimedia.org/T230222 (DStrine) [17:47:54] fundraising-tech-ops: improve backups from frav1002 to archive - https://phabricator.wikimedia.org/T230223 (Jgreen) p:Triage→Normal [18:10:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Monthly donor message on payments missing contact email address - https://phabricator.wikimedia.org/T230225 (Pcoombe) [18:10:53] (CR) XenoRyet: [C: +2] Parameterize max USD amount in bigamount message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529106 (https://phabricator.wikimedia.org/T229932) (owner: Ejegg) [18:11:42] (Merged) jenkins-bot: Parameterize max USD amount in bigamount message [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/529106 (https://phabricator.wikimedia.org/T229932) (owner: Ejegg) [18:38:47] (PS1) Jgleeson: WIP: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) [18:43:55] (CR) jerkins-bot: [V: -1] WIP: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [19:13:42] fundraising-tech-ops: improve backups from frav1002 to archive - https://phabricator.wikimedia.org/T230223 (Jgreen) Spelunked the Debian package, looks like log file encryption was disabled at 7.3.12 and never reenabled, so we'd need to build a custom package to support encryption. Probably not worth it. [19:57:39] (CR) Ejegg: [C: -1] "Good concept! Let's leave the recorded failure count out of the getPaymentParams / makePayment / handleException loop though." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529390 (https://phabricator.wikimedia.org/T218120) (owner: Cstone) [20:13:48] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, FR-Email: Figure out if pymysql changes output format of silverpop export - https://phabricator.wikimedia.org/T230168 (Ejegg) I just ran two silverpop exports against the dev_civicrm database (so it wouldn't change in between runs), one with t... [20:15:45] thanks ejegg! I was going back and forth on the handleException point [20:16:18] sure thing. Let's try the simplest change first! [20:16:34] makes sense [20:35:34] (PS2) Ejegg: build: Update linters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528584 (owner: Esanders) [20:36:17] (CR) Ejegg: [C: +2] "Thanks for the update! Confirmed locally that the changed .val() calls still return the right values, even without :selected." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528584 (owner: Esanders) [20:45:19] (PS2) Ejegg: Use MediaWikiServices instead of $wgContLang and $wgParser [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/524597 (https://phabricator.wikimedia.org/T160811) (owner: Jforrester) [20:47:50] (PS3) Ejegg: Use MediaWikiServices instead of $wgContLang and $wgParser [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/524597 (https://phabricator.wikimedia.org/T160811) (owner: Jforrester) [20:50:09] (CR) Ejegg: [C: +2] "Thanks for helping us keep up with the times! Clean, low-risk switch, and local testing shows banners, messages, and admin UI in working o" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/524597 (https://phabricator.wikimedia.org/T160811) (owner: Jforrester) [20:50:20] (Merged) jenkins-bot: build: Update linters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528584 (owner: Esanders) [20:50:22] (PS4) Ejegg: Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [20:50:54] (CR) Ejegg: [C: +2] "Thanks again. Another straightforward, low-risk update." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [21:00:09] ejegg: thx ^ [21:00:12] :) [21:02:29] AndyRussG: sure thing! I hope those don't make rebasing the rest of the stuff too complicated [21:05:12] fr-tech I'm about to write back to the new Amazon Pay person. Anyone else want in on the meeting? [21:05:29] Yea, I could get in on that. Any time is fine for me. [21:07:06] (Merged) jenkins-bot: Use MediaWikiServices instead of $wgContLang and $wgParser [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/524597 (https://phabricator.wikimedia.org/T160811) (owner: Jforrester) [21:07:08] (Merged) jenkins-bot: Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [21:11:27] (CR) jenkins-bot: build: Update linters [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/528584 (owner: Esanders) [21:23:55] (CR) jenkins-bot: Replace references to deprecated Squid config with modern CDN ones [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/514396 (owner: Jforrester) [21:29:27] (CR) jenkins-bot: Use MediaWikiServices instead of $wgContLang and $wgParser [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/524597 (https://phabricator.wikimedia.org/T160811) (owner: Jforrester) [23:56:54] (CR) XenoRyet: [C: +2] Update MXN symbol for TY letters [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529397 (https://phabricator.wikimedia.org/T220636) (owner: Ejegg)