[00:22:01] [02:11:39] (PS6) Eileen: Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 [02:14:58] (CR) jerkins-bot: [V: -1] Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 (owner: Eileen) [02:15:17] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 (owner: Eileen) [04:46:23] (CR) Ejegg: [C: +2] Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 (owner: Eileen) [04:51:08] (Merged) jenkins-bot: Update geocoder plugin for php 7 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526573 (owner: Eileen) [07:45:45] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530042 (owner: L10n-bot) [10:59:24] Wikimedia-Fundraising-Banners: Fix banner amount error messages - https://phabricator.wikimedia.org/T229962 (Pcoombe) Open→Resolved a:Pcoombe Fixed all these. Some of the monthly amount errors in banners were still using DonationInterface messages, I changed them to use the ones from FR2015_trans... [14:35:25] (CR) Jgleeson: [C: +2] "Code looks good and tests passing locally." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530000 (owner: Ejegg) [14:36:13] (Merged) jenkins-bot: Restore correct gateway_txn_id for Ingenico [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530000 (owner: Ejegg) [14:53:33] thanks jgleeson ! [14:54:08] np! [14:55:58] I'll hold off deploying that + the rest of the txn_id refactor till after this morning's tests [14:58:22] (CR) Ejegg: "The code looks good and the install runs correctly and creates a mapping, but the sample is tab-separated and the import UI doesn't seem t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [14:58:51] fr-tech what news for scrum of scrums? [15:04:32] everytime you type that it takes me to this scene from LOTR https://www.youtube.com/watch?v=GQ05_gDud6w [15:04:39] none from me ejegg ! [15:11:39] (PS2) Jgleeson: WIP: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) [15:16:20] (CR) Ejegg: "Thanks for this work! Looks like some of those files could use whitespace normalization too, in case you want to put up a separate patch (" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [15:17:02] (CR) jerkins-bot: [V: -1] WIP: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [16:32:46] (PS2) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [16:33:13] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [16:33:21] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [17:26:41] Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) [17:29:15] Fundraising-Backlog: As a donor, if I only donate $1, I don't want to be asked for a recurring contribution for more - https://phabricator.wikimedia.org/T230502 (mepps) [18:41:18] (CR) Ejegg: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [18:41:28] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [18:42:29] (CR) Mepps: "I agree with Ejegg. There seem to be too many joins and it's still ordering by ct.total amount as well." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/526303 (https://phabricator.wikimedia.org/T228349) (owner: Eileen) [18:44:02] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (mepps) @Cstone @XenoRyet Either of you want to tackle this? I could try to help tomorrow morning too. [18:45:35] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (mepps) @jgleeson what did we plan to do here? Please write it up if you have time before leaving for Wikimania. [18:46:19] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (mepps) Or anyone else who remembers what our plan was? @Ejegg remembers something about mustache templates. [18:47:31] (PS4) Ejegg: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [18:47:38] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (mepps) @XenoRyet are you taking a look at this? @Ejegg thought he remembered you saying you might. [18:52:20] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [18:54:09] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (mepps) Also, do we know what we wanted to do on this during the sprint? [19:04:27] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: As a donor, if I only donate $1, I don't want to be asked for a recurring contribution for more - https://phabricator.wikimedia.org/T230502 (mepps) a:mepps [19:20:06] (PS1) Mepps: For $2 and under donations, ask for recurring $1 donation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) [19:21:11] (CR) Ejegg: "Looks like some actual test fails based on missing methods now" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [19:21:52] (CR) Eileen: "ejegg is DOES - read the little popup help next to that field" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [19:26:35] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (DStrine) [19:26:42] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (DStrine) [19:27:23] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: Add more silverpop data to Civi (query names, query criteria, segment data) - https://phabricator.wikimedia.org/T227363 (... [19:27:31] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: Add more silverpop data to Civi (query names, query criteria, segment data) - https://phabricator.wikimedia.org/T227363 (... [19:42:06] Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) So I had a weird experience testing this locally. I saw the error on my first test. Then I added some logging and tested again, and strangely the error text showed up! Then I... [19:42:50] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) [19:43:03] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) a:mepps [19:43:55] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: As a donor, if I only donate $1, I don't want to be asked for a recurring contribution for more - https://phabricator.wikimedia.org/T230502 (mepps) a:mepps→XenoRyet @XenoRyet Want to take a look at this or ask someone... [19:44:33] eileen: ahh, I see the 'Import Field Separator' box now. I had assumed the 'CSV/SQL' selector was missing a 'TSV' option [19:45:01] ejegg: it's a bit hidden - esp the fact you can type in 'tab; [19:45:13] the mapping looks good, though I get a popup 'The data columns in this import file appear to be different from the saved mapping. Please verify that you have selected the correct saved mapping before continuing.' [19:45:42] and two notices "Undefined offset: 0 in CRM_Contact_Import_Form_MapField->buildQuickForm() (line 509 of crm/civicrm/CRM/Contact/Import/Form/MapField.php) [19:46:23] but looking at the field list, all the relevant columns do seem to be mapped to Civi fields [19:50:20] hmm - just trying to test the file again locally [19:54:36] ejegg: yeah I'm seeing that too - I'll see if I can see why . I don't get the enotice though [19:57:09] (CR) Ejegg: "Still seems a bit odd to ask a $2 donor for a $2.75 monthly contribution. Maybe if they give under $3 ask for $1?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) (owner: Mepps) [19:59:59] I had some weirdness around the first column - which I suspect relates - will try adding it & punting the numbers by one [20:02:24] (CR) Mepps: "I read it as $2 would get asked for $1 since it's less than or equal to but I can make it just less than $3." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) (owner: Mepps) [20:03:43] (PS2) Mepps: For donations under $3, ask for recurring $1 donation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) [20:22:46] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530210 [20:22:50] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530210 (owner: Ejegg) [20:24:46] (PS6) Eileen: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) [20:24:48] (PS1) Eileen: Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) [20:26:06] (PS1) Eileen: Rekey mapping fields to base zero [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/530212 (https://phabricator.wikimedia.org/T228712) [20:26:27] ejegg: I put up 2 patches to address the mismatched fields - I'll fix better in core [20:26:54] thanks! I'll check 'em out [20:27:08] the enotice happens if you don't choose 'update' because contact ID is not an available field if you choose 'skip' [20:34:34] ok, pretty sure I had chosen 'update', but I'll try again with the new patch [20:36:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530210 (owner: Ejegg) [20:42:45] eileen: shoot, I reinstalled with the new patches and chose 'update' but now the mapping is off by 1 and I get *3* notices [20:42:51] the popup did go away, though :) [20:44:12] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530215 [20:46:47] eileen: oh right, I just saw your note about it needing a change in core. Will wait for that [20:46:57] (CR) Ejegg: Rekey columns to included contact id - notes (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [20:50:27] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (LeanneS) [20:52:11] ejegg: this is the core change - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/530212/ [20:52:16] well civi core [20:52:42] If you actually want to try the update you will probably need this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/524960/ [20:53:17] how dya like this one https://github.com/civicrm/civicrm-core/pull/15033 [20:57:19] eileen: oh hey, is there a UI for the 'environment' variable in CiviCRM? [20:58:17] ejegg: on the debug screen - civicrm/admin/setting/debug?reset=1 [20:58:36] thanks! [20:58:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (Eileenmcnaughton) sigh [20:59:44] eileen: oh, so that does change behavior? "Set this value to Staging/Development to prevent cron jobs & mailings from being executed" [21:00:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (Eileenmcnaughton) @LeanneS how urgent is this (trying to channel David - I think he would say 'when do you need it by') [21:00:09] Are you able to test stuff fine with 'Development' selected? [21:00:26] ejegg: yep it's supposed to protect you from sending out mail by accident [21:00:51] hmm, ok [21:02:00] I think it just changes the outbound mail var on install - civicrm/admin/setting/smtp?reset=1 [21:02:05] on enable I mean [21:02:26] (I can still change to 'redirect to database') [21:03:08] got it [21:03:52] (PS2) Eileen: Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) [21:04:00] I fixed Conact [21:04:41] (PS4) Ejegg: Add prospecting fields missing from dev envs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524960 (https://phabricator.wikimedia.org/T228713) (owner: Eileen) [21:04:48] mepps: did you reply to Doreen? [21:05:00] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530215 (owner: Ejegg) [21:05:35] (CR) XenoRyet: [C: +2] "I think this looks fine and the amounts make sense this way." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) (owner: Mepps) [21:05:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (LeanneS) I know. :( Sometime in the next month would be great. I can manually update in the meantime. [21:06:40] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530215 (owner: Ejegg) [21:06:42] (Merged) jenkins-bot: For donations under $3, ask for recurring $1 donation [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530201 (https://phabricator.wikimedia.org/T230502) (owner: Mepps) [21:06:51] (CR) Eileen: "fixed" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:09:49] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (XenoRyet) @mepps Yea, this is on my list. Sick kids have kept me from getting too far yet, but I be... [21:23:22] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530215 (owner: Ejegg) [21:24:58] !log updated payments-wiki from 9533f70fab to 44eae2d65f [21:25:04] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:30:54] (CR) Ejegg: [C: +2] "OK, this works for me now. We should get that variable set in our vagrant role, but it's not immediately clear how." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524960 (https://phabricator.wikimedia.org/T228713) (owner: Eileen) [21:36:09] (Merged) jenkins-bot: Add prospecting fields missing from dev envs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/524960 (https://phabricator.wikimedia.org/T228713) (owner: Eileen) [21:38:06] (CR) Ejegg: [C: +2] Rekey mapping fields to base zero [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/530212 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:42:55] (Merged) jenkins-bot: Rekey mapping fields to base zero [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/530212 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:43:23] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530228 [21:43:25] (PS7) Ejegg: Add targetsmart extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:43:49] (CR) Ejegg: [C: +2] "With the missing prospect fields installed and the core update to rekey the fields, this works for me!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528926 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:43:53] (CR) Eileen: [C: +2] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530228 (owner: Eileen) [21:44:06] (PS3) Ejegg: Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:44:11] (CR) Ejegg: [C: +2] Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:49:06] (CR) jerkins-bot: [V: -1] Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) (owner: Eileen) [21:49:18] (PS4) Eileen: Rekey columns to included contact id - notes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530211 (https://phabricator.wikimedia.org/T228712) [21:58:52] (PS1) Ejegg: Re-apply: Switch to pymysql [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/530232 (https://phabricator.wikimedia.org/T213757) [21:59:05] (CR) Ejegg: [C: +2] Re-apply: Switch to pymysql [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/530232 (https://phabricator.wikimedia.org/T213757) (owner: Ejegg) [21:59:41] (Merged) jenkins-bot: Re-apply: Switch to pymysql [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/530232 (https://phabricator.wikimedia.org/T213757) (owner: Ejegg) [22:01:16] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/530233 [22:01:26] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/530233 (owner: Ejegg) [22:01:54] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/530233 (owner: Ejegg) [22:03:17] (PS1) Eileen: Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/530234 [22:03:41] !log updated fundraising python tools from 827ce3750e to 5c080bac63 [22:03:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:03:57] ejegg: I just did a vendor update ^^ - it's OK to put a .gitignore in there? [22:04:28] eileen: as long as it's not ignoring files we need to deploy! [22:04:35] :-) [22:05:04] no - tests - do we +2 our own vendor updates or does someone else? [22:05:18] I think we have to +2 those still [22:06:10] ok [22:09:26] ejegg: if you can +2 it then I'll deploy those just-merged changes in a few [22:10:12] oh sorry, I thought you were asking about the V+2 [22:10:22] you can go ahead and C+2 it [22:10:29] ah ok - cool [22:10:41] I guess zuul does V+2 that repo! [22:10:49] :-) [22:10:50] (CR) Eileen: [C: +2] Vendor update [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/530234 (owner: Eileen) [22:11:41] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530235 [22:12:15] (PS6) Ejegg: Add previous payment failure amount to getNextInvoiceID generation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529390 (https://phabricator.wikimedia.org/T218120) (owner: Cstone) [22:12:23] (CR) Ejegg: [C: +2] Add previous payment failure amount to getNextInvoiceID generation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529390 (https://phabricator.wikimedia.org/T218120) (owner: Cstone) [22:13:28] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530235 (owner: Eileen) [22:17:29] (Merged) jenkins-bot: Add previous payment failure amount to getNextInvoiceID generation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529390 (https://phabricator.wikimedia.org/T218120) (owner: Cstone) [22:31:40] (PS9) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [22:35:06] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530235 (owner: Eileen) [22:36:21] eileen: ooops, was the php56 linter the only thing running on gate-and-submit for crm? [22:36:37] ejegg: oh maybe? [22:36:54] https://integration.wikimedia.org/zuul/ is eerily quiet [22:38:09] hmm - so we need to add php7 tests - can I proceed with that deploy in the meantime? [22:38:40] yep [22:39:41] you know I've been clicking 'submit' on a lot of patches today - I just thought I was impatient - but maybe they weren't self-submitting [22:40:12] https://gerrit.wikimedia.org/r/529390 did self-dubmit [22:40:14] *submit [22:40:33] maybe it is the patience thing [22:40:54] but i think the deployment branch does skip phpunit tests [22:41:16] !log civicrm revision changed from 569e52e23d to 3caf54a0d2, config revision is 1c76e94ac3 [22:41:22] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:41:54] ok - that's gone out - I'll wait 10 mins just in case the geocoder causes a flood of failmail & then enable [22:46:51] Eileen I thought I’d replied but I guess I didn’t. I’ll do that tomorrow [22:47:03] cool [22:54:35] (PS1) Ejegg: Uncomment PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530239 (https://phabricator.wikimedia.org/T230170) [22:55:12] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (Ejegg) a:Ejegg [23:07:05] (PS1) Ejegg: Add Netbanking sub text, shrink logo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530241 (https://phabricator.wikimedia.org/T228698) [23:08:15] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (Eileenmcnaughton) @LeanneS I imp... [23:10:42] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (Eileenmcnaughton) I note that for... [23:55:11] (CR) XenoRyet: [C: +2] Uncomment PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530239 (https://phabricator.wikimedia.org/T230170) (owner: Ejegg) [23:59:11] (Merged) jenkins-bot: Uncomment PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530239 (https://phabricator.wikimedia.org/T230170) (owner: Ejegg)