[06:30:05] (PS5) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [06:34:46] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [06:40:47] (PS6) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [06:45:29] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [07:30:13] (PS7) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [07:31:11] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530287 (owner: L10n-bot) [07:35:24] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [07:48:12] (PS8) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [07:53:40] (CR) jerkins-bot: [V: -1] Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [07:56:00] (PS9) Eileen: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) [13:15:13] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) Okay, so I've found more interesting behavior. Basically the error highlighting appears if I tab away from the box, but when I click... [13:17:23] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) There are two places I thought the initial error highlighting might be coming from: validation_input and ext.donationinterface.valida... [13:27:21] fundraising-tech-ops: some Fundraising users running macOS Mojave are having trouble with browser client certificates - https://phabricator.wikimedia.org/T230553 (Jgreen) [13:27:36] fundraising-tech-ops: some Fundraising users running macOS Mojave are having trouble with browser client certificates - https://phabricator.wikimedia.org/T230553 (Jgreen) OIT sent [13:35:58] fundraising-tech-ops: some Fundraising users running macOS Mojave are having trouble with browser client certificates - https://phabricator.wikimedia.org/T230553 (Jgreen) p:Triage→Normal [13:36:16] fundraising-tech-ops, Gerrit: move main fundraising puppet repo to gerrit - https://phabricator.wikimedia.org/T222840 (Jgreen) p:Triage→Low [13:36:33] fundraising-tech-ops: reconfigure payments*:/srv to /var/log - https://phabricator.wikimedia.org/T211594 (Jgreen) p:Triage→Low [13:36:46] fundraising-tech-ops: upgrade fundraising databases from Debian Jessie to Stretch - https://phabricator.wikimedia.org/T221003 (Jgreen) p:Triage→Normal [13:42:14] fundraising-tech-ops: some Fundraising users running macOS Mojave are having trouble with browser client certificates - https://phabricator.wikimedia.org/T230553 (Jgreen) [14:33:58] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) I'm currently thinking this might be something from Firefox, because I noticed the red highlighting doesn't happen in Chrome and the... [14:35:32] (PS1) Mepps: Changed class and id names to fit conventions from other forms Could improve tech debt slightly later, but open to not merging this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) [14:50:53] (CR) jerkins-bot: [V: -1] Changed class and id names to fit conventions from other forms Could improve tech debt slightly later, but open to not merging this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [15:06:13] fr-tech, has anyone done anything with drush submodule dependencies? I'm trying to do something like this 'dependencies[] = queue2civicrm:fredge' based on the docs here https://www.drupal.org/docs/7/creating-custom-modules/writing-module-info-files-drupal-7x#project-dependencies but it looks like drush is looking up the dependency up online and not finding it [15:09:01] jgleeson: hmm, I've never had to mess with those before [15:09:48] jgleeson: are you in Sweden? [15:09:53] yup! [15:10:38] we've got a shared function across paymentinit and anti-fraud called 'fredge_prep_data' [15:10:54] so I thought I could include fredge as a dependency to save copypasta [15:11:06] ... or more copyasta than I've already done :) [15:11:29] heh, right on [15:12:08] I'm guessing drupal has a way to share stuff [15:12:11] I guess that's why they were paired up in the first place [15:12:21] ejegg, yeah that makes sense [15:13:00] jgleeson: would it make sense to just have two different drush jobs in the same module then? [15:13:36] That was actually my initial thought with this task [15:15:25] umm it feels like it would be clean to have them sit in their respective subfolders [15:15:50] although I don't like one having a function and the other calling it [15:16:42] I guess they both fit under the 'fredge' umbrella [15:25:00] so it looks like that method is loading up the db table schema and validating the messages fields using schema fields [15:44:08] (CR) Cstone: [C: +2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530241 (https://phabricator.wikimedia.org/T228698) (owner: Ejegg) [15:45:22] thanks cstone! [15:45:31] Hope you're feeling better today [15:45:52] hah yeah I am ! [15:45:59] local sushi betrayed me [15:46:34] never trust sushi far from the coast... [15:51:53] cstone wanna deploy that invoice increment patch? [15:53:03] sure [16:03:41] (Merged) jenkins-bot: Add Netbanking sub text, shrink logo [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530241 (https://phabricator.wikimedia.org/T228698) (owner: Ejegg) [16:06:17] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530407 [16:06:40] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530407 (owner: Ejegg) [16:07:16] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530407 (owner: Ejegg) [16:20:45] fr-tech, I'm here but just about to eat so won't make standup [16:21:27] (PS1) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530410 [16:21:34] my update is that I'm still finishing off breaking up the queue consumers, it was a little trickier than I thought. [16:25:05] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530410 (owner: Cstone) [16:45:40] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530421 [16:45:47] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530421 (owner: Ejegg) [16:47:36] (CR) Ejegg: [V: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/530410 (owner: Cstone) [16:52:37] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530421 (owner: Ejegg) [16:53:54] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530421 (owner: Ejegg) [17:02:35] !log civicrm revision changed from 3caf54a0d2 to 9c7b2ffbc9 [17:02:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:06:46] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530421 (owner: Ejegg) [17:10:35] (PS2) Mepps: Changed class and id names to fit conventions from other forms Could improve tech debt slightly later, but open to not merging this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) [17:11:00] !log updated payments-wiki from 44eae2d65f to 00eb090dcc [17:11:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:30:16] fr-tech, see you all in the alerts channel? [17:30:25] Yep, it's that time. [17:31:31] here i go! [17:52:09] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: India bank transfer icons and/or test redesign - https://phabricator.wikimedia.org/T228698 (Ejegg) OK, the Netbanking icon is now a bit smaller, with text 'Netbanking' below. @Dstrine, if I squint hard I can read "Unified Payments Interface" unde... [17:53:55] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (Ejegg) OK, this is up and ready to test at https://payments.wikimedia.org/index.php?title=Special:AstroPayGateway&appeal=JimmyQuote&payment_method=bt&recurring=&uselang=en... [17:54:17] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: As a developer, I want to be able to change the timeout for the Silverpop Api in the config - https://phabricator.wikimedia.org/T182795 (mepps) [18:11:29] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (EMartin) Great! We will get some folks to test. Thanks., [18:28:26] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: count impressions and campaigns in 2018 - https://phabricator.wikimedia.org/T229960 (AndyRussG) @Dstrine I guess this is done, eh? [19:18:08] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (DannyS712) [19:28:52] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (Ejegg) Thanks for the report, @DannyS712. Wikimedia Fundraising uses this page in a very particular way - we source it as an image from the donation Thank You page (host... [19:34:05] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [19:35:17] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.26 ms [19:40:13] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 36 failures. Last run 7 minutes ago with 36 failures. Failed resources (up to 3 shown) [19:40:19] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 7 minutes ago with 27 failures. Failed resources (up to 3 shown) [19:41:49] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [19:45:11] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 36 failures. Last run 12 minutes ago with 36 failures. Failed resources (up to 3 shown) [19:45:13] PROBLEM - check_puppetrun on frbackup2001 is CRITICAL: CRITICAL: Puppet has 27 failures. Last run 12 minutes ago with 27 failures. Failed resources (up to 3 shown) [19:45:19] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.26 ms [19:49:37] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [19:50:11] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [19:50:13] RECOVERY - check_puppetrun on frbackup2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [19:55:17] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.34 ms [20:12:47] (CR) Ejegg: [C: +2] "This looks good, as do the changes to omnimail-silverpop! The 'Statement' concept in 9.0 is a bit strange, huh?" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [20:18:03] (Merged) jenkins-bot: Update composer - league/csv version 9 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/526580 (https://phabricator.wikimedia.org/T228711) (owner: Eileen) [20:27:26] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Edits to the employer field test - https://phabricator.wikimedia.org/T229343 (Ejegg) p:Triage→Normal a:Ejegg [20:33:37] (PS29) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [20:47:44] (PS1) Ejegg: Alternate 'Employer' placeholder text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530449 (https://phabricator.wikimedia.org/T229343) [20:49:53] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (Ejegg) Open→Resolved p:Triage→Normal [20:50:08] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Replace MySQL-python with pymysql in fundraising python scripts - https://phabricator.wikimedia.org/T213757 (Ejegg) Open→R... [20:50:13] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 2 others: All fundraising python scripts should run on python 3 by 2020 - https://phabricator.wikimedia.org/T197805 (Ejegg) [20:50:22] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, FR-Email: Figure out if pymysql changes output format of silverpop export - https://phabricator.wikimedia.org/T230168 (Ejegg) Open→Resolved p:Triage→Normal [20:50:39] (CR) Vedmaka Wakalaka: "> Patch Set 28:" (25 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [21:04:30] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) @CCogdill_WMF Can you confirm whether you see the error message when you directly click on the "Donate Monthly"... [21:09:10] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) @Ejegg Oh! I think this is caused by the type being "number" as I've learned it happens when any value with a d... [21:10:37] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (LeanneS) @Eileenmcnaughton Thanks... [21:11:42] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (Ejegg) @mepps I guess that type=number was set to pop up the numeric keypad on mobile devices. See T217854 for other w... [21:12:18] relocating... [21:16:18] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Patch-For-Review: Bug: donations below should include error message on updonate - https://phabricator.wikimedia.org/T230501 (mepps) Yup @Ejegg I got it. I'll put up a patch tomorrow morning. [22:37:01] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (Eileenmcnaughton) @leannes I don'... [22:45:02] (PS1) Ejegg: WIP: Add div under updonate to disable form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530457 [22:56:32] arr, z-index is hard: https://coder-coder.com/z-index-isnt-working/ [23:08:08] (PS2) Ejegg: Add div under updonate to disable form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530457 [23:20:50] (PS1) Ejegg: Add problems_email to context for all forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530459 (https://phabricator.wikimedia.org/T230225) [23:21:08] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Monthly donor message on payments missing contact email address - https://phabricator.wikimedia.org/T230225 (Ejegg) p:Triage→High a:Ejegg [23:22:09] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: Monthly donor message on payments missing contact email address - https://phabricator.wikimedia.org/T230225 (Ejegg) Embarrassing bug with an easy fix, so I'm pulling it into sprint.