[00:11:03] (CR) XenoRyet: [C: +2] SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [01:52:48] fr-tech oh shoot, i just got a ty email for a test donation from 2 days ago. del [01:52:56] delay? duplicate? [01:53:49] Did you get one at the time ejegg|away? [01:55:37] i think so... gmail search in phone ui doesnt show another msg with the same cntct id in the footer though [01:55:46] aha [01:56:58] i think it was the test with the bad gateway txn id patch [01:57:17] and the first one got recorded under the invoice id [01:57:37] then in today's audit file a duplicate was filed [01:58:38] because ingenico audot parser looks it up by gateway txn id [01:58:50] timing is right for audit [01:59:06] ok, i've convinced myself not to worry [01:59:52] mepps no cause for alarm then [02:00:29] Cool thanks ejegg|away! [03:23:19] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add new calendar year fields to silverpop export - https://phabricator.wikimedia.org/T228241 (Eileenmcnaughton) Open→Resolved [03:23:22] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, and 3 others: Add calendar year totals fields to CiviCRM & export ? some? of them to silverpop - https://phabricator.wikimedia.org/T170972 (Eil... [04:03:25] (PS3) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [04:03:52] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [04:04:00] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [04:05:50] (PS23) AndyRussG: Banner live preview [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/497611 (https://phabricator.wikimedia.org/T208125) (owner: Vedmaka Wakalaka) [04:06:31] (PS17) AndyRussG: Banner in-page preview mode [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/508720 (owner: Vedmaka Wakalaka) [04:42:52] (PS13) AndyRussG: Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) [04:46:57] (CR) jerkins-bot: [V: -1] Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [05:11:51] (PS14) AndyRussG: Banner preview: JS improvements [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) [05:37:13] (PS7) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [05:39:22] (CR) jerkins-bot: [V: -1] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:46:04] (PS8) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [06:48:05] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:49:01] (CR) jerkins-bot: [V: -1] Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [06:58:31] (PS9) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [07:03:28] (PS5) AndyRussG: Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) [07:03:42] (PS5) AndyRussG: Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) [07:03:58] (PS4) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:06:51] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [07:23:11] (PS5) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:23:39] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [07:24:05] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [07:24:53] (PS6) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:28:25] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [07:35:08] (PS7) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:37:39] (CR) jerkins-bot: [V: -1] Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [07:41:13] (PS8) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:55:36] (PS30) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [11:06:57] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: count impressions and campaigns in 2018 - https://phabricator.wikimedia.org/T229960 (DStrine) Open→Resolved [14:27:53] (PS3) Mepps: Changed class and id names to fit conventions from other forms Could improve tech debt slightly later, but open to not merging this [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) [14:27:55] (PS1) Mepps: Add step and min to avoid html validation error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530582 (https://phabricator.wikimedia.org/T230501) [17:34:10] (CR) XenoRyet: [C: +2] Add problems_email to context for all forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530459 (https://phabricator.wikimedia.org/T230225) (owner: Ejegg) [17:35:07] Fundraising-Backlog: Adyen links testing issue - https://phabricator.wikimedia.org/T230621 (EMartin) [17:40:05] (Merged) jenkins-bot: Add problems_email to context for all forms [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530459 (https://phabricator.wikimedia.org/T230225) (owner: Ejegg) [17:43:12] PROBLEM - check_gcsip on payments2002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [17:45:14] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [17:45:14] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [17:48:14] PROBLEM - check_gcsip on payments2002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [17:48:14] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.167 second response time [17:48:15] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.159 second response time [17:51:14] RECOVERY - check_gcsip on payments2002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.161 second response time [18:28:50] Fundraising-Backlog: Adyen links testing issue - https://phabricator.wikimedia.org/T230621 (EMartin) [18:36:59] Fundraising-Backlog: PayTM for India not functioning - https://phabricator.wikimedia.org/T230625 (EMartin) [18:37:48] (PS3) Mepps: Add div under updonate to disable form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530457 (owner: Ejegg) [18:38:09] (CR) Mepps: [C: +2] "Looks great!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530457 (owner: Ejegg) [18:38:55] (Merged) jenkins-bot: Add div under updonate to disable form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530457 (owner: Ejegg) [19:10:53] again [19:39:31] fr-tech do we know what caused this morning's spate of failmail? [19:40:39] (PS5) Ejegg: Add settings and logos for two UY-specific cards [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/472503 (https://phabricator.wikimedia.org/T208963) [19:42:21] fr-tech also, if anyone wants to talk through the message replacement strategy here I'm available for video chat: https://gerrit.wikimedia.org/r/530449 [20:02:10] hmm, looks like there was a short period of time where db connections were failing [20:27:14] ejegg: that was my fault, I was doing package updates and missed that it was picking up mariadb until it was too late, and I ended up restarting the service [20:41:30] ah, got it. I don't think we lost anything important. [20:44:43] it was a clean restart at any rate [21:32:18] (CR) Ejegg: [C: +2] "This refactor still looks good to me after rebase!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/516459 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [21:33:25] AndyRussG: did you notice that this patch needs a tiny whitespace reformat to pass quibble? https://gerrit.wikimedia.org/r/519950 [21:37:57] AndyRussG: oh, oops, looks like it got subsumed into https://gerrit.wikimedia.org/r/519959 ? [21:39:02] or... no [21:55:50] ok, the static thing just didn't need to be in that chain. [21:56:22] (CR) Ejegg: [C: +2] "Also still looks good after the rebase & comment removal." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [22:20:37] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper showing Not symbol, freezing up - https://phabricator.wikimedia.org/T230637 (MBeat33) [22:26:44] ejegg: hmmm I'm confused [22:28:00] I think that static thing needs to be there [22:28:06] I must have made a mistake in the rebase [22:29:20] I kinda wish there was a more automatic way to do it in fact... [22:40:52] (CR) Ejegg: [C: +2] "Thanks AndyRussG! I can't get away with anything nasty when I test locally now, and the rearrangement of the callback code looks good." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) (owner: AndyRussG) [22:41:07] oh does it? looking again [22:42:33] Hmm, looking at the last PS on https://gerrit.wikimedia.org/r/530004 , everything seems to function correctly without that static-ifying patch [22:42:57] yeah, getPreviewLink is still called instance-ly [22:45:22] and the preview links look fine on the banner list [22:47:34] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper showing Not symbol, freezing up - https://phabricator.wikimedia.org/T230637 (MBeat33) [22:55:38] ejegg: must be that by accident I squashed that into another commit I think [22:56:12] ejegg: in a little bit I can check for sure [22:56:43] Hmm, sure doesn't look squashed in [22:57:10] then how did the staticy stuff get callable? [22:57:59] I'll look again, but it seems to still be calling the preview link functions on instances [22:58:03] with -> [22:58:45] hm! [22:58:53] Oh instance-ly you said [22:59:15] you said instance-ly but I read static-ly [23:00:44] heh, because instance-ly isn't a word maybe? And statically is... [23:11:57] heading on out for the weekend. Have a good one fr-tech! [23:15:50] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: deduper showing Not symbol, freezing up - https://phabricator.wikimedia.org/T230637 (MBeat33) Seilo cid=26034374 is also getting this error.