[04:53:17] (PS8) AndyRussG: Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) [05:01:44] (CR) AndyRussG: "The purpose of this change was to remove unneeded BannerRenderer instantiations, to make it easier to refactor the BannerRenderer construc" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [05:06:19] (PS10) AndyRussG: Refactor BannerRenderer and SpecialBannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519959 (https://phabricator.wikimedia.org/T225101) [05:06:40] (PS6) AndyRussG: Rename link to preview saved version on-wiki [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519973 (https://phabricator.wikimedia.org/T225101) [05:06:57] (PS6) AndyRussG: Rename and move update preview button [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519974 (https://phabricator.wikimedia.org/T225101) [05:07:12] (PS9) AndyRussG: Require edit token for previewing banners via Special:BannerLoader [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/530004 (https://phabricator.wikimedia.org/T229126) [07:17:52] (CR) AndyRussG: "mpleR" (5 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [07:20:51] (CR) AndyRussG: "> mpleR" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [14:48:06] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530868 [14:51:07] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530868 (owner: Ejegg) [15:10:56] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530877 [15:11:29] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530868 (owner: Ejegg) [15:12:35] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530877 (owner: Ejegg) [15:36:55] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530877 (owner: Ejegg) [15:36:57] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: India bank transfer icons and/or test redesign - https://phabricator.wikimedia.org/T228698 (Ejegg) Open→Resolved p:Triage→Normal a:Ejegg [15:37:10] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Bug: payment form still displays warning that we do not accept over 10K donations - https://phabricator.wikimedia.org/T229932 (Ejegg) Open→Resolved [15:37:23] Fundraising Sprint King Kong vs. Mozilla, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, and 6 others: Implement Ingenico recurring up sell - https://phabricator.wikimedia.org/T216560 (Ejegg) Open→Resolved [15:37:25] Fundraising-Backlog, Epic: EPIC: Recurring upsell for donors - https://phabricator.wikimedia.org/T143429 (Ejegg) [15:39:21] !log updated payments-wiki from 00eb090dcc to e3b378f65d [15:39:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [15:42:01] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Monthly donor message on payments missing contact email address - https://phabricator.wikimedia.org/T230225 (Ejegg) @Pcoombe thanks for reporting this. Should be fixed now for all languages. [15:46:25] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: harmonize dedupe Navigation menu and Nav Menu edit screen - https://phabricator.wikimedia.org/T230731 (MBeat33) [15:57:49] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Finalise & test field mapping for targetsmart import - https://phabricator.wikimedia.org/T228712 (LeanneS) Ah I see those now! Thes... [16:08:18] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530877 (owner: Ejegg) [16:41:12] fr-tech anyone want to take a look at https://gerrit.wikimedia.org/r/530449 ? [16:42:06] hey ejegg i was just looking at it [16:44:33] thanks cstone! Any questions or concerns? [16:50:21] not any yet ejegg [17:00:00] Fundraising-Backlog: Adyen links testing issue - https://phabricator.wikimedia.org/T230621 (Ejegg) Oh hey, looks like it's because we don't actually have any payment_submethods turned on for IE. @EMartin, what cards should be enabled for Ireland? [17:04:09] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Replace hacky check for choiceData staleness with a real check, and send back data on how often it happens - https://phabricator.wikimedia.org/T229365 (Ejegg) @AndyRussG you fixed this with https://gerrit.wikimedia.org/r/523095 , right? [17:28:33] (CR) Cstone: [C: +2] "Looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530449 (https://phabricator.wikimedia.org/T229343) (owner: Ejegg) [17:29:00] ejegg worked nicely for me to switch out the placeholder text easily [17:29:04] (PS1) Ejegg: Fix formatting for a couple SmashPig files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530911 [17:30:30] (Merged) jenkins-bot: Alternate 'Employer' placeholder text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530449 (https://phabricator.wikimedia.org/T229343) (owner: Ejegg) [17:32:09] (PS1) Ejegg: Make recurring day & amount editable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530913 (https://phabricator.wikimedia.org/T198268) [17:32:13] cstone: great! [17:32:40] it's a bit of a bummer that one can't override ALL the messages that might appear using the same config file [17:33:02] but it seemed less icky than multiple mustache template blocks [17:33:52] yeah definitely [18:06:27] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Replace hacky check for choiceData staleness with a real check, and send back data on how often it happens - https://phabricator.wikimedia.org/T229365 (AndyRussG) >>! In T229365#5422587, @Ejegg wrote: > @AndyRussG you fixed this with https://gerrit... [18:08:45] Fundraising-Backlog: Where's my upsell donation? - https://phabricator.wikimedia.org/T230744 (Ppena) [18:39:45] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530944 [18:40:00] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530944 (owner: Ejegg) [18:49:04] Fundraising-Backlog: Where's my upsell donation? - https://phabricator.wikimedia.org/T230744 (Ejegg) On the Contributions tab, try clicking the 'Recurring Contributions' link at the top. For the contact using your Yahoo email address, I do see a $2 recurring contribution with a start date of September 17th 2... [18:57:38] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530944 (owner: Ejegg) [18:58:25] oh hey, there's a new git command on the block: switch ! [19:07:23] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530947 [19:14:03] ejegg: hmmm can it wash my dishes? [19:15:50] AndyRussG: I'm still not sure how it's better than checkout, actually [19:16:08] ejegg: looks like it's mostly a more coherent wrapper to the various functions of checkout? [19:16:16] I guess so [19:28:31] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530947 (owner: Ejegg) [19:31:13] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530947 (owner: Ejegg) [19:35:49] !log updated payments-wiki from e3b378f65d to 7b8091ba87 [19:35:56] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:50:42] (CR) Eileen: [C: +2] Make recurring day & amount editable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530913 (https://phabricator.wikimedia.org/T198268) (owner: Ejegg) [20:08:14] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (DStrine) Resolved→Open [20:08:53] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (DStrine) Can this be turned off again? This is not needed for the 1 hour test. We have other high priority tasks to work on. [20:12:29] (CR) Eileen: [C: +2] Fix formatting for a couple SmashPig files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530911 (owner: Ejegg) [20:17:40] (Merged) jenkins-bot: Fix formatting for a couple SmashPig files [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530911 (owner: Ejegg) [20:18:02] (Merged) jenkins-bot: Make recurring day & amount editable [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530913 (https://phabricator.wikimedia.org/T198268) (owner: Ejegg) [20:46:43] (PS1) Ejegg: Revert "Uncomment PayTM" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530962 [20:46:50] (CR) Ejegg: [C: +2] Revert "Uncomment PayTM" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530962 (owner: Ejegg) [20:48:06] (Merged) jenkins-bot: Revert "Uncomment PayTM" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530962 (owner: Ejegg) [20:49:24] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530947 (owner: Ejegg) [20:49:27] (PS1) Ejegg: Add variant to show PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530963 [20:49:32] (CR) Ejegg: [C: +2] Add variant to show PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530963 (owner: Ejegg) [20:50:33] (Merged) jenkins-bot: Add variant to show PayTM [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530963 (owner: Ejegg) [20:51:16] (CR) Ejegg: [C: +2] Make BannerRenderer link methods static [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/519950 (https://phabricator.wikimedia.org/T225101) (owner: AndyRussG) [20:53:36] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530965 [21:05:52] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530965 (owner: Ejegg) [21:06:27] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/530965 (owner: Ejegg) [21:14:54] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530968 [21:14:59] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530968 (owner: Ejegg) [21:17:07] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530968 (owner: Ejegg) [21:20:07] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194442 MB (20% inode=99%) [21:21:43] !log updated payments-wiki subdesarrollo [21:21:47] !log updated payments-wiki from 7b8091ba87 to 85dce8f79f [21:21:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:21:51] ugh [21:21:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:22:10] paste-o etched in the server logs [21:23:13] PROBLEM - check_disk on frlog1001 is CRITICAL: DISK CRITICAL - free space: / 46122 MB (86% inode=98%): /boot 182 MB (73% inode=99%): /srv 23746149 MB (65% inode=98%) [21:23:56] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530968 (owner: Ejegg) [21:24:55] hmm, are those inode stats for real? [21:25:17] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194442 MB (20% inode=99%) [21:27:01] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/530968 (owner: Ejegg) [21:28:13] PROBLEM - check_disk on frlog1001 is CRITICAL: DISK CRITICAL - free space: / 46122 MB (86% inode=98%): /boot 182 MB (73% inode=99%): /srv 23746148 MB (65% inode=98%) [21:30:13] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194442 MB (20% inode=99%) [21:32:32] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (Ejegg) This is turned back off for now. @Dstrine or @EMartin can you document what the problems were? If you want to test it more, you can get a version of the form with... [21:33:13] PROBLEM - check_disk on frlog1001 is CRITICAL: DISK CRITICAL - free space: / 46122 MB (86% inode=98%): /boot 182 MB (73% inode=99%): /srv 23746146 MB (65% inode=98%) [21:35:13] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194441 MB (20% inode=99%) [21:38:13] RECOVERY - check_disk on frlog1001 is OK: DISK OK - free space: /srv 23746145 MB (65% inode=98%): /dev 7950 MB (100% inode=99%): /run 1535 MB (96% inode=99%): / 46122 MB (86% inode=98%): /dev/shm 7962 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 7962 MB (100% inode=99%): /boot 182 MB (73% inode=99%): /run/user/3649 1592 MB (100% inode=99%) [21:40:13] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194441 MB (20% inode=99%) [21:42:07] (CR) Ejegg: [C: -1] "Seems fine to use IDs instead of classes here, but there are a couple inconsistencies." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [21:45:17] PROBLEM - check_disk on bellatrix is CRITICAL: DISK CRITICAL - free space: / 33675 MB (95% inode=98%): /srv 3194441 MB (20% inode=99%) [21:50:13] RECOVERY - check_disk on bellatrix is OK: DISK OK - free space: /srv 3194440 MB (20% inode=99%): /dev 80567 MB (100% inode=99%): /run 16059 MB (99% inode=99%): / 33675 MB (95% inode=98%): /dev/shm 80580 MB (100% inode=99%): /run/lock 5 MB (100% inode=99%): /sys/fs/cgroup 80580 MB (100% inode=99%) [22:08:52] (PS1) Eileen: Add api & test for target smart import [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/530976 [22:09:34] ejegg: I got https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/530976/ ready-ish for review - I will continue doing my own testing on it [22:10:17] thanks eileen! downloading it now [22:13:49] eileen: I see CRM_Core_BAO_Cache::getItem is deprecated, but no hint as to what it should be replaced with [22:14:49] guessing a wrapper to various caches introduced lately, but I forget where those are [22:14:53] ejegg: ah - the Civi::cache() is the way to go - note that the civi update is NOT required before the targetsmart stuf f in the end [22:15:05] but we should do it next since we want it out before slushy time [22:15:31] ok, because you pulled in a core thing here, it looks like? [22:19:50] yeah just copied it in [23:49:33] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (XenoRyet) Possible tasks: Finish decommissioning old unsubscribe and move that functionality to the...