[05:52:07] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Check in on Safari changes and possible impact to CentralNotice - https://phabricator.wikimedia.org/T230820 (AndyRussG) Summary: - In an upcoming version, Safari on the iPad will become indistinguis... [08:02:36] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/531838 (owner: L10n-bot) [11:54:09] (PS33) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [12:21:30] (CR) Vedmaka Wakalaka: "This change is ready for review." (4 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [13:13:43] (PS4) Krinkle: Only register adminUI modules on the CN infra wiki (e.g. Meta-Wiki) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/531223 (https://phabricator.wikimedia.org/T221805) [13:16:22] (CR) jerkins-bot: [V: -1] Only register adminUI modules on the CN infra wiki (e.g. Meta-Wiki) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/531223 (https://phabricator.wikimedia.org/T221805) (owner: Krinkle) [13:16:27] (CR) jerkins-bot: [V: -1] Only register adminUI modules on the CN infra wiki (e.g. Meta-Wiki) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/531223 (https://phabricator.wikimedia.org/T221805) (owner: Krinkle) [13:23:37] (PS5) Krinkle: Only register adminUI modules on the CN infra wiki (e.g. Meta-Wiki) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/531223 (https://phabricator.wikimedia.org/T221805) [14:04:09] Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, Patch-For-Review: Make sure silverpop export does not include endowment donations (except in explicit endowment fiel... - https://phabricator.wikimedia.org/T228349 [14:06:28] hi fr-tech! [14:06:57] howdy ejegg [14:07:04] thank for the code review! [14:07:17] thanks* [14:10:18] hello! [14:10:43] hey cstone :) [14:15:10] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Check in on Safari changes and possible impact to CentralNotice - https://phabricator.wikimedia.org/T230820 (Ejegg) Related MacWorld article: https://www.macworld.com/article/3403436/safari-on-ipados... [14:16:24] hi jgleeson_ and cstone [14:16:32] thanks for your CR yesterday! [14:25:45] hey ejegg I was a little confused about why we are dividing by 2 the batch times in the queue consumers. Do you know what the history around that is? [14:28:17] jgleeson: since we were running 2 queue consumers in one batch job, we gave each one half the allocated time [14:28:34] ohhhh I see [14:28:37] clever [14:28:43] heh, not really [14:28:53] solomonic? [14:29:13] * jgleeson is looking up solomonic [14:29:15] diving the baby in two [14:29:28] lol [14:30:28] two women were arguing over who was the mother of a baby. King solomon says divide the baby in two and give one half to each. one woman cried and said no, better the other woman have it all. King S declared her the mommy [14:30:42] so i heard it, anyway [14:32:05] who'd of thought he would of went on to INSPIRE the even better wmf queue consumer designs! [14:32:11] would have [14:39:01] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Check in on Safari changes and possible impact to CentralNotice - https://phabricator.wikimedia.org/T230820 (spatton) Thanks for this great summary @AndyRussG and for the helpful links, @Ejegg! @Pco... [15:02:06] blargh, shoehorning these labels into the table-based forms is just as unfun as I expected [15:02:48] (CR) Jgleeson: "Thanks for all the feedback. I've fixed the items listed in the next patch!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [15:02:59] (PS8) Jgleeson: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) [15:03:18] ejegg, html tables! [15:03:25] guess I could just add new table rows :( [15:04:12] yeah. and we're just using them for vertical alignment [15:04:59] so even adding new table rows leaves us with a tricky horizontal alignment problem [15:06:26] just spin the horizontal align knob on the ol' CRT till it lines up, I guess [15:13:52] ejegg, I just looked over 'WIP form labels via new variant mechanism' and I can see what you mean about the html stuff although the approach looks sound to me [15:14:28] pretty handy that lightncandy supports runtime partials [15:14:58] I feel like Nirzar and PCoombe were working on a non-tables design of the form [15:15:09] but I don't remember where that went [15:16:12] the way we broke up the partials (rows within a table) really doesn't give us the flexibility to just use sane CSS for a part [15:16:22] those tables are serious tech debt [15:17:12] yeah I see what you mean [15:17:53] I wonder if Sadok has any time to take a look at the payments forms [15:21:45] so what's the issue you're getting at the moment ejegg the labels aren't lining up with the fields? [15:22:24] yeah, it's just a jumble [15:23:14] gonna spend an hr or two stripping out all the table crap and seeing if I can get it to work without that [15:24:03] ejegg, check out that css hack for td child nodes in the first answer https://stackoverflow.com/questions/18941108/vertical-align-all-elements-in-td [15:25:07] jgleeson: I don't think that's the answer here. the labels need to be at the top of the td and horizontally aligned with their corresponding boxes [15:27:13] ah ok [15:45:34] (PS1) Ejegg: WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [15:45:45] ^^^ doesn't look so bad on desktop [15:46:15] buncha JS refs to tds and trs need fixing [15:48:16] (CR) jerkins-bot: [V: -1] WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 (owner: Ejegg) [15:48:19] oh hey, here's an interesting mockup: https://wikimedia.invisionapp.com/share/46CGX9RPU#/screens/242426184 [15:59:54] (PS2) Ejegg: WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [16:01:47] (CR) jerkins-bot: [V: -1] WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 (owner: Ejegg) [16:11:39] (PS3) Ejegg: WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [16:12:16] this might not be so bad... [16:14:23] ok, little error message alignment still to fix [16:33:21] fr-tech coming [16:33:22] ! [17:30:01] (PS1) Ejegg: Non-USD support for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 [17:31:29] (PS2) Ejegg: Non-USD support for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 [17:33:25] (CR) jerkins-bot: [V: -1] Non-USD support for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 (owner: Ejegg) [17:42:00] (PS1) Ejegg: Fix other amount validation for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 [17:44:04] (CR) jerkins-bot: [V: -1] Fix other amount validation for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 (owner: Ejegg) [18:18:30] (PS4) Ejegg: WIP kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [18:23:37] (PS5) Ejegg: Kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [18:26:18] (PS3) Ejegg: Non-USD support for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 [18:26:20] (PS2) Ejegg: Fix other amount validation for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 [18:49:34] have a great weekend fr-tech! [18:49:36] o/ [21:14:22] (PS6) Ejegg: Kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 [21:18:27] (PS3) Ejegg: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) [21:21:04] (CR) jerkins-bot: [V: -1] Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [21:28:30] ejegg: leanne has ok'd the targetsmart imports so far so I can schedule it [21:28:47] woohoo! [21:38:20] ejegg: if you can check process control commit I'll deploy [21:40:17] eileen: looking [21:43:21] eileen: ok, so */4 means every 4 minutes, and you've got the timeout set to 5 minutes with allow overtime [21:43:32] so each batch should take less than 4 min? [21:44:01] ejegg: yes I think they take a couple of min - running one now but didn't do date first - will try [21:44:21] again [21:48:18] eileen: cool, the commit looks good then! [21:49:25] hmm it looks like it took a little over 4 mins [21:49:46] I might slow down to 6 mins - seems safer? Timeout should also be 6? [21:50:10] maybe was 4.5 mins [21:51:26] ejegg: just updated both to 6 [21:51:31] ok, cool [21:51:51] yep, yaml looks good [21:52:22] no need to block out silverpop hours on this one? [21:57:22] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 2 others: Create batch job wrapping target smart import allowing us to schedule it - https://phabricator.wikimedia.org/T228714 (Eileenmcnau... [22:05:51] ejegg: hmm not sure - we really started that for the dedupe jobs didn't we? This shouldn't affect silverpop too much [22:05:56] !log process-control config revision is 8c900d909f [22:06:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:06:08] cool [22:06:50] it's running [22:07:06] :) :) :) [22:37:38] (PS4) Ejegg: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) [22:39:42] (CR) jerkins-bot: [V: -1] Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [22:45:46] ok - it crashed - will have to figure out why [23:01:25] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 2 others: Create batch job wrapping target smart import allowing us to schedule it - https://phabricator.wikimedia.org/T228714 (Eileenmcnau... [23:18:16] (PS5) Ejegg: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) [23:29:22] (PS9) Ejegg: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [23:29:30] (CR) Ejegg: [C: +2] Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [23:30:20] (CR) jerkins-bot: [V: -1] Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [23:31:36] hrm? [23:31:57] weird mysql thing [23:32:01] let's try that again [23:32:18] (CR) Ejegg: [C: +2] Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [23:36:19] looking better this time [23:37:13] (Merged) jenkins-bot: Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/529413 (https://phabricator.wikimedia.org/T227805) (owner: Jgleeson) [23:37:17] yay! [23:37:32] ok, heading out. fr-tech, have a great weekend!