[00:16:40] (CR) jerkins-bot: [V: -1] Stock CiviCRM 5.17rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532493 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [00:18:46] !log civicrm revision changed from ab2a9b264b to 517e6ee4e0, config revision is 8c900d909f [00:18:52] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:55:09] ejegg|afk: I have a commit on process-control to start running all 8 files concurrently [01:02:28] I'm kinda tempted to just push out but .... [01:02:44] I'll have lunch first... [01:22:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) [01:22:49] fr-tech ^ this just in [01:24:38] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (JJMC89) [01:25:17] AndyRussG: do you know what caused it? [01:26:23] I see the missing Order By [01:27:44] eileen: haven't dug into it yet, but it looks potentially ugly [01:27:56] :-( [01:28:21] ```ORDER BY DESC``` [01:28:29] What should it order by? [01:29:57] eileen: hmmm dunno... Just in a weird HR meeting right now about goals [01:30:10] Not weird, I mean, not usually scheduled [01:30:14] ah [01:30:49] Dunno if others were invited to such, there was an earlier session too [01:34:30] (PS2) Eileen: Stock CiviCRM 5.17rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532493 (https://phabricator.wikimedia.org/T228826) [01:34:32] (PS1) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 [01:36:16] (CR) jerkins-bot: [V: -1] Stock CiviCRM 5.17rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532493 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [01:36:23] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 (owner: Eileen) [01:38:29] (PS2) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 [01:40:17] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 (owner: Eileen) [01:46:29] (PS3) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 [01:47:29] !log process-control config revision is 24aed9745e [01:47:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:47:42] I figured it was OK to turn these on without getting someone to check [01:51:24] (CR) jerkins-bot: [V: -1] Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 (owner: Eileen) [01:55:44] Fundraising Sprint Never Ending Query, Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Nurse love & iterate on our targetsmart batch job - https://phabricator.wikimedia.org/T228715 (Eileenmcnaughton) I now have 8 jobs running so all 8 csv files a... [02:03:49] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 2 others: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (Eileenmcnaughton) @me... [02:19:02] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) Thanks so much for reporting this @JJMC89!! I'm getting the same issue locally with updated versions o... [02:19:19] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) p:Triage→Unbreak! [02:19:53] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) [03:08:47] (PS1) Eileen: Temporary patch to help on the transition on bulkCreate (renamed bulkSave). [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532505 (https://phabricator.wikimedia.org/T228286) [03:14:57] (CR) jerkins-bot: [V: -1] Temporary patch to help on the transition on bulkCreate (renamed bulkSave). [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532505 (https://phabricator.wikimedia.org/T228286) (owner: Eileen) [03:20:12] AndyRussG: seems to be a recent core change [03:21:20] ejegg: yeah, can't think of what else it could be [03:21:25] reproducible locally [03:22:26] Looks like the SQL error is in the table selection? still have to analyze it more closely, but there's a bit that says, "FROM `cn_notices` `notices` ORDER BY DESC" at the end [03:22:56] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (Ejegg) Git bisect points to core commit I082152b64141f1a9a4085bb... [03:24:54] git bisect!! never heard of that [03:25:30] oooh, it's the best for finding bugs! [03:25:43] bisect to disect then? [03:25:49] yep yep [03:26:09] so you start a session with 'git bisect start [03:26:10] ' [03:26:35] then pick a known good sha from the past and use 'git bisect good ' [03:27:13] and because your current state is bad you type 'git bisect bad' [03:27:36] and git automatically hops to the commit halfway between known good and known bad [03:27:55] (PS1) Eileen: A bit of phpstorm love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532506 [03:27:56] and you check again and either type 'git bisect good' or 'git bisect bad' [03:28:06] Ooooh bootiful [03:28:22] and git keeps hopping to the midpoint between good & bad till there's only one guilty commit left [03:28:39] which in this case is titled 'Clean up LinkRenderer usage in IndexPager and extensions' [03:29:00] which sure seems relevant given the stack trace [03:29:23] a glance at it doesn't show obvious errors [03:30:01] but maybe the CN Pager child class was doing something funky? [03:30:31] ejegg: CN Pager always does something funky [03:30:49] wouldn't have it any other way [03:31:01] hmm, looks like the constructor signature has changed! [03:31:12] - public function __construct( IContextSource $context = null ) { [03:31:17] + public function __construct( IContextSource $context = null, LinkRenderer $linkRenderer = null ) [03:32:32] but would a missing linkrenderer fubar the ordering? [03:36:11] hmm, the parent::construct() call has been moved in the TablePager constructor [03:36:52] ...and moving it back to the bottom fixes the error on Special:CentralNotice! [03:36:57] so... why? [03:37:09] and I guess that placement deserves a comment [03:39:50] ejegg: sorry specifically what did you change to make it work? Got a quick patch file to share on a gist or pastebin? [03:39:52] aha, parent constructor calls $this->getIndexField() [03:40:05] I'll put up something in gerrrit, one sec [03:40:11] ejegg: just FYi I went ahead & deployed additional targetsmart jobs without a +2 since it seemed like it was implicitly approved [03:40:22] eileen: rockin! [03:40:32] seemed like a simple enough multiplexer [03:41:20] yeah - we are up to 666k contacts imported [03:41:34] dunno if that's significant.... [03:43:01] heheheh [03:45:02] AndyRussG: https://gerrit.wikimedia.org/r/532507 [03:47:03] ejegg: woohooo! Nice super-speedy sleuthing! [03:47:55] :) thanks! [03:48:29] super thankful for our beta setup [03:57:51] yeah for sure eh [03:59:27] ejegg: yeah fixes it for me too! [03:59:37] Imma assign u the task and put it in review, k? [04:00:13] cool cool [04:00:31] ok, gonna head to bed. have a good night! [04:00:39] ejegg: que descanses! [04:02:59] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible, Patch-For-Review: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) a:Ejegg Thanks @ejegg!! I c... [04:24:54] ejegg|away: if you're there, if you fix the comment style to // and add a blank line before line 49, I'll +2 right away! [04:25:08] we should really make sure this gets on the train tomorrow morning... [05:36:25] (PS1) Eileen: Fixes to preferred language handling to make it survive the upgrade. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532515 (https://phabricator.wikimedia.org/T228826) [05:46:08] (PS1) Eileen: Add bulkSave fn to help with switching to the renamed fn on update. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532517 (https://phabricator.wikimedia.org/T228826) [05:47:53] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible: Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (JJMC89) Open→Resolved [09:16:33] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/532579 (owner: L10n-bot) [11:27:42] (CR) D3r1ck01: [C: +1] "lgtm!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485514 (owner: Fomafix) [11:29:50] (CR) D3r1ck01: "lgtm!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/471662 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [11:29:56] (CR) D3r1ck01: [C: +1] Have wgNoticeProjects default to [] [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/471662 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [13:19:10] tzag fr-tech! [13:19:31] welcome back mepps ! [13:20:11] thank you jgleeson! how goes? [13:20:56] things are good thanks! it was a holiday here too yesterday so just back from a welcomed long weekend :) How was your vacation? [13:30:19] jgleeson it was really good [13:30:35] the beach was amazing and we got the kids napping on the same schedule most days! [13:32:43] good work! [13:37:12] now i'm trying to wade through email [13:52:31] Wikimedia-Fundraising-Banners: Check UX of desktop fundraising banners on iPad - https://phabricator.wikimedia.org/T231325 (Pcoombe) [13:56:18] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Check in on Safari changes and possible impact to CentralNotice - https://phabricator.wikimedia.org/T230820 (Pcoombe) Thanks for spotting this and researching it! I created {T231325} for the banner t... [13:57:37] heading to the park with Oscar, back later! [13:59:25] hi mepps! welcome back [14:04:40] hi ejegg! thanks! [14:17:45] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Beta-Cluster-reproducible, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Special:CentralNotice DBQueryError DBTransactionStateError - https://phabricator.wikimedia.org/T231261 (AndyRussG) Thanks... [14:19:57] tzag mepps, jgleeson, ejegg fr-tech [14:20:15] hi AndyRussG! [14:20:21] howsie goesies? [14:21:36] hey AndyRussG! [14:21:48] jgleeson: hey :) [14:22:10] hello everyone! [14:22:17] hello cstone :) [14:22:20] cstone: helloooo :) [14:22:42] frtech: there seems to be a pileup of drupal jobs on civi1001 [14:23:10] Jeff_Green, mepps, did Dallas make it on to IRC yet? [14:23:56] great question jgleeson! i'm not sure but i doubt he'd be online yet anyways since he's on PT time [14:24:42] jgleeson: I don't think so, he was online yesterday as his personal user but he hadn't created a new work user yet [14:24:46] hmm Jeff_Green is it the target smart job? [14:24:48] mepps have you seen the band 'Pigeons Playing Ping Pong'? [14:24:52] mepps: yes [14:25:04] Jeff_Green: that's kind of expected, I guess [14:25:16] really? what is it doing? [14:25:29] eileen's got it working on 8 different csvs at once, importing a bunch of ancillary data to Civi [14:25:46] is it a one-time import? [14:25:54] Since it's all updates to existing contact rows she thought it wouldn't be deadlocking [14:26:01] yeah, should be done today or tomorrow [14:26:04] ok [14:26:20] just noitced that eileen requested it be disabled [14:26:23] load is high on civi1001 but I haven't seen any alerts re. the database side of things [14:26:29] ok, great [14:26:33] ejegg did she decide against that? ^^ [14:26:43] I see a couple of 'bus error' failures in the older logs [14:27:02] mepps was that email from a bit more than a day ago? [14:27:34] She set it processing one part of the file at first [14:27:47] and assumed when it finished it would start sending failmail [14:28:06] but then it turned out to have a quiet failure mode [14:28:40] so when that first piece finished she created 8 jobs to import the rest of the file chunks [14:28:42] yeah ejegg it was from yesterday morning [14:29:23] so it is failing now or working as expected ejegg? [14:30:19] mepps mostly working as expected [14:30:42] though there are some failures in email overnight - not sure if those are data-related [14:33:50] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Performance-Team (Radar): Remove hacky EventLogging-duplicating code and use new lightweight EL facilities - https://phabricator.wikimedia.org/T214709 (AndyRussG) [14:33:53] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [14:36:39] Fundraising-Backlog: Data Exported from Civi contains spaces - https://phabricator.wikimedia.org/T231330 (NNichols) [14:39:38] fr-tech, do you know if the Individual goals: Department-wide training workshop session was recorded? I missed yestedays as it was a holiday in the UK and the second session is tonight at 2am UK time [14:39:58] yesterday's* [14:44:04] good question jgleeson! Obviously I couldn't attend either. apparently there will be make up sessions, but who else from fr-tech didnt' make it? [14:51:43] Fundraising-Backlog: Unusable emails addresses - https://phabricator.wikimedia.org/T231332 (NNichols) [14:52:14] jgleeson: mepps: I was there for the evening session [14:52:21] great AndyRussG [14:52:44] hmmm I'm not sure I feel like "great" is the operative word here [14:52:51] I can give a summary during standup [14:52:56] Wikimedia-Fundraising-Banners: Don't offer monthly suggestion when country doesn't support upsell - https://phabricator.wikimedia.org/T230944 (Pcoombe) Also don't offer it for certain methods e.g. Credit Card in France (where it's Adyen, which doesn't offer recurring) [15:05:27] (CR) Ejegg: [C: +2] A bit of phpstorm love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532506 (owner: Eileen) [15:11:06] (Merged) jenkins-bot: A bit of phpstorm love [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532506 (owner: Eileen) [15:12:37] (CR) Ejegg: [C: +2] "Passing the form values in seems like a pain. Thanks for this workaround!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532515 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [15:14:40] (CR) Ejegg: [C: +2] "Cool, this will make the upgrade easier. Let's tie a string around something to remember to undo this later!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532517 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [15:24:03] (Merged) jenkins-bot: Fixes to preferred language handling to make it survive the upgrade. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532515 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [15:24:05] (Merged) jenkins-bot: Add bulkSave fn to help with switching to the renamed fn on update. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532517 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [15:25:45] (CR) Bartosz Dziewoński: [C: +2] Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485514 (owner: Fomafix) [15:27:36] fr-tech, today's (and the first ever) random song suggestion for others is, Ben Howard - Rivers in your mouth [15:28:26] ooh thanks jgleeson I was just looking for something to listen to [15:29:58] cstone, the album that song is part of is also a big thumbs up from me. It's called 'I Forget Where We Were' [15:30:18] ive apparently listened to a bunch already haha [15:30:24] :)) [15:36:27] jgleeson cstone thanks, duly noted, queueing up the evil music streaming service [15:36:41] (evil only because they interrupt the music with commercials, of course) [15:36:51] :) [15:41:23] (Merged) jenkins-bot: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485514 (owner: Fomafix) [15:48:33] fundraising-tech-ops: puppetize and configure fruec banner log parser/db injector script - https://phabricator.wikimedia.org/T231249 (Jgreen) fruec database is created per sql/create_tables.sql The db portion of /etc/fruec.yaml is: db_settings: user: 'fr_stats' password: '(nope!)' host: 'fundraisingd... [15:59:03] Wikimedia-Fundraising-Banners: Check UX of desktop fundraising banners on iPad - https://phabricator.wikimedia.org/T231325 (scervantes) @Pcoombe is there a way we can test it if we don't have an ipad? Would setting Chrome Inspector device to iPad do it? [16:02:01] jgleeson: did you want to get in on this HEPdata conversation? [16:02:10] (employer field next steps) [16:02:24] sorry, joining now! [16:23:57] @ejegg about sir? [16:52:34] hi seddon! [16:52:42] just finished a meeting [16:53:50] what's up? [16:54:24] ejegg: do page views on donate wiki end up in the regular web request logs? [16:54:50] Seddon they do! [16:55:03] and the hive tables on the main cluster [16:56:05] Then a rube goldberg machine sends a subset of them (via Kafka and a wierd django-based python app) to the pgheres tables in our fundraising dbs [17:07:01] lol [17:07:42] aww, the cashless economy is killing local currencies: https://www.bbc.co.uk/news/uk-england-devon-47471231 [17:09:38] ejegg, that's some crazy coincidence, "Devon singer Ben Howard" [17:09:49] "Devon singer Ben Howard also became the face of the £10 note in May 2014." [17:11:10] jgleeson: heh, that's how I ended up at that article [17:11:16] wikihole [17:11:32] ah gotcha [17:12:02] ejegg, I'm revisting th python3 updates, did you think this warranted a tech-talk before +2? [17:12:30] jgleeson I didn't think it needed it before, but it turns out it was a great idea! [17:12:47] oh did it already happen? [17:12:52] I would have totally missed that the other script was in use otherwise [17:12:56] oh yah [17:13:05] last week [17:13:12] I guess late in your TZ? [17:13:31] ok cool, so I guess it can be +2'd now [17:13:34] anyway, I realized the fundraising statistics generator script was actually still in use [17:13:39] and needed some fixes [17:13:45] so the last PS got that all working [17:17:16] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (AndyRussG) > Steps to reproduce: > Go to https://en.wikipedia.org/wiki/Special:HideBanners > > Output: > Blank web page. Absolutely no HTML elements or alerts in the ja... [17:17:31] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (LeanneS) [17:21:06] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (Ejegg) Even better than cookies would be a way to set the banner-hide keys in localStorage (so browsers don't send data unnecessarily on every request). Though that impl... [17:31:20] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (AndyRussG) >>! In T230571#5442800, @Ejegg wrote: > Even better than cookies would be a way to set the banner-hide keys in localStorage (so browsers don't send data unnec... [17:32:26] Wikimedia-Fundraising-Banners, User-DannyS712: Special:HideBanners renders as a blank page - https://phabricator.wikimedia.org/T230571 (Ejegg) Oh yeah, just going off on a tangent. This bug report describes the intended behavior of the special page. [17:37:18] ejegg, I had my own wiki wormhole today on another wiki hehe https://tobaccotactics.org/index.php?title=Main_Page [17:37:48] oh nice, looks like a good site [17:40:05] Fundraising-Backlog: Investigate matching gifts HEP integration (was employer field V2) - https://phabricator.wikimedia.org/T228765 (Ejegg) After talking with HEPData today, we heard they do offer a daily sync of information to some of their education client. They also showed us a front-end integration with... [17:42:07] jgleeson: want to deploy your qc breakup today? [17:43:19] Fundraising Sprint Never Ending Query, Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Nurse love & iterate on our targetsmart batch job - https://phabricator.wikimedia.org/T228715 (LeanneS) Wonderful! Thanks so much. [17:49:41] yeah ejegg, definitely an eye-opener. I was looking at a post about tobacco companies using their staff to set up "Citizens Initiative's" which are petitions that require the debating of existing laws by law makers if a certain number of people sign them. Companies are prohibited from using these tools, although company employees acting as individuals are not. This particular petition was to remove laws which restrict the [17:49:41] advertising of electronic cigarettes... which doesn't feel like something individuals would care too much about. https://tobaccotactics.org/index.php?title=Imperial_Tobacco#Interfering_with_democratic_processes [17:50:15] ejegg, sure I'll deploy that today [17:53:24] nice [17:53:41] (the deploy, not the "citizen's initiatives") [17:55:00] :) [18:11:28] Fundraising-Backlog: Enable Visa, Mastercard, Amex, and JCB for Adyen in Ireland - https://phabricator.wikimedia.org/T230621 (mepps) Note: FR wants to do a test of adyen versus globalcollect and waiting on this is a minor blocker. It looks like it's a 1. @Ejegg do you know why this got prioritized for Sprint S? [18:35:59] Wikimedia-Fundraising-Banners: Check UX of desktop fundraising banners on iPad - https://phabricator.wikimedia.org/T231325 (Pcoombe) @scervantes That will do for testing responsiveness. I have an iPad so will check out the touch-friendliness. [18:42:34] (CR) jenkins-bot: Preload tablesorter styles by module 'jquery.tablesorter.styles' [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/485514 (owner: Fomafix) [18:54:12] Fundraising-Backlog: Enable the ability for user to pay with iDeal through Adyen - https://phabricator.wikimedia.org/T231370 (EMartin) [18:58:04] fundraising-tech-ops: Add Dallas Wisehaupt (DWisehaupt) to WMF-NDA and Security phabricator projects - https://phabricator.wikimedia.org/T231371 (Jgreen) [19:00:06] fundraising-tech-ops: Onboarding Dallas Wisehaupt to Fundraising Tech Operations - https://phabricator.wikimedia.org/T231372 (Jgreen) [19:00:22] fundraising-tech-ops: Onboarding Dallas Wisehaupt to Fundraising Tech Operations - https://phabricator.wikimedia.org/T231372 (Jgreen) [20:13:48] Fundraising-Backlog: Civi: small # of PayPal contribs listed twice - https://phabricator.wikimedia.org/T230956 (MBeat33) @Ejegg Kristie found another more recent example, from Aug 23rd: CID=5897344, PAYPAL_EC 31X68282EH588133Y and PAYPAL 31X68282EH588133Y [20:13:59] fundraising-tech-ops: Add Dallas Wisehaupt (DWisehaupt) to WMF-NDA and Security phabricator projects - https://phabricator.wikimedia.org/T231371 (Jgreen) Open→Resolved p:Triage→Normal a:Jgreen [20:14:01] fundraising-tech-ops: Onboarding Dallas Wisehaupt to Fundraising Tech Operations - https://phabricator.wikimedia.org/T231372 (Jgreen) [20:15:18] (PS1) Eileen: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532780 [20:15:20] (PS1) Eileen: switch to new fn name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532781 (https://phabricator.wikimedia.org/T228826) [20:15:40] (CR) Eileen: [C: +2] Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532780 (owner: Eileen) [20:21:21] (Merged) jenkins-bot: Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532780 (owner: Eileen) [20:30:20] is anyone able to give me a quick merge on this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/532781/ so I can retry the tests on the upgrade? We have a renamed fn on one repo that needs to be called from the other so first I added the new one to the civi repo here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/532517/ [20:35:52] (PS1) Jgleeson: Updated README to include instructions for setting up test mysql database and workaround for running unittests on vagrant. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 [20:47:20] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1291 processes [20:52:20] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 221 processes [20:52:24] (PS1) Jgleeson: Mediawiki Vagrant Fundraising CiviCRM unittest fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532792 (https://phabricator.wikimedia.org/T220411) [20:54:59] Fundraising-Backlog: PayPal bug? Donation processes when PP screen says I will have a chance to review transaction - https://phabricator.wikimedia.org/T230928 (EMartin) Ok, getting this over to paypal. I'll report back here. [20:55:33] (CR) Ejegg: [C: +2] switch to new fn name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532781 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [20:58:38] eileen, I just saw this commit https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/526580/ [20:58:58] which I think it the one you mentioned that was ahead of this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/526580/ [20:59:21] grrr.. ahead of this one I meant https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/532792/ [20:59:33] thanks ejegg|food [21:01:09] (Merged) jenkins-bot: switch to new fn name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532781 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [21:02:31] oops [21:04:06] (PS3) Eileen: Stock CiviCRM 5.17rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532493 (https://phabricator.wikimedia.org/T228826) [21:05:08] (PS4) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 [21:05:17] (Abandoned) Eileen: Temporary patch to help on the transition on bulkCreate (renamed bulkSave). [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532505 (https://phabricator.wikimedia.org/T228286) (owner: Eileen) [21:05:30] (CR) Eileen: "recheck" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532493 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [21:05:42] fr-tech what do you think of running the silverpop job a couple hours earlier? [21:06:03] ejegg, eileen I think I can abandon my patch for using the league/csv package as the omnimail composer dependency does appear to fix my vagrant issues also [21:06:21] apologies for going the long way around on that, I guess I must have not composer installed since that change [21:06:22] on master [21:08:48] ok, no worries! [21:08:49] (Abandoned) Jgleeson: Mediawiki Vagrant Fundraising CiviCRM unittest fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532792 (https://phabricator.wikimedia.org/T220411) (owner: Jgleeson) [21:09:13] hmm, it takes us 1 hr 15 min just to write the file from the db for the silverpop export??? [21:09:32] I know it's 3.4GB, but that still seems like it should be faster [21:09:34] db to csv? [21:09:37] yeah [21:09:42] woah that does feel long [21:09:51] it's going from a view that does all the formatting [21:09:56] ah [21:10:16] what time does it currently start? [21:10:21] but the view doesn't do any joins, just date formats and 0/1 => NO/YES [21:10:40] starts the table updates at 6 UTC [21:10:52] and finishes those around 9:05 UTC [21:11:03] then the file dump takes till 10:21 [21:11:11] then it uploads [21:11:44] is there a reason we work on UTC? [21:12:05] (assuming we are and you're not just using it to help explain to me :) [21:13:47] I don't see any issue with moving it to an earlier UTC slot unless it risks missing out a busy period from another TZ? [21:15:03] 6 UTC is closer to end of day for EST/PST [21:15:42] +/CT [21:16:05] maybe it was intentially to capture the end of day traffic on US tz [21:16:21] intentionally* [21:21:33] fr-tech, looks like there's a few other things waiting to be deployed to CRM otherthan the decoupled consumer changes [21:21:39] 38addc2060 Break out existing shared consumer drush jobs into indivdual jobs for each consumers. [21:21:39] b6233a446f Add ability to track multiple targetsmart jobs [21:21:40] 9a574616a8 A bit of phpstorm love [21:21:40] a9d6ec9799 Fixes to preferred language handling to make it survive the upgrade. [21:21:40] 18c47b9668 Submodule update [21:21:41] 0552eb1e43 switch to new fn name [21:22:00] eileen, can the above go out? [21:23:17] (PS1) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532800 [21:23:53] jgleeson: that 'submodule update' might be the CiviCRM upgrade ! [21:24:05] yeah I'll delay those other ones [21:24:10] maybe just cherry-pick your drush one for now? [21:24:30] would be nice to do that separately b/c of the process-control config changes we'll need to coordinate [21:25:02] it's probably too late to do it now so I'll leave that patch and just cherry-pick the consumer patch like you say and do that tomorrow [21:25:19] (Abandoned) Jgleeson: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532800 (owner: Jgleeson) [21:27:46] sorry the submodule one was just a super minor change [21:28:00] I should have added it into the commit message [21:29:34] oh in that case jgleeson the rest of that is deployable now [21:30:36] ah cool [21:31:22] I think I need to write up a short test plan for this release ejegg as it's likely involved drip feeding through each queue consumer and confirming all went as expected [21:31:35] it will* [21:31:56] ok, sounds good [21:44:53] (PS34) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [21:51:05] Fundraising-Backlog: Center payment icons on payments page for user view - https://phabricator.wikimedia.org/T231391 (EMartin) [21:59:04] (CR) Vedmaka Wakalaka: "This change is ready for review." (14 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [22:02:19] eileen: that latest fail on taretsmart6 is weird [22:02:22] missing contact_id [22:02:38] yeah I'm looking & can't see why [22:02:50] but if I look at the rows around the value for targetsmart_progress6 they all have a value there [22:04:57] the row it's broken on seems fine [22:15:50] (PS1) Eileen: Add values to data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532812 [22:19:32] (PS2) Eileen: Add values to data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532812 [22:20:23] (CR) Ejegg: [C: +2] "seems worth a shot!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532812 (owner: Eileen) [22:29:08] Wikimedia-Fundraising-CiviCRM: Error received when importing via the Civi import function - https://phabricator.wikimedia.org/T231399 (RLewis) [22:30:12] (Merged) jenkins-bot: Add values to data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532812 (owner: Eileen) [22:33:11] Hello I am back on IRC it rules [22:33:22] (PS1) Eileen: Add values to data [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532814 [22:33:28] (CR) Eileen: [C: +2] Add values to data [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532814 (owner: Eileen) [22:40:26] !log civicrm revision changed from 517e6ee4e0 to 049c9666b6, config revision is 24aed9745e [22:40:31] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:44:14] (PS1) Eileen: Desparate attempt to catch error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532816 [22:44:17] welcome back, tskaff_ ! [22:44:34] Haha thanks! [22:45:34] (PS1) Eileen: More desparation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532817 [22:48:48] (CR) Ejegg: [C: +2] More desparation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532817 (owner: Eileen) [22:48:56] (CR) Ejegg: [C: +2] "blah" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532816 (owner: Eileen) [22:54:42] (Merged) jenkins-bot: Desparate attempt to catch error [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532816 (owner: Eileen) [22:54:44] (Merged) jenkins-bot: More desparation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532817 (owner: Eileen) [22:57:32] (PS1) Eileen: Desparate attempt to catch error [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532821 [22:57:34] (PS1) Eileen: More desparation [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532822 [22:57:43] (CR) Eileen: [C: +2] Desparate attempt to catch error [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532821 (owner: Eileen) [22:57:49] (CR) Eileen: [C: +2] More desparation [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/532822 (owner: Eileen) [23:02:08] !log civicrm revision is 049c9666b6, config revision is 24aed9745e [23:02:12] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:46:01] Fundraising Sprint Never Ending Query, Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Nurse love & iterate on our targetsmart batch job - https://phabricator.wikimedia.org/T228715 (Eileenmcnaughton) I've resolved test fails & recut it - still to d...