[01:15:54] heh, not my idea for a name either, i just voted for it! [01:38:17] oh hmmm! or maybe it was cstone's? Or mepps's? [01:40:03] I was on vacation! [01:46:00] (PS2) Eileen: Update afform [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532842 (https://phabricator.wikimedia.org/T228826) [01:46:02] (PS2) Eileen: Update contactlayouteditor in tandem [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532843 (https://phabricator.wikimedia.org/T228826) [01:46:04] (PS5) Eileen: Add extension to manage our query modifications [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532845 (https://phabricator.wikimedia.org/T228826) [01:46:06] (PS4) Eileen: Update deduper for 5.17 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532844 (https://phabricator.wikimedia.org/T228826) [01:46:08] (PS1) Eileen: Log deduping from our hook so we can remove hack [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533121 (https://phabricator.wikimedia.org/T228826) [01:52:46] we have a mystery genious [02:30:17] (PS1) Ejegg: Update deps for compat with latest mw core [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533124 [02:30:51] (CR) Ejegg: [C: +2] Update deps for compat with latest mw core [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533124 (owner: Ejegg) [02:32:34] (CR) jerkins-bot: [V: -1] Update deps for compat with latest mw core [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533124 (owner: Ejegg) [02:32:42] (Merged) jenkins-bot: Update deps for compat with latest mw core [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533124 (owner: Ejegg) [02:40:18] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533126 [02:40:29] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533126 (owner: Ejegg) [02:41:06] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533126 (owner: Ejegg) [02:57:03] (PS1) Ejegg: Update DonationInterface and vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533129 [02:58:44] (CR) Ejegg: [C: +2] Update DonationInterface and vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533129 (owner: Ejegg) [03:19:54] (Merged) jenkins-bot: Update DonationInterface and vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533129 (owner: Ejegg) [03:28:38] !log updated payments-wiki from 231b7b0850 to 1d5d7503b0 [03:28:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [03:52:08] (CR) jenkins-bot: Update DonationInterface and vendor [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533129 (owner: Ejegg) [03:53:46] (PS12) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [03:53:48] (PS5) Ejegg: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) [04:46:21] (PS5) Eileen: Re-apply WMF patches [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/532499 [04:46:23] (PS1) Eileen: Fix inconsistencies in duplicate retrieval [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/533134 (https://phabricator.wikimedia.org/T228826) [04:47:02] (PS5) Eileen: Update deduper for 5.17 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/532844 (https://phabricator.wikimedia.org/T228826) [04:51:51] (CR) jerkins-bot: [V: -1] Fix inconsistencies in duplicate retrieval [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/533134 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [04:52:28] (PS1) Eileen: Add exportUi extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533137 (https://phabricator.wikimedia.org/T228826) [10:03:42] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (CCogdill_WMF) [10:03:50] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (CCogdill_WMF) p:Triage→High [12:57:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Accessibility: Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (Pcoombe) [13:14:34] Fundraising-Backlog: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) [13:20:54] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (Pcoombe) Thanks for spotting this and reproducing! It's a donatewiki issue, fr-creative will sort it. [13:28:47] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) Many thanks, @Pcoombe I nearly added you at the start but thought I'd let fr-tech sort as I wasn't sure who would be able to fix this. I will use the donate... [13:35:17] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) p:Triage→High [13:40:30] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (CCogdill_WMF) @MNoorWMF is checking into the opt-in language. [14:01:16] jgleeson_: I got the paypal audit working! [14:01:42] ejegg, yeah I have tested it and it works. I'm just adding some updates to the read about those two scripts and how they work for future reference [14:01:50] thanks! [14:02:04] oh, nice! Thank YOU for the documentation updates [14:03:35] it looks like the parse_nightly script uses a paypal api integration to fill in some blanks [14:03:36] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Wikimedia-CentralNotice-Administration: Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException» (when trying to clone a banner) - https://phabricator.wikimedia.org/T173782 (mepps) The error display was... [14:07:13] jgleeson_: hmm, I think I remember looking at that and realizing the condition was never satisfied to actually use the API [14:07:45] if 'last_name' not in out and queue_name != 'refund': [14:07:56] (out is the dict sent to the queue) [14:08:15] if it's a donation/recurring without a last name [14:08:19] I think [14:08:35] hmm hmm [14:08:37] hey ejegg, we neither had our check-in on monday (since i wasn't here) or our mid-sprint check-in. would you like to chat this morning? [14:08:47] when you're free :) [14:08:47] mepps sure! [14:08:56] oh my gosh, I'm supposed to be in another meeting :( [14:09:13] meeting overload ejegg ! [14:09:35] ahh, oops, no, confusing IRC time with local time :P [14:09:47] it's sometimes the same! [14:10:00] haha got it! [14:10:08] what is your irc time? [14:10:13] and why is it different than local? [14:10:30] heh, it's the timezone of my VPS [14:10:45] US eastern [14:10:59] gotcha ejegg [14:11:24] i don't want to interrupt you and jgleeson too much so just let me know when works for you [14:14:32] jgleeson where did you add your documentation? [14:14:46] (PS1) Ejegg: Card alt text: include when translated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533228 (https://phabricator.wikimedia.org/T231549) [14:15:00] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Accessibility, Patch-For-Review: Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (Ejegg) p:Triage→Normal a:Ejegg [14:16:50] mepps he said README, so I imagine there's a patch imminent [14:17:02] oops ejegg i missed that [14:24:25] yeah I'm gonna push it after I +2 ejegg's patch then I can branch from new master [14:24:46] I also just one run over the silverpop export stuff, but I tested that last time I think so I don't expect it to take up much time [14:25:14] currently trying to turn my readme text into markdown which is surprisingly hard [14:30:42] ejegg do you want to meet before your other meeting? asking because otherwise i'll take a break to walk to the store now [14:30:48] hmm interesting jgleeson [14:31:05] what are you finding challenging? [14:36:04] finding an online editor to convert it [14:36:06] found one [14:36:10] done now! [14:37:22] cool, i was going to send you one but you're on top of it ;) [14:37:54] (PS1) Jgleeson: Added readme updates to paypal audit package. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533235 [14:38:31] I tried https://stackedit.io/ but found it a little confusing? so I then I moved to https://dillinger.io/ which was easy enough [14:39:43] cool! [14:40:31] mepps i have 15 min right now for a checkin [14:40:59] (CR) Mepps: [C: +2] Card alt text: include when translated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533228 (https://phabricator.wikimedia.org/T231549) (owner: Ejegg) [14:41:02] oops, you're probably walking to the store now [14:41:05] great ejegg [14:41:09] oh cool [14:41:18] meet in the usual hangout? [14:41:40] if it's still available [14:41:53] yeah looks like it's not [14:41:58] in the standup meet room then? [14:42:01] sure [14:49:01] (PS2) Jgleeson: Added readme updates to paypal audit package. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533235 [14:50:00] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 3 others: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (mepps) @AndyRussG Where are we with this? I'm thinking it's in the wro... [14:58:02] oh shoot, we need to reschedule that silverpop job [15:01:39] ejegg, i think we've got some encoding weirdness inside the silverpop_export.update.py csv output [15:01:53] all the columns/values are prefixed with b' [15:02:58] ejegg, https://stackoverflow.com/questions/6269765/what-does-the-b-character-do-in-front-of-a-string-literal [15:03:13] I'll add notes to the ticket [15:07:36] (CR) Jgleeson: [C: -1] "Thanks for updating. I manage to get the parse_nightly script to work as expected with messages pushed to the queue." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [15:23:36] (Merged) jenkins-bot: Card alt text: include when translated [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533228 (https://phabricator.wikimedia.org/T231549) (owner: Ejegg) [15:42:00] (PS1) TSkaff: clarified currency in Russian TY footer part 2 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533249 [15:44:34] fr-tech, I just noticed that when you pass a vairant in the URL and then remove that variant, the variant rules still apply. I'm guessing this is due to it being in the session? If so, is this desired behaviour? (I'm guessing it is, I just want to confirm :) [15:48:38] jgleeson_: yep, in the session! [15:48:43] we needed to do that for updonate [15:49:01] cool, I was checking out your labels patch and wanting to compare old to new [15:49:15] I got round it by adding another variant subseuqent to the labels ones [15:49:17] one* [16:01:46] (PS1) Mepps: Use specific error message when banner name missing/invalid [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533253 (https://phabricator.wikimedia.org/T173782) [16:09:55] jgleeson_: ah right, just putting something random in the variant param should do it [16:10:15] yeah [16:10:20] fr-tech are folks in the retro or do we want to keep standup at the same time? [16:10:37] ejegg, did you notice things got a little wider in your divs version of the donor form? [16:11:09] i'm in the retro [16:11:54] jgleeson_: oh drat, I was hoping I had gotten it pretty much equal [16:12:07] I do need to test that in more browsers though [16:12:09] I'll add a screenshot to the phab task [16:12:15] and my browser version [16:12:16] I'm having user error for the retro how do I get into this [16:12:31] I'm in the retro mepps [16:12:43] although I don't imagine I'll add much :) [16:13:16] cstone if you add /webrtc after the link it will take you to the browser format [16:14:07] got it to work on other computer! [16:14:28] ejegg, sorry I should have ben more specific. things are wider using the labels variant [16:14:44] or not hmm [16:15:19] ok jgleeson_, let me check on that [16:16:17] ejegg, here's a screenshot of the new labels variant div style above and the old tables style below https://pasteboard.co/IuXtj9P.png [16:17:17] thanks [16:18:13] hmm, we should add the missing templates and appeal text to vagrant payments-wiki [16:19:20] (CR) Jgleeson: [C: +1] "This works great for me. MustacheForm tests also passing for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [16:19:58] ah ejegg could it be related to stuff already missing maybe? [16:21:27] (CR) Jgleeson: [C: +1] "My browser version is Version 76.0.3809.132 (Official Build) (64-bit)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [16:21:45] (CR) Jgleeson: [C: +1] "chrome*** :)" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [16:22:18] It looks like the payments form expands less when the appeal takes up more space [16:22:22] but still does expand some [16:22:47] just trying to fix that silverpop export first [16:23:22] sure thing, sorry to distract! [16:23:46] mepps, did we decide to skip fr-tech standup? [16:23:54] the meeting has dropped off for me [16:23:57] no worries, thanks for all the detailed review! [16:24:07] jgleeson i moved it later though i'm okay to just have it at normal time if folks prefer [16:24:10] fr-tech ^^ [16:24:35] ahh I see it, it looks like it's spanning two days [16:24:51] so google bumped it up to the top bit [16:25:21] i edited it back down again jgleeson_ [16:28:12] (CR) Mepps: [C: +2] "Great work!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533235 (owner: Jgleeson) [16:28:47] (Merged) jenkins-bot: Added readme updates to paypal audit package. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533235 (owner: Jgleeson) [16:31:05] (PS6) Ejegg: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) [16:31:07] (PS1) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533260 (https://phabricator.wikimedia.org/T197805) [16:31:33] ooops, that should have been on the same chain of patches [16:32:18] (PS13) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) [16:32:20] (PS7) Ejegg: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) [16:33:55] thanks mepps, I just spotted a typo! so I'll push up a minor update to that [16:35:34] (CR) Ejegg: "Thanks for all the CR, jgleeson! I should have examined that output, especially considering the csv reader needed elimination." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [16:36:48] jgleeson_: fortunately the fix for the output was just as simple as the fix for the input - just get rid of our workaround and use the core CSV class [16:36:54] and hey presto it comes out UTF8 [16:37:41] (PS1) Jgleeson: Typo fix to paypal audit README [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533264 [16:37:58] awesome ejegg [16:38:02] I'll give it a whirl now [16:44:36] looking good ejegg ! [16:45:33] I'm just gonna have a poke around in fundstatgen.py [16:46:56] cool cool [16:47:28] that was using the default csv from the start [16:47:38] since it's just outputting digits for the most part [16:51:03] ejegg, it looks like the fundstatgen.py has it's own config but I can't see a sample [16:51:29] could you share yours so I can drop it in? [16:51:50] oh sure [16:52:02] lemme add an example config to git [16:52:06] thanks! [16:53:50] oh hey, there /is/ a fundstatgen.cfg checked in [16:54:11] you just need to fill out the hostname, username, and password for your civicrm db [16:54:11] oh sorry I see it [16:54:17] hidden in plain sight [16:54:18] yeah, no idea why it's not yaml [16:54:40] then you run it with PYTHONPATH=`pwd` python3 FundraiserStatisticsGen/methodgen.py -c FundraiserStatisticsGen/fundstatgen.cfg temp [16:54:55] (assuming 'temp' is a dir you've just created for outputting the csv files) [16:55:49] thanks! [16:55:56] feels like another opportunity for a readme [16:57:50] yep yep [16:57:57] lemme just add a skeletal one [17:14:35] (Abandoned) Ejegg: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533260 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [17:17:39] (PS2) Mepps: Use specific error message when banner name missing/invalid [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533253 (https://phabricator.wikimedia.org/T173782) [17:25:31] (CR) Jgleeson: [C: +2] "Nice job! I tested out paypal audit download_nightly and parse_nightly, silverpop_export/update.py and fundstatgen.py, and they all worked" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [17:29:03] (CR) AndyRussG: "> Patch Set 1:" [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/532858 (https://phabricator.wikimedia.org/T231406) (owner: AndyRussG) [17:37:41] fr-tech, I'm finishing a little earlier today so catch you all tomorrow! [17:49:05] (Merged) jenkins-bot: Convert fr tools to python 3 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520350 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [17:49:07] (Merged) jenkins-bot: SafeConfigParser -> ConfigParser [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/520669 (https://phabricator.wikimedia.org/T197805) (owner: Ejegg) [18:09:36] (PS1) Cstone: WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [18:38:05] (CR) jerkins-bot: [V: -1] WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [19:28:55] (PS2) Ejegg: Typo fix to paypal audit README [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533264 (owner: Jgleeson) [19:28:59] (CR) Ejegg: [C: +2] Typo fix to paypal audit README [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533264 (owner: Jgleeson) [19:30:01] (PS2) Ejegg: Updated README to include instructions for setting up test mysql database and workaround for running unittests on vagrant. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 (owner: Jgleeson) [19:30:15] (CR) Ejegg: "PS2: blankspace tweak" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 (owner: Jgleeson) [19:30:23] (Merged) jenkins-bot: Typo fix to paypal audit README [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533264 (owner: Jgleeson) [19:55:42] (PS3) Ejegg: Updated README to include instructions for setting up test mysql database and workaround for running unittests on vagrant. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 (owner: Jgleeson) [19:55:49] (CR) Ejegg: [C: +2] Updated README to include instructions for setting up test mysql database and workaround for running unittests on vagrant. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 (owner: Jgleeson) [19:59:06] (Merged) jenkins-bot: Updated README to include instructions for setting up test mysql database and workaround for running unittests on vagrant. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/532784 (owner: Jgleeson) [20:13:34] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/533319 [20:13:47] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/533319 (owner: Ejegg) [20:14:09] !log disabled fundraising python jobs [20:14:13] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:14:16] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/533319 (owner: Ejegg) [20:18:03] !log updated fundraising python tools from c0f4e7a379 to b42bda6bf3 [20:18:07] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:19:36] d'oh, looks like not everything is hunky dory [20:20:22] oh right, hah, i need to update those job definitions to use python3 [20:20:26] (PS2) Cstone: WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [20:24:23] Jeff_Green: is it too late in the day to ask for another python package installed on civi1001? [20:25:07] we need python3-paramiko [20:25:58] (CR) jerkins-bot: [V: -1] WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [20:34:07] ejegg: ok done I think [20:44:00] thanks! [20:44:59] sweet, audit downloaders work now [20:49:28] hoping the sp exporter takes less time with python3 [20:49:44] since we're using the native csv library and no hokey unicode workaround [20:49:54] (also hoping it creates identical output!) [20:50:53] Looks like 6/8 ts files are finished & the last 2 have maybe 3 hours to go [20:51:08] that's great to hear eileen ! [20:51:34] yep - did you see Caitlin's new job - to get the data to silverpop [20:52:48] ejegg on the different amount option for updonate is there a maximum amount set for USD? It wasn't letting me make a $5 on $35 USD but I could make a $5 CAD donation on a $9.99 CAD [20:53:18] cstone: oh weird [20:53:31] the max amount should be the original amount [20:54:09] was that with my patch applied or without? [20:54:23] I was testing your currency conversion patch but it was doing it on master too [20:54:40] hmmmm [20:54:58] try with the next patch in the chain too? [20:55:09] ok [20:55:41] oh how did I miss this one its probably it [20:56:42] i think we were comparing text to numbers before that final patch [21:18:06] (PS1) Ejegg: Add skeletal readme for FundStatGen [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/533335 [21:19:39] (CR) Cstone: [C: +2] "Looks good, let my $35 recurring through on a $35 donation." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 (owner: Ejegg) [21:20:23] sweet, new CSV export code produces files with exactly the same size. Diffing... [21:22:09] (CR) Ejegg: "Thanks, big spender!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 (owner: Ejegg) [21:22:26] nice, zero difference in the CSVs generated. And in 1/3 the time! [21:24:45] woo csv speed [21:26:08] oh hey, that's enough time to not reschedule the sp export [21:26:16] though I think they wanted to push it earlier in any case [21:34:40] ok, uploader works too [21:34:58] looka like time to re-enable those jobs [21:36:06] !log re-enabled fundraising python jobs [21:36:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:42:32] hmm how do you get gerrit to resubmit again? I don't see that patch in zuul ejegg [21:44:27] cstone it may be because there's a prerequisite patch still unreviewed [21:44:35] oooh hah [21:44:40] https://gerrit.wikimedia.org/r/531951 [21:45:13] ok cool that one worked great for me too [21:45:23] i see now what I did [21:46:02] (PS1) Scervantes: Change 'Wikimedia Foundation' from eng to spanish [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533342 [21:50:44] ejegg the js currency one is really cool, would it be rolled out everywhere in the end? There was just two $s before it said USD [21:54:37] cstone oops, let me take another look [21:54:55] ummm, I think that's the only place we use JS to format a currency [21:55:02] ah okay [21:55:09] the other amount box is formatted server side [21:55:23] but the PHP intl library can do most all the same tricks [21:55:39] anyway, lemme see where that second $ is coming from [21:56:40] the ones I meant where the one at the top of the form and then the one on the first pop up [21:57:06] sorry, can you show me? quick screenshare? [21:57:36] sure let me grab headphones [21:58:28] ok back [21:59:26] ok, ummm, let's use the standup link from today? [21:59:29] ok [22:03:55] (CR) Cstone: [C: +2] "The JS currency formatter is really cool! Looked good with CAD and USD." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 (owner: Ejegg) [22:17:47] (Merged) jenkins-bot: Non-USD support for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531951 (owner: Ejegg) [22:23:12] (Merged) jenkins-bot: Fix other amount validation for updonate [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531955 (owner: Ejegg) [22:31:44] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533352 [22:32:02] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533352 (owner: Ejegg) [22:41:06] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 [22:45:13] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 (owner: Ejegg) [22:50:08] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/533352 (owner: Ejegg) [22:54:48] (PS2) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 [22:55:34] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 (owner: Ejegg) [23:21:50] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 (owner: Ejegg) [23:23:49] !log updated payments-wiki from 1d5d7503b0 to 51d9ed79b6 [23:23:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:29:12] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 (owner: Ejegg) [23:58:03] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/533354 (owner: Ejegg)