[09:11:47] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533411 (owner: L10n-bot) [10:24:44] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Accessibility, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (Pcoombe) Open→Resolved Wonderfu... [13:46:19] (CR) AndyRussG: Campaign fallback (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [14:30:11] (PS4) Mepps: Used ids instead of classes and allowed for comma and decimal inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) [14:30:22] (CR) jerkins-bot: [V: -1] Used ids instead of classes and allowed for comma and decimal inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [14:30:25] (Abandoned) Mepps: Add step and min to avoid html validation error [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530582 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [14:33:47] (PS5) Mepps: Used ids instead of classes and allowed for comma and decimal inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) [14:51:21] The new Gerrit interface has a button for auto-replying "Ack"! [14:51:28] Is that a thing that I should know about? [14:51:58] I kinda feel like it's Bill the Cat noise [14:52:05] https://en.wikipedia.org/wiki/Bill_the_Cat [14:52:16] as in Ack-nowledged? [14:52:34] oh hmmm maybe that's it [14:53:38] it could also be a synonym for Yuck! :) [14:53:55] I thought it was like a visceral "ooops" [14:54:32] AndyRussG I'm confused--do i have to do something to get the new interface? [14:55:01] also i think of Ack as surprise and shock [14:55:06] like a "Yikes!" [14:55:34] it makes me think of MQ [14:57:10] https://www.rabbitmq.com/nack.html [15:02:16] (CR) AndyRussG: "Looking good, almost almost almost there!!! :) Thanks!!" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [15:08:40] fundraising-tech-ops: puppetize and configure fruec banner log parser/db injector script - https://phabricator.wikimedia.org/T231249 (AndyRussG) Thanks much @Jgreen!! [15:09:11] mepps: yeah, there's a link at the very bottom of your old interface Gerrit page [15:09:35] Thanks AndyRussG! [15:09:44] You can then switch back if you don't like it [15:09:59] It took me all of 5 minutes to get used to the new one and like it better [15:10:21] You can preview the formatting of comments... also make adjustment as to how the diffs will appear [15:11:36] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Client-side event impression event logging is broken - https://phabricator.wikimedia.org/T231404 (AndyRussG) [15:11:51] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Client-side event impression event logging is broken - https://phabricator.wikimedia.org/T231404 (AndyRussG) a:AndyRussG [15:18:36] jgleeson: ack is pretty fundamental - way down the stack in TCP it's used as a response to any packet arriving [15:19:23] oh cool, my knowledge is thin in those parts! [15:19:29] as i understand, that's the big difference between TCP and UDP - UDP doesn't send ACKs [15:19:48] so UDP is used when lossiness is acceptable as a tradeoff for speed [15:19:55] that sounds vaguely familiar [15:21:44] fr-tech, I realised I've accepted the meeting invite for the HEPdata call next week but I'm on vacation next week so I won't make it. I've updated the invite! [15:25:33] ooh the new gerrit ui is nice [15:26:38] just updated my virtualbox and vagrant, and with vb6 it seems to take less cpu [15:26:49] nice! [15:28:54] (had to update after my linux install jumped to kernel 5.2 - VB 5.1 just wasn't starting) [15:30:09] one of the evolutions to http is based on UDP, which seems weird to me - lossiness in a web page would be pretty disruptive [15:30:22] but maybe they do the loss-prevention at the application layer? [15:31:00] https://blog.cloudflare.com/the-road-to-quic/ [15:31:52] ooh, it puts encryption right in the transport layer! [15:46:14] (CR) Ejegg: [C: +2] Used ids instead of classes and allowed for comma and decimal inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [15:46:27] oh hey, yeah, that new gerrit UI is prettier [15:46:43] it'll take some getting used to... [15:47:16] I actually like the old :) [15:52:48] oh gross, 'download' link is totally hidden in skinny windows in the new ui [15:53:07] i was hoping they'd fixed the horiz scroll bug, but this is worse [15:55:14] huh, new Ui does let you show all diffs inline [15:56:41] (CR) Ejegg: [C: +2] Log deduping from our hook so we can remove hack [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533121 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [15:56:49] (PS2) Ejegg: Log deduping from our hook so we can remove hack [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533121 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [16:00:32] heh, grafana pw strength indicator says my generated pw is 'strong like a bull' [16:01:00] strong like ox! [16:01:51] (I think that's a movie quote?1?!) [16:02:02] boris badenov? [16:02:20] I think so I can hear it clearly [16:20:16] @AndyRussG: Hey Andy [16:21:03] @AndyRussG: Whats the best way of getting CN impression numbers [16:29:17] Seddon gimme just a sec pls [16:51:49] Fundraising Sprint Quick and the Deadlocked, Fundraising-Backlog, Recurring-Donations, Patch-For-Review: trigger a second email in recurring upsell to denote the recurring part - https://phabricator.wikimedia.org/T228162 (Cstone) @CCogdill_WMF is there any content yet for the second email in the... [17:22:26] Seddon: what specific numbers do you need? [17:24:46] ejegg, I forgot to say, thanks for the code review! [17:29:37] yw! [17:43:57] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) Do we have any estimate of the timeframe for this resolving (before Monday's send?)? [17:44:03] (Merged) jenkins-bot: Used ids instead of classes and allowed for comma and decimal inputs [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/530380 (https://phabricator.wikimedia.org/T230501) (owner: Mepps) [17:53:30] wat - zuul backlog to merge is 2 hours??? [18:20:17] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MNoorWMF) This is complete now. Receipt: https://donate.wikimedia.org/w/index.php?title=Special:LandingPage&country=FR&uselang=fr&&utm_medium=email&utm_source=sp60... [18:23:57] (PS35) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:24:25] (CR) Vedmaka Wakalaka: "This change is ready for review." (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [18:35:30] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) Hurray! Thank you @MNoorWMF [18:35:36] Fundraising-Backlog, donate.wikimedia.org: Opt-in showing in English to French-language donors - https://phabricator.wikimedia.org/T231552 (MBeat33) Open→Resolved a:MBeat33 [18:36:31] Wikimedia-Fundraising-Banners: Check UX of desktop fundraising banners on iPad - https://phabricator.wikimedia.org/T231325 (TSkaff) Adding some Radio button test history from Runjini for context on when/why we did radio: You can view the test sheet here: [[ URL | Radio Button Tests: 2017-18 ]] - The in... [19:39:31] do'h, one more missing python module on civi1001 [19:40:02] Jeff_Green or dwisehaupt : how do you feel about installing python3-redis on civi1001 on a Friday? [19:40:10] hoping that would be pretty low risk [19:40:34] ejegg: it's fine with me [19:40:55] we can check for dependency eelpits in virtualbox [19:41:23] hehe, nice [19:45:43] (PS1) Ejegg: Delete crufty test trait methods & phpcs exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533589 [19:52:26] (PS2) Ejegg: Delete crufty test trait methods & phpcs exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533589 [20:31:10] (PS1) Ejegg: Expunge last trace of superglobal access [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533600 [20:34:53] (PS1) Ejegg: Replace slow in_array( ... array_keys() ) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533601 [21:02:12] (PS1) Ejegg: Clean up GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533603 [21:40:36] (PS1) Ejegg: Gatway base class: add missing fn visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533608 [21:40:38] (PS1) Ejegg: Add missing method visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533609 [21:43:50] (PS2) Ejegg: Add missing method visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533609 [21:44:58] (CR) jerkins-bot: [V: -1] Add missing method visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533609 (owner: Ejegg) [21:45:58] ejegg|food: we're going to defer that new package to Tuesday after all (Monday holiday), Dallas is working on the puppet code and testing in virtualbox [21:49:49] Jeff_Green: ok, cool. [21:50:06] oops, left the |food flag up! [21:57:15] (PS2) D3r1ck01: CNChoiceDataResourceLoaderModule: Avoid using globals, use RL Config [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/532345 [22:30:49] !log disabled fundraising targetsmart import jobs [22:30:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:00:54] (PS1) Ejegg: Add missing method visibility on tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533614 [23:08:20] (PS1) Ejegg: Delete nonstandard fn comment annotations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533615