[00:02:39] (Merged) jenkins-bot: Delete crufty test trait methods & phpcs exception [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533589 (owner: Ejegg) [00:02:43] (PS1) Eileen: Cleanup field options in field code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534548 [02:21:51] (PS2) Eileen: Get latest apiv4 code to go with latest civi [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/534273 (https://phabricator.wikimedia.org/T228826) [02:22:12] (CR) jerkins-bot: [V: -1] Get latest apiv4 code to go with latest civi [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/534273 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [02:24:05] (PS4) Eileen: Stock CiviCRM 5.18rc [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/534244 (https://phabricator.wikimedia.org/T228826) [03:11:51] eileen: do we want an 'else' clause on those 'case' statements? [03:12:25] ejegg: hmm yeah ok - I assumed it would just handle but maybe not - ELSE '' I guess [03:13:13] (CR) Ejegg: "Looks good! Just one more trailing space. Also, do we want 'else' clauses on those case statements?" (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) (owner: Eileen) [03:14:11] eileen to test, we could run that final 'create view' statement and try running the export-only job [03:14:52] yeah - they don't want us to mess with anything today but tomorrow is free for all (not their words) [03:15:26] yeah, i imagine they want to see if the regular export is back working again [03:15:44] I feel like we do want to ELSE '' [03:15:57] since we're coalescing nulls to '' elsewhere in that view [03:16:32] (PS11) Eileen: Add new Silverpop fields to export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) [03:16:48] I just pushed those changes - just checking the conversion [03:19:51] (PS12) Eileen: Add new Silverpop fields to export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) [03:20:00] ejegg: ok good spotting on the casting - pushed a change [03:26:25] (CR) Eileen: Add new Silverpop fields to export. (2 comments) [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) (owner: Eileen) [03:27:33] eileen one more trailing space - 'b ' in income_range [03:28:18] thanks! fixed [03:28:20] (PS13) Eileen: Add new Silverpop fields to export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) [03:34:11] (PS14) Ejegg: Add new Silverpop fields to export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) (owner: Eileen) [03:34:29] (CR) Ejegg: [C: +2] "Let's give it a try!" [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) (owner: Eileen) [03:34:53] have a good rest of your day eileen. I'mma head to bed [03:35:06] (Merged) jenkins-bot: Add new Silverpop fields to export. [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534250 (https://phabricator.wikimedia.org/T231538) (owner: Eileen) [03:35:33] thanks [03:49:37] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ejegg) Thanks @EMartin! We have already implemented the Connect integration, including creating new payments fr... [04:22:15] (Abandoned) Eileen: Get latest apiv4 code to go with latest civi [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/534273 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [05:48:30] (PS1) Eileen: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) [05:54:21] (CR) jerkins-bot: [V: -1] Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [05:56:31] (PS2) Eileen: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) [06:01:37] (CR) jerkins-bot: [V: -1] Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [06:04:35] (PS3) Eileen: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) [06:08:12] PROBLEM - check_gcsip on payments2002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [06:09:26] (CR) jerkins-bot: [V: -1] Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [06:11:12] RECOVERY - check_gcsip on payments2002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.204 second response time [06:13:25] (PS4) Eileen: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) [06:19:17] (CR) jerkins-bot: [V: -1] Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [06:20:35] (PS5) Eileen: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) [06:35:11] (PS1) Eileen: Switch Omnimail tests to headless. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534570 [07:25:09] (CR) Awight: "To be clear, I was just reviewing the code out of idle curiosity, and I'm happy to see it merged as-is or with further improvements." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [09:16:22] Fundraising-Backlog: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (jrobell) [11:58:07] (CR) Krinkle: [C: +2] Use EventLogging API directly for impression event [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/534222 (https://phabricator.wikimedia.org/T231404) (owner: AndyRussG) [12:36:57] (Merged) jenkins-bot: Use EventLogging API directly for impression event [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/534222 (https://phabricator.wikimedia.org/T231404) (owner: AndyRussG) [12:43:23] (CR) jenkins-bot: Use EventLogging API directly for impression event [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/534222 (https://phabricator.wikimedia.org/T231404) (owner: AndyRussG) [13:06:49] (CR) Cstone: [C: +2] "Looks good for me in Firefox and Chrome." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 (owner: Ejegg) [13:08:47] (Merged) jenkins-bot: Kill table layout [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531941 (owner: Ejegg) [13:22:25] Fundraising-Backlog: civicrm failed outbound connections to https://www-prod.civicrm.osuosl.org - https://phabricator.wikimedia.org/T232094 (Jgreen) [13:28:40] woohoo! [13:29:00] (CR) Cstone: [C: +1] "Looks good for me too in Firefox and Chrome. I do see the wider form with labels previously mentioned, with the quote there it shifts free" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [13:30:00] hey ejegg I just saw the tiny bit of width change mentioned previously, was that super optimized to be that width? Or is it fine to be wider? [13:30:18] I'll try tinkering with it a bit more to see if I can constrain it [13:30:24] thanks for the review! [13:37:58] Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Bug: donations below should include error message on up... - https://phabricator.wikimedia.org/T230501 [14:05:31] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (EMartin) Thanks Elliot, so the work is exclusively on our end? No need for Ingenico to assist. Am I understan... [14:12:17] (CR) AndyRussG: "> To be clear, I was just reviewing the code out of idle curiosity, and I'm happy to see it merged as-is or with further improvements." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [15:04:15] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ejegg) @EMartin yes, I believe we can do it all ourselves. We'll want to test with one subscription initially,... [15:06:09] (PS6) Ejegg: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [15:06:26] (CR) Ejegg: [C: +2] "Less repeated code, more reliability checks. LGTM!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [15:09:11] (CR) Ejegg: [C: +1] "Looks good, and getting rid of that PEAR error mode voodoo makes me happy. Might clean up an unused import." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534570 (owner: Eileen) [15:12:49] (Merged) jenkins-bot: Omnimail test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534561 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [15:25:18] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (DStrine) [15:31:50] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Performance-Team (Radar): Remove hacky EventLogging-duplicating code and use new lightweight EL fac... - https://phabricator.wikimedia.org/T214709 [15:35:06] Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Bug: donations below should include error message on up... - https://phabricator.wikimedia.org/T230501 [15:42:42] (PS5) Cstone: WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [15:48:35] Fundraising-Backlog, Fr-Q2-2019-cleanup-list: Orphan rectifiers should output stats to grafana - https://phabricator.wikimedia.org/T232043 (DStrine) [15:49:42] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe, Fr-Q2-2019-cleanup-list: We need merge handling for opt in - https://phabricator.wikimedia.org/T232037 (DStrine) [16:13:31] (PS5) Mepps: CentralNotice: Replace run with insertIntoJobQueue in banner save [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 [16:13:43] not sure if i got that right AndyRussG ^^ [16:16:56] Fundraising-Backlog: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (kaythaney) [16:18:02] Fundraising-Backlog: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (kaythaney) [16:19:53] mepps: thanks, it's a big improvement!!! Mmm so I guess think about the context in which this would be read... The normal context is git log output, which may be one-line or multiline, or a git history graph, where you only see the first line [16:20:43] Fundraising-Backlog: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (Pcoombe) I'll prepare a patch for this, as a chance to test the new direct git method. [16:21:08] So, in any of those contexts, you'll already know that we're talking about CentralNotice... So "CentralnNotice" shouldn't be in the commit message [16:22:11] What does need to be there in the first line is a bit more explanation of what part of the code the change touches [16:23:07] Specifically, some mention of the MessageIndexRebuildJob should be there [16:23:42] Otherwise, a reader can't tell what "run" and "insertIntoJobQueue" refers to [16:25:15] Mmmm in the detailed explanation below, looks good! Just one detail, we're not inserting a message into the job queue, but rather a job, I think [16:25:33] (maybe check the doc for the details if you want, but definitely it's not a message) [16:26:54] Finally maybe just add the Bug: tag with the Phab bug ID just below or above the Chenge-Id: bit [16:27:03] Thanks again in advance!!!! [16:27:13] mepps: ^ [16:36:39] (PS6) Mepps: Use MessageIndexRebuildJob insertIntoJobQueue method when saving Banner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 [16:39:04] welcome dwisehaupt! [16:51:31] (PS7) Mepps: Use MessageIndexRebuildJob insertIntoJobQueue method when saving Banner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) [16:57:17] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (EMartin) Elliott, For your awareness, Ingenico advise that they can help run that script for us if it makes... [17:02:55] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ejegg) @EMartin If they're willing to do that for free, I'd happily accept it! We would still need to write a b... [17:04:38] fr-tech i'm in the same meeting as dstrine [17:10:36] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (Ejegg) @MBeat33 We're talking about migrating the old GlobalCollect recurring donations to use the new Ingenico... [18:21:47] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install new eqiad netsec server - https://phabricator.wikimedia.org/T232137 (RobH) p:Triage→Normal [18:21:59] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install new eqiad netsec server - https://phabricator.wikimedia.org/T232137 (RobH) [18:22:52] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frnetmon1001 - https://phabricator.wikimedia.org/T232137 (RobH) [18:32:07] fundraising-tech-ops: Issue new SSL Client Certificate for ccarter - https://phabricator.wikimedia.org/T232138 (Dwisehaupt) [18:35:17] fundraising-tech-ops: Issue new SSL Client Certificate for jcuriel - https://phabricator.wikimedia.org/T232139 (Dwisehaupt) [18:56:36] (CR) XenoRyet: [C: +2] Expunge last trace of superglobal access [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533600 (owner: Ejegg) [18:56:52] (CR) XenoRyet: [C: +2] Replace slow in_array( ... array_keys() ) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533601 (owner: Ejegg) [19:09:56] (CR) XenoRyet: [C: +2] Add 'useraction=commit' to PayPal EC redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/534205 (https://phabricator.wikimedia.org/T230928) (owner: Ejegg) [19:33:29] Fundraising-Backlog, FR-Ingenico, Fr-Q2-2019-cleanup-list, Recurring-Donations: Investigate migrating old ingencio recurring to new ingencio - https://phabricator.wikimedia.org/T232017 (MBeat33) Thanks, @Ejegg I was just thinking about asking you for more about what those options might mean when... [19:36:46] (Merged) jenkins-bot: Expunge last trace of superglobal access [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533600 (owner: Ejegg) [19:36:48] (Merged) jenkins-bot: Replace slow in_array( ... array_keys() ) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533601 (owner: Ejegg) [19:36:52] (Merged) jenkins-bot: Add 'useraction=commit' to PayPal EC redirect [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/534205 (https://phabricator.wikimedia.org/T230928) (owner: Ejegg) [19:45:49] fr-tech I'm going to head out for a bit. I'll be around later to finish up! [20:14:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate how to generate generic email for failed recurring donations - https://phabricator.wikimedia.org/T230064 (MBeat33) Multilingual support for this email would be super helpful, and directly increase the rate of donors re-upping. When DS follow... [20:16:53] (CR) XenoRyet: [C: +2] Clean up GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533603 (owner: Ejegg) [20:21:20] (CR) XenoRyet: [C: +2] Gatway base class: add missing fn visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533608 (owner: Ejegg) [20:30:57] (Merged) jenkins-bot: Clean up GatewayType interface [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533603 (owner: Ejegg) [20:34:10] Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: if existing CID has email opt-out, ask script to keep that when merging new ones - https://phabricator.wikimedia.org/T232151 (MBeat33) [20:43:17] (Merged) jenkins-bot: Gatway base class: add missing fn visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533608 (owner: Ejegg) [21:14:36] (CR) XenoRyet: [C: +2] Add missing method visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533609 (owner: Ejegg) [21:17:05] (CR) XenoRyet: [C: +2] Add missing method visibility on tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533614 (owner: Ejegg) [21:18:33] (CR) XenoRyet: [C: +2] Delete nonstandard fn comment annotations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533615 (owner: Ejegg) [21:18:50] thanks for the review, XenoRyet [21:18:56] Yea, no worries. [21:19:17] Good to tidy things up a bit. [21:27:21] (Merged) jenkins-bot: Add missing method visibility [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533609 (owner: Ejegg) [21:27:23] (Merged) jenkins-bot: Add missing method visibility on tests [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533614 (owner: Ejegg) [21:27:26] (Merged) jenkins-bot: Delete nonstandard fn comment annotations [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/533615 (owner: Ejegg) [21:27:52] (PS6) Cstone: WIP: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [21:34:03] Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: ask 'force merge' script to prefer most recent contrib data - https://phabricator.wikimedia.org/T232152 (Aklapper) [22:00:17] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/534691 [22:04:25] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/534691 (owner: Eileen) [22:04:55] (Merged) jenkins-bot: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/tools into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/534691 (owner: Eileen) [22:10:42] (PS2) Eileen: Switch Omnimail tests to headless. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534570 [22:10:48] (CR) Eileen: Switch Omnimail tests to headless. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534570 (owner: Eileen) [22:12:08] !log tools revision changed from b42bda6bf3 to 643c48b26a [22:12:10] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:22:57] (PS1) Eileen: COALESCE the decile fields to '' [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/534696 (https://phabricator.wikimedia.org/T231538) [23:28:16] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, and 2 others: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (Eileenmcnaughton) I've depl...