[03:31:44] (PS2) Eileen: Add finally-working attempt to log into Silverpop & get the queyr html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) [03:35:50] (CR) jerkins-bot: [V: -1] Add finally-working attempt to log into Silverpop & get the queyr html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [03:39:03] (PS3) Eileen: Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) [03:44:12] (CR) jerkins-bot: [V: -1] Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [03:49:25] (CR) AndyRussG: [C: -1] "After a bit more poking, I've found that I'm getting significant slowness when adding new translatable messages to banners on my *local wi" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [04:13:17] (PS4) Eileen: Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) [04:18:10] (CR) jerkins-bot: [V: -1] Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [04:33:26] (PS5) Eileen: Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) [06:11:19] (PS1) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [06:17:32] (CR) jerkins-bot: [V: -1] Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [06:18:15] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Wikimedia-Fundraising-CiviCRM: Error received when importing via the Civi import function - https://phabricator.wikimedia.org/T231399 (Eileenmcnaughton) Open→Resolved [06:27:32] (PS2) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [06:40:34] (CR) jerkins-bot: [V: -1] Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [06:56:27] (CR) Awight: [C: +2] Use specific error message when banner name missing/invalid (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533253 (https://phabricator.wikimedia.org/T173782) (owner: Mepps) [06:56:50] awight: boo! [06:56:52] also thanks! [06:57:01] also howsie goesies? [07:00:07] (CR) AndyRussG: "> After a bit more poking, I've found that I'm getting significant slowness when adding new translatable messages to banners on my *local " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [07:00:33] (PS3) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [07:01:43] AndyRussG: Hi! Just trying to catch up on my patch injustices :-) [07:02:07] (Merged) jenkins-bot: Use specific error message when banner name missing/invalid [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533253 (https://phabricator.wikimedia.org/T173782) (owner: Mepps) [07:02:41] AndyRussG: btw, this might not be the direction you want to go in, but I found some suspicious, custom caching that we can drop: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/484809/ [07:03:00] awight: hey I'm sure you're way beyond caught up...! Thanks for poking at the CN stuff!!! [07:03:43] That caching stuff might be responsible for the messages not updating after they're saved? [07:04:40] awight: oh hey that's exactly the bit I'm banging my head against right now [07:05:12] Do you know what the purpose of that caching was? [07:05:34] (CR) jerkins-bot: [V: -1] Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [07:06:03] IIRC, it was to save us a scan of the banner contents, looking for triple braces. But I think it was done under the shadow of a misunderstanding of the wikitext parser. [07:06:56] A full parse is expensive, but I don't think we're actually saving any parsing. Just a pcre_regex scan of the parser output, which is cheap. [07:07:25] Hmm interesting [07:07:36] The part that you modified in that patch has since changed: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralNotice/+/master/includes/Banner.php#849 [07:08:05] oh for increased complexity ;-) [07:08:15] (CR) jenkins-bot: Use specific error message when banner name missing/invalid [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/533253 (https://phabricator.wikimedia.org/T173782) (owner: Mepps) [07:08:47] ah `invalidateCache` is what was missing from the logic when I wrote that quick patch... [07:08:48] Ah right just moar better caching [07:09:08] So probably we could just rip that whole caching bit and related functions out? [07:09:25] I think it's worth a try! Can the bug be reproduced locally? [07:09:36] awight: in fact yes! [07:09:41] :D [07:09:48] well not fully [07:10:06] the slowness of the translate rebuild index thingy is indeed happening locally [07:10:29] however I'm stumped as to the how the state of the banner described in the bug is ocurring [07:10:48] https://phabricator.wikimedia.org/T231703 [07:11:03] https://meta.wikimedia.org/wiki/Special:CentralNoticeBanners/edit/T231703_test [07:11:30] Got a bunch of messages in the banner body, but no message fields in the UI [07:12:36] Remind me, why don't we use normal wikitext i18n? [07:12:40] I guess maybe somehow the cache key doesn't get invalidated when the request times out because of trying to rebuild the Translate indexes within the request? Lemme just check if the cache key invalidation might happen after the Translate thingy [07:13:32] awight: you mean, why does CN have the special i18n triple curlies thing? [07:13:53] Yeah, it's always bugged me [07:14:06] I assume there was a reason, I just cannot remember what it was now. [07:14:28] Well, currently there are different permissions set for translatable banner messages [07:14:43] Okay that sounds legit! [07:14:44] And the permissions for publishing a translation are special [07:15:09] Eh I wouldn't be surprised if there isn't a better way [07:16:21] Any idea what MessageGroups::singleton()->recache() is for? [07:17:39] It's still possible to sneak through a "normal" i18n message though, so maybe it's worth considering a voluntary way of writing i18n message substitutions coming from our protected namespace. [07:17:43] hmm lemme look [07:17:44] Ah another recent use is that we have special sanitization in place for banner translatable messages [07:18:19] aha okay I'll drop that bone :-) [07:20:03] awight: it's possible for a CN administrator to put a normal i18n message, or anything else in a banner, but CN admins are part of our evil web of mistrust [07:20:04] whereas translators don't quite reach the same level of mistrustworthiness [07:20:04] and the content and publishability of the CN translatable messages is what's extra locked down [07:23:58] +1 I don't like the MessageGroups recache, IMO if we need that we're doing something wrong. [07:24:51] Hmm It's also used in SpecialPageTranslation#markForTranslation [07:24:59] I really wish I had my head fully wrapped around the translate extension guts, but I haven't reached that level of perversion yet [07:26:16] NikeRabbit is really generous with explanations, if you ever visit #mediawiki-i18n [07:26:53] It's safe to say that not everything happening within the guts is kosher. [07:27:23] oh hey good idea [07:27:28] Very organic code that has been accumulating since before some of the better advances in MediaWiki-core [07:28:02] Just one example: it doesn't take advantage of dependency injection... [07:28:22] "accumulating"...? 8p [07:28:52] Argh we might actually need that `recache` since we're creating a new message group for each banner. [07:29:22] This is tantalizing, of course: [07:29:24] > TODO: This will go away if we start tracking messages in database :) [07:29:28] baahaha WHAT [07:29:43] * awight is afraid to git blame and find myself in the distorted mirror [07:30:48] That call was actually an improvement! https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/459834/ [07:31:52] ah yeah I remember that now [07:32:02] It was a suggestion from Niklas that I didn't understand [07:32:24] also, you'll be happy to know that TODO wasn't yours [07:36:10] awight: btw how's life outside the... err... walled garden? [07:36:18] (PS4) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [07:36:40] AndyRussG: Turns out, there was water outside the garden as well 8D [07:37:34] oh hmmm... but does the sludge look rose-coloured there too? [07:37:55] We're still not making ends meet, but free daycare is going to make a huge difference. [07:38:17] Daycare was $100/day for one kid, in the SF area. [07:38:31] ouch [07:38:38] yeah that's nuts [07:39:05] that's even with the kid taking the mandatory work option to stamp license plates at school ;-) [07:39:40] ehhhhhh [07:40:11] well at least now you've got even more language adaptation games for them to play [07:40:17] & the eldest kid comes home every day glowing about school, which I'm okay hearing multiple times [07:40:32] oh wow that's great to hear [07:40:47] Yeah I was not expecting anything special there, so it's a great surprise. [07:40:59] mine are both now in "secondary" school (like junior high in the US) [07:41:14] youngest just started grade 7 [07:41:35] (CR) jerkins-bot: [V: -1] Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [07:41:43] I hope the scholastic motivation has improved! [07:42:49] aarrgh my eldest is generally despising the private, sweet and academically very uneven Montessori-ish school she has the privilege to go to [07:42:58] she refuses to do any homework at all [07:43:22] while the youngest, who's in the same school, two grades below her, spends like hours on homework every day [07:43:38] oof I'm sure that increases the burning [07:44:25] yeah I wish I knew how to get Sofi out of the "bad apathetic student" self-image/rut [07:45:14] at least they both seem pretty healthy socially/friends-wise [07:45:40] is the school Mari raves about all in German? [07:45:56] Hopefully the things Sofi *is* interested in will take the lead... [07:46:51] yup, we're going full immersion, and luckily there's a city-wide (maybe national) program of "welcome classes" to help refugees integrate into school. [07:47:16] Yeah... thanks... that's more or less the hopeful path I'm imagining for her [07:47:22] wow that's fantastic [07:49:45] Well I'm sure soon they'll both be climate activists [07:49:47] https://www.cbc.ca/news/canada/montreal/greta-thunberg-1.5275586 [07:52:22] \o/ [07:55:17] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535073 (owner: L10n-bot) [07:56:51] awight: ;) hey great to hear from u as always eh... I may be fading out soon for the evening [08:04:00] I was trying not to mention the bedtime! o/ [08:21:15] awight: ahhhhehhhhblrrrrghh [08:21:47] awight: btw I think I found the bug about the banner message fields not updating on form submit [08:24:40] It's because SpecialCentralNoticeBanners generates the edit form, then submits it, which does the save stuff, and then re-generates it [08:25:02] and through that process we get an initial banner object with the old content, which is never marked as dirty [08:25:12] and from which it extracts the message fields to show on the form [08:27:57] (CR) Nikerabbit: "I have a patch that defers message group stats rebuild out of the message index rebuild: https://gerrit.wikimedia.org/r/c/mediawiki/extens" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [08:31:59] (CR) AndyRussG: "> Patch Set 7:" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [08:42:04] (PS1) Eileen: Fix upgrade regression [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535122 (https://phabricator.wikimedia.org/T228826) [08:44:30] Hmm I have a fix for Kristies regression - I think I might cheat & self review so I can get it out [08:45:05] (CR) Eileen: [C: +2] "I'm being naughty & self-reviewing to get this out as it's a regression" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535122 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [08:49:00] (PS1) Eileen: CiviCRM submodule uuupdate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535124 [08:49:16] (CR) Eileen: [C: +2] CiviCRM submodule uuupdate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535124 (owner: Eileen) [08:55:38] !log civicrm revision is d1d65f37ea, config revision is 5a6a9c6c03 [08:55:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [09:12:10] (CR) AndyRussG: [C: +2] "Yaaaaaaayyyyyy thanks all!!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [09:17:37] (Merged) jenkins-bot: Use MessageIndexRebuildJob insertIntoJobQueue method when saving Banner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [09:22:32] (PS5) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [09:24:10] (CR) jenkins-bot: Use MessageIndexRebuildJob insertIntoJobQueue method when saving Banner [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [09:38:41] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/535131 [09:38:56] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/535131 (owner: Eileen) [09:42:42] !log civicrm revision changed from d1d65f37ea to 516eeb54b5, config revision is 5a6a9c6c03 [09:42:43] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [09:45:58] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice reloads old translatable messages on form submit - https://phabricator.wikimedia.org/T72939 (AndyRussG) [09:46:58] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 3 others: CentralNotice reloads old translatable messages on form submit - https://phabricator.wikimedia.org/T72939 (AndyRussG) a:AndyRussG [09:49:43] (PS1) AndyRussG: In SpecialCentralNoticeBanners use $this->banner in processSaveBannerAction() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) [09:51:54] (PS2) AndyRussG: In SpecialCentralNoticeBanners use $this->banner in processSaveBannerAction() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) [09:52:50] (CR) AndyRussG: "Thanks so much!!! This looks like a good idea!! Let's investigate further before moving on, maybe? I think the issue mentioned in the comm" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484809 (https://phabricator.wikimedia.org/T72939) (owner: Awight) [09:59:34] (CR) AndyRussG: "> hoping to understand exactly how the error state described in the bug occurred (banner content saved but no message fields show up in th" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/459843 (https://phabricator.wikimedia.org/T231703) (owner: Mepps) [10:02:33] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice: Timeout when creating translation variables Translate Extension - https://phabricator.wikimedia.org/T231703 (AndyRussG) Than... [11:06:29] (CR) Awight: [C: +1] "Congratulations on possibly fixing this archaic bug!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) (owner: AndyRussG) [12:15:50] (PS1) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/535170 [12:39:43] (Abandoned) Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/535170 (owner: Hashar) [13:16:07] nice work mepps and AndyRussG [13:16:43] thanks ejegg! though i can't really claim credit because maggie from a year ago did the work and i can barely remember what she was thinking :P [13:16:51] so let's give it all to AndyRussG for reviewing :) [13:16:58] :) [13:22:11] mepps wat? nooo that credit is yours!! by that logic, the late night me of a few hours ago is at least as much of a mystery to the morning me typing this.... ;p [13:22:44] haha it may be tricky if none of our past selves can get credit [13:31:29] (PS1) Pcoombe: Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) [13:32:52] Hi ejegg, Kaitlin requested new copy for the endowment TY email and I thought I'd have a go at it myself. Could you or someone else take a look at the above? [13:33:24] sure thing pcoombe [13:36:53] (CR) jerkins-bot: [V: -1] Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [13:37:51] hmm [13:38:37] oh, that's a kindof silly test [13:39:17] just meant to make sure the subject line changes when sending financial type=Endowment [13:39:22] but I should make it less static [13:49:53] (PS1) Ejegg: Fix endowment TY test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535193 (https://phabricator.wikimedia.org/T232121) [13:50:00] ah, it wasn't static, it was just looking at the wrong subject file [13:50:32] fr-tech can anyone rubber-stamp that one-liner so pcoombe's letter update doesn't fail tests? ^^^^ [13:50:42] ejgg i'll look! [13:50:51] thanks! [13:51:11] Fundraising Sprint King Kong vs. Mozilla, Accuracy-Review-of-Wikipedias, Bad-Words-Detection-System, Better Use Of Data, and 89 others: Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (GoogleLegacy) [13:51:26] (CR) Mepps: [C: +2] Fix endowment TY test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535193 (https://phabricator.wikimedia.org/T232121) (owner: Ejegg) [13:52:03] i kind of liked how the old gerrit interface wouldn't let you click the rebase button if there was nothing to rebase [13:56:17] the new one does have some clearer text on the panel that pops up at least... [13:56:58] arr, what's up with that dlocal audit parser? [13:57:13] (Merged) jenkins-bot: Fix endowment TY test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535193 (https://phabricator.wikimedia.org/T232121) (owner: Ejegg) [14:00:40] ok, looks like there's a hung process - maybe related to the network attacks over the weekend? [14:00:48] just need to kill a process and delete a lock file [14:01:31] morning Jeff_Green ! Can you help kill a stuck process on civi? [14:01:36] 6392 1 0 Sep08 ? 00:00:57 /usr/bin/python3 /srv/tools/audit/astropay/download_nightly [14:01:40] ejegg: sure, sec [14:03:05] ejegg: done [14:03:15] hmm, why didn't we make process-control put its lock files in /var/run/lock? [14:03:22] where does it put them? [14:03:46] (CR) Thiemo Kreuz (WMDE): [C: +1] "Looks reasonable to me." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/484809 (https://phabricator.wikimedia.org/T72939) (owner: Awight) [14:04:04] Jeff_Green: can you please delete /tmp/jenkins-download_nightly.lock too? [14:04:54] also done! [14:05:07] (CR) Ejegg: [C: +2] "Retroactively +2ing this one. Thanks, Eileen!" [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535122 (https://phabricator.wikimedia.org/T228826) (owner: Eileen) [14:05:13] thanks Jeff_Green [14:05:57] ok, re-running the dlocal audit cycle [14:27:48] fr-tech hehe @ eileen's chosen name for the new Silverpop query-scrape api call: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/534736 [14:28:21] hah I saw that and it's great [14:39:14] well drat, that download is still hanging [14:39:54] (PS2) Ejegg: Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [14:42:57] (CR) Ejegg: [C: +2] "Nice! This fixes it for me locally, and the code looks good." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) (owner: AndyRussG) [15:01:59] ejegg i'm waving at you and saying hi in our call [15:07:31] Fundraising Sprint Winter Wanderland, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Large contribution report from Danny - https://phabricator.wikimedia.org/T182134 (DStrine) [15:17:24] (Merged) jenkins-bot: In SpecialCentralNoticeBanners use $this->banner in processSaveBannerAction() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) (owner: AndyRussG) [15:26:26] (CR) jenkins-bot: In SpecialCentralNoticeBanners use $this->banner in processSaveBannerAction() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) (owner: AndyRussG) [15:42:45] (PS7) Ejegg: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) [15:45:55] (PS3) Ejegg: WIP cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) [15:47:16] (PS2) Ejegg: Fix Amazon widget position [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/534858 [15:47:20] fr-tech anyone able to review this Amazon layout fix? ^^^^ [15:47:44] I'll check it out ejegg [15:47:49] Thanks jgleeson ! [15:48:13] There's login & password info for an amazon sandbox buyer up on frpm [15:48:25] in the settings repo, under payments-wiki-testing [15:48:54] look in the git log, it's the comment added just last week on the amazon account info in the 20-DI-accounts file [15:49:04] (CR) jerkins-bot: [V: -1] WIP cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) (owner: Ejegg) [15:54:56] ejegg, didn't you add some vagrant fixes also a few weeks back? [15:55:15] did they get merged [15:55:31] jgleeson there's a patch to pull in the appeal text: https://gerrit.wikimedia.org/r/c/mediawiki/vagrant/+/534261 [15:55:37] (still not merged) [15:55:50] unfortunately it requires destroy / rebuild [15:56:12] because the import of the main page fails if you re-provision [15:56:25] i bet there's a way to fix that... [15:56:30] hmmm yea [15:56:35] feels like we could tweak that [15:56:44] make it conditional on a db query, perhaps? [15:57:01] I think there's already some similar conditional in the crm role [15:57:19] actually, lemme try that [15:57:35] oh yeah, do you mean the 'unless' check? [15:57:37] * ejegg finds yet another way to procrastinate on that silly cancel error message [15:57:43] heh, that's the check [15:58:57] thanks for the keyword! [15:59:04] np [16:01:02] (CR) Jforrester: [C: +2] Have wgNoticeProjects default to [] [extensions/CentralNotice] (REL1_33) - https://gerrit.wikimedia.org/r/534251 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [16:04:51] fr-tech, today's random song suggestion is Pink Floyd - Comfortably Numb. Sufficiently spacey to work to :) [16:06:42] (Merged) jenkins-bot: Have wgNoticeProjects default to [] [extensions/CentralNotice] (REL1_33) - https://gerrit.wikimedia.org/r/534251 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [16:10:03] ejegg, looks like I might also need ssl based on the return URL [16:10:07] hmm, 'unless' works for 'exec' statements [16:10:12] jgleeson: oh shoot, yeah [16:10:17] I'll check out whether that still works [16:10:22] (the role) [16:10:27] the amazon js actually refuses to work without https [16:10:44] jgleeson: I think cstone and mepps were able to use the https role to look at that patch last week [16:11:12] I just tried adding 'unless' to the import_text tasks but no dice [16:11:20] ah shoot [16:11:25] hmm [16:11:39] what's the conditional you have in mind? [16:11:58] I know puppet supports ruby style conditions in resource blocks [16:12:11] but I think you wanna hit the DB right? [16:12:50] oh hmm, what would a ruby style condition look like in the mediawiki::import::text block? [16:13:20] let me find a bookmarked doc page with more info :) [16:13:30] Yeah, I've got the 'unless' written as a mysql command-like query [16:14:47] https://wikitech.wikimedia.org/wiki/Puppet_coding#Conditionals [16:14:50] (CR) AndyRussG: "@Ejegg @Awight thanks much!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535133 (https://phabricator.wikimedia.org/T72939) (owner: AndyRussG) [16:15:34] ah I wonder if the mediawiki resource extends a base resource that has something similar to what you're looking for or if it's standalone [16:16:49] feels like that import text command could be improved to update if the page exists [16:17:21] https://puppet.com/docs/puppet/3.8/lang_conditional.html [16:17:53] ah, right [16:18:14] so it would just be getting the output of a shell command into the conditional var [16:18:24] I think so [16:19:41] hmm, seems to be using mwscript edit.php [16:19:53] that should be able to handle update, no? [16:20:04] lemme try again, maybe it's not actually dying [16:21:26] oh hey, it's actually fine :) [16:21:44] jgleeson: want to go ahead and test that patch with just a 'vagrant provision' ? [16:22:28] oh wait, that didn't actually try to reload the pages [16:22:38] think I need to change the content to make it try again [16:24:09] hmm looks like paymentswiki links are pointing to :8080 even via https [16:24:21] I wonder if we can detect that [16:24:56] hmm, we're using the {{fullurl:}} macro to generate those [16:25:29] (CR) jenkins-bot: Have wgNoticeProjects default to [] [extensions/CentralNotice] (REL1_33) - https://gerrit.wikimedia.org/r/534251 (https://phabricator.wikimedia.org/T208694) (owner: MacFan4000) [16:25:29] so that macro should know [16:25:54] but... let's see, the https role is basically just a reverse proxy in nginx [16:26:08] even if I browse to https://payments.wiki.local.wmftest.net:4430/w/index.php?title=Special:AmazonGateway¤cy=USD&country=US&amount=1&ffname=amazon [16:26:22] I get failures in the network tab trying to load :8080 stuff [16:26:26] weird [16:26:39] so I guess mediawiki needs some PHP var set to know that it's actually https? [16:26:51] ah that's probably it [16:27:06] are the links correctly https on the main dev wiki? [16:28:08] eew, main dev wiki is giving me this: Exception from line 535 of /vagrant/mediawiki/includes/GlobalFunctions.php: A protocol-relative $wgServer may not contain a port number [16:28:24] is that part of my local setup? [16:28:31] hi XenoRyet ! [16:28:38] Howdy [16:29:01] XenoRyet: we're trying to get the Amazon layout fix through, to unblock payments-wiki deploys [16:29:13] so dev wiki looks ok for me [16:29:13] (in case you're eager to get that Ireland form out there) [16:29:26] jgleeson: ahh, so the https role must be setting something there [16:29:31] and not on paymentswiki [16:29:37] from the main page, I can go to SpecialPages and it keeps https / 4430 [16:30:22] I'll check out what the https role adds [16:32:41] is there an easy way to check what roles you have active? [16:33:35] cstone: I think it's 'vagrant list-roles' and the ones with asterisks by them are active. [16:34:07] Not sure if there's a cleaner way, but that gets it done. [16:34:14] yep that works thanks [16:34:34] oh huh, on my version it's 'vagrant roles list' [16:34:52] ejegg, I think that might be an alias [16:34:58] list-roles [16:34:58] yeah those both bring up the same thing for me [16:35:20] oh yeah, list-roles works too. cool! [16:36:29] Yea, enable-role and disable-role should work as well. For some reason those come out of my fingers easier than the other way. [16:37:09] so I'm looking at how we could also update payments wiki when https in enabled to add the same config here https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/role/manifests/https.pp for paymentswiki [16:37:14] jgleeson: looks like puppet/modules/role/templates/https/fixWgServer.php.erb has some php code to fix the thing up [16:37:31] ha [16:37:40] so just include that file if it exists, from our local settings template [16:37:43] ? [16:38:27] I'm confused on whether mediawiki::settings{} write to both dev-wiki and and paymentwiki? [16:38:34] i don't think so [16:38:51] or rather, not without explicitly specifying the otherwiki [16:39:16] and it seems wrong to make the https role know about paymentswiki [16:39:53] https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/payments/manifests/init.pp [16:41:07] hmm not sure if the namespace title actually does anything https://github.com/wikimedia/mediawiki-vagrant/blob/master/puppet/modules/payments/manifests/init.pp#L50 [16:41:58] oh shoot, I've gotta drop off to cook ejegg. I'll pick this up when I get back, sorry! [16:46:26] okok [17:08:27] PROBLEM - check_puppetrun on payments1004 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[openssh-server] [17:13:21] RECOVERY - check_puppetrun on payments1004 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [17:20:33] cstone or mepps: were you able to test the Amazon form despite the https role not fixing all the paymentswiki links? [17:20:54] It would be nice to be able to get the form changes out before all the banners get turned back on [17:21:27] just since cached CSS and JS can mess up the appearance if people are in the middle of a donation when we deploy [17:22:27] ejegg i was just investigating that [17:22:34] thanks! [17:23:04] is there extra stuff you need to do with the https role right now nothing is loading for me [17:25:21] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 6 minutes ago with 3 failures. Failed resources (up to 3 shown): Package[php7.0-redis],Package[php7.0-sqlite],Package[initramfs-tools] [17:28:40] cstone oh, the URL would need a port number [17:29:00] https://payments.wiki.local.wmftest.net:4430/w/index.php?title=Special:AmazonGateway¤cy=USD&country=US&amount=1&ffname=amazon [17:30:21] PROBLEM - check_puppetrun on civi1001 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 11 minutes ago with 3 failures. Failed resources (up to 3 shown): Package[php7.0-redis],Package[php7.0-sqlite],Package[initramfs-tools] [17:35:21] RECOVERY - check_puppetrun on civi1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [17:37:28] ejegg hmm that was still giving me ERR_SSL_PROTOCOL_ERROR, I just tried restarting everything and I still get it [17:56:17] PROBLEM - check_puppetrun on frauth1001 is CRITICAL: CRITICAL: Puppet has 5 failures. Last run 9 minutes ago with 5 failures. Failed resources (up to 3 shown): Package[libpam-systemd],Package[clamav],Package[clamav-freshclam],Package[openssh-client] [18:01:15] PROBLEM - check_puppetrun on frauth1001 is CRITICAL: CRITICAL: Puppet has 5 failures. Last run 14 minutes ago with 5 failures. Failed resources (up to 3 shown): Package[libpam-systemd],Package[clamav],Package[clamav-freshclam],Package[openssh-client] [18:06:17] RECOVERY - check_puppetrun on frauth1001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [18:09:40] cstone: oh, did you accept the self-signed certificate? [18:12:18] ejegg, cstone, back! [18:12:37] how's it going? my irc got d/c grrr [18:14:10] jgleeson: i had a meeting, just getting back to it [18:14:27] ejegg I thought I had but good question [18:17:36] i bet it was a previous box I remember doing it on [18:20:11] would the https role have created one? [18:24:05] cstone the https role would have created a self-signed cert [18:24:06] hmm [18:24:25] but you'd have to manually tell your browser to accept it [18:24:34] it looks like that config file to fix the wgServer entries should be loaded in for paymentswiki also [18:24:41] jgleeson_: oh, for real? [18:24:49] yeah from what I can see, just gonna confirm it [18:24:51] I guess it's the other settings that are missing then [18:24:54] exit() in it hehe [18:25:12] yup [18:27:13] heh, nice [18:28:52] ok, so how about the settings that are added via those ::settings calls - are they getting applied? [18:29:12] like mwvSupportsHttps [18:29:40] that gets dropped in here settings.d/puppet-managed/01-Vagrant-HTTPS-support-flag.php [18:29:51] and then pulled in by settings.d/wikis/CommonSettings.php [18:29:58] which is pulled in by both wikis [18:30:31] within LocalSettings.php [18:30:44] /LocalSettings.php * [18:32:13] actually [18:32:47] I don't think the fullurl parser picks up the port [18:32:54] so I wonder if there is something ELSE doing that [18:33:38] oh no it does [18:33:43] so our port is set incorrectly somewhere [18:36:13] (PS37) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:37:17] ok the side links in payments wiki do have the full https .. 4430 urls [18:37:20] (PS38) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:37:31] but our main_page content doesn't [18:37:48] I wonder if it's only parsed once or something? [18:38:18] hmm [18:38:23] import::text [18:38:25] gotta get some lunch, back soon [18:38:31] enjoy! [18:48:34] hey jgleeson any idea on ERR_CONNECTION_RESET errors when just trying to load the https payments wiki main page? I don't think its even getting to the point where I can accept the self signed cert [18:51:26] (PS39) Vedmaka Wakalaka: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) [18:56:10] (CR) Vedmaka Wakalaka: "recheck" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [19:03:07] (CR) Vedmaka Wakalaka: "This change is ready for review." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [19:20:35] cstone: what URL are you using? [19:21:44] https://payments.wiki.local.wmftest.net:4430/wiki/Main_Page [19:22:49] ok, that looks good [19:25:05] (PS8) Ejegg: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) [19:25:29] cstone: ^^^ should lock down the width of the label variant a bit [19:25:44] there's still some change, but not as much as without the max-width set [19:25:53] nice [19:26:29] sorry cstone missed you earlier message [19:26:37] no worries [19:26:47] been trying to workout why our urls aren't getting updated [19:26:52] hmm [19:26:57] cstone, what does it show in the network tab [19:27:36] it feels like the server config serving up the TLS cert isn't 100% [19:27:41] or it could be browser cache [19:27:52] ctrl-f5 fix anything cstone? [19:27:58] sorry, I know that's not helpful! [19:28:02] or restarting nginx? [19:28:11] PROBLEM - check_puppetrun on frqueue1002 is CRITICAL: CRITICAL: Puppet has 3 failures. Last run 5 minutes ago with 3 failures. Failed resources (up to 3 shown): Package[libpam-systemd],Package[openssh-client],Package[openssh-server] [19:29:10] network tab has just the google error page stuff [19:32:12] hmm [19:32:26] ssh onto the vagrant box [19:32:29] and run `sudo nginx -c /etc/nginx/nginx.conf -t` [19:33:11] RECOVERY - check_puppetrun on frqueue1002 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [19:37:17] PROBLEM - check_puppetrun on frdb1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[libpam-systemd] [19:42:17] RECOVERY - check_puppetrun on frdb1002 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [19:48:10] Fundraising-Backlog: MinFraud Anomolies - https://phabricator.wikimedia.org/T232385 (EMartin) [19:51:44] Wikimedia-Fundraising-CiviCRM, fundraising-tech-ops: Permissions to git-update staging civi for select FR-creative members - https://phabricator.wikimedia.org/T232386 (Ejegg) [19:54:29] Wikimedia-Fundraising-Banners: Don't offer monthly suggestion when country doesn't support upsell - https://phabricator.wikimedia.org/T230944 (Pcoombe) Open→Resolved a:Pcoombe This is fixed in current best, I realised we could just re-use frb.shouldShowRecurring() from CoreJS. Cleaned them all up... [19:57:51] (PS1) Ejegg: Make PayTM available by default for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535276 (https://phabricator.wikimedia.org/T230170) [20:02:14] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: MinFraud Anomolies - https://phabricator.wikimedia.org/T232385 (DStrine) [20:04:18] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Improve state component's munging of new data added for Campaign Fallback - https://phabricator.wikimedia.org/T232235 (DStrine) [20:04:32] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2019-20-cleanup-list: Add index to created_date & index_date for civicrm_contact - https://phabricator.wikimedia.org/T232036 (Eileenmcnaughton) [20:06:44] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list: Turn off failmail for silverpop timeouts. - https://phabricator.wikimedia.org/T226747 (XenoRyet) [20:08:40] Fundraising-Backlog: Investigate new adyen 3DS version the second it's available - https://phabricator.wikimedia.org/T228340 (DStrine) Open→Declined [20:09:14] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2019-20-cleanup-list: Look at deleting old merged contacts - https://phabricator.wikimedia.org/T226447 (DStrine) [20:11:12] Fundraising-Backlog, FR-Ingenico, Documentation: Document ingenico credit card processing - https://phabricator.wikimedia.org/T114204 (DStrine) [20:21:52] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Document how to query CentralNotice data via Hive and Druid - https://phabricator.wikimedia.org/T217175 (AndyRussG) [20:25:18] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Geoip lookup - Misidentifying country due to travelling - https://phabricator.wikimedia.org/T175691 (AndyRussG) [20:34:17] Fundraising-Backlog: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (NNichols) [20:34:20] ejegg: do you have an opinion on whether I should create a custom table / field for mailing criteria data or use the mailing _stats table (which would mean a non-upstreamable change to it) [20:35:22] Fundraising-Backlog: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) That's odd - I could swear I included a fix for that in the code we put out - will check [20:36:51] Fundraising-Backlog: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) Ah dang - it's clashing with the targetsmart importer - I'll just disable that module since we finished the import [20:40:43] Fundraising-Backlog: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) Try again now - I can remove that code from our extension now [20:43:43] Fundraising-Backlog: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (NNichols) I've made it to the mapping screen!! I'll let you know if there are any other issues. You're the best! 🙌 [20:46:30] eileen: oh, breaking upstreamability would be a big downside [20:48:49] I guess a custom table is the way to go then. Are the mailing fields extensible via the normal custom field mechanisms? [20:55:27] (CR) Cstone: [C: +2] "Looks good in Firefox and Chrome." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [20:58:52] (Merged) jenkins-bot: Form labels via new variant mechanism [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/531766 (https://phabricator.wikimedia.org/T169795) (owner: Ejegg) [21:02:04] ejegg: yeah they should be extendable [21:02:07] (CR) Cstone: [C: +2] "Exciting!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535276 (https://phabricator.wikimedia.org/T230170) (owner: Ejegg) [21:02:11] it might not be UI exposed [21:03:21] cstone, eileen, our https URL problem is being caused by mediawiki parsercache, specifically a memcache cache holding the earlier version of the page prior to enabling the https role [21:03:35] I just disabled parser cache and the URLs are fixed [21:03:59] sorry wrong e..., ejegg * [21:04:29] (Merged) jenkins-bot: Make PayTM available by default for India [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535276 (https://phabricator.wikimedia.org/T230170) (owner: Ejegg) [21:06:43] setting $wgEnableParserCache=false; should fix it on fundraising/1_31 but that's not the fix for >=1.33 https://www.mediawiki.org/wiki/Manual:$wgEnableParserCache [21:08:07] jgleeson: ooh [21:08:18] nice find [21:08:36] hmm I'm getting some errors with the amazon js now [21:08:48] what kind of errors? [21:08:50] login1.js:44 Uncaught TypeError: Cannot read property 'match' of null [21:08:50] at Object.t.K (login1.js:44) [21:08:50] at Object.window.amazon.Login.setClientId (login1.js:58) [21:08:50] at window.onAmazonLoginReady (:15:133) [21:08:51] at login1.js:59 [21:08:53] at login1.js:61 [21:08:55] t.K @ login1.js:44 [21:08:57] window.amazon.Login.setClientId @ login1.js:58 [21:08:59] window.onAmazonLoginReady @ VM90:15 [21:09:01] (anonymous) @ login1.js:59 [21:09:03] (anonymous) @ login1.js:61 [21:09:05] feels like it can't login? [21:09:13] ok, let me see [21:10:11] cstone, I wonder is disabling the role and reenabling and provisioning might fix it? [21:10:40] if* [21:10:55] after changing the parsercache setting? [21:11:00] jgleeson can you tell if it's trying to call that onAmazonLoginReady with null or something? [21:11:12] no sorry, to make your https://... urls load [21:11:59] jgleeson: and can you tell if the wgAmazonGatewayClientID config value is getting passed to the client-side? [21:13:10] jgleeson you can try this in the console: [21:13:11] mw.config.get('wgAmazonGatewayClientID'); [21:13:12] oh it looks like I don't have the payments-wiki-test credentials locally [21:13:19] ahh, that'll do it [21:13:19] I thought I'd added those, sorry! [21:13:31] will grab them [21:14:30] cstone, the parser cache fix is a step after the https urls load. sorry for the confusing replies! [21:14:48] my retry suggestion was to fix your ERR_CONNEC... issue [21:14:52] no worries thanks for the clarification [21:15:03] yeah i tried that earlier and it did the same thing [21:15:42] i just have it turned off for now [21:16:34] ah ok [21:16:56] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: MinFraud Anomolies - https://phabricator.wikimedia.org/T232385 (MBeat33) Those are great points about the applicability of AVS and CVV in Japan, @EMartin Re: Minfraud, one thing I think I heard @Cstone say was that sometimes Minfr... [21:17:06] ejegg, after dropping those details in and loading the amazon donation form I got redirected to amazon.com [21:19:44] should I login with my sellercentral account or my personal amazon? [21:23:15] jgleeson did you already use the test account credentials? I got that far when trying to test it originally [21:24:32] cstone, do you mean credentials in the code that the integration uses or credentials we use to login to amazon? [21:25:02] there are login amazon test credentials that ejegg added on friday when we were trying to test [21:25:15] ahhh in the commit message [21:25:22] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Fr-backlog-cleanup-Q3_2017-18: Add "mobile" to list of phone type options on a contact record - https://phabricator.wikimedia.org/T89017 (Eileenmcnaughton) Open→Resolved a:Eileenmcnaughton CHecked with MG & ok to close now as ... changed [21:25:59] I remember ejegg saying something about details in a commit message I think [21:26:03] fake donor credentials [21:26:23] they're in a // comment in the 20-DI-Accounts.php file [21:26:35] right above the settings [21:26:48] but it's easiest to find them via git log -p [21:27:37] worked [21:27:44] thanks [21:27:59] * jgleeson wonders where I got commit message from @_@ [21:29:26] @_@ is an underrated smiley I should use it more [21:30:46] :) [21:31:37] ejegg, I see the change! although when I click donate I get an error [21:32:01] oh? can you tell what the error is? [21:32:09] Let me try locally... [21:32:41] hmm, it seems to be working for me [21:33:05] I wonder if there's anything more we need to configure in the amazon pay dashboard [21:33:05] I'll do one better [21:33:07] I'll show you [21:33:08] ! [21:33:23] heh, i'm in another meeting right now, unfortunately [21:33:42] https://phabricator.wikimedia.org/F30284633 [21:33:50] sorry I meant via capture [21:34:04] oh nice [21:34:25] hmm, anything in syslog? [21:39:46] Fundraising-Backlog, Unplanned-Sprint-Work: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) [21:40:02] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Unplanned-Sprint-Work: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) [21:40:21] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Unplanned-Sprint-Work: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) Ok to close? [21:47:09] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: MinFraud Anomolies - https://phabricator.wikimedia.org/T232385 (Cstone) They were down once due to Clouflare being down but that was a one time thing this summer. [21:50:52] (CR) Jgleeson: [C: +2] "Works as expected for me. Pushed through a successful donation once all the right credentials and smashpig config were in place." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/534858 (owner: Ejegg) [21:51:52] thanks jgleeson ! [21:51:56] np [21:52:04] that parse cache was a really curve ball [21:52:12] real* [21:52:49] not sure if that can be fixed as I'm guessing it wasn't designed to work with vagrants funny port usage [21:53:10] ah well [21:53:15] goodnight fr-tech! [22:03:50] (Merged) jenkins-bot: Fix Amazon widget position [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/534858 (owner: Ejegg) [22:10:46] fundraising-tech-ops: Access to the ssh frdev1001 server - https://phabricator.wikimedia.org/T232401 (RLewis) [22:19:06] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535303 [22:19:12] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535303 (owner: Ejegg) [22:20:03] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535303 (owner: Ejegg) [22:20:39] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535304 [22:20:43] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535304 (owner: Ejegg) [22:26:17] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535304 (owner: Ejegg) [22:26:41] ok fr-tech, I'm going to try a payments deploy [22:26:49] fingers crossed [22:28:59] !log updated payments-wiki from 51d9ed79b6 to 15baf7f58b [22:29:00] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:33:44] looking good so far [22:34:02] (after a force-reload with ctrl-f5) [22:41:54] (CR) Ejegg: "OK pcoombe, this is now up on staging for test. You should be able to test the endowment-specific email with the 'financial type' dropdown" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [22:46:22] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (Ejegg) OK, this is up on production as a variant for Ingenico. Tr... [22:47:00] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10): Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (Ejegg) OK, this is turned back on by default on India bank transfer forms [22:49:19] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Enable Visa, Mastercard, Amex, and JCB for Adyen in Ireland - https://phabricator.wikimedia.org/T230621 (Ejegg) OK, this is available on production: https://payments.wikimedia.org/index.php?title=Special:AdyenGateway&appeal=JimmyQu... [22:55:21] ok, i'm heading out but I'll keep an eye on IRC and email [23:04:59] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Unplanned-Sprint-Work: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (NNichols) yes! thank you [23:10:57] Fundraising-Backlog: Weird things happening in a donor record - https://phabricator.wikimedia.org/T232416 (NNichols) [23:19:44] Fundraising-Backlog: Weird things happening in a donor record - https://phabricator.wikimedia.org/T232416 (NNichols) This is a user issue. Not sure how to delete this! Please disregard [23:24:25] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (Volker_E) Looks good to me! [23:24:37] Fundraising-Backlog: Weird things happening in a donor record - https://phabricator.wikimedia.org/T232416 (XenoRyet) Setting task to invalid based on the above comment. @NNichols if you have task edit authority, that's about as close to deleting it as phab gets. [23:24:50] Fundraising-Backlog: Weird things happening in a donor record - https://phabricator.wikimedia.org/T232416 (XenoRyet) Open→Invalid [23:43:53] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535304 (owner: Ejegg) [23:44:51] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Enable Visa, Mastercard, Amex, and JCB for Adyen in Ireland - https://phabricator.wikimedia.org/T230621 (EMartin) Looks good! Just tried it and works for Ireland. Many thanks [23:57:27] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10): Add PayTM to Dlocal India form - https://phabricator.wikimedia.org/T230170 (EMartin) Awesome! Thank you.