[00:08:40] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Unplanned-Sprint-Work: Unable to import contacts - https://phabricator.wikimedia.org/T232391 (Eileenmcnaughton) Open→Resolved [00:29:49] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535304 (owner: Ejegg) [01:02:33] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (scervantes) Perfect @Ejegg, thank you for working on this! [01:14:21] (CR) Krinkle: [C: +1] Have wgNoticeProjects default to [] [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/534469 (https://phabricator.wikimedia.org/T208694) (owner: Jforrester) [02:43:30] (CR) AndyRussG: "Hey... I'm about to send this and other accumulated stuff in the master branch on this week's deploy train... So maybe this cherry-pick is" [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/534469 (https://phabricator.wikimedia.org/T208694) (owner: Jforrester) [02:49:52] (CR) Krinkle: [C: +1] "This week seems fine. Thanks for the pull-through." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/534469 (https://phabricator.wikimedia.org/T208694) (owner: Jforrester) [03:19:47] ok if anyone is around I need motivation thoughts. Struggling to stay working on things I'm not enjoying [03:31:01] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Values in translatable message fields in banner editor forms may be wrong - https://phabricator.wikimedia.org/T232430 (AndyRussG) [03:32:45] (PS1) Eileen: Revert "Remove largest_donation_date from calcs" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535343 (https://phabricator.wikimedia.org/T229273) [03:38:34] (PS1) AndyRussG: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/535344 [03:39:59] eileen: you can do it! [03:40:18] thanks AndyRussG - it's just like a fight with your own brain sometimes [03:40:31] eileen: heh my brain and I know the feeling for sure! [03:40:46] yesterday was a case in point, fixing code that felt like finding a needle in a septic tank [03:41:06] yeah & you kind of drift off & before you know you are starting over. [03:41:31] (CR) AndyRussG: [C: +2] Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/535344 (owner: AndyRussG) [03:42:01] (CR) AndyRussG: [C: -1] "Ok thanks!! See I2fd2fcee2d." [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/534469 (https://phabricator.wikimedia.org/T208694) (owner: Jforrester) [03:42:03] I'm trying to run some performance comparisons & if I don't keep the caches warm it invalidates them - which happens when I drift off [03:47:08] (Merged) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/535344 (owner: AndyRussG) [03:58:23] (CR) jenkins-bot: Merge branch 'master' into wmf_deploy [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/535344 (owner: AndyRussG) [06:06:46] Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, and 4 others: Bug: Trigger caused db locks - https://phabricator.wikimedia.org/T229273 (Eileenmcnaughton) We have discussed turni... [07:11:57] (CR) Vedmaka Wakalaka: "I have replaced the `while` loop with a simple `for` and introduced a `wgCentralNoticeMaxIterations` configuration setting to control max " [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [08:10:13] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/535444 (owner: L10n-bot) [08:12:32] (PS6) Eileen: Add finally-working attempt to log into Silverpop & get the query html [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534736 (https://phabricator.wikimedia.org/T230509) [08:12:34] (PS6) Eileen: Retrieve criteria on Mailing.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/534993 (https://phabricator.wikimedia.org/T230509) [08:12:36] (PS1) Eileen: Run civix update to update generated code [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535512 [08:12:38] (PS1) Eileen: Add storage for silverpop data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535513 (https://phabricator.wikimedia.org/T230509) [08:18:55] (CR) jerkins-bot: [V: -1] Add storage for silverpop data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535513 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [08:25:25] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (schoenbaechler) Wow! Great to see how the payment form evolves @E... [08:28:31] (PS2) Eileen: Add storage for silverpop data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535513 (https://phabricator.wikimedia.org/T230509) [12:53:45] Hey AndyRussG, what was your IRC setup again? I'm gonna update mine [12:54:46] jgleeson hi! So you need a VPS [12:54:58] fr-tech, is https://gerrit.wikimedia.org/ not loading for anyone else? [12:55:07] AndyRussG, check! [12:55:14] Doesn't need much power or anything [12:55:41] On the VPS you need weechat, tmux [12:55:57] and also a ssl cert [12:56:30] Thought it can be self-signed, though a normal valid one is better [12:56:51] So just ssh into your VPD [12:57:00] VPS I mean [12:57:26] Open a tmux session [12:57:38] Run weechat there [12:57:55] In weechat set up the relay extension [12:58:42] open the network connections for the port you choose for the relay [12:59:06] Then you can connect via Web with Glowing Bear [13:00:02] And detach from the tmux session and close your ssh connection to the VPS while leaving weechat running! [13:00:12] ta-ta!!! [13:00:50] IRC setup with no hard Brexit! [13:01:05] lol [13:01:07] nice [13:01:26] thanks for the detailed instructions, I'll give it a go now! :) [14:37:59] (PS1) Ejegg: Forms CSS: less scroll, minor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535614 [14:42:13] (CR) Awight: "Minor comments, looks great!" (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [15:03:12] jgleeson: have fun! mmm there are plenty of details I glossed over, I guess check the doc for the weechat relay plugin/script/thingy, and also some tmux doc maybe [15:05:55] hey AndyRussG, I got sidetracked speaking to my ISP as it's been dropping out for the last few hours. Back on now though and just launched the google cloud micro instance and checking out their web ssh client [15:07:14] jgleeson: ah yeah they have some silly in-browser console you're supposed to use to set up access... Then after that you can use a normal ssh client from the command line, IIRC [15:22:40] (CR) AndyRussG: Campaign fallback (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [15:43:20] (PS2) Ejegg: Forms CSS: less scroll, minor cleanup [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535614 [15:52:49] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Jgreen) a:Dwisehaupt @jrobell sorry, I didn't manage to get started on this earlier! We're going to have Dallas handle the account setup so he can... [15:56:25] (PS4) Ejegg: Cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) [15:57:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, MinervaNeue, Accessibility, Readers-Web-Backlog (Design): Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (alexhollender) @Volker_E not sure what we're doing with this task.... [16:02:54] fundraising-tech-ops: Issue new SSL Client Certificate for ccarter - https://phabricator.wikimedia.org/T232138 (Dwisehaupt) Certificate and password provided to ccarter. Awaiting confirmation that he has installed it successfully. [16:26:01] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) Request sent for authorization of access to: civicrm, civicrm database, and dev/staging shell access. [16:40:49] (PS5) Ejegg: Cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) [16:41:47] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) Date: Tue, 10 Sep 2019 09:30:23 -0700 From: Lisa Gruwell To: Dallas Wisehaupt Cc: Jessica Robell Subject: Re: Requesting authorization of... [16:52:15] (Abandoned) Jforrester: Have wgNoticeProjects default to [] [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/534469 (https://phabricator.wikimedia.org/T208694) (owner: Jforrester) [16:54:41] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (Ejegg) Good question @schoenbaechler ! I assume we're going to ru... [16:54:59] Fundraising-Backlog: 500 error when testing Endowment thank you emails in Civi - https://phabricator.wikimedia.org/T232504 (Pcoombe) [17:02:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review, User-MacFan4000: wgNoticeProjects should not default to wikimedia projects - https://phabricator.wikimedia.org/T208694 (Jdforrester-WMF) Open→Resolved a:Jdforrester-WMF Done in master, in production, and in REL... [17:06:12] fundraising-tech-ops: Issue new SSL Client Certificate for jcuriel - https://phabricator.wikimedia.org/T232139 (Dwisehaupt) Confirmed with Jonathan that the cert install worked and he is using the new cert. [17:19:08] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (Pcoombe) >>! In T169795#5479952, @Ejegg wrote: > Good question @s... [17:35:37] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: GB credit card form - Postal code field wraps to next line - https://phabricator.wikimedia.org/T232507 (Pcoombe) [17:37:55] ^ Sorry to be the bearer of more bugs today. I'll poke around in the browser devtools to see if I can figure out what's happening there [17:39:19] (PS1) XenoRyet: Center payment icons for mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535653 [17:40:44] (PS2) XenoRyet: Center payment icons for mobile [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535653 [17:43:51] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising, and 3 others: Labels for payments form fields - https://phabricator.wikimedia.org/T169795 (Pcoombe) Ooh, I notice this label variant fixes {T169797} too! [17:46:51] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Inconsistent order of payment field errors - https://phabricator.wikimedia.org/T169797 (Ejegg) a:Ejegg [18:06:43] thanks for testing the form pcoombe! I'll take a look at that postal code [18:07:24] It might have to do with some slight amount of whitespace in the HTML between the two elements [18:08:12] hmm, yeah, I think I need to get rid of that newline [18:10:31] Fundraising-Backlog: 500 error when testing Endowment thank you emails in Civi - https://phabricator.wikimedia.org/T232504 (Ejegg) Seems to die around line 587 of thank_you.module: ` lang=php $civi_mailing = $civimail_store->getMailing('thank_you', $template_info->name, $template_info->revision); ` So the t... [18:17:41] ah yeah, I think that can fix it [18:20:26] (PS1) Ejegg: Trim trailing spaces from mustache partials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535662 (https://phabricator.wikimedia.org/T232507) [18:20:59] fr-tech what do you think of that ^^^ as a solution for the wrapping GB form fields? [18:21:40] Seems to work, but do you think we should respect trailing spaces? [18:21:51] Maybe just trim_end? [18:21:55] and maybe just newlines? [18:22:12] err, rtrim, that is [18:23:29] (PS2) Ejegg: Trim trailing newlines from mustache partials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535662 (https://phabricator.wikimedia.org/T232507) [18:23:45] ok, i convinced myself. Still seems to get the fields to stop wrapping [18:24:55] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, Patch-For-Review: GB credit card form - Postal code field wraps to next line - https://phabricator.wikimedia.org/T232507 (Ejegg) p:Triage→High a:Ejegg [18:32:45] weechat is groovy [18:34:21] (CR) XenoRyet: [C: +2] "Yea, works fine, and I think rtriming the newlines is the better approach." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535662 (https://phabricator.wikimedia.org/T232507) (owner: Ejegg) [18:40:13] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: MinFraud Anomolies - https://phabricator.wikimedia.org/T232385 (XenoRyet) a:XenoRyet [19:02:42] (Merged) jenkins-bot: Trim trailing newlines from mustache partials [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/535662 (https://phabricator.wikimedia.org/T232507) (owner: Ejegg) [19:20:31] AndyRussG: thanks for all the detailed info earlier. I managed to get weechat running through tmux on a micro vps and have now ported over my settings to there! [19:34:19] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535680 [19:34:36] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535680 (owner: Ejegg) [19:37:51] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Enable Visa, Mastercard, Amex, and JCB for Adyen in Ireland - https://phabricator.wikimedia.org/T230621 (XenoRyet) Open→Resolved [19:40:41] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: 500 error when testing Endowment thank you emails in Civi - https://phabricator.wikimedia.org/T232504 (DStrine) [19:53:21] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (Eileenm... [19:53:44] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (DStrine) [19:59:08] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/535680 (owner: Ejegg) [20:02:27] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535689 [20:02:35] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535689 (owner: Ejegg) [20:10:49] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535689 (owner: Ejegg) [20:12:50] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (KHaggar... [20:13:56] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (Eileenm... [20:20:06] Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: ask 'force merge' script to prefer most recent contrib data - https://phabricator.wikimedia.org/T232152 (MBeat33) @NNichols depending on what we cover in tomorrow's meeting with Sandra, I may close this task. Seems like the Deduper interface, older dedupe... [20:23:00] fundraising-tech-ops: dissolve frack unix group cps_data and related bits - https://phabricator.wikimedia.org/T232529 (Jgreen) [20:28:46] fundraising-tech-ops: dissolve frack unix group cps_data and related bits - https://phabricator.wikimedia.org/T232529 (Jgreen) Open→Invalid [20:35:58] Fundraising-Backlog, FR-Civi-Dedupe: Civi: restore search settings to pre-September update - https://phabricator.wikimedia.org/T232532 (MBeat33) [20:39:22] Fundraising-Backlog, FR-Civi-Dedupe: Civi: restore Force Merge to pre-September update - https://phabricator.wikimedia.org/T232533 (MBeat33) [20:43:44] Fundraising-Backlog, FR-Civi-Dedupe: Civi: restore Find Matches using Fishing Net to pre-September update - https://phabricator.wikimedia.org/T232534 (MBeat33) [20:46:33] !log updated payments-wiki from 15baf7f58b to 5432f9c3a4 [20:46:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:47:50] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-DonationInterface, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): GB credit card form - Postal code field wraps to next line - https://phabricator.wikimedia.org/T232507 (Ejegg) Open→Resolved OK, depl... [21:14:27] Fundraising-Backlog, fundraising-tech-ops, FR-Q2-FY2019-20-cleanup-list: Create read-only user for civicrm devdb on staging - https://phabricator.wikimedia.org/T212745 (Jgreen) I created user dev_civicrm_read with select & create temporary tables on the dev_civicrm database. I'm not sure where this w... [21:33:18] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, FR-Civi-Dedupe: Civi: restore Force Merge to pre-September update - https://phabricator.wikimedia.org/T232533 (DStrine) [21:41:35] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) Unix user created, added to the fundraising group and config pushed. [21:44:29] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535689 (owner: Ejegg) [21:51:14] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) [frack::puppet] ce660567 Adding new user jkumalah [21:53:33] fr-tech sorry, i'll be 5-10 min late to tech talk [21:53:49] (Abandoned) Cstone: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/522179 (owner: Cstone) [21:53:57] ejegg: okok [21:58:20] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, FR-Civi-Dedupe: Civi: restore Force Merge to pre-September update - https://phabricator.wikimedia.org/T232533 (Eileenmcnaughton) a:Eileenmcnaughton [21:59:08] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql access for jkumalah - https://phabricator.wikimedia.org/T232543 (Dwisehaupt) [22:46:22] (PS1) Eileen: Add a little extra info to help out devs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535726 [22:48:36] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Add new TOS text to India forms - https://phabricator.wikimedia.org/T231886 (EMartin) Here's the new Legal language for the India Payments Page (highlights to show the new text): We do not sell or trade your information to anyone.... [22:53:10] (PS2) Eileen: Add a little extra info to help out devs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535726 [22:54:18] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/535689 (owner: Ejegg) [22:59:45] (PS4) Eileen: Reformat sql to use group by & eliminate the order by [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528307 (https://phabricator.wikimedia.org/T229273) [23:00:21] (PS5) Ejegg: Reformat sql to use group by & eliminate the order by [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528307 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:01:04] (CR) Ejegg: [C: +2] Reformat sql to use group by & eliminate the order by [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528307 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:05:52] (Merged) jenkins-bot: Reformat sql to use group by & eliminate the order by [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528307 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:13:32] (PS1) Eileen: Pass search limit through to getDuplicatePairs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535734 (https://phabricator.wikimedia.org/T232533) [23:14:08] If anyone can review this https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/535734/ it's just a one-word patch [23:18:45] (CR) Ejegg: [C: +2] Pass search limit through to getDuplicatePairs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535734 (https://phabricator.wikimedia.org/T232533) (owner: Eileen) [23:23:16] also trivial but no priority - just reflects a little brain pain I had https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/535726/ [23:23:40] Fundraising-Backlog: India Banner legal language - https://phabricator.wikimedia.org/T232552 (EMartin) [23:23:51] :) looks handy [23:25:05] (Merged) jenkins-bot: Pass search limit through to getDuplicatePairs [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/535734 (https://phabricator.wikimedia.org/T232533) (owner: Eileen) [23:25:31] ejegg: it's brain-kind [23:26:32] oh phooey, can't auto-rebase the largest donation date patch [23:28:17] ah, cause of the min/max edit [23:28:21] (PS1) Eileen: CiviCRM Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535736 [23:28:30] easy enough to do manually [23:28:53] (CR) Eileen: [C: +2] CiviCRM Submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535736 (owner: Eileen) [23:29:01] (PS3) Ejegg: re-add date of largest contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528310 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:29:21] (CR) Ejegg: "PS3: manual rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528310 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:31:48] (CR) Ejegg: [C: +2] re-add date of largest contribution [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/528310 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [23:34:45] ejegg: great - I'll deploy now & then generate one more patch with the trigger code [23:34:52] cool! [23:38:49] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/535737 [23:38:55] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/535737 (owner: Eileen) [23:41:05] (PS6) Ejegg: Cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) [23:44:00] !log civicrm revision changed from 516eeb54b5 to 68621b2100, config revision is 37534f025e [23:44:18] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, FR-Civi-Dedupe, Patch-For-Review: Civi: restore Force Merge to pre-September update - https://phabricator.wikimedia.org/T232533 (Eileenmcnaughton) @MBeat33 I just pushed out a patch for this [23:46:40] see you later! [23:50:09] (PS1) Eileen: Add copies of trigger mysql before & after today's change [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535741 (https://phabricator.wikimedia.org/T229273)