[00:25:58] Fundraising-Backlog, fundraising-tech-ops: Page fr-tech about spikes in frtechmail - https://phabricator.wikimedia.org/T202419 (Aklapper) a:cwdent→None [02:15:42] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused... - https://phabricator.wikimedia.org/T210101 [02:46:21] (CR) AndyRussG: "Thanks for working on this!!! :)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [02:53:46] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Review incoming patches (2019-09 and later) - https://phabricator.wikimedia.org/T232964 (AndyRussG) [02:54:25] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 4 others: CentralNotice: Review incoming patches 2019-06 and 2019-07 - https://phabricator.wikimedia.org/T226655 (AndyRussG) Open→Resolved Clo... [05:06:30] Fundraising-Backlog: Create FRUEC process-control job - https://phabricator.wikimedia.org/T232968 (AndyRussG) [05:39:10] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Turn off LandingPage events from testwiki - https://phabricator.wikimedia.org/T203020 (AndyRussG) [05:40:26] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Turn off LandingPage events from testwiki - https://phabricator.wikimedia.org/T203020 (AndyRussG) Reminder: For config changes on the main production wikis, please do not +2 (unless you are deploying). Thanks much!! [05:41:51] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Create FRUEC process-control job - https://phabricator.wikimedia.org/T232968 (AndyRussG) [05:42:02] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Create FRUEC process-control job - https://phabricator.wikimedia.org/T232968 (AndyRussG) a:AndyRussG [07:35:28] (CR) Awight: Drop unused columns (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [07:37:49] (PS8) Awight: Drop unused columns and tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [07:39:29] (CR) jerkins-bot: [V: -1] Drop unused columns and tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [08:01:49] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/536853 (owner: L10n-bot) [08:22:54] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/536846 (owner: L10n-bot) [08:30:56] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/536853 (owner: L10n-bot) [08:37:32] (PS9) Awight: Drop unused columns and tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [08:40:37] Fundraising-Backlog: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (jrobell) [08:44:25] (PS10) Awight: Drop unused columns and tables [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/78172 (owner: Mwalker) [08:52:37] Fundraising Sprint Window dressing is mostly olive oil, Fundraising Sprint XML ate my homework, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Consider not displaying protection log entries in RecentChanges caused... - https://phabricator.wikimedia.org/T210101 [09:22:29] Fundraising-Backlog: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Peachey88) [09:54:40] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Peachey88) [15:27:18] (CR) Ejegg: [C: -1] "Looks pretty good! Some suggestions inline." (6 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [15:32:53] Thanks ejegg ! [15:35:34] sure thing cstone. I totally could have done that earlier... [15:35:45] what do you think of the 'template' param to thank_you_send? [15:37:16] yeah that makes a lot more sense [15:38:08] cool [15:42:17] fr-tech, I need to take care of some house related stuff so I'm gonna be afk for a while. Be be later! [16:39:26] (PS1) Ejegg: Update composer dependencies [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/537146 [16:39:33] (CR) Ejegg: [C: +2] Update composer dependencies [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/537146 (owner: Ejegg) [16:40:17] (Merged) jenkins-bot: Update composer dependencies [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/537146 (owner: Ejegg) [16:43:23] (PS1) Ejegg: Update composer dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/537148 [16:43:32] (CR) Ejegg: [C: +2] Update composer dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/537148 (owner: Ejegg) [17:04:38] (CR) Ejegg: [V: +2 C: +2] Update composer dependencies [wikimedia/fundraising/SmashPig/vendor] - https://gerrit.wikimedia.org/r/537148 (owner: Ejegg) [17:06:28] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537155 [17:06:33] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537155 (owner: Ejegg) [17:06:56] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537155 (owner: Ejegg) [17:10:00] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Center payment icons on payments page for user view - https://phabricator.wikimedia.org/T231391 (XenoRyet) @EMartin This change is deployed and live now. Take a look and let me know what you think. [17:49:21] !log updated SmashPig standalone from 5d187092a7 to a0151434f4 [17:49:23] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:53:12] Fundraising-Backlog: Create employer typeahead field with HEP data - https://phabricator.wikimedia.org/T233038 (DStrine) [18:25:02] (PS1) Cstone: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 [18:39:57] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for eileen - https://phabricator.wikimedia.org/T232645 (Dwisehaupt) Open→Resolved [18:55:55] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) Sent on an email about using the ssh-agent and keychain functionality on MacOS to cut down on repetitive entries of the ssh key passphrase. [18:57:46] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T233043 (Dwisehaupt) [19:04:49] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Email: As a developer, I want to be able to change the timeout for the Silverpop Api in the config - https://phabricator.wikimedia.org/T182795 (Ejegg) Pull request for first bit merged: https://github.com/mrmarkfrench/silverpop-php-connector/pull/29 [19:28:41] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T233043 (Dwisehaupt) Coordinated time with rlewis when they are available to attempt and install. Will generate the certificate before then and send out the SMS. [20:01:31] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (LeanneS) @Eileenmcnaughton Awesome thanks so much!! [20:12:27] (CR) Ejegg: [C: -1] "Let's keep financial_type out of thank_you_send_mail and just calculate the template in thank_you_for_contribution" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 (owner: Cstone) [20:46:52] AndyRussG: do you want to paste the link to the gerrit change for default config file name? [20:52:02] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, Patch-For-Review: Create new error page for payment cancel, restyle Ingencio hosted cancel button - https://phabricator.wikimedia.org/T224063 (Ejegg) Note to reviewers: I left the... [21:30:44] (PS1) AndyRussG: Make default config ./fruec.yaml and /etc/fruec.yaml [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/537212 [21:30:57] fr-tech ^ [21:31:10] ejegg: oh hey it looks like that repo already does ping us! [21:31:13] oh nice [21:31:26] maybe just by virtue of being under the fundraising dir? [21:31:33] I guess it probably goes by the wikimedia/fundraising prefix [21:31:38] yep yep [21:32:23] (CR) Ejegg: [C: +2] Make default config ./fruec.yaml and /etc/fruec.yaml [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/537212 (owner: AndyRussG) [21:32:28] looks good! [21:38:13] ejegg: thanks!!! [21:40:15] ejegg: fr-tech: I just pushed a new commit to add the fruec consume job to the process control repo on frpm1001 [21:40:31] Anyone who'd like to review that, that'd be great [21:40:55] Also, anyone who'd like to help me deploy the new updated FRUEC version and the new process control job, I'm around for that! :) thanks much in advance [21:46:38] (PS2) Cstone: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 [21:48:46] (PS3) Cstone: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 [21:50:49] thanks for the review on the above ejegg I was having issues getting all the email function relationships straight [21:53:56] ah yeah, it's a bit of a rat's nest in there [21:54:02] and all global fns... [21:58:35] cstone PS3 looks great, i just realized we need another thing in thank_you_send_test_form_submit to let us test the endowment template [21:59:06] we had added a 'financial type' dropdown. I guess we can change that to a 'template' dropdown [21:59:21] with 'thank_you' and 'endowment_thank_you' as choices [22:00:00] ok, so that dropdown is defined from lines 122 to 131 of the thank_you.module [22:00:12] you can get rid of the lookup for financial type values [22:00:33] change the element to 'template' and just use an inline array for the options [22:02:51] then in thank_you_send_test_form_submit you should be able to just pass it through [22:03:36] so then in the next patch when you add the recurring notification template it'll just be a matter of adding one more value to the inline 'options' array [22:08:02] cstone I'll copy this onto the gerrit change for posterity [22:10:43] (CR) Ejegg: [C: -1] "PS3 looks great! Just realized we need one more change to be able to test the different templates via the test form." (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 (owner: Cstone) [22:12:56] thanks ejegg! I was wondering if I should change that or if it would be doing too much [22:14:04] cstone without that change we don't have a way to test the endowment template, so I think it makes sense to do here [22:14:11] ok cool [22:40:11] Fundraising-Backlog: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) Hello @jrobell, As this is a request for a new user to have access, it will require authorization from Lisa. Have you sent the request along yet and gotte... [23:13:14] Fundraising Sprint Princess Mongodb, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice setting a surprising content security policy in production when using &banner= URL ... - https://phabricator.wikimedia.org/T225261 [23:17:30] Fundraising Sprint Princess Mongodb, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice setting a surprising content security policy in production when using &banner= URL ... - https://phabricator.wikimedia.org/T225261 [23:21:53] AndyRussG|bassoo: LMK when you're back if you want to deploy the fruec job [23:22:39] ejegg: I'd love to, thanks much... I'm here-ish--just gotta walk the wog but I could do that now or after walking the FRUEC [23:22:43] whichever u prefer [23:22:54] either's fine [23:24:09] ejegg: K lemmy walky wog then and we can Fruec in about 25 min, k? [23:25:08] aaargh sorry if that sounds awful [23:26:32] hahaha [23:26:44] have a good wog [23:29:50] or the wog is thinking, yay, I'll have a good human [23:29:59] as in, gonna walk my human, yay