[00:02:53] ejegg: hey! I can do the Fruec depoy anytime now [00:02:56] thanks again [00:03:37] ok, cool. pick a google meet room, any google meet room [00:04:32] let's say tomorrow's tech talk one? https://meet.google.com/pau-rggj-byc [00:06:42] ejegg: okok! :) [00:13:24] (CR) Ejegg: [V: +2 C: +2] Make default config ./fruec.yaml and /etc/fruec.yaml [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/537212 (owner: AndyRussG) [00:22:30] (PS1) AndyRussG: Make default config ./fruec.yaml and /etc/fruec.yaml [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/537228 [00:23:12] (CR) AndyRussG: [V: +2 C: +2] Make default config ./fruec.yaml and /etc/fruec.yaml [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/537228 (owner: AndyRussG) [00:34:28] !log updated fruec from fb29cb7407 to 97128874bf [00:34:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [00:38:38] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (DStrine) [06:25:13] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[php7.0-redis] [06:30:15] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 13 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[php7.0-redis] [06:35:13] RECOVERY - check_puppetrun on mintaka is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [07:12:19] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537286 (owner: L10n-bot) [07:13:32] hello - first checkin from Malaysia - have no idea what time it is for everyone right now [07:15:35] ah ok - middle of the night in PST - & Jack will be starting work soon [07:17:45] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537286 (owner: L10n-bot) [09:29:20] (PS1) Eileen: Code formatting only - new array syntax [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537343 [09:29:22] (PS1) Eileen: Add ability to turn omnihell on & off [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) [09:30:21] (CR) jerkins-bot: [V: -1] Add ability to turn omnihell on & off [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [09:35:36] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [09:46:21] (PS1) Eileen: Revive largest_donation_date test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537347 [09:46:53] (PS2) Eileen: Revive largest_donation_date test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537347 (https://phabricator.wikimedia.org/T229273) [14:15:22] PROBLEM - Host frbast1001 is DOWN: PING CRITICAL - Packet loss = 100% [14:20:26] RECOVERY - Host frbast1001 is UP: PING OK - Packet loss = 0%, RTA = 0.40 ms [14:42:34] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (jrobell) @Dwisehaupt I haven't reached out to Lisa yet, it may be helpful if you could send an email to her and cc me, like you did with Jerr... [14:59:41] fundraising-tech-ops: puppetize and configure fruec banner log parser/db injector script - https://phabricator.wikimedia.org/T231249 (AndyRussG) Hi! We were able to deploy this fine! :) (Thanks much to @Ejegg for the help with that.) > python-mysql.connector is puppet-installed So we tried to run FRUEC man... [15:00:52] (PS1) Jgleeson: Added review notes [wikimedia/fundraising/centralnotice_changes_monitor] - https://gerrit.wikimedia.org/r/537458 [15:03:55] (PS2) Jgleeson: Added review notes [wikimedia/fundraising/centralnotice_changes_monitor] - https://gerrit.wikimedia.org/r/537458 [15:23:56] (PS3) Jgleeson: Added review notes [wikimedia/fundraising/centralnotice_changes_monitor] - https://gerrit.wikimedia.org/r/537458 [15:40:22] (PS4) Cstone: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 [15:53:28] (PS4) Jgleeson: Added review notes [wikimedia/fundraising/centralnotice_changes_monitor] - https://gerrit.wikimedia.org/r/537458 [16:15:15] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql access for jkumalah - https://phabricator.wikimedia.org/T232543 (Dwisehaupt) I forwarded on some useful information for using the ssh-agent to help reduce repetative entries of the ssh-passphrase. [16:20:37] fr-tech anyone available to review the Cancel form task? would be nice to get that out this sprint [16:21:01] ejegg|away: I'm gonna jump on that as soon as I wrap up the OKR thing [16:21:07] and pick up Oscar [16:21:15] thanks jgleeson! [16:21:17] np [16:22:51] ejegg: I looked at it yesterday, code looks good, but I ran into some issues testing it with my local setup. I'll try to sort that out once I'm not in meetings. [16:30:28] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T233043 (Dwisehaupt) Revoked and generated the new client certificate. Cert was sent via email and password was sent via SMS. [16:30:41] AndyRussG: I pushed up my notes on the CNCM app here https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/centralnotice_changes_monitor/+/537458/. I think it might be helpful for me to talk through the 'Potential Bug' found with you to make sure I understand what the expected behaviour is. Also I didn't add actual code fixes as I felt like you might come up with better solutions to the [16:30:43] small bugs found? sorry if that's a lazy approach, I could add them in as patches if that helps! :) [16:44:58] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) Access request sent to Lisa. It was missing the subject line as my tea hasn't kicked in yet. :) [16:50:29] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) Request for yubikey sent to techsupport. [16:51:45] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T233043 (Dwisehaupt) Received response that the cert is all set up. [16:52:33] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) Open→Resolved [16:56:01] hi Jeff_Green! Any further thoughts on how we can allow pcoombe, tskaff, cdenis, and scervantes to test updates to Thank You email templates? [16:57:35] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for eileen - https://phabricator.wikimedia.org/T232645 (Dwisehaupt) p:Triage→Normal [16:58:32] ejegg: I haven't had a chance to work on that, sorry [17:00:05] ok [17:03:03] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for jcuriel - https://phabricator.wikimedia.org/T232139 (Dwisehaupt) p:Triage→Normal [17:03:15] (CR) XenoRyet: [C: +2] Tag txn_type cart and payment_type instant as EC [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/536723 (https://phabricator.wikimedia.org/T230956) (owner: Ejegg) [17:03:17] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for ccarter - https://phabricator.wikimedia.org/T232138 (Dwisehaupt) p:Triage→Normal [17:03:39] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (Dwisehaupt) p:Triage→Normal [17:03:48] (Merged) jenkins-bot: Tag txn_type cart and payment_type instant as EC [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/536723 (https://phabricator.wikimedia.org/T230956) (owner: Ejegg) [17:04:37] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for rlewis - https://phabricator.wikimedia.org/T233043 (Dwisehaupt) p:Triage→Normal [17:06:24] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frqueue2001 - https://phabricator.wikimedia.org/T232630 (Papaul) [17:07:05] (PS5) Ejegg: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 (owner: Cstone) [17:07:46] (CR) Ejegg: [C: +2] "Looks great, works locally with both templates" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 (owner: Cstone) [17:08:18] thanks ejegg! [17:09:21] :) [17:09:46] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537489 [17:09:54] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537489 (owner: Ejegg) [17:10:24] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/SmashPig] (deployment) - https://gerrit.wikimedia.org/r/537489 (owner: Ejegg) [17:13:19] (Merged) jenkins-bot: Create new $params['template'] to choose between thank you email templates. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537172 (owner: Cstone) [17:18:32] !log updated SmashPig payments listener from a0151434f4 to dc0c6b208b [17:18:34] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:27:38] Wikimedia-Fundraising, Wikimedia-Fundraising-Banners, Design: UX: display icons for accepted card types for each payment channel - https://phabricator.wikimedia.org/T58415 (Pcoombe) [17:31:38] (CR) XenoRyet: [C: +2] "Code looks good, does what it says, and both the form and the iframe look fine." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) (owner: Ejegg) [17:41:47] (PS2) Ejegg: Code formatting only - new array syntax [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537343 (owner: Eileen) [17:41:55] (CR) Ejegg: [C: +2] Code formatting only - new array syntax [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537343 (owner: Eileen) [17:42:44] (PS2) Ejegg: Add ability to turn omnihell on & off [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [17:42:48] (CR) Ejegg: [C: +2] Add ability to turn omnihell on & off [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [17:51:55] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) a:Dwisehaupt Key request has been responded to and yubikey will be shipped to Erin. [17:56:44] (Merged) jenkins-bot: Code formatting only - new array syntax [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537343 (owner: Eileen) [17:56:46] (Merged) jenkins-bot: Add ability to turn omnihell on & off [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537344 (https://phabricator.wikimedia.org/T230509) (owner: Eileen) [17:59:18] Fundraising-Backlog, fundraising-tech-ops: fundraising access request for Rosie Lewis - https://phabricator.wikimedia.org/T232632 (Dwisehaupt) a:Jgreen→Dwisehaupt Hello @RLewis, The two things we need to do at this point are to have you generate an ssh keypair and to get the public side of your... [18:12:28] (PS1) Ejegg: Add IE to Adyen form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537506 (https://phabricator.wikimedia.org/T230621) [18:12:43] git fr-tech anyone want to review that trivial bit? ^^^^ [18:13:13] (CR) Jgleeson: [C: +2] Add IE to Adyen form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537506 (https://phabricator.wikimedia.org/T230621) (owner: Ejegg) [18:13:45] just looking over cancel text for error form patch ejegg [18:14:16] is testing this with only ingenico good enough coverage ? [18:15:30] jgleeson: so far, I think we only get the cancel status back on a result switcher for ingenico [18:15:50] ah ok [18:16:25] DLocal gives us that ambiguous status [18:16:40] and I don't think Adyen has a cancel button in the iframe [18:17:01] Amazon is all in our form after the login, and we don't show a cancel button there [18:17:16] and then with PayPal we specify a URL for cancel [18:17:33] let's see what URL we're specifying now [18:18:15] I feel like we could specify the result switcher with a querystring parameter for PayPal cancel [18:18:53] and override the processDonorReturn fn in paypal's version of that page to look for that parameter and set the payment status to cancelled [18:19:58] ok, looks like when paypal donors cancel they go to https://donate.wikimedia.org/wiki/Ways_to_Give [18:23:58] dwisehaupt or Jeff_Green can you please kill the stalled astropay_download_nightly process on civi1001 again? [18:24:10] oh hey, there are two [18:24:22] 28381 and 28829 [18:25:49] done [18:26:51] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/537511 [18:26:55] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/537511 (owner: Ejegg) [18:26:58] I saw one of the lockfiles and removed it [18:27:34] thanks Jeff_Green [18:28:31] (Abandoned) Jgleeson: Update SmashPig recurring processor tests to use new invoice_id convention to closer reflect how it works in the real world [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/527179 (owner: Jgleeson) [18:32:51] huh, D-Local says their SFTP server is fixed now but the python job is still hanging on listdir [18:33:31] guessing it's not convenient to sftp locally to test [18:33:37] ip whitelist? [18:33:57] Jeff_Green: could you please try with the command-line sftp client? [18:33:58] maybe ssh tunnel? [18:34:14] ejegg: sure, one sec [18:34:20] jgleeson: network access from our cluster is locked down by user [18:34:37] oh I see [18:35:02] so we can't make outbound calls from frpm1001 and alike? [18:35:33] yah, only the users that are expected to need to make external connections [18:35:54] hrmf, I deleted the private key...backtracking [18:35:59] huh [18:36:41] Jeff_Green: ah, we needed to revert a change to the yaml file - those leading spaces turned out to be necessary [18:37:22] really? funky. that's not the case in the other ones [18:37:38] yeah, we were getting a yaml parse error otherwise [18:37:51] Jeff_Green: yeah. yaml indents are ... interesting. [18:38:36] fr-tech does anyone know a way to search across all wikimedia/fundraising projects on gerrit? I've tried '*' but can't seem to crack it [18:39:04] jgleeson: hmmmm what are you looking for? [18:39:09] jgleeson: also thanks for the review notes! [18:39:19] ejegg: remind me the remote path, is it /reports ? [18:39:33] AndyRussG: I wanna set up a shortcut so I can see all fundraising projects with patches open [18:41:02] Jeff_Green: yep, /reports [18:41:19] ok so i'm in /reports and it looks like it still stalls on 'ls' [18:41:27] thanks for writing such good stuff to review AndyRussG! I have a few questions about CN in general that would good to ask if we can find some time to talk through the review points or maybe another time if it distracts from the review! [18:41:36] Jeff_Green: ok, same as with the python library [18:41:46] thanks for checking! I'll report back to dlocal [18:43:31] I thought I might be able to look for gerrit patches with the reviewer=fundraising but it doesn't like you searching against groups [18:43:40] as a workaround [18:44:18] oh actually [18:44:23] ejegg: yammlint doesn't seem too offended by astropay-audit.yaml, it complains only about line length and the missing --- at the beginning [18:44:26] using the 'projects:' filter seems to work [18:44:38] ejegg: is that the file that's producing an error? [18:46:06] ejegg: actually yamllint errors for globalcollect-audit.yaml [18:47:19] OH you already fixed it, I missed that [18:47:38] * Jeff_Green wonders if we should fix the globalcollect one the same way [18:49:36] fr-tech, for anyone interested I think this link shows all open gerrit patches across all fundraising projects which need code review! https://gerrit.wikimedia.org/r/#/q/projects:wikimedia/fundraising+status:open [18:49:39] jgleeson: anytime is cool! [18:50:21] wikimedia/fundraising/LoveMap ??? [18:50:33] jgleeson: ah yeah that makes sense as a way to search [18:50:34] also ??? [18:50:55] Updated 4 years, 3 months ago [18:51:01] https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/LoveMap/+/137516/ [18:53:08] AndyRussG: I'm just gonna grab a snack and a drink, fancy catching up on the hour? [18:53:25] jgleeson: hummm I have no context on that other than the fact that a person mentioned in the code as an author no longer works here [18:53:59] 'An embeddable world map that highlights global stories of giving and love for the WMF' [18:54:08] kinda sounds cool [18:54:37] well hmmm [18:57:32] (Merged) jenkins-bot: Cancel text for error form [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/532395 (https://phabricator.wikimedia.org/T224063) (owner: Ejegg) [18:58:00] (Merged) jenkins-bot: Add IE to Adyen form settings [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537506 (https://phabricator.wikimedia.org/T230621) (owner: Ejegg) [19:02:14] AndyRussG: is now good for you? [19:02:51] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/537515 [19:02:55] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/537515 (owner: Ejegg) [19:03:44] Fundraising-Backlog: Turn on EventLogging from Donate Wiki at 100% - https://phabricator.wikimedia.org/T233145 (AndyRussG) [19:04:08] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Turn on EventLogging from Donate Wiki at 100% - https://phabricator.wikimedia.org/T233145 (AndyRussG) [19:04:15] oh hey, RMS resigned as president of the FSF [19:04:30] I guess enough members cancelled their memberships [19:04:35] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Turn on EventLogging from Donate Wiki at 100% - https://phabricator.wikimedia.org/T233145 (AndyRussG) [19:04:37] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [19:04:44] woah [19:05:15] oh damn [19:09:13] https://www.engadget.com/2019/09/17/rms-fsf-mit-epstein [19:10:00] yep... but that last email was really just the straw that made the bucket overflow [19:10:11] err, something like that [19:10:21] https://www.theregister.co.uk/2019/09/17/richard_stallman_interview/ [19:12:26] https://medium.com/@selamie/remove-richard-stallman-fec6ec210794 [19:14:06] to pick a point in isolation (and not by any means defend the other actions committed) is it fair to criticize someone for being paid to promote free software at a corporate event? I'm not sure [19:16:55] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Dlocal cancel buttons don't go back to the payments wiki form - https://phabricator.wikimedia.org/T229336 (EMartin) Resolved→Open [19:17:02] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 [19:18:08] I guess the fee could be donated to the cause [19:18:23] that would be a likely reasonable compromise [19:19:30] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/537515 (owner: Ejegg) [19:21:00] (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 (owner: Ejegg) [19:21:19] (CR) Ejegg: [C: +2] "recheck" [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 (owner: Ejegg) [19:25:30] PLOUTOS (Plutus) was the god of wealth. The young god was blinded by Zeus so he would distribute wealth indiscriminately and not favour the good. [19:27:00] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 (owner: Ejegg) [19:27:25] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 (owner: Ejegg) [19:32:17] !log updated payments-wiki from fc82318180 to adef0e858f [19:32:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:39:32] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Dlocal cancel buttons don't go back to the payments wiki form - https://phabricator.wikimedia.org/T229336 (DStrine) I see this got reopened. This doesn't seem actionable on our end any time soon. We could meet with them at some point but it's pret... [19:42:17] Fundraising Sprint Princess Mongodb, Fundraising-Backlog: Dlocal cancel buttons don't go back to the payments wiki form - https://phabricator.wikimedia.org/T229336 (EMartin) yes, before I let this go dormant, i wanted to know if we wanted to have a further conversation with them to find a work around for... [19:48:15] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24): Create new error page for payment cancel, restyle Ingencio hosted cancel button - https://phabricator.wikimedia.org/T224063 (Ejegg) O... [19:48:55] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Civi: small # of PayPal contribs listed twice - https://phabricator.wikimedia.org/T230956 (Ejegg) Open→Resolved [19:49:07] Fundraising Sprint Princess Mongodb, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, and 2 others: CentralNotice setting a surprising content security policy in production when using &banner= URL ... - https://phabricator.wikimedia.org/T225261 [19:49:14] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, FR-Email: Resolve timing issues with email export & IBM-side import - https://phabricator.wikimedia.org/T232009 (Ejegg) Open→Resolved p:Triage→High [19:51:17] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Center payment icons on payments page for user view - https://phabricator.wikimedia.org/T231391 (DStrine) Open→Resolved [19:54:00] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 4 others: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (DStrine) Open→Resolved [19:54:04] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 4 others: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (DStrine) Resolved→Open [19:54:42] Fundraising Sprint Men In Slack, Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, and 4 others: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (DStrine) Open→Resolved [20:00:27] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/537517 (owner: Ejegg) [20:02:00] Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Bug: donations below should include error message on up... - https://phabricator.wikimedia.org/T230501 [20:13:40] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Patch-For-Review: Turn on EventLogging from Donate Wiki at 100% - https://phabricator.wikimedia.org/T233145 (DStrine) [20:13:42] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog: Create FRUEC process-control job - https://phabricator.wikimedia.org/T232968 (DStrine) [20:13:45] Fundraising Sprint S 2019, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Tiny text change and release Campaign fallback - https://phabricator.wikimedia.org/T232859 (DStrine) [20:13:47] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog: 500 error when testing Endowment thank you emails in Civi - https://phabricator.wikimedia.org/T232504 (DStrine) [20:13:50] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (DStrine) [20:13:51] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Client-side event impression event logging is broken - https://phabricator.wikimedia.org/T231404 (DStrine) [20:13:55] Fundraising Sprint S 2019, Fundraising-Backlog, Wikimedia-Fundraising-Banners, FR-dlocal, Patch-For-Review: dLocal: on donation form, show Netbanking / UPI choice sooner in flow? - https://phabricator.wikimedia.org/T231452 (DStrine) [20:13:56] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Unusable emails addresses - https://phabricator.wikimedia.org/T231332 (DStrine) [20:13:58] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog: Data Exported from Civi contains spaces - https://phabricator.wikimedia.org/T231330 (DStrine) [20:14:00] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, and 2 others: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (DStrine) [20:14:03] Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog: Supporting FR-Creative to do more payments wiki work - https://phabricator.wikimedia.org/T228448 (DStrine) [20:14:04] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 4 others: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (DStrine) [20:14:06] Fundraising Sprint S 2019, Fundraising-Backlog, FR-Ingenico: Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (DStrine) [20:14:09] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, and 2 others: trigger a second email in recurring upsell to denote the recurring part - https://phabricator.wikimedia.org/T228162 (DStrine) [20:14:11] Fundraising Sprint S 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2019-20-cleanup-list: Civi: create annual $ summary TY email button - https://phabricator.wikimedia.org/T221271 (DStrine) [20:14:13] Fundraising Sprint S 2019, Fundraising-Backlog, FR-Paypal, FR-Q2-FY2019-20-cleanup-list: Paypal refunds missing predecessor - https://phabricator.wikimedia.org/T211847 (DStrine) [20:14:15] Fundraising Sprint S 2019, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (DStrine) [20:14:18] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Karma chameleons hide amongst us, Fundraising Sprint King Kong vs. Mozilla, and 22 others: New scripts to ingress data fro... - https://phabricator.wikimedia.org/T195594 [20:14:20] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, and 2 others: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (DStrine) [20:14:22] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, and 2 others: CentralNotice: Timeout when creating translation variables Translate Extension - https://phabricator.wikimedia.org/T231703 (DStrine) [20:14:25] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Epic: Test data for new scripts to ingress data from Kafkatee into MySQL - https://phabricator.wikimedia.org/T201623 (DStrine) [20:14:28] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint S 2019, Fundraising-Backlog, Analytics: Identify source of discrepancy between HUE query in Count of event.impression and druid queries v... - https://phabricator.wikimedia.org/T204396 [20:14:30] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Men In Slack, and 16 others: DB schemas (production changes and test DB) and SQL commands to ... - https://phabricator.wikimedia.org/T196564 [20:14:32] Fundraising Sprint Lactose is unusually tolerant, Fundraising Sprint Land before Timeouts, Fundraising Sprint Matt Damon to head up Space Force, Fundraising Sprint Men In Slack, and 16 others: Write a specification for mapping banner/landing page impression... - https://phabricator.wikimedia.org/T196563 [20:14:37] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, and 15 others: Queries and maybe scripts to verify equivalence of d... - https://phabricator.wikimedia.org/T198752 [20:17:34] Fundraising Sprint S 2019, Fundraising-Backlog, FR-Ingenico: Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (Ejegg) We're currently depending on this choice to tell Civi which type of credit card was used. When we take these buttons away we'll nee... [20:48:26] hey AndyRussG: let's catch up tomorrow when we're both online [20:48:30] bye for now! [20:52:56] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, and 2 others: Remove hacky EventLogging-duplicating code and use new lightweight EL facilities - https://phabricator.wikimedia.org/T214709 (AndyRu... [20:53:09] cstone: do you want to handle the civi deploy? [20:53:55] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: Turn off LandingPage events from testwiki - https://phabricator.wikimedia.org/T203020 (AndyRussG) [20:54:00] I'd like to deploy soon so we can turn off the attempted screen-scrapes that are all failing [20:54:07] ejegg sure was just gona get some food real quick [20:54:26] ok, bon apetit [20:57:11] dstrine: I added to the sprint a couple tasks that didn't roll over but should: https://phabricator.wikimedia.org/T203020 (needed to start getting good data for FRUEC) and https://phabricator.wikimedia.org/T214709 (on the train but the train stalled... we should be able to close it on Thursday... Thought I'd leave it in so we don't forget to do so) [20:57:14] hope that makes sense! [21:15:29] ejegg im back the plan would be to turn off the thank you mail job, deploy, then turn it back on and check them? [21:26:53] Jeff_Green dwisehaupt hi! just checking that u saw https://phabricator.wikimedia.org/T231249#5499484 [21:26:57] Many thanks in advance! [21:27:21] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1680 processes [21:29:26] AndyRussG: what's the library situation where you've been testing? [21:29:42] Jeff_Green: locally you mean? [21:29:55] The test mentioned in the comment was on civi1001 [21:30:09] Locally I just run pip to bring in the dependencies [21:30:15] ah [21:31:59] Pretty sure that just works with the setup.py [21:34:25] cstone: yeah! [21:34:39] sorry, was afk without indicating [21:34:47] no worries [21:36:15] cstone looks like there's no drush parameter for a TY batch limit, hence no slow start command [21:36:24] but you can set the batch size to 1 in the UI [21:36:48] Seddon: hi! [21:37:06] ok [21:37:12] https://meta.wikimedia.org/wiki/MediaWiki:Centralnotice-template-Community_insights_mediawiki lacks a "close" button, and people reports it's starting to be annoying [21:37:21] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 215 processes [21:37:34] hauskatze: oh hey, i noticed that myself earlier today [21:37:44] Seddon: are you still around? [21:37:54] ejegg: I come here from -tech [21:38:05] I set a diet of 2 views per user and day for now [21:38:11] so mitigate a bit the spam [21:38:16] *to [21:38:35] ah, ok. Let's see who made the original banner [21:38:45] and if they're fine with adding the close button [21:38:48] Since I hide banners I didn't noticed myself :) [21:38:54] ejegg: trizek [21:39:30] that's not someone I'm familiar with - do you suppose they're on IRC someplace? [21:40:38] ejegg: https://phabricator.wikimedia.org/p/Trizek-WMF/ [21:40:38] Yup, as Trizek on -tech, -operations, etc. [21:40:47] and as AndyRussG says [21:40:49] :) [21:40:59] I hope the diet helps a bit [21:41:06] got to go now [21:41:13] hauskatze: thanks! [21:41:17] thanks hauskatze [21:41:24] At your service [21:41:34] I just wonder what kind of data they may need, and if adding a a close button without warning might mess up some aspect of campaign data? [21:42:34] I don't think you can force people to see a banner anyways [21:42:41] Bad practice IMHO [21:43:41] Plus no request on meta, entry in the Calendar, etc. [21:44:09] I commented on https://phabricator.wikimedia.org/T232643 asking for a close button [21:44:58] AndyRussG: what's the exact error when you try to run fruec? [21:45:52] !log civicrm revision changed from 45dbfdb96f to 90db6cb5a1 [21:45:53] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:45:56] AndyRussG: maybe what you need is python3-mysql.connector [21:47:05] Jeff_Green: inside of python the modules themselves don't have python3- type prefixes [21:47:37] python3 just knows to look in the python3 library dir [21:48:38] on my machine, there's a /usr/lib/python3/dist-packages/mysql directory with a 'conncetor' directory inside it [21:48:41] Jeff_Green: according to the pkginfo on python3-mysql.connector, it points to the same URL that AndyRussG listed in the ticket. i think that's a good option. [21:48:52] but we don't see that on civi1001 [21:49:08] ejegg: yeah, they aren't there [21:49:51] the python-* versions are, I'll switch it [21:50:12] hmm ejegg blanking on where in the civi UI the settings for the thank you is located [21:50:35] cstone /admin/config/thank_you/configure [21:50:56] thanks! [21:51:00] yw [21:52:18] AndyRussG: that banner just looks like a link to a survey. I'd be surprised if they're too concerned with pageview vs bannerview vs clickthrough rates - guessing they're just going to analyze survey responses [21:52:32] so maybe not too bad to add the standard close button [21:54:17] interesting, python3-yaml was already installed so that shouldn't have been missing unless that hardcoded library path is breaking things [21:57:51] Jeff_Green: yaml worked fine [21:58:12] Well, nothing worked without the PYTHONPATH setting [21:58:18] ok, then give it a try now [21:58:21] and with it, only mysql wasn't found [21:58:43] Jeff_Green: yay it's there! [21:58:50] mysql makes sense b/c I didn't realize this is a python3 project, we had the python-* versions only [21:59:04] Ahhh okok right :) [21:59:05] I'm not sure why you would have to override the system's python path to find these [21:59:31] it could be that you're clobbering the python path with the /srv/fruec part rather than appending it [21:59:43] Jeff_Green: well what it didn't find without PYTHONPATH set was precisely the fruec module [21:59:48] So that's what we added first [21:59:59] and so with that, it found the fruec module, but didn't find anything else [22:00:17] Maybe we should just make it /srv/fruec:$PYTHONPATH [22:00:57] AndyRussG: Unfortunately we can't use the bash var for the existing pythonpath in the process-control yaml [22:01:03] we have to be explicit [22:01:13] Hmmm [22:01:20] Jeff_Green: ^ ? [22:02:08] Jeff_Green: for dev purposes, I was doing pip3 install -e . [22:02:18] from within the FRUEC directory [22:02:32] AndyRussG: right, I think that's the idea, at least that's what you'd do in perl (/me ducks) [22:02:43] That creates a symlink in a standard python location to the actual code location [22:02:49] right [22:03:05] Hmmm [22:03:06] Okok [22:03:15] AndyRussG: we can set the PYTHONPATH var ourselves for just that job - no need to mess with machine-wide settings [22:03:16] So should we expect to have to set PYTHONPATH in the job config? [22:03:27] Right but should that be what we do? [22:03:28] i don't think there's any harm in explicitly overwriting PYTHONPATH like that [22:03:45] And as u said, we have to explicitly overwrite [22:03:59] Jeff_Green: ok but is that like the best practice that you'd *like* us to do? [22:03:59] well, we could make a debian package for fruec :) [22:04:09] naaaaaaah nope nope nope [22:04:12] hahahahah [22:04:13] hehehe [22:04:22] ejegg: that's the right idea! [22:04:35] well [22:04:45] I'm totally down for just doing as I'm told [22:05:11] I'm guessing what we've done elsewhere is to set PYTHONPATH like you said above [22:07:00] Jeff_Green: in existing jobs I see a lot of PYTHONPATHs being set to /srv/tools, and a couple (for the old banner stats) to /etc/fundraising [22:07:09] but nothing adding in system library locations [22:07:15] yeah [22:07:35] isn't that odd? Wouldn't you expect some of those scripts to need the system libs? [22:08:13] fr-tech tech-talk? [22:08:19] Ah oops! [22:08:23] AndyRussG: that is odd, they actually do need system livs [22:08:26] *libs [22:09:16] https://stackoverflow.com/questions/19917492/how-to-use-pythonpath [22:09:23] that's confusing me further :-) [22:13:27] I keep finding examples like this: "export PYTHONPATH=$PYTHONPATH:/Users/dan/pymodules" [22:13:57] Jeff_Green: I think we figured it out... Python doesn't rely only on PYTHONPATH [22:14:01] to find system libs [22:14:12] ah! great [22:15:02] Jeff_Green: so we'll just set PYTHONPATH in the job config to /srv/fruec [22:15:04] sound good? [22:15:16] yep! [22:15:25] Jeff_Green: k thanks much!!! [22:15:41] Jeff_Green: ah also one other thing... We decided that soooon we'd like to delete all the existing json log files [22:15:57] so that the data going into the test DB is actually comparable to the real data [22:16:12] it isn't yet, since there are a couple more things that need to be deployed for that to happen [22:16:32] I don't imagine it's worth making a ticket for that? Maybe we could just ping you when we're ready? [22:17:04] Not a problem to delete them, I imagine? [22:17:50] I don't understand [22:18:22] what json files do you want to delete? [22:18:51] AndyRussG: ^^^ [22:19:05] Jeff_Green: all the ones generated from the new kafka streams [22:19:44] are we going to stop collecting them too? [22:21:26] ah, I missed the line about changing the contents [22:21:42] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising-Backlog: Center payment icons on payments page for user view - https://phabricator.wikimedia.org/T231391 (XenoRyet) [22:21:53] Jeff_Green: yeah [22:22:07] There are actually three things needed to deploy before the data turns good [22:22:08] yeah, why don't we make a task for this, and on that task specify the cutoff time between old and new format [22:22:14] Ok sure sounds good [22:22:21] PROBLEM - check_procs on frdb1001 is CRITICAL: PROCS CRITICAL: 1007 processes [22:22:27] Yeah /srv/archive/banner_logs/201[89]/*json* [22:22:40] we have to delete them in three places in a coordinated way, so tasking will be good [22:22:59] Jeff_Green: ah okok sure! Thanks much :) [22:23:05] cool, thx! [22:23:10] ;) [22:27:21] RECOVERY - check_procs on frdb1001 is OK: PROCS OK: 219 processes [22:59:25] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Ingenico: Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (XenoRyet) a:XenoRyet [23:49:13] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Ingenico: Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (Ejegg) @XenoRyet want to work with @Cstone on this? We went over this in tech talk and think we might have worked out a simple way... [23:50:34] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Ingenico: Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (XenoRyet) Yea, I'll try to catch up with her in the morning. Also spaced on tech-talk, sorry about that.