[00:09:59] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, and 2 others: One-time import of target smart data into IBM -- how to do this? - https://phabricator.wikimedia.org/T231538 (Eileenmcnaughto... [00:10:01] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Investigate: TargetSmart Civi import - https://phabricator.wikimedia.org/T227513 (Eileenmcnaughton) [04:11:33] (Abandoned) Eileen: Revert "Remove largest_donation_date from calcs" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535343 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [05:38:55] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (Eileenmcnaughton) @ejegg this is what I use for the HAC project - howeve... [05:40:10] (PS1) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [06:24:11] (PS2) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [07:20:19] RECOVERY - check_mailq on civi1001 is OK: OK: postfix mailq (4736) is below threshold (5000/7500) [07:30:21] (PS3) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [07:35:42] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [07:37:55] (PS4) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [07:40:15] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [07:42:12] (PS5) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [07:47:35] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [07:50:14] (PS6) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [07:55:55] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [08:04:40] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537864 (owner: L10n-bot) [08:16:09] Fundraising-Backlog, Patch-For-Review: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (jrobell) Yeay! :) Thank you @Pcoombe and @DStrine and team for your work on this! So we can close this task then? @kaythaney do you have what you need? [08:36:07] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/537842 (owner: L10n-bot) [08:50:37] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537864 (owner: L10n-bot) [08:51:14] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql and Civi access for jkumalah - https://phabricator.wikimedia.org/T232543 (jrobell) Thanks DStrine. Just a heads up that Erin will need the same access. [10:02:54] (PS7) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [10:08:24] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [10:35:26] (PS8) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [10:39:02] (PS9) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [10:44:33] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [11:20:18] (CR) Pcoombe: "> Patch Set 2:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [11:21:22] Fundraising-Backlog, Patch-For-Review: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (Pcoombe) @jrobell No, this was just a test from the staging environment. It still needs to be deployed to production which will make it the email donors actually get. [12:13:19] Fundraising-Backlog, Patch-For-Review: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (jrobell) Gotcha! Thank you for clarifying, Peter! [12:39:15] (PS10) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [12:44:26] (CR) jerkins-bot: [V: -1] Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [13:31:49] fr-tech, pcoombe is now a good time to switch civicrm staging back to master so I can confirm elliott's patch fixed the thankyou mail testing failure? I can't recreate the failure locally so this looks like the next best way. thanks! [13:32:25] I can then switch it back to what it's currently on, which is a detached version of HEAD with a few cherrypicks I think (I'm guessing Eileen was testing that) [13:33:31] jgleeson: I'm done testing the new TY email there, so no objection from me [13:33:49] thanks pcoombe ! [13:35:14] hmmm staging low loading really slow [13:35:23] after switching over to master [13:36:34] hmm live civi and staging are loading slowly for me [13:36:45] pcoombe: are you able to load up civicrm? [13:38:18] jgleeson: Both load for me, and not particularly slow. Staging has some warning about "Unknown extension: uk.org.futurefirst.networks.emailamender" [13:39:03] thanks pcoombe, not loading for me here [13:44:21] so they both now load after switching over to my mobile data [13:44:30] i can also see the failure now [13:44:50] I'll switch back over to ejegg's patch and test that out [13:53:42] ok that worked although when switching over to master I noticed a new Financial Type drop down was present and confused me a little [13:54:31] on the thankyou test email form [13:54:34] anywayyy [13:54:46] it looks like ejegg|away's fix fixes the issue so that's good [13:55:34] (CR) Jgleeson: [C: +2] "Code looks good and tests passing. I can't recreate the problem locally as discussed so I switched staging over to this patch to confirm t" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537653 (https://phabricator.wikimedia.org/T232504) (owner: Ejegg) [14:01:24] (Merged) jenkins-bot: Thank you test fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537653 (https://phabricator.wikimedia.org/T232504) (owner: Ejegg) [14:37:35] fr-tech do we send any emails from civi that aren't tied to a contribution? [14:42:26] cstone: how come? [14:43:05] I would imagine most of our emails are contribution related but for I couldn't be sure [14:43:14] all cases* [14:43:39] to get a working unsubscribe link in the 2nd updonate email, right now the logic I was going to use looks for a contribution [14:44:14] i should have brought this up in tech talk yesterday but I misunderstood the issue [14:47:30] I think failmail sends from civi [14:47:35] civi/drupal [14:48:06] checkout srv/org.wikimedia.civicrm/sites/all/modules/wmf_common/failmail.php:13 [14:48:53] and it looks like all phpmail in civi goes through srv/org.wikimedia.civicrm/modules/wmf_communication/Mailer.php:33 [14:49:13] so you could check what is calling that static method to work back and find out what's sending mail [14:50:36] thanks! I wonder if it still would need an unsubscribe link though from some email rules im not 100% sure on [14:55:52] Fundraising-Backlog: Add option to search by orderId and error message to pending/damage queue ui - https://phabricator.wikimedia.org/T233319 (jgleeson) [14:58:09] cstone: it sounds like your template needs the contribution record right? [14:58:24] or the code prior to you populating the template [14:58:46] yeah the unsubscribe queue consumer is looking for a contribution id [14:58:58] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Add option to search by orderId and error message to pending/damage queue ui - https://phabricator.wikimedia.org/T233319 (DStrine) [15:01:43] cstone: are you trying to work out if we need to unsubscribe mail that doesn't related to a contribution? [15:01:51] if so my guess is we don't [15:02:55] hmm actually now you've got me thinking about people optin to emails here https://payments.wikimedia.org/index.php?title=Special:EmailPreferences/optin&variant=wle_001 [15:03:00] hmm yeah maybe because it'll be a one time thing? [15:03:41] looks like you can optin without having a previous donation/contribution [15:04:12] cstone ooh, that is tricky [15:05:49] would the yearly summary emails have this same issue too ejegg? [15:05:53] cstone so there's the original one-time contribution [15:06:00] cstone yeah, now that you mention it [15:06:22] but with those we'll be able to choose any ID from the contributions [15:07:40] ah okay i was thinking these had to be super unique but they can use the same contribution for different emails then? [15:07:43] thanks dstrine ! [15:08:42] cstone yeah, the unsubscribe link just needs to be able to find the original contact [15:09:15] in fact, we probably SHOULD make it possible to have an unsubscribe link with just a contact ID and some kind of verification code [15:09:33] but for now the front-end unsubscribe logic is looking for a contribution ID [15:09:59] oh rly ejegg ? [15:10:24] does that mean we have another process for people who opt-in ? [15:13:09] i think the optins are the opposite where they are entering their email into a form? [15:15:39] cstone: I'm wonder do we also unsubscribe these later on if requested via the same process? [15:16:54] (via the unsubscribe queue consumer which fails if there is no contribution-id I think) [15:17:41] hmm yeah do the mass sent emails use ibm to manage the unsubscribes there? [15:17:44] jgleeson: yeah, the opt-in is just with email [15:18:06] cstone also yeah, the ibm emails have an ibm unsubscribe link [15:18:30] and it would be nice to use our own form for that too [15:19:14] see T127401 [15:19:15] T127401: Create WMF-hosted unsubscribe page - https://phabricator.wikimedia.org/T127401 [15:20:15] oh, and T99821 [15:20:16] T99821: Spike: Use WMF-hosted unsubscribe page for Fundraising emails, make conditional opt-out options - https://phabricator.wikimedia.org/T99821 [15:21:16] ejegg: just by email? [15:21:25] sorry can you elaborate a little [15:21:47] jgleeson: people can opt in just by entering their email address in the opt-in form [15:22:08] And if their address doesn't correspond to an existing contact, we create one [15:23:02] yep, I'm curious how we then unsubscribe these emails if requested [15:24:57] jgleeson: I guess the idea was that we only send TY email from civi, which always has a contribution ID [15:30:03] cstone: are you working on making it so we can unsubscribe without the contribution dependency? [15:30:13] or is this something unrelated [15:30:54] jgleeson this is for the 2nd updonate email which doesn't have a contribution id tied directly to it [15:32:04] got it [15:32:48] i guess for now ill use the invoice id to look up the original contribution? then if we switch to a contact id system it could be switched to that [15:35:36] cstone yeah, I think we need to tell the qc to retry the message later when it can't find the original [15:37:46] so around line 317 of the recurringQueueConsumer, in the block where we know the token is set [15:37:58] we check to make sure we have a valid contactID [15:38:14] and if not, we throw a WmfException with a retryable code [15:38:21] like the MISSING_PREDECESSOR [15:40:50] hmm, and if we've already looked up the contribution tracking record, we will have the contribution ID right there [15:41:08] so no need to make another db query [15:44:16] ejegg: we managed to get dash working btw! [15:44:20] on yarn [15:44:40] so it might be as straightforward as the guide suggested [15:44:54] I'm kinda suspicious the previous issue I run into went away [15:45:03] ok cool, thanks ejegg! [15:45:26] although I don't know why CI was failing at some git command, feels like recheck worthy [15:58:15] jgleeson: oh cool! [15:58:32] let's see, maybe it's testing with a wildly different version of node? [15:59:28] would be worth asking CI folks if they understand [16:01:42] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Paypal, FR-Q2-FY2019-20-cleanup-list: Paypal refunds missing predecessor - https://phabricator.wikimedia.org/T211847 (jgleeson) So it looks like this gateway saved for this transaction is 'paypal_ec' and not 'paypal' as supplied in the mes... [16:03:11] jgleeson: ^^^ guessing the original payment had the correct gateway and the refund message is tagged wrong? [16:03:46] hmm [16:04:12] what pushes to that queue? paypal itself [16:04:23] ? [16:04:39] paypal sends us IPN messages and the listener drops those right in the paypal-jobs queue [16:05:05] then the paypal job runner picks them up and decides what to do with them [16:05:23] including what gateway to tag them with and what queue they go to next [16:05:42] so it's all in the SmashPig codebase [16:06:35] let's see, and the RefundMessage seems to use the presence of an invoice_id or rp_invoice_id as a flag to indicate that it's an EC payment [16:07:10] if we can't depend on that, we may need to add some hack to the refund queue consumer [16:07:43] to try again with a different gateway if it can't find the predecessor using the originally-tagged gateway [16:08:20] and slap a big 'FIXME: delete this once we definitively kill legacy integration' on it [16:08:47] also, thanks for the CR on that mail test patch! [16:09:17] (PS3) Ejegg: Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [16:09:23] (CR) Ejegg: [C: +2] Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [16:10:17] hmmm [16:10:44] I wonder if I could track down the original message consumed by smashpig to see if the invoice id was there [16:10:58] jgleeson: it should be in the logs for that day [16:11:27] cool I'll jump on frlog and see if I can find it [16:11:30] thanks! [16:11:43] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/538055 [16:11:48] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/538055 (owner: Ejegg) [16:11:49] fr-tech I'll miss today's standup, I'm still at the wake [16:11:57] OK AndyRussG [16:12:06] sending best wishes AndyRussG :( [16:12:20] Thanks!! [16:15:25] fundraising-tech-ops, DC-Ops, Operations, decommission, ops-eqiad: decommission frav1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T222109 (Jgreen) [16:15:44] (Merged) jenkins-bot: Update endowment thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/535187 (https://phabricator.wikimedia.org/T232121) (owner: Pcoombe) [16:15:59] fundraising-tech-ops: synchronize frmon1001:/var/lib/grafana to frmon2001:/var/lib/grafana - https://phabricator.wikimedia.org/T232029 (Jgreen) [16:17:20] fr-tech anyone know how to link to a specific line within an etherpad? [16:17:44] I didn't even know it could do that. [16:17:50] we have some useful notes about frack log locations on line 382 of our tech-talk ether pad [16:19:07] hmmm maybe I should check to see if we have info on logs on the fundraising wiki and if not add it there [16:19:24] as etherpad isn't the safest :) [16:19:44] fundraising-tech-ops: set up cross-host backups between frmon1001 and frmon2001 - https://phabricator.wikimedia.org/T233328 (Jgreen) [16:20:15] fundraising-tech-ops: set up cross-host backups between frmon1001 and frmon2001 - https://phabricator.wikimedia.org/T233328 (Jgreen) [16:20:50] !log updated fundraising CiviCRM from 90db6cb5a1 to 5def62ab05 [16:20:51] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:21:26] fundraising-tech-ops: set up cross-host backups between frmon1001 and frmon2001 - https://phabricator.wikimedia.org/T233328 (Jgreen) commit cf298b3f3085d1862937754d3fa2908e8ba7e971 Author: Jeff Green Date: Thu Sep 19 15:48:07 2019 +0000 iptables allow for frav hosts to cross-rsy... [16:22:06] pcoombe: can you point me to a banner that has the Remind Me Later code in it? [16:22:22] or Seddon ^^^ ? [16:22:30] or spatton ^^^ ? [16:22:36] or tskaff ^^^ ? [16:23:12] ejegg: https://en.wikipedia.org/wiki/NASA?banner=B1920_0701_enWW_dsk_p1_lg_template&country=US [16:23:19] thanks! [17:25:34] Wikimedia-Fundraising-CiviCRM: recurring cancelations report: searchby time periods - https://phabricator.wikimedia.org/T233337 (DStrine) [17:27:19] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: recurring cancelations report: backfill DS actions and mark them going forward - https://phabricator.wikimedia.org/T233338 (DStrine) [17:27:36] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: recurring cancelations report: searchby time periods - https://phabricator.wikimedia.org/T233337 (DStrine) [17:29:40] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: recurring cancelations report: investigate parsing paypal recurring cancel reasons - https://phabricator.wikimedia.org/T233339 (DStrine) [17:41:18] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: recurring cancelations report: investigate parsing paypal recurring cancel reasons - https://phabricator.wikimedia.org/T233339 (DStrine) [17:53:08] fr-tech, I've added some notes on our logs across frack here https://collab.wikimedia.org/wiki/Fundraising/Engineering#Fundraising_Log_Diving feel free to update/correct! thanks [18:00:34] thanks jgleeson [18:26:04] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: 500 error when testing Endowment thank you emails in Civi - https://phabricator.wikimedia.org/T232504 (Ejegg) Open→Resolved [18:26:29] Fundraising-Backlog: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (Ejegg) OK, this is deployed to production [20:07:18] (PS8) Cstone: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [20:07:33] (PS3) Ejegg: Revive largest_donation_date test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537347 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [20:07:37] (CR) Ejegg: [C: +2] Revive largest_donation_date test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537347 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [20:13:40] (Merged) jenkins-bot: Revive largest_donation_date test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537347 (https://phabricator.wikimedia.org/T229273) (owner: Eileen) [20:13:42] (CR) jerkins-bot: [V: -1] Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [20:17:07] fundraising-tech-ops: set up cross-host backups between frmon1001 and frmon2001 - https://phabricator.wikimedia.org/T233328 (ayounsi) [20:17:09] fundraising-tech-ops: synchronize frmon1001:/var/lib/grafana to frmon2001:/var/lib/grafana - https://phabricator.wikimedia.org/T232029 (ayounsi) [20:17:11] fundraising-tech-ops, DC-Ops, Operations, decommission, ops-eqiad: decommission frav1001.frack.eqiad.wmnet - https://phabricator.wikimedia.org/T222109 (ayounsi) [20:17:16] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (Ejegg) Cool, that will be helpful for generating the text-based emails.... [20:19:22] ejegg in local queue testing can things be requeued? I could get the error to happen when I ran the rqc first but it seemed to completely clear the queue [20:21:22] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 4 others: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) @Dstine I adde... [20:23:18] cstone: ah yeah, to requeue it [20:23:34] there's a smashpig maintenance task [20:23:36] lemme see [20:24:03] Maintenance/RequeueDelayedMessages.php [20:24:16] oh hey, it would be nice to have a flag on that to ignore the retry date [20:24:30] and just requeue everything where that's not null [20:26:29] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Princess Mongodb, Fundraising Sprint Quick and the Deadlocked, and 4 others: I want to be able to read a list communication fields in civi - https://phabricator.wikimedia.org/T227498 (mepps) @Eileen I upda... [20:28:28] Fundraising-Backlog: Update Endowment automatic thank you email - https://phabricator.wikimedia.org/T232121 (Pcoombe) Open→Resolved Just made a test endowment donation and confirmed I get the new email. Thanks! [20:34:54] (PS9) Cstone: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [20:39:03] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Wikimedia-Fundraising-Banners, FR-dlocal, Patch-For-Review: dLocal: on donation form, show Netbanking / UPI choice sooner in flow? - https://phabricator.wikimedia.org/T231452 (mepps) @Ejegg are you working on this and should it be moved t... [20:40:40] (PS1) Ejegg: Allow overriding requeue date cutoff [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/538104 [20:40:59] cstone: ^^^ adds an option to the maintenance script to help testing retry-able messages [20:41:03] (CR) jerkins-bot: [V: -1] Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [20:42:27] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Wikimedia-Fundraising-Banners, FR-dlocal, Patch-For-Review: dLocal: on donation form, show Netbanking / UPI choice sooner in flow? - https://phabricator.wikimedia.org/T231452 (Ejegg) @mepps That patch was mostly just an experiment - I'm n... [20:42:55] ejegg cool ill check it out [20:44:17] for my failing CI test it looks like its sending 2 emails and im guessing one is the original thank you email, is there a setting to turn that off? its not happening locally for me [20:48:51] oh weird, I'll try locally [20:49:50] that last patch I put up was me trying to see if that was what was happening [20:51:27] jeez, I'm getting a ton of test failures locally [20:52:58] the notification test was failing locally but got further in CI in the last patch [21:04:14] (CR) Cstone: [C: +2] "Looks good and worked great for me." [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/538104 (owner: Ejegg) [21:04:42] (Merged) jenkins-bot: Allow overriding requeue date cutoff [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/538104 (owner: Ejegg) [21:04:50] ejegg cool that patch let me test that nicely [21:05:31] rockin! [21:06:14] phpunit is still failing spuriously on my local db - maybe I'll fire up vagrant [21:07:09] oh hey, that trigger update seems to have gotten me past the errors [21:07:15] ok, now I see the emailsend thing! [21:07:22] so let's see what you're testing [21:08:08] hmm, TestMailer::countMailings should be pretty straightforward [21:08:16] so in your local db it really is 1? [21:09:05] yeah [21:09:40] well, you can always call TestMailer::setup() after creating the $firstContribution [21:09:59] the test would be a bit more focused that way [21:10:03] haha brilliant [21:10:08] yeah i like that [21:10:22] cool! maybe just add a comment to say 'reset mailing count [21:10:23] ' [21:10:38] so ppl don't think it's duplicate code and delete it [21:17:28] (PS10) Cstone: Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) [21:22:47] (CR) jerkins-bot: [V: -1] Add second email when creating a new updonate recurring donation. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [21:23:36] hah now just a phantom space to figure out [21:26:55] oh heh, currency formatting [21:27:54] my local one is $6.00 and CI is $ 6.00 [21:28:16] (CR) Ejegg: [C: -1] "Just a few trivial cleanup suggestions" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/533284 (https://phabricator.wikimedia.org/T228162) (owner: Cstone) [21:28:52] cstone: hmm, I think that might depend on some fiddly locale settings [21:29:05] I'd be happy just looking for the 6.00 [21:40:30] ejegg for the $mailingData['finanical_type'] thank_you_get_from_name() looks for it for an endowment check, would it be better to just call variable_get instead of thank_you_get_from_name? [21:44:23] cstone: oh drat, I totally missed that [21:45:04] yeah it doesnt apply to what im doing but I didn't want to stray too far from the original setup for $params [21:45:05] hmm, I'd prefer we updated that function to look up the from_name by template name [21:45:31] Like, we should have updated that fn too in the preliminary patch [21:48:00] ahh yeah I can make another small one? [21:51:21] cstone: sure! [21:51:35] or if you want to mush that fix in here I don't mind [21:51:52] though... yeah, much clearer with a small separate fix [21:57:34] (PS1) Cstone: Check the template for endowment instead of financial_type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538116 [22:06:51] woo a passing test for once :P [22:07:01] ejegg i created that mini patch [22:38:42] (CR) Ejegg: [C: +2] Check the template for endowment instead of financial_type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538116 (owner: Cstone) [22:38:45] thanks! [22:38:57] sorry for the delay [22:39:28] (CR) jerkins-bot: [V: -1] Check the template for endowment instead of financial_type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538116 (owner: Cstone) [22:41:45] hrm? [22:42:12] (CR) Ejegg: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538116 (owner: Cstone) [22:44:04] (PS1) Ejegg: Update Amazon library to stop trim warnings [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/538124 [22:44:16] (CR) Ejegg: [C: +2] Update Amazon library to stop trim warnings [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/538124 (owner: Ejegg) [22:47:27] (Merged) jenkins-bot: Check the template for endowment instead of financial_type. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538116 (owner: Cstone) [22:49:46] (Merged) jenkins-bot: Update Amazon library to stop trim warnings [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/538124 (owner: Ejegg) [22:51:32] !log updated payments-wiki from adef0e858f to 939b771800 [22:51:35] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:53:26] (CR) jenkins-bot: Update Amazon library to stop trim warnings [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/538124 (owner: Ejegg) [23:05:59] (CR) jenkins-bot: Update Amazon library to stop trim warnings [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/538124 (owner: Ejegg) [23:31:24] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frqueue2001 - https://phabricator.wikimedia.org/T232630 (Papaul) [23:33:00] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frqueue2001 - https://phabricator.wikimedia.org/T232630 (Papaul) a:Papaul→Dwisehaupt This is done at my end.