[07:30:40] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/538517 (owner: L10n-bot) [07:54:22] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/538504 (owner: L10n-bot) [08:24:18] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/538517 (owner: L10n-bot) [10:28:23] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, and 2 others: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (Eileenmcnaughton) @CCogdill... [11:47:45] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, and 2 others: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (CCogdill_WMF) Ah yessss thi... [12:29:37] Fundraising-Backlog, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice: CentralNotice: Saving banners with translatable messages may time out - https://phabricator.wikimedia.org/T224598 (Nikerabbit) Is this also solved with the fix for {T231703}? [12:42:38] Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (CDenes_WMF) [13:07:16] tzag fr-tech! [13:08:00] tzag mepps :) [13:08:19] how's it going jgleeson? [13:08:41] good good thanks mepps how about you? [13:09:07] oh not bad, i started my day with an early morning run which always sets me up well [13:09:57] good going! [13:20:46] how was your weekend jgleeson? do anything fun? [13:29:25] mepps: we took the kids out to a local heritage site on Saturday as the weather was good so that was fun. We had torrential rain Sunday so that was lazy day for us all :) How about you anything fun? [13:30:46] jlgeeson, nice! we spent time with some friends and my dad and his wife, and yesterday just hung out as a family but that was quite fun! [13:31:37] :) [14:03:33] mepps: you around? [14:03:40] oops yes jgleeson [14:03:44] :) [14:13:06] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, and 2 others: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (Eileenmcnaughton) The hash... [14:16:49] Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (DStrine) a:DStrine→None [14:22:38] Fundraising Dash, Fundraising-Backlog: Main A/B data table - https://phabricator.wikimedia.org/T88752 (DStrine) a:MeganHernandez_WMF→None [14:28:33] tzag mepps jgleeson fr-tech [14:28:50] tzag AndyRussG! [14:29:03] :) [14:36:47] Fundraising-Backlog: UpDonate: Can't give more than initial amount - https://phabricator.wikimedia.org/T233451 (EWilfong_WMF) I experienced this issue on a donation made on 8/26/19. Just re-tested and did not experience the same issue, so it does appear the bug I encountered has been resolved. [14:44:04] hi fr-tech [14:48:37] How's everybody's Monday going so far? [14:50:15] ejegg hi! So far, hectic kid-drop-off-y and errand-y [14:50:39] Hopefully FRUEC-y in a bit [14:50:44] You? [14:52:26] hey ejegg, good thanks! how about you? [14:52:55] oh, pretty good, just a little bit of tile planning with the contractors and trying to clear out the ol' gmail inbox [14:53:48] looks like eileen has a ton of patches in review [14:53:53] (mostly test cleanup) [14:54:18] I really need to do more civi review [14:54:32] it's the one area of the stack I don't do any review on [14:55:15] (normally because you're so efficient ejegg!) [14:56:20] jgleeson: after the stack of not-so-interesting test fixes, this would be the next in the chain to review: https://gerrit.wikimedia.org/r/537788 [14:56:26] adding a new extension [14:56:53] the extension already existed but had been abandoned for a couple years [14:57:24] so eileen picked it up and has been making changes to it here: https://github.com/eileenmcnaughton/Email-Amender [14:57:41] I'm guessing the gerrit patch has the latest version from github [14:57:51] I think previously I've avoided review because of the unittests uncertainty on vagrant but I think we've improved that a bit recently [15:02:28] ejegg check-in? [15:02:44] oops, be right there mepps [15:10:00] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (EYener) After speaking with @jrobell, I will also need access to: Turnilo Banner data Pageview data Thank you! [15:12:23] Fundraising-Backlog: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (jrobell) [15:15:42] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Have a way to import a list of languages or a list of wikis to target in CentralNotice - https://phabricator.wikimedia.org/T220386 (Trizek-WMF) [15:34:46] Delayed tzag fr-tech [15:34:52] hi cstone! [15:37:46] hello! [15:39:56] (CR) Ejegg: [C: +1] "The comments are nice! We should be consistent on how we index those cleanup IDs though" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538355 (owner: Eileen) [15:46:10] (CR) Ejegg: [C: +2] "Nice! Trait versions get us a couple extra checks." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538358 (owner: Eileen) [15:50:52] (CR) Ejegg: [C: +2] Improve cleanup in Benevity test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538360 (owner: Eileen) [15:53:19] (CR) Ejegg: [C: +2] Improve cleanup on DonationTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538361 (owner: Eileen) [15:54:59] (CR) Ejegg: [C: +1] "Why not go all the way?" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538363 (owner: Eileen) [15:55:21] (CR) Ejegg: [C: +2] Improved but not perfect cleanup on import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538364 (owner: Eileen) [15:56:06] (CR) Ejegg: [C: +2] Improve cleanup on recurring test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538366 (owner: Eileen) [15:56:55] (CR) Ejegg: [C: +2] Improve phone test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538367 (owner: Eileen) [15:58:10] (CR) Ejegg: [C: +2] "OK, on second look it seems like you're moving to indexing all the cleanup IDs consistently this way" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538355 (owner: Eileen) [16:03:34] (Merged) jenkins-bot: Add some comment blocks [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538355 (owner: Eileen) [16:03:48] (Merged) jenkins-bot: Use test trait instead of copies of helper functions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538358 (owner: Eileen) [16:03:50] (Merged) jenkins-bot: Improve cleanup in Benevity test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538360 (owner: Eileen) [16:03:53] (Merged) jenkins-bot: Improve cleanup on DonationTest [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538361 (owner: Eileen) [16:06:37] (CR) Ejegg: [C: +2] "This is a help - I'll make another patch to clean up the now-unused properties" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538363 (owner: Eileen) [16:07:30] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) Hi @EYener, If your issues are around connecting to frdev1001, using the proper ssh passphrases/yubikey clicks, or mysql login a... [16:08:58] cstone: delayed tzag response [16:09:03] a.k.a. hi! [16:12:02] (Merged) jenkins-bot: Improve cleanup on adyen test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538363 (owner: Eileen) [16:12:19] (Merged) jenkins-bot: Improved but not perfect cleanup on import test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538364 (owner: Eileen) [16:12:22] (Merged) jenkins-bot: Improve cleanup on recurring test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538366 (owner: Eileen) [16:12:24] (Merged) jenkins-bot: Improve phone test [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538367 (owner: Eileen) [16:19:00] (PS1) Ejegg: More test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538663 [16:30:33] (PS2) Ejegg: Composer update - includes Elliot's upstreamed patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538374 (owner: Eileen) [16:31:22] (PS2) Ejegg: Allow api debug=TRUE to set curl debug when calling Omnihell.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538376 (owner: Eileen) [16:32:10] (CR) Ejegg: [C: +2] Allow api debug=TRUE to set curl debug when calling Omnihell.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538376 (owner: Eileen) [17:10:22] (PS1) TheSandDoctor: CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/538676 (https://phabricator.wikimedia.org/T233538) [19:25:22] fr-tech, dwisehaupt and Jeff_Green i'm goinf to be late to the meeting too... sorry! [19:25:36] maybe 10 minutes [19:25:52] ok, shall we just reschedule? [19:27:25] ejegg|afk: ^^ [19:30:02] i'm fine with delay or reschedule. [19:30:16] AndyRussG: I just did a process-control deploy which appeared to rsync a merged but undeployed change to fruec_consume.yaml, guessing it's this PYTHONPATH commit, does that sound OK/right to you? [19:37:43] hi fr-tech, Jeff_Green, dwisehaupt I'm in the meeting now [19:37:47] and nobody else is [19:38:01] ha. well andy said he'd be late too [19:38:29] aha, cstone is in there [19:38:42] and says the rest of fr-tech is going to show up in a minute [19:39:04] ok [19:42:11] jgleeson we're back on the call [19:43:56] Fundraising-Backlog: Fraud filters allowing jibberish names through - https://phabricator.wikimedia.org/T233658 (EMartin) [20:12:08] Fundraising-Backlog: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Ejegg) https://wikitech.wikimedia.org/wiki/Analytics/Data_access [20:13:02] Fundraising-Backlog: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (mepps) @jrobell, @Ejegg added documentation for how to make the request to analytics above. [20:15:21] Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (Ejegg) Hi @CDenes_WMF ! We could do the old process of pulling the translation from meta, but if you'd like, you can also use the process we've been practicing in meetings to submit a the fix as gerrit change yourself. [20:15:48] Fundraising-Backlog: UpDonate: Error message when donating (maybe anti-fraud) - https://phabricator.wikimedia.org/T233455 (Ejegg) Open→Invalid [20:24:06] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (mepps) Hmm, we think this could be pulling the gift source and using and if conditional in the thank you letter. [20:38:53] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (LeanneS) @mepps That would be great! [20:55:33] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage batch import should have choice to not send TY emails - https://phabricator.wikimedia.org/T230450 (Ejegg) Are they currently skipping the thank you email by adding a no_thank_you column to the import, or are we currently sending emails? [21:10:03] Fundraising-Backlog, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (EYener) [21:20:32] Fundraising-Backlog, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (EYener) Thanks for the link, @Ejegg! After reviewing the documentation and other resources, I believe @jkumalah and I... [22:13:12] fr-tech here's the trivial fix for the failing adyen audits: https://gerrit.wikimedia.org/r/538346 [22:13:22] anyone got a sec to review? ^^^ [22:31:41] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: PHP-queue predis backend is losing data when exit() is call in popAtomic callback - https://phabricator.wikimedia.org/T178104 (Ejegg) Possible upgrade for PHP-Queue: use a lua script to temporarily move data to a different structure while processing a j... [22:38:29] (CR) Ejegg: [C: +2] Composer update - includes Elliot's upstreamed patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538374 (owner: Eileen) [22:44:36] (Merged) jenkins-bot: Composer update - includes Elliot's upstreamed patch [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538374 (owner: Eileen) [22:44:39] (Merged) jenkins-bot: Allow api debug=TRUE to set curl debug when calling Omnihell.get [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538376 (owner: Eileen) [22:53:09] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (EYener) Hi @Dwisehaupt and thanks for your help today. I can now access the frdev1001 db via ssh shell and wanted to follow up on 2 remaining... [22:54:04] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, FR-Email: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (Ejegg) @MNoor and @CCogdill_WMF : Do we need to omit endowment donations... [22:58:13] (PS1) Ejegg: End of year template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538712 (https://phabricator.wikimedia.org/T195907) [22:58:15] (PS1) Ejegg: End of year summary: code formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538713 (https://phabricator.wikimedia.org/T195907) [22:58:18] (PS1) Ejegg: End of year summary: declare implicit properties [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538714 (https://phabricator.wikimedia.org/T195907) [23:14:19] PROBLEM - check_minfraud_secondary on payments1004 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:18:19] RECOVERY - check_minfraud_secondary on payments1004 is OK: HTTP OK: Status line output matched 200,301,302 - 662 bytes in 0.046 second response time [23:19:47] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage batch import should have choice to not send TY emails - https://phabricator.wikimedia.org/T230450 (Ejegg) [23:21:06] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage batch import should have choice to not send TY emails - https://phabricator.wikimedia.org/T230450 (Ejegg) Open→Resolved a:Ejegg Resolved with a change to the batch entry profile to show the 'no th... [23:23:50] Fundraising-Backlog, fundraising-tech-ops: Pats has gotten a new yubikey and needs the public key updated for access. - https://phabricator.wikimedia.org/T232640 (Ppena) ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQDjaTIEkvIKu1r8C+KI2DQndFcDtLzeUX8X7UyZ73qoMP2OWaVY0HrBrqKfhidKh1YCzcIhv2Fz1YG9n8G/v/kwm3cVkIbOs6c... [23:24:19] PROBLEM - check_minfraud_primary on payments1002 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:33:19] RECOVERY - check_minfraud_primary on payments1002 is OK: HTTP OK: Status line output matched 200,301,302 - 787 bytes in 1.547 second response time [23:41:53] PROBLEM - check_minfraud_primary on payments1003 is CRITICAL: connect to address minfraud-us-east.maxmind.com and port 443: Cannot assign requested address [23:44:19] PROBLEM - check_minfraud_primary on payments1002 is CRITICAL: connect to address minfraud-us-east.maxmind.com and port 443: Cannot assign requested address [23:44:19] PROBLEM - check_minfraud_primary on payments1004 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:44:19] PROBLEM - check_minfraud_secondary on payments1002 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:47:23] PROBLEM - check_minfraud_primary on payments1003 is CRITICAL: connect to address minfraud-us-east.maxmind.com and port 443: Cannot assign requested address [23:47:23] PROBLEM - check_minfraud_secondary on payments1003 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:48:19] RECOVERY - check_minfraud_primary on payments1002 is OK: HTTP OK: Status line output matched 200,301,302 - 787 bytes in 0.055 second response time [23:48:19] RECOVERY - check_minfraud_secondary on payments1002 is OK: HTTP OK: Status line output matched 200,301,302 - 662 bytes in 1.901 second response time [23:48:19] RECOVERY - check_minfraud_primary on payments1004 is OK: HTTP OK: Status line output matched 200,301,302 - 787 bytes in 1.549 second response time [23:50:13] PROBLEM - check_minfraud_primary on payments1001 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:51:19] RECOVERY - check_minfraud_primary on payments1003 is OK: HTTP OK: Status line output matched 200,301,302 - 787 bytes in 0.067 second response time [23:51:19] RECOVERY - check_minfraud_secondary on payments1003 is OK: HTTP OK: Status line output matched 200,301,302 - 662 bytes in 1.562 second response time [23:53:19] PROBLEM - check_minfraud_primary on payments1001 is CRITICAL: connect to address minfraud-us-east.maxmind.com and port 443: Cannot assign requested address [23:59:19] PROBLEM - check_minfraud_primary on payments1001 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:59:19] PROBLEM - check_minfraud_primary on payments1004 is CRITICAL: CRITICAL - Socket timeout after 61 seconds [23:59:19] PROBLEM - check_minfraud_primary on payments1002 is CRITICAL: connect to address minfraud-us-east.maxmind.com and port 443: Cannot assign requested address