[00:05:33] any fr server admins around? frauth2001 says the radius server is down. fyi. but only codfw [00:06:47] eh yea, and because i said something it decided to recover and runs again :) nevermind [00:10:39] Fundraising-Backlog, fundraising-tech-ops: Pats has gotten a new yubikey and machine and needs the public keys for ssh and the yubikey updated for access. - https://phabricator.wikimedia.org/T232640 (Dwisehaupt) Hello @Ppena. It will probably be best to schedule some time to check this out with you in a... [00:11:12] Fundraising-Backlog, fundraising-tech-ops: Pats has gotten a new yubikey and machine and needs the public keys for ssh and the yubikey updated for access. - https://phabricator.wikimedia.org/T232640 (Ppena) Awesome-Thanks Dallas!! [02:20:15] PROBLEM - check_gcsip on payments1001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [02:20:15] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [02:20:15] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [02:20:16] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [02:20:16] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [02:23:09] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.236 second response time [02:23:15] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.377 second response time [02:23:15] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.199 second response time [02:23:15] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.201 second response time [02:23:16] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 1.303 second response time [03:20:13] PROBLEM - check_gcsip on payments1001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:20:15] PROBLEM - check_gcsip on payments2003 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:20:15] PROBLEM - check_gcsip on payments2001 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:20:15] PROBLEM - check_gcsip on payments1002 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:20:16] PROBLEM - check_gcsip on payments1004 is CRITICAL: CRITICAL - Socket timeout after 121 seconds [03:23:09] RECOVERY - check_gcsip on payments1001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.215 second response time [03:23:15] RECOVERY - check_gcsip on payments2001 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.195 second response time [03:23:15] RECOVERY - check_gcsip on payments1002 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.223 second response time [03:23:15] RECOVERY - check_gcsip on payments2003 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.196 second response time [03:23:16] RECOVERY - check_gcsip on payments1004 is OK: HTTP OK: HTTP/1.1 200 OK - 343 bytes in 0.240 second response time [07:28:22] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539042 (owner: L10n-bot) [07:30:35] (Abandoned) Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/538787 (owner: L10n-bot) [07:30:54] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539042 (owner: L10n-bot) [07:37:26] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/539035 (owner: L10n-bot) [08:44:11] Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (CDenes_WMF) Ok I will give it a shot :) stay tuned! *Camille de Nes *(she/her) Global Campaign Manager Wikimedia Foundation [09:10:55] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (MSuijkerbuijk_WMF) Copying below, thanks! Your public key has been saved in /Users/marianasuijkerbuijk/.ssh/id_rsa.pub. The key fingerprint is: SHA256... [09:17:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:22:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:27:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 3% free (227 MB out of 7628 MB) [09:32:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 3% free (154 MB out of 7628 MB) [09:37:18] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 2% free (109 MB out of 7628 MB) [09:42:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (33 MB out of 7628 MB) [09:47:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:52:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:57:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:02:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:07:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:12:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:17:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:22:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:27:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:32:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:37:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:42:11] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:47:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [10:52:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (5 MB out of 7628 MB) [10:57:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (5 MB out of 7628 MB) [11:02:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (6 MB out of 7628 MB) [11:07:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (6 MB out of 7628 MB) [11:12:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (6 MB out of 7628 MB) [11:17:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (7 MB out of 7628 MB) [11:22:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (7 MB out of 7628 MB) [11:27:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (7 MB out of 7628 MB) [11:28:23] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Have a way to import a list of languages or a list of wikis to target in CentralNotice - https://phabricator.wikimedia.org/T220386 (Elitre) Ciao @Jseddon, I asked Trizek to update the task description to explain better how cumbersome the process cu... [11:32:12] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (7 MB out of 7628 MB) [11:37:12] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (5 MB out of 7628 MB) [11:42:12] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (3 MB out of 7628 MB) [11:47:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (2 MB out of 7628 MB) [11:52:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [11:57:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:02:09] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:07:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:12:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:17:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:22:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:22:19] tzag fr-tech! [12:27:16] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:32:10] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:37:16] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:42:14] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:42:27] tzag mepps ! [12:42:30] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: Create FRUEC process-control job - https://phabricator.wikimedia.org/T232968 (mepps) @AndyRussG It looks like you were working on this and put something out yesterday. Should it be in review/dep... [12:42:40] how's it going jgleeson? [12:43:04] d [12:43:38] good good, just dropped Oscar off as nursery so now the house is eerily quiet! [12:43:42] how about you mepps ? [12:44:36] similar with quiet house! both kids are out for the day [12:44:48] :) [12:45:11] s/as/at/ [12:45:34] ha [12:45:39] i didn't notice [12:47:16] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:47:36] mepps: do you know what frav is? anti-virus maybe? [12:52:10] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [12:57:10] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [12:57:46] i do not jgleeson [13:02:10] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [13:07:16] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [13:08:29] (PS2) Mepps: Change name, default, and add documentation for MaxCampaignFallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/538967 (https://phabricator.wikimedia.org/T232859) [13:12:14] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [13:17:16] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (1 MB out of 7628 MB) [13:18:10] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Have a way to import a list of languages or a list of wikis to target in CentralNotice - https://phabricator.wikimedia.org/T220386 (Trizek-WMF) The system on Extension:Translate: {F30464239} [13:18:33] hi Jeff_Green, i just saw your email [13:22:16] RECOVERY - check_swap on frav1002 is OK: SWAP OK - 96% free (7314 MB out of 7628 MB) [14:02:40] Fundraising-Backlog, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (jrobell) Hey all, I spoke to Erin and Jerrie about this and there seems to be some confusion around which groups are... [14:28:23] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (Dwisehaupt) Hello Maria, I actually need the contents of the file. You can get that using the following command in a Terminal window: cat /Users/mari... [15:18:24] fr-tech anything to share with other teams in Scrum of Scrums? [15:18:52] ejegg: nothing here, thanks! [15:24:22] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, and 2 others: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (Ejegg) p:Triage→High a:Ejegg [15:47:12] (CR) Mepps: [C: +2] "Looks good, but I really wish we could do this dynamically in the app. Also for some reason it didn't sync up to the phab task but the com" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/537677 (https://phabricator.wikimedia.org/T232886) (owner: Ejegg) [15:48:10] (Merged) jenkins-bot: Update totals-earned chart for 2019 [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/537677 (https://phabricator.wikimedia.org/T232886) (owner: Ejegg) [16:24:47] Fundraising-Backlog, MediaWiki-extensions-CentralNotice, User-TheSandDoctor: CentralNotice needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233538 (Krinkle) Resolved→Open a:TheSandDoctor→AndyRussG The CentralNotice extension is special in that it has a... [16:26:17] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (MSuijkerbuijk_WMF) Hi Dallas, Let's see if it's right now, see below ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCeXqjNtW71/FoQSyEyqWUsExlvKnhyzNrEcJXzjZ... [16:29:11] (PS1) AndyRussG: Check for config file in fruec root directory [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539154 [16:40:05] (PS3) Ejegg: EOY summary: Quit filtering big query with function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538727 (https://phabricator.wikimedia.org/T195907) [16:40:07] (PS4) Ejegg: End of year summry template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) [16:40:09] (PS1) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 [17:02:36] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (Dwisehaupt) Hello Mariana, Thanks, that's what I needed. I have updated the repo and pushed the key around. If you haven't yet, you should create an... [17:24:23] (CR) Krinkle: "From perf POV, my only concern is that it register no extra modules, and output no additional HTML/CSS/JS or config vars on regular page v" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [17:53:16] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (MSuijkerbuijk_WMF) Hi Dallas, I'm trying to follow the last instructions you shared. Should it be run on Terminal? It is not working. Any tip? I was... [18:47:45] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Recurring-Donations: trigger a second email in recurring upsell to denote the recurring part - https://phabricator.wikimedia.org/T228162 (spat... [18:52:52] (PS8) XenoRyet: No Card Selector Ingenico Variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) [19:03:24] so it looks like our form loading tests deliberately inject the the payment_submethod resulting in that being treated as a preset submethod which hides some output in the patch I'm working on hmmmm [19:06:59] (PS1) Jgleeson: WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [19:08:25] (CR) jerkins-bot: [V: -1] WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:11:01] Fundraising Sprint Quick and the Deadlocked, Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Recurring-Donations: trigger a second email in recurring upsell to denote the recurring part - https://phabricator.wikimedia.org/T228162 (DStr... [19:12:00] (PS2) Jgleeson: WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [19:13:19] (CR) Jgleeson: [C: -1] "oh man, looks like my coding styles need fixing again" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:13:25] (CR) jerkins-bot: [V: -1] WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:15:27] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539187 [19:15:29] (PS1) Ejegg: Minify for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539188 [19:15:31] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539187 (owner: Ejegg) [19:15:41] (CR) Ejegg: [C: +2] Minify for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539188 (owner: Ejegg) [19:16:21] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539187 (owner: Ejegg) [19:16:32] (Merged) jenkins-bot: Minify for deploy [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539188 (owner: Ejegg) [19:22:14] (CR) Ejegg: [C: +2] "This fixes the 'where to look for it' problem! I guess you explicitly DON'T want to catch IOErrors thrown when the file exists but isn't r" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539154 (owner: AndyRussG) [19:32:47] mepps are you working on a tech email for email standup? [19:33:04] urg, no i forgot ejegg [19:33:14] are you or XenoRyet up for it? [19:33:31] I can do it [19:33:59] thank you!! [19:34:15] I could as well, but if ejegg is on it, that's cool. [19:38:50] Fundraising-Backlog: oanda/expense report linkage error - https://phabricator.wikimedia.org/T233844 (DStrine) [19:53:44] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (herron) >>! In T233636#5517703, @EYener wrote: > Tools / Data Sources > Turnilo > Superset Afaict LDAP... [19:53:59] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (herron) [20:07:08] ejegg: ^ thanks! Got a sec to manually verify and submit, too? Thanks!! (https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/FRUEC/+/539154) [20:07:24] AndyRussG: oh sure, one sec [20:08:37] thx! [20:09:26] AndyRussG: what is the name of the property that will change in banner impressions after campaign fallback is deployed? [20:09:44] just going to mention the name and point analysts to you for deeper info [20:09:53] in the weekly email advancement standup [20:11:35] (CR) Ejegg: [V: +2 C: +2] Check for config file in fruec root directory [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539154 (owner: AndyRussG) [20:13:16] AndyRussG: ah, it just adds a campaignStatuses property [20:13:31] so it doesn't clobber an existing thing to do that? [20:23:03] ejegg: correct [20:23:14] cool [20:23:41] the fruec config patch is merged now [20:23:58] ejegg: yeah existing fields are considered legacy and do not change in the way they operate, except that they will only refer to the last attempted campaign [20:24:02] ¡gracias! [20:24:21] de nada [20:24:25] :) [20:24:41] fr-tech any objections if I deploy the latest FRUEC and try to run the darn thing again? [20:24:47] go for it! [20:24:55] yeee thanks! [20:39:30] (PS1) AndyRussG: Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539197 [20:42:16] (Abandoned) AndyRussG: Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539197 (owner: AndyRussG) [20:45:28] (PS1) Ejegg: Update node modules and production version number [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/539198 [20:45:58] (PS1) AndyRussG: Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539199 [20:46:05] (CR) Ejegg: [C: +2] Update node modules and production version number [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/539198 (owner: Ejegg) [20:46:45] (Merged) jenkins-bot: Update node modules and production version number [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/539198 (owner: Ejegg) [20:47:09] (PS1) Ejegg: Update dependencies [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/539201 [20:47:11] fr-tech I'm seeing a really weird diff in Gerrit for the FRUEC merge to the deployment branch: https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/FRUEC/+/539199 [20:47:20] (CR) Ejegg: [C: +2] Update dependencies [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/539201 (owner: Ejegg) [20:47:23] I think it's an artefact of some Gerrit weirdness [20:47:35] since locally all diffs look fine [20:47:54] I guess I'll just merge 'n' deploy [20:48:09] AndyRussG: that diff looks just like the diff for the merged patch [20:48:13] plus a 'merge list' line [20:48:21] at least when I load it [20:48:53] ejegg: you don't see a "<<<<<<< HEAD (971288 Make default config ./fruec.yaml and /etc/fruec.yaml)" in the diff for __init__.py ? [20:49:09] (CR) Ejegg: [V: +2 C: +2] Update dependencies [wikimedia/fundraising/dash/node_modules] - https://gerrit.wikimedia.org/r/539201 (owner: Ejegg) [20:49:20] ejegg: d'oh! It's a new Gerrit UI bug [20:49:26] Switch back to the old UI and all is bootiful [20:49:47] weird! Yeah, I'm still on the old UI [20:49:58] tried the new one for a bit & didn't like it [20:50:04] Mmmm yeah... K I guess that confirms it's a Gerrit bug [20:50:12] oh yeah new UI does weird stuff on merge [20:50:16] i noticed that yesterday [20:51:10] cstone: oh hmmm... K yeah I thought it was that I'd done the merge wrong somehow... thx..! [20:51:25] I actually abandoned a previous merge attempt [20:51:52] for me it wasn't showing any changes at all in the new UI while old UI looked fine [20:52:10] huh! that's really weird [20:52:31] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539202 [20:57:02] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539202 (owner: Ejegg) [20:57:06] Hmmm I don't see any bugs [20:57:08] https://bugs.chromium.org/p/gerrit/issues/list?q=&can=2 [20:57:24] (CR) AndyRussG: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539199 (owner: AndyRussG) [20:57:46] hmm, is it only messing up diffs on merge commits? [20:57:46] (Merged) jenkins-bot: Merge branch 'master' into deployment [wikimedia/fundraising/dash] (deployment) - https://gerrit.wikimedia.org/r/539202 (owner: Ejegg) [20:59:18] file that bug! [21:00:19] !log updated fundraising internal dashboard from 4473c65af0 to 69fdbec60d [21:00:21] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:10:00] !log update fruec from 97128874bf to c591bd653b [21:10:02] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:13:56] fr-tech help with fruec deploy needed...! I did fundraising_code_update -p fruec [21:14:18] and it said fruec revision changed from 97128874bf to c591bd653b [21:14:21] which is correct [21:14:40] However cat /srv/fruec/.version-stamp still has the old sha [21:15:02] and also of course so does the live code on civi1001 after I did rsync_blaster [21:15:38] (I blindly did rsync_blaster before checking the verison-stamp [21:15:40] ) [21:16:28] Oh and what's really weird is that the code itself in /srv/fruec is the new version [21:16:56] Weird. Did f_c_u have any unusual output? [21:17:11] XenoRyet: nope! [21:17:24] But the new code is there on both frpm1001 and civi1001 [21:17:29] (CR) Cstone: "Works nicely for Visa, Amex, Mastercard, and Discover. Also grabbing the correct card type from the normal form when using a different car" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [21:17:30] But on both, with the old version stamp [21:18:34] civi1001:~$ cat /srv/fruec/.version-stamp [21:18:36] 97128874bfe7cb4bb3348435a52b48bccbfab01f [21:19:14] while it should be c591bd653b570eb18ebc48a733e0527bb09b0b97 [21:19:20] Yea, that's confusing [21:19:39] https://gerrit.wikimedia.org/g/wikimedia/fundraising/FRUEC/+/c591bd653b570eb18ebc48a733e0527bb09b0b97 [21:21:26] dwisehaupt: ^ ? any thoughts? [21:21:53] I guess I might as well try running the job, in any case [21:22:08] seems like a bug in fundraising_code_update [21:24:34] looking [21:24:45] Yea, if the right code is live, might as well run the job. [21:26:07] Hmmm K... thx XenoRyet [21:26:12] Thx also dwisehaupt! [21:27:02] i'm not fully up on this deploy process yet. but if the version-stamp didn't get updated, the rsync would gladly still send it out. [21:28:32] dwisehaupt: right! Yeah that's apparently what happened... [21:30:46] i'm digging, but would need to find where that version-stamp is actually written. [21:33:55] yeah. the log entries show the correct revisions. [21:34:50] and the .version-stamp file has the correct permissions. [21:41:25] from what i can see, the fundraising_code_update has all the correct info showing the correct revision. is there any downside to running the command again? [21:45:22] I can't see there's any harm in that. [21:47:26] AndyRussG: the .version-stamp file is explicitly referenced in code in DonationInterface, SmashPig, and a couple of CiviCRM modules [21:48:05] so we should look into update failures to keep the message metadata nice in those codebases [21:48:29] but if you're not explicitly using it in fruec, the failure to update shouldn't affect your deploy in any way [21:52:43] (CR) Ejegg: "cstone to test the type-grabbing logic, you would need to proceed to the iframe, enter one of the test card numbers https://epayments.deve" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [21:52:50] ejegg: do you have an idea of where or how the .version-stamp file is written. i could only find references to it being read. [21:53:20] dwisehaupt: good question! I assumed it was part of fundraising_code_update [21:53:48] but i haven't looked into the internals of that command in a long time [21:55:41] oh jeez, terminal formatting escape codes right in the perl script - as if perl wasn't hard enough to read :) [21:55:53] ah. i see. i think it's buried in the FrDeploy perl module [21:56:25] around line 496 [21:57:45] dwisehaupt: where is the perl module? [21:58:15] /usr/share/perl5/FrDeploy.pm [21:58:29] thanks [21:59:15] ah, it only writes that if versionfile is defined for the project [22:00:01] hmm, which it is for fruec [22:00:09] lemme see if the other projects are in sync [22:00:57] hmm, dash is a couple versions back [22:01:04] interesting. [22:01:17] yeah, the config looks like it should be dtrt [22:07:07] (CR) Cstone: "> Patch Set 8:" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [22:11:55] (CR) Ejegg: "yeah, cstone and XenoRyet this definitely could use a unit test! See https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/tests/" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [22:13:01] dwisehaupt: so it looks like the versionfile must be being written with the old value of $project->{'revision'} [22:13:47] ohhh, that should be $project->{'new-revision'} [22:13:58] AndyRussG: I bet that bug has been there for years [22:14:15] nice catch! [22:14:41] between that and the gerrit UI, we owe you a bounty [22:17:03] fr-tech the new 2nd email text has 'This donation will be debited on or around the %%day%% of the month, until you ask us to stop. " in it, is there already something that grabs the calculated day? Or would we just use the day they donated on? [22:21:09] cstone we would use the day they donated on, but we might need to add a new parameter to the template context [22:21:39] (CR) XenoRyet: "I'm working on a test based on the testGoodSubmit, but when it hits the new code, staged data doesn't have a paymentProductId like it does" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [22:23:21] dwisehaupt: ejegg: nice catch on your part, rather!!! :D [22:23:41] K I'm gonna try running the fruec job [22:26:15] K it's running! [22:26:31] woo! [22:26:43] yay! [22:26:58] python3 at 25% CPU [22:27:38] Oh awwwwww [22:27:41] error!!!! [22:28:03] heh. [22:28:03] RuntimeError: Couldn't extract sample rate from filename: centralnotice-impressions-20180530-204353.log.gz [22:28:28] That'd be something we can fix easily with the config [22:28:42] dwisehaupt: I'll make a ticket? It's a mini change [22:28:49] sounds good. [22:28:50] cstone: dwisehaupt: also thanks! [22:29:07] i need to pop the kids to the orthodontist. back in a little while and i'll look at it. [22:29:13] I'll also purge the database so we can run the same job again [22:29:21] have fun! [22:36:17] fr-tech, could someone try cloning our expense form and seeing if they're able to link the clone to the exchange rates master doc by clicking the orange bottom on the second row? thanks! https://docs.google.com/spreadsheets/d/1-_2hGaUCZ8U7WzzX2RqT0dEIuBVWRzwxkjlfZhq9YNI/edit#gid=1483315145 [22:36:37] On it, one sec. [22:36:37] s/bottom/box/ [22:36:46] thanks XenoRyet [22:37:22] Yea, seemed to work for me. [22:37:38] awesome, thanks for confirming [22:37:42] No worries [22:37:50] back to Last Of Us! :) [22:37:59] Catching up? [22:38:03] yep [22:38:08] Have fun [22:38:14] in anticipation of #2 [22:38:24] I suspected as much [22:38:28] :0 [22:38:36] :) * [22:38:39] Need to do that myself [23:02:54] * dwisehaupt will watch you all play and not get sucked into himself. [23:22:08] jgleeson|away: working for me too now. Thanks for the fix! [23:28:15] (PS5) Ejegg: End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) [23:28:17] (PS2) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 [23:31:02] (PS1) Cstone: Add new parameter day_of_month to recurring notification email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539210 (https://phabricator.wikimedia.org/T288162) [23:41:31] at some point, i'm going to ask for some help looking at the service logs to see what we can usefully pull out for metrics. also i'll be asking if there are other places we could get them exported or written from.