[01:36:06] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Nuria) @jrobell Are the two analysts full timer or contractors? If contractors they would need an NDA o... [02:09:39] (CR) Eileen: [C: +2] "Doesn't look like any errant changes snuck in" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538713 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:10:39] (CR) Eileen: [C: +2] "Yep we should do this" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538714 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:12:50] (CR) Eileen: [C: +2] "Yep I agree" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538727 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:15:47] (Merged) jenkins-bot: End of year summary: code formatting [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538713 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:15:50] (Merged) jenkins-bot: End of year summary: declare implicit properties [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538714 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:21:35] (Merged) jenkins-bot: EOY summary: Quit filtering big query with function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538727 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [02:23:28] (CR) Eileen: [C: +2] "Looks good to me - I had some issues when I extended my clean up with some fails but jenkins is happy with these" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538663 (owner: Ejegg) [02:29:58] (Merged) jenkins-bot: More test cleanup [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538663 (owner: Ejegg) [02:42:09] (CR) Eileen: [C: -1] "Just spotted a easy-to-fix error" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:12:57] (PS6) Eileen: End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:12:59] (PS1) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [03:18:32] (CR) Eileen: [C: -1] "ejegg I also added a very preliminary test that I used to help me step through this https://gerrit.wikimedia.org/r/539218" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [09:12:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 3% free (177 MB out of 7628 MB) [09:17:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:22:13] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [09:27:15] PROBLEM - check_swap on frav1002 is CRITICAL: SWAP CRITICAL - 1% free (0 MB out of 7628 MB) [11:42:45] (PS3) Jgleeson: WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [11:47:12] (CR) jerkins-bot: [V: -1] WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [12:24:37] Dear Fun Draising:# [12:24:46] brilliant! [14:07:14] RECOVERY - check_swap on frav1002 is OK: SWAP OK - 15% free (1138 MB out of 7628 MB) [14:53:50] ejegg: I ran into a blocker on the payment submethods ticket. It looks like when we go down the path of just wanting to show an image for the payment submethod and not the select boxes, the code expects the submethod to have a 'label' property in all cases and isn't handling label_key message alternatives. I think we get away with this as it just raises an undefined index notice but it's [14:53:52] breaking tests since the code I've added wakes it up. I can fix it by adding awareness of the label_keys to the part where we generate the view data for the icon images, or I could just plug the gap in the tests but that feels bad. It feels like a the former would be a separate piece of work and I'm not sure how is involved. I'd be interested to hear your thoughts? [14:54:59] how much* is involved [14:56:08] the code in question is here https://github.com/wikimedia/mediawiki-extensions-DonationInterface/blob/master/gateway_forms/Mustache.php#L198 [14:57:21] jgleeson: oh, that sounds like a pretty simple fix [14:58:15] hmm, also, 'label' is pretty ambiguous in the context of the whole form [14:58:25] we should probably swap that for submethod_label [14:58:45] and just also feed in a submethod_label_key [14:59:02] in PHP we'd just wrap those assignments in an isset() guard [14:59:08] or !empty, whatevs [14:59:34] hmm my thinking was that I'd have to resolve the key though [14:59:37] then in the template we just put the same conditionals that we have on the usual submethod selector buttons [14:59:41] is that just as a simple as one functiomn? [14:59:44] function [15:00:16] jgleeson the template has access to the translation function [15:00:40] with {{ l10n payment_submethod_key }} [15:00:45] oops, meeting [15:01:59] thanks [15:06:14] (PS2) Cstone: Add new parameter day_of_month to recurring notification email. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539210 (https://phabricator.wikimedia.org/T288162) [15:35:09] (PS7) Ejegg: End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) [15:35:11] (PS3) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 [15:40:12] (PS1) Ejegg: Update exchange rates for 2019 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/539352 [15:40:46] fr-tech anyone got a minute to review that exchange rate update ^^^ ? [15:41:33] Argentinian donors in particular are getting a very inaccurate conversion atm [15:43:58] to say nothing of any potential Venezuelan donors, but we haven't gotten anything in VEB or VEF since the end of 2016 [15:47:33] (CR) Cstone: [C: +2] Update exchange rates for 2019 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/539352 (owner: Ejegg) [15:48:02] are those used for estimations then? [15:48:04] (Merged) jenkins-bot: Update exchange rates for 2019 [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/539352 (owner: Ejegg) [15:54:31] cstone yep, estimations on the payments forms [15:58:03] (PS4) Jgleeson: WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [15:58:05] (PS1) Jgleeson: Add support for payment submethod label_keys within Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) [15:58:23] oh man this ticket has turned into a real can of worms [15:58:40] back soon, gotta go get oscar from nursery! [16:00:37] (CR) jerkins-bot: [V: -1] WIP: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [16:19:16] Fundraising-Backlog, fundraising-tech-ops: Update glob setting in fruec.yaml for only json files - https://phabricator.wikimedia.org/T233967 (AndyRussG) [16:19:35] (PS2) Ejegg: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [16:22:13] (CR) Ejegg: "Thanks for the test!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [16:22:48] (CR) Ejegg: "The bad date formatting should be fixed in the next patch (there were extra percent signs before the format strings)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [16:38:06] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (Dwisehaupt) Hi Mariana, In order to correctly connect to our hosts, you need the ssh keypair, the ssh config, which basically tells the ssh program ho... [17:04:55] (PS1) Cdenes: Correct a typo in French, and disambiguate currency in all of email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539372 [17:44:07] (PS2) Cdenes: Correct a typo in French, and disambiguate currency in all of email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539372 [17:45:02] Fundraising-Backlog, fundraising-tech-ops: Update glob setting in fruec.yaml for only json files - https://phabricator.wikimedia.org/T233967 (Dwisehaupt) p:Triage→Normal a:Dwisehaupt This has been updated. [frack::puppet] e994e674 Adjust fruec glob pattern to only pull in json files [17:55:07] (PS1) Ejegg: Let Python guess PayPal audit encoding [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/539379 [17:55:49] (PS3) Cdenes: Correct a typo in French, and disambiguate currency in all of email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539372 [18:03:30] Fundraising Sprint Never Ending Query, Fundraising Sprint Office  , Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, and 2 others: Scrape HTML from IBM UI and bring queries into civi - https://phabricator.wikimedia.org/T230509 (Dwisehaupt) [18:26:01] fr-tech, does it make more sense to prefix new unit test cases within adyen as DLocal...Test or Adyen..Test [18:26:36] jgleeson let's leave AstroPay as astropay for now [18:26:57] I've been hearing for the past year that they're going to change again, so let's wait [18:27:10] (and Adyen has no plans to change afaik) [18:27:14] sorry I meant astropay #_# [18:27:39] ok thanks! [18:44:10] (PS5) Jgleeson: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [18:46:02] (CR) jerkins-bot: [V: -1] Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:02:08] (PS6) Jgleeson: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [19:04:01] (CR) jerkins-bot: [V: -1] Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:04:37] (CR) Ejegg: [C: +2] "Looks good! Thanks cdenes." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539372 (owner: Cdenes) [19:10:36] (Merged) jenkins-bot: Correct a typo in French, and disambiguate currency in all of email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539372 (owner: Cdenes) [19:17:21] (PS7) Jgleeson: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [19:18:30] (PS1) Jgleeson: WIP: add astropay/dlocal Form Load Test to confirm payment_submethod behaviour [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) [19:20:23] (CR) jerkins-bot: [V: -1] WIP: add astropay/dlocal Form Load Test to confirm payment_submethod behaviour [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [19:22:18] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/539402 [19:22:46] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/539402 (owner: Ejegg) [20:12:43] Fundraising-Backlog, fundraising-tech-ops: Pats has gotten a new yubikey and machine and needs the public keys for ssh and the yubikey updated for access. - https://phabricator.wikimedia.org/T232640 (Dwisehaupt) We needed to do a quick edit to the .ssh/config file for the username to match and she is all... [20:52:00] (CR) Ejegg: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/539402 (owner: Ejegg) [20:53:55] !log updated fundraising CiviCRM from 52d2a24404 to 6d90d0cf06 [20:53:57] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:06:25] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (Ejegg) p:Triage→Normal a:CDenes_WMF [21:06:59] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: French Thank You Email Typo - https://phabricator.wikimedia.org/T233620 (Ejegg) OK Camille, I deployed the change. Thanks for finding & fixing it! [21:13:53] fundraising-tech-ops: Update PayPal API certificate before October 13th, 2019 - https://phabricator.wikimedia.org/T233988 (Ejegg) [21:27:14] (CR) Ejegg: [C: -1] "Mustache.php edit looks good, but you need to change a different part of the template." (2 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [22:29:50] (PS9) XenoRyet: No Card Selector Ingenico Variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) [22:32:41] (PS10) XenoRyet: No Card Selector Ingenico Variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) [22:33:44] cstone: Not sure if you're done for the day or not, but I added that test to the no card select patch. [23:08:30] (CR) Ejegg: [C: -1] "Looks pretty good, just needs a little fix." (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [23:10:03] (PS2) Ejegg: Explicitly specify encoding per report type [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/539379