[00:56:50] (CR) Eileen: [C: -1] "Sorry ejegg I spotted one more little thing. With that fixed I think it's all good to go" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [00:57:26] (PS3) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [02:05:01] fr-tech if anyone is around... I'm gonna try re-running the initial FRUEC job in a minute... Hope no one has any objections! [02:41:47] or rather, how did it go, AndyRussG ? [02:42:05] ejegg: not done it yet! [02:42:20] just adding a debug flag to the commands in the job [02:42:31] para ver qué pex [02:42:57] ("pex" = softened version of "pedo") [02:43:27] ("pedo" = literally, "fart", or figuratively, what's wrong, or what's happening...) [02:43:43] https://www.asihablamos.com/word/palabra/Que%20pex.php [02:47:48] hehe, nice website [02:48:11] ooh, some colombianisms i haven't yet encountered [02:48:26] lotsa regionality in the speech here [03:12:20] ejegg: wanna take a peek at 422a0f7d48 in localsettings? [03:15:03] will do! [03:15:36] ejegg: thanks much! [03:19:33] AndyRussG: looks kashrut [03:20:33] oh, that's misused - like saying "it looks law" instead of "it looks legal" or "it looks illegal" [03:20:37] ejegg: ¡gracias carnal! [03:20:41] anyway, looks good [03:21:05] hah, thanks buddy [03:23:11] (CR) Ejegg: End of year summary template fixes (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:26:15] (PS8) Ejegg: End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) [03:26:15] (PS4) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) [03:31:19] ejegg: fr-tech: doin' a quick process-control deploy [03:34:35] fr-tech finally doing the fruec run again [03:35:40] Fundraising-Backlog, fundraising-tech-ops: Update glob setting in fruec.yaml for only json files - https://phabricator.wikimedia.org/T233967 (AndyRussG) [03:38:14] AndyRussG: is it all done? [03:44:02] guess I'll tune in tomorrow for the answer. ¡Que descanses! [03:46:03] ejegg|away: it tried! [03:46:04] and failed [06:06:37] (PS1) AndyRussG: Log configuration file seleciton at debug level [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539452 [06:34:02] (PS1) AndyRussG: Decode lines as utf8 for gzipped files [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539457 [06:46:11] Fundraising-Backlog, fundraising-tech-ops: Update glob setting in fruec.yaml for only json files - https://phabricator.wikimedia.org/T233967 (AndyRussG) Open→Resolved Thanks so much!! Works great! [07:25:02] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539475 (owner: L10n-bot) [07:26:11] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539475 (owner: L10n-bot) [07:36:39] (CR) jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/539467 (owner: L10n-bot) [07:54:54] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (MSuijkerbuijk_WMF) Hi Dallas, That would be great if we could connect on a call. I've tried to follow those instructions but when I add that on the te... [10:15:39] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (jrobell) Hi @Nuria and all, Jerrie is full time staff with a req number and Erin is a full time contr... [12:15:12] (CR) Jgleeson: "ohhh good spot. I completely missed the submethods loop change of scope. Thanks!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [12:45:47] (CR) Eileen: [C: +2] End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [12:48:38] (PS4) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [12:51:43] (Merged) jenkins-bot: End of year summary template fixes [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538974 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [12:54:33] (CR) jerkins-bot: [V: -1] Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [13:08:38] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog: oanda/expense report linkage error - https://phabricator.wikimedia.org/T233844 (DStrine) Open→Resolved [13:12:46] (PS5) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [13:19:27] (CR) jerkins-bot: [V: -1] Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [13:36:09] (PS1) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539534 (https://phabricator.wikimedia.org/T195907) [13:36:36] (PS2) Jgleeson: Add support for payment submethod label_keys within Mustache [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) [13:36:38] (PS8) Jgleeson: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) [13:36:40] (PS2) Jgleeson: WIP: add astropay/dlocal Form Load Test to confirm payment_submethod behaviour. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) [13:38:46] (CR) jerkins-bot: [V: -1] WIP: add astropay/dlocal Form Load Test to confirm payment_submethod behaviour. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [13:42:29] (CR) jerkins-bot: [V: -1] Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539534 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [13:44:57] (Abandoned) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539534 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [13:46:14] (PS6) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [13:52:12] (CR) jerkins-bot: [V: -1] Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [13:53:29] (PS7) Eileen: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) [13:59:00] (CR) Eileen: [C: +1] "This seems OK - I'll try to look again tomorrow with fresh eyes but" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [14:27:40] tzag fr-tech [14:34:26] tzag mepps! [14:34:43] tzag cstone! [14:34:57] and hello! good morning to you :) [14:35:03] oh wait, are you back in denver now? [14:35:08] not yet leaving tomorrow [14:35:24] oh good, although i guess i would have been right either way [14:36:08] haha yeah [14:45:14] (CR) Mepps: [C: +1] "I didn't test locally (how might I do this) but the logic looks sound. I sort of prefer the original if/else block just for clarity but I " [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539457 (owner: AndyRussG) [14:46:06] tzag fr-tech [14:46:49] (CR) Mepps: [C: +2] Log configuration file seleciton at debug level [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539452 (owner: AndyRussG) [14:46:57] hey AndyRussG! [14:54:17] mepps :) [15:45:33] (CR) AndyRussG: "> Patch Set 1: Code-Review+2" [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539452 (owner: AndyRussG) [15:58:02] (PS2) AndyRussG: Decode lines as utf8 for gzipped files [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539457 [16:13:21] (CR) AndyRussG: "> I didn't test locally (how might I do this) but the logic looks sound." [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539457 (owner: AndyRussG) [16:14:20] mepps: thanks for the code review! Updated ^ [16:14:54] Also btw, on this repo, sadly, +2 for CR is not enough to merge... You also have to do +2 verified, and then manually click the "Submit" button. Thanks again! [16:19:07] Fundraising-Backlog: UpDonate: match current best banner copy & logic - https://phabricator.wikimedia.org/T234059 (spatton) [16:23:09] hi fr-tech! [16:23:54] hello ejegg ! [16:24:05] ejegg: hellooooo [16:24:28] cstone: helloooo too [16:24:51] helllllo AndyRussG ! [16:25:10] heeeeello to tha two of ya! [16:26:39] (CR) Ejegg: [V: +2] Log configuration file seleciton at debug level [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539452 (owner: AndyRussG) [16:26:58] morning dwisehaupt [16:28:17] howdy. always fun to have a accidental forced reboot when you kill your windowmanager by pasting the wrong PID. :) [16:28:41] heh, nice [16:40:03] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Q2-FY2019-20-cleanup-list: Civi: create annual $ summary TY email button - https://phabricator.wikimedia.org/T221271 (Ejegg) In the interests of using the same template for the automated email and the on-dema... [16:45:55] Fundraising-Backlog: UpDonate: Can't give more than initial amount - https://phabricator.wikimedia.org/T233451 (Ejegg) Open→Resolved a:Ejegg [16:58:43] ejegg: thanks for the manual verifmerge! ^ [16:59:41] yw! [17:08:57] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frban1001.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (RobH) p:Triage→Normal [17:09:01] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frban2001.codfw.wmnet - https://phabricator.wikimedia.org/T234069 (RobH) p:Triage→Normal [17:09:14] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frban1001.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (RobH) [17:09:27] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frban2001.codfw.wmnet - https://phabricator.wikimedia.org/T234069 (RobH) [17:09:43] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frban1001.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (RobH) [17:09:48] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frban2001.codfw.wmnet - https://phabricator.wikimedia.org/T234069 (RobH) [17:29:32] (CR) Cstone: [C: +2] "Looks good, grabs the right type of card normally and using the variant, tests passing locally for me." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [17:31:25] Nice, that's for the review cstone. That's big for a friday deploy so I'll push it out on monday. [17:41:38] (CR) Ejegg: "Thanks for the comments, Eileen - I'll switch it to using the civi db name from the drupal db settings like we use elsewhere in our drupal" (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [17:51:02] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Nuria) @jrobell both need phabricator accounts and ldap accounts (via creating a user in wikitech) o... [17:52:26] (CR) Mepps: [V: +2 C: +2] Decode lines as utf8 for gzipped files [wikimedia/fundraising/FRUEC] - https://gerrit.wikimedia.org/r/539457 (owner: AndyRussG) [18:19:17] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (DStrine) Their phab accounts are @EYener and @jkumalah I have a wiktech account but I have forgotten... [18:22:44] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Nuria) @DStrine : just creating a user/password on https://wikitech.wikimedia.org/wiki/Main_Page is enough [18:24:15] (PS5) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) [18:30:50] (PS8) Ejegg: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [18:31:16] (CR) Ejegg: [C: +2] "Thanks!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [18:37:28] (Merged) jenkins-bot: Add unit test for render eoy receipt email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539218 (https://phabricator.wikimedia.org/T195907) (owner: Eileen) [18:44:06] wow, cloudflare is supporting QUIC [18:44:17] and QUIC is gonna be HTTP/3 [18:44:34] feels like protocol evolution is happening very QUICly [18:44:56] nice explanatory thread here: https://twitter.com/jgbarah/status/1177480451193131009 [18:54:51] ooh thanks for the link ejegg also quiche [19:00:44] yeah, but it's quiche made with rust - eeew [19:01:33] mmm iron [19:10:15] interesting ejegg! but yeah cstone, now i want quiche [19:10:21] but not rusty quiche [19:34:01] mepps ok, I think I'm done sending vacation requests - thanks for the speedy approval! [19:34:24] trying to get at least one full day off in each city [19:35:10] then Nov 7 I'll be on a plane most of the day [19:35:35] oh, I should decline some meetings during that Civi event too [19:35:51] starting next week! [20:02:47] (PS6) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) [20:02:49] (PS1) Ejegg: End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) [20:20:20] (Merged) jenkins-bot: No Card Selector Ingenico Variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/537775 (https://phabricator.wikimedia.org/T224929) (owner: XenoRyet) [20:20:47] Wow, that took a while to merge. [20:21:04] oh wow [20:29:45] I mean, I wasn't waiting on it or anything, but I wonder what zuul's been doing all day. [20:36:47] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Civi: underscore in email address slows search - https://phabricator.wikimedia.org/T234100 (MBeat33) [20:43:59] fr-tech who here uses MySQL Workbench? [20:44:03] cstone you use it, right? [20:44:09] yep [20:45:49] cstone: ah cool! One of the new FR analytics folks e-mailed me asking for help setting it up... I can cc you on the reply, since I'm sure you'd be of more assistance than me, okok? [20:45:53] thx in advance! [20:45:58] sure! [20:46:01] :) cool [20:48:24] Done, thanks! [20:59:01] today is a good long day of running a vm inside a vm talking to another vm. package building sure can be interesting. [21:33:42] (PS1) Ejegg: DB switcher: reformat code for drupal style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539626 [21:37:16] (PS1) Ejegg: Rewrite unused get_prefix fn for EOY email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539627 (https://phabricator.wikimedia.org/T195907) [21:40:37] (PS7) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) [21:40:38] (PS2) Ejegg: End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) [21:46:40] (CR) jerkins-bot: [V: -1] End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [21:46:47] (CR) jerkins-bot: [V: -1] End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [23:44:26] (PS8) Ejegg: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) [23:44:28] (PS3) Ejegg: End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) [23:44:30] (PS1) Ejegg: EOY summary: check later for missing config [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539639 (https://phabricator.wikimedia.org/T195907) [23:44:32] (PS1) Ejegg: EOY summary: fix string extraction & test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539640 (https://phabricator.wikimedia.org/T195907) [23:51:38] (CR) jerkins-bot: [V: -1] EOY summary: fix string extraction & test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539640 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [23:52:04] (CR) jerkins-bot: [V: -1] End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [23:52:11] (CR) jerkins-bot: [V: -1] End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg)