[03:00:06] (CR) AndyRussG: "See a few inline notes for minor things to fix in follow-on changes... Thanks so much for all this work!!!" (3 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [03:00:12] (CR) AndyRussG: [C: +2] Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [03:04:02] (Merged) jenkins-bot: Campaign fallback [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/517931 (https://phabricator.wikimedia.org/T124969) (owner: Vedmaka Wakalaka) [03:04:37] (CR) AndyRussG: "Nice work!!!! Just one nit-pick... (See inline.)" (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/538967 (https://phabricator.wikimedia.org/T232859) (owner: Mepps) [03:52:33] (CR) Eileen: [C: +2] End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:53:19] (CR) Eileen: [C: +2] End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:58:18] (Merged) jenkins-bot: End of year summary: fix calculation [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539157 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:58:20] (Merged) jenkins-bot: EOY summary: fix string extraction & test data [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539640 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [03:59:33] (Merged) jenkins-bot: End of year summary: add fn visibility [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539615 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [12:46:33] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (EYener) Hi @Nuria I have created a Wikitech account. My username is my full name, Erin Yener. Please le... [12:48:08] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (jkumalah) HI @Nuria my wikitech is aslo my full name, Jerrie Kumalah [14:26:19] ejegg: around? [14:29:12] what's up Jeff_Green ? [14:30:13] hey, I've been looking at the task of web endpoint monitoring, and hacked a parallel web getter that we can use to test and roll up a bunch of endpoints into a single nagios metric, and also inject to prometheus/grafana [14:31:04] now I'm at the point of configuring, i.e. which endpoint URLs to test for each situation [14:31:36] can you help me go through that and figure out what we want to check from payments, payments listener, and/or civi hosts? [14:33:00] Jeff_Green: cool! [14:33:15] the config is in puppet/hieradata/site/common.yaml [14:33:19] exit [14:33:25] whoops ^^^ :-) [14:33:39] so I guess the easiest to start with would be the minfraud and ingenico connectivity checks we had been doing already [14:34:10] yep, I've got those in the payments: section [14:34:45] It'll be simple to find the URLs for the other processors, but would we want to make authenticated requests? [14:34:49] starting to look at payment_listener, i know some of what I have is not correct, have been spelunking the various configs trying to figure out what we hit from there [14:35:17] or is getting a 'permission denied' response just fine for connectivity checks? [14:35:18] good question, I don't know. I can modify it to do that if we want, but I was looking at it more as a connectivity test so far [14:35:35] the script is configurable to tolerate whatever we want [14:35:36] ok, as long as we're not setting off any intrusion detection [14:35:47] ha I wondered about that :-) [14:35:48] i imagine it would run pretty often [14:35:59] the way it is now, it will run every 5 minutes, one hit per endpoint [14:36:31] cool, I'll spend a bit of time today gathering those URLs [14:36:33] oh also from every host, so I guess in terms of payments that's 7 hits per minute [14:36:52] is there an associated phab? [14:36:53] in the end it's the same as what we've been doing as individual requests from nagios [14:37:15] there's a task I think you posted a while back re. adding some endpoints, finding... [14:39:02] https://phabricator.wikimedia.org/T212252 [14:41:07] Fundraising-Backlog, fundraising-tech-ops: Create icinga alert for connectivity to Ingenico Connect endpoint - https://phabricator.wikimedia.org/T212252 (Jgreen) >>! In T212252#4860836, @Jgreen wrote: > We already get a lot of middle-of-the-night alerts about hiccups in endpoint connectivity, regardless... [14:41:45] ignore that ^^^ it's just rebroadcasting an old comment [14:49:18] thanks! [14:53:39] Jeff_Green did you see https://phabricator.wikimedia.org/T233846 ? We need to replace the PayPal API cert before 13 Oct. I've downloaded a new one and dropped it in my homedir on the puppet master. [14:55:06] Yes, thanks for tasking that, saw it this AM. I was going to let Dallas take it for more puppet exposure. [14:55:13] sounds good! [14:55:20] should be quick, we'll probably get it done today [14:55:29] nice [14:57:05] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Nuria) ping @herron I guess jerrie can be added to wmf and Erin to nda groups in ldap? [15:08:09] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (EYener) Hi @Nuria I do have an LDAP account: eyener-ctr I'm not certain if/what groups I belong to, how... [15:52:58] Fundraising-Backlog, FR-Adyen: Adyen & India: prevent donate.wiki URL from seeming to offer a recurring option - https://phabricator.wikimedia.org/T234235 (MBeat33) [17:26:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: More small fixes needed for Campaign fallback - https://phabricator.wikimedia.org/T234248 (AndyRussG) [17:48:41] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Review Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) [17:53:53] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make form variant=labels default - https://phabricator.wikimedia.org/T234252 (Pcoombe) [18:09:59] XenoRyet: want to do a payments-wiki deploy? Sounds like folks are eager to see that variant in action. [18:10:26] Oh, right. I had forgotten that was ready to go. I'll push it out now. [18:19:41] (PS1) XenoRyet: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/539925 [18:22:49] (CR) XenoRyet: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/539925 (owner: XenoRyet) [18:31:03] Fundraising-Backlog: Rework Jimmy language on Endowment donate page & update aesthetic to match new site - https://phabricator.wikimedia.org/T228773 (kaythaney) Shared this update with @spatton & @Pcoombe last Friday -- ask is to update the Endowment donatewiki page with the content and edits [[ https://docs... [18:32:25] Fundraising-Backlog: Rework Jimmy language on Endowment donate page & update content - https://phabricator.wikimedia.org/T228773 (kaythaney) [18:57:10] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/539925 (owner: XenoRyet) [19:02:42] (PS1) XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/539939 [19:07:23] (CR) XenoRyet: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/539939 (owner: XenoRyet) [19:07:57] (PS1) Ejegg: EOY summary: split calculation into two steps [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [19:13:53] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/539939 (owner: XenoRyet) [19:15:30] !log Updated payments-wiki from 5193dcdfa9 to 80dead6444 [19:15:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:17:51] (CR) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/539939 (owner: XenoRyet) [19:19:13] Fundraising-Backlog: Example Phabricator spec - https://phabricator.wikimedia.org/T234260 (DStrine) [19:20:28] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (herron) Open→Resolved a:herron `jkumalah` has been added to ldap group `wmf`, `eyener` has... [19:20:46] Fundraising-Backlog: Example Phabricator spec - https://phabricator.wikimedia.org/T234260 (DStrine) [19:22:08] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (herron) [19:24:57] (PS2) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [19:26:57] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Ingenico, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Not required to choose card type in new Ingenico iframe? - https://phabricator.wikimedia.org/T224929 (XenoRyet) @Pcoombe @spatton We did set this up as a variant, and it is deployed to p... [19:28:41] (PS3) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [19:52:44] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Make form variant=labels default - https://phabricator.wikimedia.org/T234252 (DStrine) [19:57:02] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update IBM with TargetSmart Age data - https://phabricator.wikimedia.org/T233744 (DStrine) [19:58:05] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, User-TheSandDoctor: CentralNotice needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233538 (DStrine) [19:59:48] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (Nuria) Please make sure you can access https://turnilo.wikimedia.org [20:30:15] (PS4) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [20:31:08] Fundraising-Backlog, Analytics, Operations, SRE-Access-Requests: Banner History and page view data access for fundraising analysts - Jerrie and Erin - https://phabricator.wikimedia.org/T233636 (jkumalah) @Nuria I have access. Thank you! [21:15:25] (PS1) Ejegg: db_switcher - don't call get_prefix statically [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539971 (https://phabricator.wikimedia.org/T195907) [21:15:50] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frban1001.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Jclark-ctr) [21:16:31] (PS2) Ejegg: db_switcher - don't call get_prefix statically [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539971 (https://phabricator.wikimedia.org/T195907) [21:20:51] (PS1) AndyRussG: CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/539975 (https://phabricator.wikimedia.org/T233538) [21:35:26] dang, the summary calculation is taking forever on staging [21:35:46] I could definitely break that into a bunch of simpler queries using temp tables [21:55:19] (CR) AndyRussG: [C: +2] CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/539975 (https://phabricator.wikimedia.org/T233538) (owner: AndyRussG) [22:00:10] (Merged) jenkins-bot: CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] (wmf_deploy) - https://gerrit.wikimedia.org/r/539975 (https://phabricator.wikimedia.org/T233538) (owner: AndyRussG) [22:15:48] (PS3) Ejegg: db_switcher - don't call get_prefix statically [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539971 (https://phabricator.wikimedia.org/T195907) [22:15:50] (PS5) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [22:26:00] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for kthaney - https://phabricator.wikimedia.org/T232647 (Dwisehaupt) Open→Resolved p:Triage→Normal [22:27:53] Fundraising-Backlog, fundraising-tech-ops: Pats has gotten a new yubikey and machine and needs the public keys for ssh and the yubikey updated for access. - https://phabricator.wikimedia.org/T232640 (Dwisehaupt) Open→Resolved Worked with @Ppena and she corrected a setting in her ssh config file.... [22:32:03] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (Dwisehaupt) Worked with @MSuijkerbuijk_WMF to update the user setting in her ssh config file and she was able to connect. @CCogdill_WMF - Could you ad... [22:32:28] (PS6) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [22:34:13] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst (contractor) - Erin Yener - https://phabricator.wikimedia.org/T232982 (Dwisehaupt) @Cstone spent some time this morning with @EYener working with vagrant to get a mysql workbench setup. [22:47:28] (PS7) Ejegg: EOY summary: split calculation, include more donations [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/539940 (https://phabricator.wikimedia.org/T195907) [22:48:16] fr-tech OK, ^^^ seems to work pretty well with our dataset [23:02:39] (PS1) AndyRussG: Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539986 [23:04:24] (CR) AndyRussG: [V: +2 C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/FRUEC] (deployment) - https://gerrit.wikimedia.org/r/539986 (owner: AndyRussG) [23:05:30] fr-tech gonna deploy and try new FRUEC ^ all good? [23:16:28] (PS1) Niharika29: CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] (wmf/1.34.0-wmf.24) - https://gerrit.wikimedia.org/r/539990 (https://phabricator.wikimedia.org/T233538) [23:17:23] yep AndyRussG [23:18:13] ejegg: thanks! [23:18:45] (CR) Niharika29: [C: +2] "SWAT" [extensions/CentralNotice] (wmf/1.34.0-wmf.24) - https://gerrit.wikimedia.org/r/539990 (https://phabricator.wikimedia.org/T233538) (owner: Niharika29) [23:21:43] (Merged) jenkins-bot: CentralNotice: Replace deprecated editToken with csrfToken [extensions/CentralNotice] (wmf/1.34.0-wmf.24) - https://gerrit.wikimedia.org/r/539990 (https://phabricator.wikimedia.org/T233538) (owner: Niharika29) [23:23:38] !log updated fruec from c591bd653b to 18d89675d0 [23:23:40] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:26:49] fr-tech okok deployed, now gonna try running it again!!! [23:30:28] fr-tech fruec failed again! is it ok if I try again later this evening, even if mostly no one is around, or should I wait for tomorrow? [23:45:51] fr-tech also we just deployed CN update for core compatibility to the main cluster