[00:13:42] (PS1) Ejegg: Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540250 [00:13:52] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540250 (owner: Ejegg) [00:15:48] (PS4) Ejegg: Add support for payment submethod label_keys within Mustache when single submethod shown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:15:53] (CR) Ejegg: [C: +2] Add support for payment submethod label_keys within Mustache when single submethod shown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:17:40] (Merged) jenkins-bot: Add support for payment submethod label_keys within Mustache when single submethod shown [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539356 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:39:27] (PS10) Ejegg: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:40:25] (CR) Ejegg: [C: +2] "This works! That method is starting to get a little hard to follow, though I can't think of an obvious simplification. Might be worth revi" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:41:51] (Merged) jenkins-bot: Add in support for a preset payment_submethod passed in the querystring. Passing a payment_submethod results in other available submethods being hidden. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539185 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:43:53] (PS2) Ejegg: Add nodehtml & nodehtmlmatches checks to verifyFormOutput test helper. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540174 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:44:06] (CR) Ejegg: [C: +2] "Nice addition to the ol toolkit!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540174 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:45:45] (Merged) jenkins-bot: Add nodehtml & nodehtmlmatches checks to verifyFormOutput test helper. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540174 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:46:35] (PS4) Ejegg: Add astropay/dlocal Form Load Test to confirm preset payment_submethod behaviour. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:47:12] (CR) Ejegg: [C: +1] "Thanks for the test! Noticed one bit of funkiness in the setup, but it doesn't seem to prevent it from working." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [00:54:52] !log updated fundraising CiviCRM from 6d90d0cf06 to 12c5727a23 [00:54:54] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [05:30:24] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540170 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [05:36:12] (Merged) jenkins-bot: End of year summary: output job ID after calculate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540170 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [05:53:10] Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update IBM with TargetSmart Age data - https://phabricator.wikimedia.org/T233744 (Eileenmcnaughton) a:Eileenmcnaughton [05:53:15] Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Update IBM with TargetSmart Age data - https://phabricator.wikimedia.org/T233744 (Eileenmcnaughton) [05:54:12] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (Eileenmcnaughton) @LeanneS this is still ope... [05:55:08] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising Sprint T 2019, Fundraising-Backlog: Data Exported from Civi contains spaces - https://phabricator.wikimedia.org/T231330 (Eileenmcnaughton) @dstrine @NNichols I still don't know how to replicate thi... [05:57:42] (PS21) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) [06:15:30] Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (Eileenmcnaughton) a:Eileenmcnaughton [06:15:31] Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Change in Stripe import file - https://phabricator.wikimedia.org/T230513 (Eileenmcnaughton) [06:15:41] (PS1) Eileen: Update Stripe import file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540258 (https://phabricator.wikimedia.org/T230513) [06:30:29] this is a trivial change needing review - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/540258/ - It just reflects a Stripe csv change [06:42:37] Fundraising-Backlog, fundraising-tech-ops: fundraising dev/database access request for Mariana Suijkerbuijk - https://phabricator.wikimedia.org/T232633 (MSuijkerbuijk_WMF) Thanks Dallas [07:25:44] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540288 (owner: L10n-bot) [07:36:06] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540288 (owner: L10n-bot) [14:06:06] cstone: which patch is it again that you needed reviewing? I thought it was the second email patch but it looks like that's already been +2'd [14:06:55] I can see you have a WIP patch? [14:07:05] * jgleeson is looking at this list https://gerrit.wikimedia.org/r/#/q/projects:wikimedia/fundraising+status:open [14:07:55] jgleeson: she moved it back to WIP yesterday after tech talk [14:08:16] we realized it needed some more work to make the '5th' eg. work in translation [14:10:32] ah ok makes sense. thanks ejegg [14:10:51] thanks for the review on my patches ejegg ! [14:10:56] sure thing! [14:10:57] I'll return the favour shortly :) [14:11:01] :) [14:11:28] how long is your flight? [14:13:11] there's a 1 hr flight to bogota, then it's... 10.5 hrs to Barcelona [14:13:15] is that right? [14:13:27] uff [14:13:34] oh man. I hope you have some good reading materials :) [14:13:51] I hope I sleep! [14:13:58] lol [14:20:48] so fr-tech for those interested I finally found a way to find all gerrit open patches belonging to fr-tech across multiple projects https://gerrit.wikimedia.org/r/#/q/ownerin:fr-tech+status:open [14:21:14] ownerin: was the search operator I was looking for [14:21:16] (PS2) Ejegg: Update Stripe import file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540258 (https://phabricator.wikimedia.org/T230513) (owner: Eileen) [14:21:23] (CR) Ejegg: [C: +2] Update Stripe import file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540258 (https://phabricator.wikimedia.org/T230513) (owner: Eileen) [14:21:39] jgleeson: oh, nice! [14:26:23] dang - I got pickpocketed [14:26:31] oh no! [14:26:47] las ramblas ? [14:27:13] yeah I was about to go into La Sagada Familia & looked for my wallet & it wasn't there - missing the Sagrada was probably the worst of it [14:27:55] sorry to hear that eileen. it might be worth contacting the travel team [14:28:00] I thought about still going in (had my ticket) but wanted to check the cafe I'd just been in [14:28:27] I called international SOS - but it might wind up easier to borrow money from a civi person in the end [14:28:40] (Merged) jenkins-bot: Update Stripe import file [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540258 (https://phabricator.wikimedia.org/T230513) (owner: Eileen) [14:29:08] otherwise I have to get an advance & repay WMF I think - which is likely harder than borrowing from a person - esp if I can borrow from Chris who will have an NZ bank account [14:29:43] argh! Sorry to hear that eileen [14:30:02] last time I was in BCN someone tried to steal my backpack [14:30:50] they went about it super casually though - instead of grabbing and running they just picked it up like it was theirs and started walking off at a normal pace [14:30:59] yeah - I wasn't feeling like I had anyone nearby especially but it seems more likely than me having left my zip open & it having fallen out - given the area's reputation [14:31:09] our friend saw though, and ran up and screamed at the guy who dropped the bag [14:31:43] (my first assumption was that I'd somehow left it at the care 1km up the road) but nothing there when I got back [14:31:45] ccccccknfuvhdnlndvburjftjbdnijrgjrjtfhvnclvi [14:31:46] ugh yeah, and someone stole Adam's wife's purse when they were there in 2016 [14:31:54] well, at least you still have your yubikey [14:31:58] lol [14:32:05] yeah that's a relief [14:32:16] lol [14:32:20] still have all the important things - phone, laptop, yubikey & passport [14:32:53] sucks that you missed out on Sagrada Familia though :( [14:33:06] (just catching up on mattermost) [14:33:47] Yeah - I could try again tomorrow maybe - not sure - I figure I'll wait until I catch up with people in 90 mins before trying to figure it out [14:34:34] I also stuffed up going to Gaudi House - I left getting there quite tight & then realised it was sooner than I thought. Still it was a 12 min walk & I got there not much after I should have but it didn't seem right when I got there [14:34:52] then I realised I was at Gaudi House real estate agency.... [14:35:09] so not a great tourism day success [14:35:36] awww [14:35:59] there's a nice gaudi building not too far from plaza catalunya [14:37:25] from the north corner, just walk northwest on passeig de gracia 4 blocks and it's on your right [14:37:47] https://en.wikipedia.org/wiki/Casa_Batll%C3%B3 [14:38:47] err, on your left [14:39:34] that looks cool - I think there are maybe half a dozen people meeting up in about 80 mins for tapas & drinks so I won't make any decisions about tomorrow until I catch up with them [15:11:26] ejegg: should I push out that stripe fix - are there any other's queued - I didn't hear back from Caitlin on the Silverpop one [15:11:34] Fundraising-Backlog: Update English Thank You email - https://phabricator.wikimedia.org/T234446 (spatton) [15:21:39] eileen: should be clear to push out the stripe fix [15:21:55] ok - I'll do that one [15:22:05] I just deployed the current state of the EOY, so nothing else is in the queue [15:22:28] fr-tech: what's the good word for Scrum of Scrums? [15:22:51] ejegg: cool - I saw you are going to send them out quite slowly [15:23:20] no news from the riddermark today ejegg [15:23:23] eileen: or at least start slowly, in case donor services gets a lot of questions [15:23:26] jgleeson: :) [15:23:34] yeah makes sense [15:27:34] (PS1) Ejegg: Disambiguate EGP currency symbol [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540426 (https://phabricator.wikimedia.org/T223996) [15:32:00] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540430 [15:34:03] (CR) Eileen: [C: +2] "Ok - this does what was requested" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540426 (https://phabricator.wikimedia.org/T223996) (owner: Ejegg) [15:34:23] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540430 (owner: Eileen) [15:40:56] (Merged) jenkins-bot: Disambiguate EGP currency symbol [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540426 (https://phabricator.wikimedia.org/T223996) (owner: Ejegg) [15:41:17] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540432 [15:42:36] ejegg: if I have no T-ideas can I just vote - I'm all in on Trojan Horse Whisperer & Total reset --hard & Terabytes of Endearment [15:43:41] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540432 (owner: Eileen) [15:43:59] hmm zuul is being slow :-( [15:45:49] ejegg hey thx nothing for SoS from me today [16:25:11] fr-tech I've got to talk to a locksmith for a few min, might be late to stdup [16:48:02] Fundraising Sprint T 2019, Fundraising-Backlog: Update currency symbol in Thank You email for EGP - https://phabricator.wikimedia.org/T223996 (Ejegg) p:Triage→Low a:Ejegg [16:50:22] Fundraising Sprint T 2019, Fundraising-Backlog: Update currency symbol in Thank You email for EGP - https://phabricator.wikimedia.org/T223996 (Ejegg) I had the file with these symbols open and it was one keystroke to fix, so bringing this into sprint. [17:01:18] (PS2) Ejegg: wmf_communication: reformat files for drupal standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540231 [17:01:19] (PS2) Ejegg: Templating: make l10n_number available to templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540232 (https://phabricator.wikimedia.org/T220636) [17:17:42] ft-tech: I've gotta run and pick up a prescription for Cat, probably be late to -talk. [17:28:56] Fundraising-Backlog, Continuous-Integration-Infrastructure, Release-Engineering-Team-TODO, Release-Engineering-Team (CI & Testing services): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (Jdforrester-WMF) Hey, happy to help ou... [17:31:08] Fundraising-Backlog, Continuous-Integration-Infrastructure, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (Jdforrester-WMF) [18:22:39] (CR) Ejegg: "One thing noted by CStone in tech talk - when the contact's display name is based on their email address, the email amender does not fix t" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [18:23:00] Fundraising-Backlog, Continuous-Integration-Infrastructure, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (Jdforrester-WMF) a:Jdforre... [18:37:33] Wikimedia-Fundraising-Banners, Wikimedia-Portals: Run fundraising messages on portal in France - https://phabricator.wikimedia.org/T234466 (Pcoombe) [18:40:09] Wikimedia-Fundraising-Banners, Wikimedia-Portals: Run fundraising messages on portal in France - https://phabricator.wikimedia.org/T234466 (Pcoombe) a:Pcoombe [18:41:21] Wikimedia-Fundraising-Banners, Wikimedia-Portals: Run fundraising messages on portal in "Big English" countries - https://phabricator.wikimedia.org/T234467 (Pcoombe) [19:15:56] (PS1) Ejegg: WIP End of year summary: add Civi activity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540468 (https://phabricator.wikimedia.org/T195907) [19:38:34] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (LeanneS) @Eileenmcnaughton Yes, done! Thank you! [19:50:16] (CR) Cstone: [C: +2] wmf_communication: reformat files for drupal standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540231 (owner: Ejegg) [19:51:00] (CR) Cstone: [C: +2] Templating: make l10n_number available to templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540232 (https://phabricator.wikimedia.org/T220636) (owner: Ejegg) [19:55:02] (CR) Jgleeson: [C: +2] "Code looks good. Tests passing." [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/539379 (owner: Ejegg) [19:55:47] (Merged) jenkins-bot: Explicitly specify encoding per report type [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/539379 (owner: Ejegg) [19:56:32] (Merged) jenkins-bot: wmf_communication: reformat files for drupal standard [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540231 (owner: Ejegg) [19:57:12] (Merged) jenkins-bot: Templating: make l10n_number available to templates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540232 (https://phabricator.wikimedia.org/T220636) (owner: Ejegg) [20:10:53] (PS5) Jgleeson: Add astropay/dlocal Form Load Test to confirm preset payment_submethod behaviour. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) [20:14:22] (CR) Jgleeson: Add astropay/dlocal Form Load Test to confirm preset payment_submethod behaviour. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [21:02:08] Fundraising Sprint Rocky Horror Presentation Layer, Fundraising Sprint Sysadmin Kane, Fundraising Sprint T 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Gender for original TargetSmart list - https://phabricator.wikimedia.org/T231362 (Eileenmcnaughton) Open→Resolved [21:17:40] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540430 (owner: Eileen) [21:17:49] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540432 (owner: Eileen) [23:05:51] (CR) XenoRyet: [C: +2] "Looks good. Works with the other variants just fine." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540201 (https://phabricator.wikimedia.org/T234252) (owner: Ejegg) [23:07:23] (Merged) jenkins-bot: Labels for form fields no longer a variant [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/540201 (https://phabricator.wikimedia.org/T234252) (owner: Ejegg) [23:44:12] (CR) XenoRyet: [C: +2] "Yep, looks good to go now." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson) [23:45:53] (Merged) jenkins-bot: Add astropay/dlocal Form Load Test to confirm preset payment_submethod behaviour. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/539401 (https://phabricator.wikimedia.org/T231452) (owner: Jgleeson)