[02:15:51] (PS1) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [02:21:53] (CR) jerkins-bot: [V: -1] Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) (owner: Eileen) [03:23:17] (PS2) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [03:29:49] (CR) jerkins-bot: [V: -1] Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) (owner: Eileen) [03:36:50] (PS1) Eileen: Add setting to move dedupe over to extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543747 (https://phabricator.wikimedia.org/T235450) [04:05:55] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (Eileenmcnaughton) [04:15:09] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Civi dedupe: make sure Mailing Events data is merged - https://phabricator.wikimedia.org/T220149 (Eileenmcnaughton) [04:18:35] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: New dedupe blocking issue - on hold - https://phabricator.wikimedia.org/T221914 (Eileenmcnaughton) The issue of opting out is the subject of https://phabricator.wikimedia.org/T231254 - I'm goi... [04:18:37] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: New dedupe blocking issue - on hold - https://phabricator.wikimedia.org/T221914 (Eileenmcnaughton) [04:18:39] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: New dedupe blocking issue - on hold - https://phabricator.wikimedia.org/T221914 (Eileenmcnaughton) I added this to the sprint as we discussed during sprint planning I would bring in the phabs... [04:18:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Are we opting out too aggressively - https://phabricator.wikimedia.org/T231254 (Eileenmcnaughton) Related discussion https://phabricator.wikimedia.org/T221914 [04:57:07] Fundraising-Backlog: Make monthly convert default and add options for on/off switch - https://phabricator.wikimedia.org/T235689 (Ammarpad) [08:36:09] (CR) Ejegg: [C: +2] Change 2nd monthly convert email to use original_currency. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543715 (https://phabricator.wikimedia.org/T235195) (owner: Cstone) [08:42:56] (Merged) jenkins-bot: Change 2nd monthly convert email to use original_currency. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543715 (https://phabricator.wikimedia.org/T235195) (owner: Cstone) [14:46:13] fundraising-tech-ops, Icinga, Operations: dwisehaupt needs access to iginca for frack hosts - https://phabricator.wikimedia.org/T235676 (crusnov) p:Triage→Normal [15:06:25] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (Ejegg) Hi @EMartin, how are you getting the numbers for the google spreadsheet? If I do this search in Civi: > Date Received - greater than or equal to "... [15:37:45] (CR) Mepps: "This looks good! Does nullifying the campaign in state nullify the variable in index.js?" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (owner: Jgleeson) [15:39:26] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (EMartin) Hi Elliott, I just reran the recon report out of civi, which I use for all recons and came up with the same result (give or take a few $) for A... [15:41:14] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (EMartin) As you can see, Astropay doesn't align to your numbers, however, Amazon and Adyen match to the respective provider portals. Astropay/Dlocal see... [15:56:25] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (Ejegg) a:Ejegg [16:12:27] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (Ejegg) OK, digging in I see there's a filter in that report on the 'to_financial_account_id' of the civicrm_financial_trxn table, and that for AstroPay /... [16:22:51] Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, and 4 others: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (DStrine) @spatton @Pcoombe @CCogdill_WMF @TSk... [16:38:37] Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, and 4 others: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (spatton) Yes. @CCogdill_WMF and I drafted cop... [17:26:50] (Abandoned) Pcoombe: Use currency symbol [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/531718 (owner: Pcoombe) [17:33:57] ejegg: I wonder if I could get you to look at this one https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/543021/ [17:36:57] sure thing eileen [17:50:22] (PS1) Pcoombe: Updated English thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543909 (https://phabricator.wikimedia.org/T234446) [17:51:39] Hi, can someone in fr-tech cherry pick ^ onto civicrm staging so I can send some test emails? Not urgent, I probably won't get back to it until tomorrow [17:57:03] (CR) jerkins-bot: [V: -1] Updated English thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543909 (https://phabricator.wikimedia.org/T234446) (owner: Pcoombe) [17:57:39] :( [18:08:24] pcoombe: ok, I just pulled it [18:08:28] I'll take a look at that test [18:08:44] (pulled it onto staging, that is) [18:10:38] ahh, it's having trouble creating the civiMail record [18:10:42] > Could not find template info comment in thank you email template with subject Your donation. Your curiosity. Your Wikipedia. [18:10:52] hmm, so those are referring [18:11:02] to a comment we would always place at the bottom [18:11:09] when we harvested a TY mail template from met [18:11:11] *meta [18:30:45] fundraising-tech-ops: fundraising access request for Nora Nichols - https://phabricator.wikimedia.org/T232623 (Jgreen) Open→Resolved Closing this task, what remains is mostly user-side stuff [18:30:47] fundraising-tech-ops: Access to the ssh frdev1001 server - https://phabricator.wikimedia.org/T232401 (Jgreen) [18:38:24] (CR) Ejegg: [C: +2] "Looks like this should work!" (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [18:38:26] (PS6) Ejegg: Step one on prospect data restore - Move any prospecting records from deleted contacts to contacts they were merged to with none. * * There is an issue whereby seemingly some UI merges of contacts have not carried across the * prospecting records. * * There are some trickinesses here * 1) what to do if the prospect data is not missing but wholly or in part different? * 2) what to do if the contact has been [18:38:27] issues & hope they go away. * * Specifically this update only deals with fixing the situation where the merged-to-record has * no row whatsoever in the prospect custom data table. There are 3918 contacts in this situation. * This is more than the 3215 where the deleted contact has 'some data' in one of the following 3 fields * - net worth * - family composition * -income * and the merged-to-contact has NULL in all 3 fi [18:38:28] mentioned fields. * * I haven't dug too heavily into whether the extra 400 have all null info or some info - it seems * safe & sensible to move whatever data there is across. * * In a token note of concern for contacts who have been through multiple merges I'm iterating through * this as a loop - so if the contact I move their data too has been deleted then the next iteration will move their * data across to the contact [18:38:28] different data left & I will look at those next - once this 'noise' * is gone. * * Bug: T232636 [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [18:39:21] (PS7) Ejegg: Step one on prospect data restore - Move any prospecting records from deleted contacts to contacts they were merged to with none. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [18:40:10] (CR) Ejegg: [C: +2] "PS7: just fix commit message" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [18:41:27] (CR) jerkins-bot: [V: -1] Step one on prospect data restore - Move any prospecting records from deleted contacts to contacts they were merged to with none. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [18:41:58] (CR) Eileen: Step one on prospect data restore - Move any prospecting records from deleted contacts to contacts they were merged to with none. (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543021 (https://phabricator.wikimedia.org/T232636) (owner: Eileen) [19:28:24] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/543933 [19:28:31] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/543933 (owner: Eileen) [19:29:21] cstone I'm going to push out your patch on recurring currency [19:29:38] thanks eileen ! [19:29:48] The phab it links to is wrong though - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/543715/ [19:30:24] oh wow haha [19:30:28] how did I manage that [19:30:57] ah 9 instead of 0 [19:31:08] should I fix that? [19:31:35] I don't think you can [19:31:38] !log civicrm revision changed from 4eac801762 to ff69d64ad4, config revision is dc3a88889d [19:31:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [19:31:52] it's merged [19:32:28] hmm yeah ok [19:33:55] (PS1) Umherirrender: Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/543935 [20:02:02] AndyRussG: are you about ?!?! :) [20:03:41] yes... ish? For some reason no electricity... But I have some battery left on my phone and on my 'puter [20:03:53] jgleeson ^ [20:03:54] oh noes! [20:04:04] it can wait, I'll put my notes on the ticket [20:04:22] Hopefully it'll be on again soon! [20:04:31] Okok thanks! [20:04:57] I figured out how to fix the broken tests but it requires some rejigging of the mixin hooks... which feels like important stuff so I wanted to run it by you. I'll add some notes to the patch and we can chat on it tomorrow when you have power :) [20:05:29] basically the mixins live inside the campaign and nulling that removes the mixins @_@ [20:05:44] so we might have to rethink the approach [20:24:00] (PS6) Jgleeson: WIP: DO NOT MERGE Reduce usage of 'campaign' local var within campaign fallback. Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 [20:50:49] (CR) Jforrester: "check experimental" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/541573 (owner: Ejegg) [22:58:37] (PS1) Jforrester: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/544071 [22:59:42] (PS1) Jforrester: build: Upgrade mediawiki-codesniffer to v28.0.0 [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/544072 [23:01:45] (CR) Jforrester: "I believe that only DonationInterface needs to keep working on 1.31/PHP 7.0, but leaving to FR-tech to review and decide if this is OK." [extensions/FundraisingTranslateWorkflow] - https://gerrit.wikimedia.org/r/544071 (owner: Jforrester) [23:01:48] (CR) Jforrester: "I believe that only DonationInterface needs to keep working on 1.31/PHP 7.0, but leaving to FR-tech to review and decide if this is OK." [extensions/FundraiserLandingPage] - https://gerrit.wikimedia.org/r/544072 (owner: Jforrester)