[14:15:27] (CR) Thiemo Kreuz (WMDE): [C: +2] Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/543935 (owner: Umherirrender) [14:17:13] (Merged) jenkins-bot: Use php null coalesce operator ?? [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/543935 (owner: Umherirrender) [14:46:21] AndyRussG: how is the power today ? [14:48:39] jgleeson: hi! All good, as of yesterday late afternoon, thanks...! [14:48:52] How's everything with you? [14:51:06] Good good thanks, you? I added some notes to the commit message on the tidy up patch or CampaignFallback. It looks like this small chage could break things so maybe it would be best to do it differently for now? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralNotice/+/543203/ [14:51:18] fundraising-tech-ops: improve backups from frav1002 to archive - https://phabricator.wikimedia.org/T230223 (Jgreen) Open→Resolved Used compresscmd to encrpyt/compress at log rotation, and a separate cron job to sweep those to /srv/archive/logs where they're picked up a day later by archive_sync and s... [14:52:26] s/or/for/ [14:53:57] fundraising-tech-ops: reimage americium to Debian Stretch - https://phabricator.wikimedia.org/T165393 (Jgreen) Open→Declined [14:53:59] fundraising-tech-ops: EPIC: migrate fundraising off of Debian Jessie - https://phabricator.wikimedia.org/T185013 (Jgreen) [14:55:09] jgleeson: cool!! yeah checking that out is first on my agenda today... [14:55:11] thanks! [14:55:37] thanks much! [15:52:29] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: CiviCRM deduplication fails when neither contact has a contribution - https://phabricator.wikimedia.org/T235890 (Ejegg) [15:53:52] ejegg|semi: Do you know if the comment in the TY email requires the specific format in the old email? Or can I just put a comment describing this as the 2019 email? [16:00:18] Fundraising-Backlog, Continuous-Integration-Infrastructure, Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (Ejegg)... [16:06:59] Fundraising-Backlog: Add day of month for recurring donations in thank you email - https://phabricator.wikimedia.org/T235893 (Pcoombe) [16:09:35] pcoombe: oops, just saw your question. It needs to be fairly similar - let me see what the minimum would be [16:14:02] (CR) Ejegg: "Looks like this is the shortest template info comment that will get the test to pass:" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543909 (https://phabricator.wikimedia.org/T234446) (owner: Pcoombe) [16:14:20] pcoombe: ok, added an example ^^^ [16:14:32] Great, thanks! [16:18:54] (PS2) Pcoombe: Updated English thank you email [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543909 (https://phabricator.wikimedia.org/T234446) [16:27:42] fundraising-tech-ops, Operations, ops-codfw: rack/setup/install frqueue2001 - https://phabricator.wikimedia.org/T232630 (Dwisehaupt) Open→Resolved @Papaul Yes, it is. Thanks. Closing it up. [16:32:14] (CR) Pcoombe: "Okay, I sent some test emails with this and it looks good. Ready for merge and deployment." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543909 (https://phabricator.wikimedia.org/T234446) (owner: Pcoombe) [16:32:40] (CR) AndyRussG: WIP: DO NOT MERGE Reduce usage of 'campaign' local var within campaign fallback. Clear out bannerCancelReason when calling setCampaign() (2 comments) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (owner: Jgleeson) [16:45:23] (CR) AndyRussG: WIP: DO NOT MERGE Reduce usage of 'campaign' local var within campaign fallback. Clear out bannerCancelReason when calling setCampaign() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (owner: Jgleeson) [16:56:54] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Security-Team: Monthly convert: set hide cookie when modal loads - https://phabricator.wikimedia.org/T235209 (chasemp) [18:24:47] (CR) AndyRussG: WIP: DO NOT MERGE Reduce usage of 'campaign' local var within campaign fallback. Clear out bannerCancelReason when calling setCampaign() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (owner: Jgleeson) [18:25:17] jgleeson: oops! I made another mistake in a previous comment on that patch! ^ pls see the latest comment for another correction... Thanks!!! [18:25:25] (PS1) Umherirrender: Declare arrays before use [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/544239 [19:18:43] Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Dedupe task failing when trying to merge 2 * RML contacts - https://phabricator.wikimedia.org/T235794 (Ejegg) [19:18:45] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: CiviCRM deduplication fails when neither contact has a contribution - https://phabricator.wikimedia.org/T235890 (Ejegg) [19:53:47] Fundraising-Backlog, Continuous-Integration-Infrastructure, Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910): Create composer-test-php70 docker image for fundraising tech's crm tests - https://phabricator.wikimedia.org/T230446 (Jdforres... [20:11:48] (PS1) Cstone: Add logging for more infornation on duplicate merchant reference (300620) errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/544251 (https://phabricator.wikimedia.org/T218120) [21:14:03] Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Dedupe task failing when trying to merge 2 * RML contacts - https://phabricator.wikimedia.org/T235794 (Eileenmcnaughton) Lol - I love the idea of deduping a dedupe phab task