[08:04:13] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/544710 (owner: L10n-bot) [08:16:14] (CR) Raimond Spekking: "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/544710 (owner: L10n-bot) [14:04:35] (CR) Daimona Eaytoy: "Uh-oh, I think this repo needs to stay on PHP 7.0" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/544436 (https://phabricator.wikimedia.org/T234597) (owner: MaxSem) [14:09:48] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice, Patch-For-Review: More small fixes needed for Campaign fallback - https://phabricator.wikimedia.org/T234248 (Jseddon) [14:09:50] Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice: Improve state component's munging of new data added for Campaign Fallback - https://phabricator.wikimedia.org/T232235 (Jseddon) [14:09:53] Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Small fixes needed for Campaign fallback - https://phabricator.wikimedia.org/T232859 (Jseddon) [14:09:56] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Minimal update Allocations UI for campaign fallback - https://phabricator.wikimedia.org/T231469 (Jseddon) [14:44:41] Fundraising-Backlog: Contact Source job failed. - https://phabricator.wikimedia.org/T236073 (DStrine) [15:10:06] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: City field and label positioned wrong on India form - https://phabricator.wikimedia.org/T236077 (Pcoombe) [15:11:17] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: City field and label positioned wrong on India form - https://phabricator.wikimedia.org/T236077 (Pcoombe) [17:35:50] Fundraising-Backlog, FR-Civi-Prospect: Cannot update drop downs on prospect tab - https://phabricator.wikimedia.org/T236096 (NNichols) [17:44:02] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-PayPal-ExpressCheckout: Duplicate donations caused by PayPal's “Final Approval” messaging - https://phabricator.wikimedia.org/T235220 (XenoRyet) @MBeat33 Ok, confirmed that everything looks norm... [17:55:58] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: New iframe failure issues (confirmed modern browsers) - https://phabricator.wikimedia.org/T235126 (XenoRyet) a:XenoRyet [18:10:02] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for spatton - https://phabricator.wikimedia.org/T235682 (Dwisehaupt) p:Triage→Normal Certificate created and emailed. Password sent to phone number of record. [18:10:43] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for andyrussg - https://phabricator.wikimedia.org/T235679 (Dwisehaupt) p:Triage→Normal Certificate created and emailed. Password sent to phone number of record. [18:15:19] Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (NNichols) [19:07:54] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Monthly convert: set hide cookie when modal loads - https://phabricator.wikimedia.org/T235209 (sbassett) [19:19:57] (PS1) Jgleeson: Uupdate donation queue consumer batch handling to not use variable_set(). [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545014 (https://phabricator.wikimedia.org/T228488) [19:31:40] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (Cstone) a:Cstone [19:42:54] (CR) Raimond Spekking: [C: +2] "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/544710 (owner: L10n-bot) [19:46:44] (PS1) Jgleeson: Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545023 [19:48:34] (PS7) Jgleeson: Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (https://phabricator.wikimedia.org/T234248) [19:49:03] (Abandoned) Jgleeson: Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545023 (owner: Jgleeson) [19:49:40] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Monthly convert: set hide cookie when modal loads - https://phabricator.wikimedia.org/T235209 (jgleeson) a:jgleeson [19:50:31] Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) @NNichols is this ongoing? Just trying to rule out a load issue [20:00:08] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (DStrine) [20:01:24] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Contact Source job failed. - https://phabricator.wikimedia.org/T236073 (DStrine) [20:06:19] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (NNichols) @Eileenmcnaughton yes. I still cannot add or change anything on the prospect tab. We were also trying to change some d... [20:17:53] mepps do you want to bring our 1-1 forwards? [20:18:01] since we are out of the other meeting [20:18:05] sure eileen, give me one minute [20:19:28] eileen i'm ready now [21:04:29] eileen: you have time to meet? [21:04:46] yes sorry - just had shower in between [21:17:25] Awww Gerrit's down! [21:22:57] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql and Civi access for jkumalah - https://phabricator.wikimedia.org/T232543 (DStrine) Resolved→Open [21:22:59] Fundraising-Backlog, fundraising-tech-ops: Access and onboarding for new fundraising analyst - Jerrie Kumalah - https://phabricator.wikimedia.org/T232080 (DStrine) [21:23:28] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql and Civi access for jkumalah - https://phabricator.wikimedia.org/T232543 (DStrine) Hey all. I'm reopening this. @jkumalah doesn't seem to have a civi cert yet. [21:28:19] Fundraising-Backlog, fundraising-tech-ops: frdev server and mysql and Civi access for jkumalah - https://phabricator.wikimedia.org/T232543 (Eileenmcnaughton) Added a civi user id - just need the cert now [21:44:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Engage having issues with batch data entry function - https://phabricator.wikimedia.org/T236106 (RLewis) [22:17:12] (CR) AndyRussG: Clear out bannerCancelReason when calling setCampaign() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545023 (owner: Jgleeson) [22:39:01] (CR) AndyRussG: Clear out bannerCancelReason when calling setCampaign() (1 comment) [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (https://phabricator.wikimedia.org/T234248) (owner: Jgleeson) [22:40:00] fr-tech hi! since jgleeson|away is |away, anyone want to help push this patch through? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/543203 It just needs an updated commit message [22:40:28] Either I could update it and someone else could +2, or vice versa... [22:40:32] thanks in advance!!! [22:41:01] AndyRussG: I can take that comment out. [22:42:03] phew glad you are looking XenoRyet - I just looked at the discussion & my brain started to fall apart [22:42:26] (PS8) XenoRyet: Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (https://phabricator.wikimedia.org/T234248) (owner: Jgleeson) [22:42:53] AndyRussG: There you go. [22:45:29] XenoRyet: yeee thanks much! [22:45:35] No worries [22:45:56] :) [22:49:35] (CR) AndyRussG: [C: +2] "Yay thanks!!!" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (https://phabricator.wikimedia.org/T234248) (owner: Jgleeson) [22:54:42] (PS1) AndyRussG: Fix statusCode value in campaignStatuses in display RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545082 [22:55:16] XenoRyet or anyone else about in fr-tech, I have another weee fix that'd be nice to put out together with Campaign Fallback: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralNotice/+/545082 [22:55:33] It just fixes a bug in the extra data we now have to send back with fallback in place [22:55:44] thanks in advance!! [22:55:54] Ok, let me take a peek [22:59:28] XenoRyet: thx [22:59:38] ! :) [23:00:43] (CR) XenoRyet: [C: +2] Fix statusCode value in campaignStatuses in display RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545082 (owner: AndyRussG) [23:00:49] (Merged) jenkins-bot: Clear out bannerCancelReason when calling setCampaign() [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/543203 (https://phabricator.wikimedia.org/T234248) (owner: Jgleeson) [23:00:51] Yea, straightforward enough. [23:01:16] jeff_green are you still about - I think I need some help reloading triggers [23:03:16] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) It looks like a custom field was deleted - 'Prior WMF Giving' - however, the triggers are still trying to update... [23:03:42] (Merged) jenkins-bot: Fix statusCode value in campaignStatuses in display RL module [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/545082 (owner: AndyRussG) [23:11:05] XenoRyet: yeee thx again!!! :D [23:12:05] de nada [23:13:28] mepps: XenoRyet I've realised the issue with https://phabricator.wikimedia.org/T236096 is that basically nothing can save to the prospect table without getting the triggers reloaded on it - is that urgent enough to harrass Jeff after hours ? [23:14:45] Eileen is any part of the dB that the queue consumers would touch effected? [23:14:53] I don't think so [23:15:11] I'm just trying to figure out if it just happened or was just noticed [23:19:56] OK Nora did it in the library with the candlestick at 2019-10-21 14:24:55 [23:20:58] So I guess that was 11 hours ago - NOW = 2019-10-21 23:20:37 [23:24:14] eileen: For what it's worth, Nora is on the east coast, she's probably done for the day already. [23:25:05] yeah my guess is that if I can get the trigger update reviewed & give Jeff / Dallas instructions for the am they can do it first thing [23:27:29] Sounds reasonable [23:33:28] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Do 'something' to prevent Major gifts / anyone deleting custom fields in the UI - https://phabricator.wikimedia.org/T236111 (Eileenmcnaughton) [23:33:48] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) I added this https://phabricator.wikimedia.org/T236111 as a follow up on the preventative side [23:35:27] (PS1) Eileen: Updated triggers for civicrm_value_1_prospect_5.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545092 (https://phabricator.wikimedia.org/T236096) [23:35:44] XenoRyet: https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/545092/ [23:36:11] hang on - thats not right [23:36:52] oh yes it is ... scroll right! [23:37:09] Ok, taking a look. [23:41:37] (PS1) Eileen: Administrative triggers update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545103 (https://phabricator.wikimedia.org/T236096) [23:42:48] XenoRyet: I added a follow up which is just the triggers update script updated - I don't really intend to use it in this deploy - Jeff will be happier doing it sans-outage with just one table in the script but I should keep that file up to date [23:43:57] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect, Patch-For-Review, Unplanned-Sprint-Work: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) [23:44:03] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect, Patch-For-Review, Unplanned-Sprint-Work: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) [23:45:09] (CR) XenoRyet: [C: +2] Updated triggers for civicrm_value_1_prospect_5.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545092 (https://phabricator.wikimedia.org/T236096) (owner: Eileen) [23:45:22] Cool, looking at that follow up now. [23:46:55] it's autogenerated so not too insane - I just missed doing that admin last time & it created confusion this time [23:47:39] Yea, looks pretty straightforward [23:48:32] Looks good, I'll just let zuul finish with it before I apply the +2 [23:50:09] (CR) XenoRyet: [C: +2] Administrative triggers update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545103 (https://phabricator.wikimedia.org/T236096) (owner: Eileen) [23:50:51] (Merged) jenkins-bot: Updated triggers for civicrm_value_1_prospect_5.mysql [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545092 (https://phabricator.wikimedia.org/T236096) (owner: Eileen) [23:52:00] thanks XenoRyet [23:52:06] No worries [23:55:16] (Merged) jenkins-bot: Administrative triggers update. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545103 (https://phabricator.wikimedia.org/T236096) (owner: Eileen) [23:55:37] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect, Patch-For-Review, Unplanned-Sprint-Work: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) @Jgreen @Dwisehaupt - could one of you load this triggers file... [23:55:58] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, FR-Civi-Prospect, Patch-For-Review, Unplanned-Sprint-Work: Cannot add or change anything on the prospect tab - https://phabricator.wikimedia.org/T236096 (Eileenmcnaughton) p:Triage→Unbreak! [23:57:52] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540430 (owner: Eileen) [23:57:58] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/540432 (owner: Eileen) [23:58:27] (Abandoned) Eileen: Add email amender extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/537788 (https://phabricator.wikimedia.org/T231332) (owner: Eileen) [23:59:36] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545115 [23:59:56] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545115 (owner: Eileen)