[00:04:15] (PS5) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [00:04:17] (PS1) Eileen: Update civix-generated code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545419 [03:57:23] (CR) Cstone: [C: +2] PayPal audit: skip BOM in TRR files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/543693 (owner: Ejegg) [03:57:59] (Merged) jenkins-bot: PayPal audit: skip BOM in TRR files [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/543693 (owner: Ejegg) [09:06:41] Fundraising-Backlog: Update English Thank You email - https://phabricator.wikimedia.org/T234446 (Pcoombe) Open→Resolved Just made a test donation and got the new email. Thanks a lot @Ejegg! [10:59:17] Fundraising-Backlog: Up-to-date Safari users getting unsupported browser errors - https://phabricator.wikimedia.org/T236243 (MBeat33) [11:28:27] Fundraising-Backlog, donate.wikimedia.org: Up-to-date Safari users getting unsupported browser errors - https://phabricator.wikimedia.org/T236243 (Pcoombe) This error message ("If the form does not load, your web browser may not be supported. Please try a more modern browser.") is from donatewiki. I coul... [11:31:51] Fundraising-Backlog, donate.wikimedia.org: Up-to-date Safari users getting unsupported browser errors - https://phabricator.wikimedia.org/T236243 (MBeat33) Thanks, @Pcoombe we'll ask these donors for the usual extra technical details. [11:39:37] Fundraising-Backlog: Update English Thank You email - https://phabricator.wikimedia.org/T234446 (CCogdill_WMF) So awesome! Thanks, everyone :) [14:38:14] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Update English Thank You email - https://phabricator.wikimedia.org/T234446 (DStrine) [15:00:09] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Contact Source job failed. - https://phabricator.wikimedia.org/T236073 (KHaggard) Hi @Ejegg - The imports ran successfully this morning 🙌🏼 Thanks for your awesome work and speedy replies! [15:18:08] fr-tech, does anyone have anything for Scrum of SCrums? [15:29:12] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Adapt banner history for campaign fallback - https://phabricator.wikimedia.org/T236285 (AndyRussG) [16:02:56] Fundraising Sprint Usual Subscripts, Fundraising-Backlog: Contact Source job failed. - https://phabricator.wikimedia.org/T236073 (Ejegg) Open→Resolved a:Ejegg Glad to hear it @KHaggard ! [16:21:17] (PS2) Ejegg: Update civix-generated code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545419 (owner: Eileen) [16:21:24] (CR) Ejegg: [C: +2] Update civix-generated code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545419 (owner: Eileen) [16:27:18] (Merged) jenkins-bot: Update civix-generated code. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545419 (owner: Eileen) [16:38:22] (PS4) Ejegg: Add indexes on contact.created_date & contact.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538372 (owner: Eileen) [16:38:48] (CR) Ejegg: [C: +2] Add indexes on contact.created_date & contact.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538372 (owner: Eileen) [16:44:11] (Merged) jenkins-bot: Add indexes on contact.created_date & contact.modified_date [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/538372 (owner: Eileen) [16:45:30] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog: FRUEC: Debug large discrepancy in data in initial test run. - https://phabricator.wikimedia.org/T235284 (AndyRussG) [16:59:12] Fundraising-Backlog, MediaWiki-General, MediaWiki-extensions-CentralNotice, Mobile: Provide a way to show notifications to mobile users comparable to Sitenotice/annonnotice - https://phabricator.wikimedia.org/T138572 (Jdlrobson) [18:16:26] fr-tech we should make sure payments-wiki is using addModuleStyles correctly, i.e. just for stuff that should be render-blocking [18:21:50] wat, regexp templates in resourceloader?? [18:25:02] well they both start with "r" [18:50:14] (CR) Ejegg: "D'oh, this isn't going to rebase very cleanly now that I merged Peter's rewrite of the whole TY email." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) (owner: Cstone) [18:51:26] Yeah no worries ejegg [19:39:10] fr-tech is there a straightforward way to insert into a civi custom field I thought I had used a function or api call before but I am blanking on that [19:43:31] Yea, there is an API call. I want to say the 'create' call will do an insert, but it's been a minute since I looked at that. [19:43:55] The opt-in consumer code will have an example of it. [19:58:08] (PS1) Ejegg: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/545648 [20:01:18] cstone what's the context? [20:01:28] im uploading an example just a sec [20:02:27] (PS2) Cstone: Add new twig variable gift_source to hide the tax information in the thank you template for DAF contributions. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) [20:03:00] for the test for DAF I was trying to figure out a way to add a gift source without doing a direct database interaction like in the above [20:03:04] Oh, to set up the gift source for a test? [20:03:12] yeah [20:03:13] ah yeah, one sec [20:03:51] So we have a shortcut fn to get the custom field alias that works in API calls [20:04:00] one sec, loading API [20:04:04] err, IDE [20:04:57] wmf_civicrm_get_custom_field_name($name, $group_name) [20:08:11] so the WmfCampaignTest uses it to set $this->campaign_custom_field_name [20:08:25] then uses the API to add a Contribution with that custom field set [20:08:30] in testMatchingDonation [20:10:03] okay cool thanks for the example! [20:10:27] yw! [20:10:47] gonna relocate, back in a bit [20:37:27] dwisehaupt: did you get any further on planning your outage? [20:38:09] we have not. today is the big PCI day but we will talk about it this afternoon. [20:50:33] cool thanks [21:04:54] (PS6) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [21:05:06] (CR) jerkins-bot: [V: -1] Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) (owner: Eileen) [21:11:33] cstone: real minor thing, but we try to keep the commit message headlines under 60-70 chars, just for ease of git-log-readability [21:12:12] (CR) Ejegg: [C: +2] Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/545648 (owner: Ejegg) [21:12:41] (Merged) jenkins-bot: Merge branch 'master' into deploy [wikimedia/fundraising/tools] (deploy) - https://gerrit.wikimedia.org/r/545648 (owner: Ejegg) [21:14:56] !log updated Fundraising python tools from b3c7453be2 to ffc7bf764b [21:14:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:16:58] ejegg makes sense [21:37:44] (PS3) Cstone: Add new twig variable gift_source to thank you mail template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) [21:47:56] (PS1) Ejegg: WIP align EOY template with DS proposal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545668 (https://phabricator.wikimedia.org/T195907) [21:54:03] (CR) jerkins-bot: [V: -1] WIP align EOY template with DS proposal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545668 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [22:43:15] (PS1) Eileen: Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 [22:43:30] (CR) jerkins-bot: [V: -1] Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 (owner: Eileen) [22:46:08] (PS7) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [22:46:10] (PS2) Eileen: Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 [22:47:25] (CR) jerkins-bot: [V: -1] Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 (owner: Eileen) [23:01:21] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 (owner: Eileen) [23:45:06] (PS3) Eileen: Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 (https://phabricator.wikimedia.org/T221914)