[00:29:52] (CR) Cstone: [C: +2] Update doc links and test URLs from old globalcollect [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/543721 (owner: Ejegg) [00:31:13] (Merged) jenkins-bot: Update doc links and test URLs from old globalcollect [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/543721 (owner: Ejegg) [00:55:49] (Abandoned) Eileen: wip [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545125 (owner: Eileen) [00:59:53] (CR) Cstone: [C: +2] Clarify comments on Silverpop export queries [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/545401 (owner: Ejegg) [01:00:33] (Merged) jenkins-bot: Clarify comments on Silverpop export queries [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/545401 (owner: Ejegg) [01:21:30] (PS1) Eileen: Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) [01:26:39] (CR) jerkins-bot: [V: -1] Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) (owner: Eileen) [01:54:35] (PS2) Eileen: Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) [02:16:33] (CR) Cstone: [C: +2] Implement Ingenico connection test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/543176 (https://phabricator.wikimedia.org/T212252) (owner: Ejegg) [02:17:01] (Merged) jenkins-bot: Implement Ingenico connection test [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/543176 (https://phabricator.wikimedia.org/T212252) (owner: Ejegg) [02:43:10] (CR) Cstone: [C: +2] Clean up unused imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/541573 (owner: Ejegg) [02:48:09] (Merged) jenkins-bot: Clean up unused imports [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/541573 (owner: Ejegg) [03:53:05] (PS1) Eileen: Fix default on merge spec. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545694 [03:53:07] (PS1) Eileen: Fix dedupe screen to always set the checkbox to 'ticked' where data would otherwise be lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545695 (https://phabricator.wikimedia.org/T235450) [04:27:16] (PS1) Eileen: Improve docs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545697 [04:28:32] (CR) jerkins-bot: [V: -1] Improve docs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545697 (owner: Eileen) [04:29:50] (PS2) Eileen: Improve docs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545697 [10:13:14] Fundraising Sprint Sysadmin Kane, Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, Recurring-Donations, FR-Email: Schedule job for annual totals emails - https://phabricator.wikimedia.org/T234360 (MBeat33) Talking January scheduling at creative offsite (January TY email campaign, and such),... [12:23:01] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Future version of Chrome might break Special:HideBanners cookies - https://phabricator.wikimedia.org/T235204 (jgleeson) a:jgleeson [14:19:59] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-Banners: Problem with email opt-outs reaching Civi as unsubscribes - https://phabricator.wikimedia.org/T234925 (CCogdill_WMF) I think my preference is option 2. I know we were... [15:18:57] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (NNichols) I think that sounds like a great... [15:25:20] fr-tech does anyone know offhand where the KafkaTee code that creates the LandingPage logs lives? [15:25:45] AndyRussG my first instinct would be to ask you... [15:25:52] :) [15:26:20] nopes [15:27:11] aww hmm 8p thanks anyway! [15:27:19] I'm pretty sure it's in puppet somewhere [15:39:17] Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Future version of Chrome might break Special:HideBanners cookies - https://phabricator.wikimedia.org/T235204 (jgleeson) **Summary:** Currently we drop //third-party//*** cookies on a users browser after they... [16:00:39] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for bbarnes - https://phabricator.wikimedia.org/T236335 (Dwisehaupt) Old certificate revoked and new sent via email. Password sent via SMS to number on record. [20:33:01] (PS3) Eileen: Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) [20:33:06] (PS8) Eileen: Move logic for handling Yes-No fields during dedupe from wmf_civicrm to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/543741 (https://phabricator.wikimedia.org/T235450) [20:33:08] (PS4) Eileen: Add handling for resolving boolean conflict on 'email.on_hold [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545676 (https://phabricator.wikimedia.org/T221914) [20:33:10] (PS3) Eileen: Improve docs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545697 [20:33:48] I've just rebased my dedupe fixes to make this one first https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/545688/ as it is a quick fix that will address failmail [20:34:24] also this is a quick fix that will help dedupers not lose us data https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/545695/ [20:43:12] XenoRyet: if you get a chance ^^ [20:52:37] (CR) XenoRyet: [C: +2] Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) (owner: Eileen) [20:53:15] thanks XenoRyet [20:53:21] No worries [20:53:39] did you see the other little one too? I'll deploy both if I can [20:53:58] Yea, looking at that one now. [20:55:22] (CR) XenoRyet: [C: +2] Fix dedupe screen to always set the checkbox to 'ticked' where data would otherwise be lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545695 (https://phabricator.wikimedia.org/T235450) (owner: Eileen) [20:59:30] (Merged) jenkins-bot: Fix resolution of preferred contact language when no contributions present [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545688 (https://phabricator.wikimedia.org/T235794) (owner: Eileen) [21:11:44] great - I'll deploy those [21:23:37] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545947 [21:24:49] Hmm - there is quite a lot of stuff in that deploy commit - maybe I should do a cherry-pick deploy [21:29:50] XenoRyet: sorry one more - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/civicrm/+/545694/ it's blocking the other one [21:30:04] No worries, looking [21:30:47] also do you know any of the commits here - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/545947/-1..1 - I am thinking 2-5 I don't know anything about & maybe will cherry-pick [21:31:58] (CR) XenoRyet: [C: +2] Fix default on merge spec. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545694 (owner: Eileen) [21:32:07] hmm eileen 2 should have been deployed already [21:32:46] I've got no info on those. [21:33:22] cstone: let me check my local head is not misinforming me then - [21:33:30] 4 too [21:36:29] looks like 2-5 should all be deployed already [21:36:42] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545948 [21:36:44] cstone: yeah my bad [21:36:50] new one ^ [21:37:19] that looks like stuff I can recognise now [21:37:55] (Merged) jenkins-bot: Fix default on merge spec. [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545694 (owner: Eileen) [21:37:57] (Merged) jenkins-bot: Fix dedupe screen to always set the checkbox to 'ticked' where data would otherwise be lost [wikimedia/fundraising/crm/civicrm] - https://gerrit.wikimedia.org/r/545695 (https://phabricator.wikimedia.org/T235450) (owner: Eileen) [21:38:11] dwisehaupt: any update on the outage? [21:39:55] (Abandoned) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545947 (owner: Eileen) [21:40:02] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545948 (owner: Eileen) [21:40:46] (PS1) Eileen: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545949 [21:41:18] (CR) Eileen: [C: +2] CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545949 (owner: Eileen) [21:46:16] (Merged) jenkins-bot: CiviCRM submodule update [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545949 (owner: Eileen) [21:50:18] eileen: we're just talking about it. we would like to separaate it from the juniper work and we know there is a gap from now until monday. [21:50:48] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545952 [21:51:05] dwisehaupt: ah so no banners/emails now? [21:51:17] perhaps we hop in a quick conversation with you, Jeff_Green, and dstrine just to make sure the time is good [21:51:27] you mean voice or here? [21:51:36] correct. there were emails this morning, but they finished a few hours ago. [21:51:52] irc is fine. [21:52:56] ok - what sort of time were you thinking about? I want to add 2 indexes to civicrm_contact table [21:53:15] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/545952 (owner: Eileen) [21:53:41] eileen: does the trigger reload affect the drupal db in any way, or is it just the civicrm db? [21:53:59] only civi - I don't need another trigger reload now though [21:54:19] oh I misunderstood [21:54:33] * Jeff_Green goes to read task . . . [21:54:57] no - the thing I want to do is add a couple of indexes - it doesn't need your permissions - I just figured I could take advantage of your outage [21:55:12] am guessing it will take 10 mins to add them - I think it was about that on staging [21:55:52] you did the trigger one already [21:55:54] oic, so I think we should be ok to do it while we are still accepting incoming payments [21:56:21] yep - just queues need to be down I expect [21:56:56] !log civicrm revision changed from 47e0800001 to a55c2d2787, config revision is 63a67f32a1 [21:56:59] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [21:57:03] we're cool with doing it tomorrow if nobody else objects [21:57:18] Fundraising Sprint Usual Subscripts, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Dedupe task failing when trying to merge 2 * RML contacts - https://phabricator.wikimedia.org/T235794 (Eileenmcnaughton) [21:57:42] Fundraising Sprint Usual Subscripts, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Dedupe task failing when trying to merge 2 * RML contacts - https://phabricator.wikimedia.org/T235794 (Eileenmcnaughton) a:Eileenmcnaughton [21:57:43] another option would be over the weekend, it doesn't look like there are any campaigns planned until another email send on monday [21:58:26] that's weekend for me anyway :-) [21:59:16] eileen: yeah, sorry for dragging along. we have yet to schedule the juniper time and just don't want to hold you up. [21:59:50] so do you have an outage need other than the juniper one? [22:00:16] because I was just trying to piggy back on that to reduce downtimes [22:02:03] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 2 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (Eileenmcnaughton) @MBeat33 sorry I mis-pin... [22:06:51] eileen: dwisehaupt Jeff_Green just catching up. the ssl thing that is going to be done this evening is ok with fr-online because it so brief. I'm worried about making this take longer. I'd vote to do the civi stuff tomorrow. [22:08:52] dstrine: yep! [22:09:34] (PS1) XenoRyet: Clear payment submethod radios on validation fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/545955 (https://phabricator.wikimedia.org/T235126) [22:10:33] (CR) jerkins-bot: [V: -1] Clear payment submethod radios on validation fail [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/545955 (https://phabricator.wikimedia.org/T235126) (owner: XenoRyet) [22:10:36] dstrine: I'm happy to do the civi one tomorrow - the reason it's kinda topical is that patch to do it got merged & then pulled into the deploy so if we DON'T do it soon then I will need to reverse it out so the script doesn't get run accidentally. But if we can do it over the weekend that would be great [22:11:00] because I think it will help on a few things & it's only going to get harder to schedule [22:11:12] (it's a very safe change - just adding an index ) [22:11:23] eileen: which table out of curiosity? [22:11:30] civicrm_contact [22:11:33] kthx [22:11:42] the goal is to add indexes on created-date & modified_date [22:12:02] in particular being able to search and dedupe on the latter is really helpful [22:12:58] cstone: Do you have vagrant, or really any payments-wiki instance, running on a mac? Or am I thinking of someone else? [22:14:26] i dont have it on a mac XenoRyet [22:14:46] but i have a macbook pro [22:15:02] hmm... I wonder if anyone does. [22:15:26] I think I have a patch to fix that iframe radio button issue, but I can't test it because it only seems reproducable on a mac. [22:15:55] Makes me wish we had a staging environment. [22:16:47] i can get it set up on my mac not sure when it would finish provisoning though [22:16:57] at least by tomorrow :P [22:17:09] Yea, that would be fine. It's not UBN priority. [22:24:39] dstrine: did you see time proposal (not on this channel) [23:46:20] Fundraising-Backlog, fundraising-tech-ops, observability, Epic: Capture metrics for postfix queue depth both overall and for specific queues and domains - https://phabricator.wikimedia.org/T235804 (Dwisehaupt) The collector was rolled for this but we ran into an issue that caused me to roll back...