[03:26:01] <wikibugs>	 (PS1) MaxSem: build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/546002 (https://phabricator.wikimedia.org/T192167)
[03:39:41] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Move DonationInterface messages used in banners to WikimediaMessages - https://phabricator.wikimedia.org/T231474 (MaxSem) Is there a way to determine which messages are used?
[06:00:09] <wikibugs>	 Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog: FRUEC: Debug large discrepancy in data in initial test run. - https://phabricator.wikimedia.org/T235284 (AndyRussG) Made some progress on figuring out what the difference is between old and new logs. I...
[06:51:45] <wikibugs>	 (CR) Jforrester: [C: +2] build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/546002 (https://phabricator.wikimedia.org/T192167) (owner: MaxSem)
[06:54:44] <wikibugs>	 (Merged) jenkins-bot: build: Bump mediawiki-codesniffer to 28.0.0 and make pass [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/546002 (https://phabricator.wikimedia.org/T192167) (owner: MaxSem)
[13:40:35] <wikibugs>	 Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Future version of Chrome might break Special:HideBanners cookies - https://phabricator.wikimedia.org/T235204 (jgleeson) (IMPORTANT)The below is my interpretation of the changes and how things work today. It'...
[13:53:33] <wikibugs>	 Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-Banners: Problem with email opt-outs reaching Civi as unsubscribes - https://phabricator.wikimedia.org/T234925 (Ejegg) Thanks for the guidance @CCogdill_WMF . Should be easy e...
[13:53:59] <wikibugs>	 (PS1) Ejegg: Silverpop export: unsubscribe donors with opt_in=0 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/546186 (https://phabricator.wikimedia.org/T234925)
[13:54:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Silverpop export: unsubscribe donors with opt_in=0 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/546186 (https://phabricator.wikimedia.org/T234925) (owner: Ejegg)
[13:56:31] <wikibugs>	 (PS2) Ejegg: Silverpop export: unsubscribe donors with opt_in=0 [wikimedia/fundraising/tools] - https://gerrit.wikimedia.org/r/546186 (https://phabricator.wikimedia.org/T234925)
[15:06:51] <wikibugs>	 Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog: FRUEC: Debug large discrepancy in data in initial test run. - https://phabricator.wikimedia.org/T235284 (AndyRussG) So actually it seems the problem is not duplicate entries in the old logs, but rather...
[15:09:57] <wikibugs>	 (PS2) Ejegg: End of year summary: align templates with DS proposal [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545668 (https://phabricator.wikimedia.org/T195907)
[15:45:18] <wikibugs>	 (PS1) Jgleeson: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/546214
[15:47:35] <wikibugs>	 (CR) Jgleeson: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/546214 (owner: Jgleeson)
[15:49:49] <wikibugs>	 Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising-Backlog, Wikimedia-Fundraising-Banners, Patch-For-Review: Problem with email opt-outs reaching Civi as unsubscribes - https://phabricator.wikimedia.org/T234925 (Ejegg) p:Triage→Normal a:Ejegg
[15:52:30] <jgleeson>	 fr-tech, just a heads up that I'm about to deploy the fixes we added to stop Amazon donations redirecting to a paymentswiki login page when an error is encountered
[15:53:37] <ejegg>	 ok jgleeson
[15:54:55] <jgleeson>	 I'm gonna check out the ingenico manifestation of the same problem too
[16:03:42] <wikibugs>	 Fundraising Sprint Usual Subscripts, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Future version of Chrome might break Special:HideBanners cookies - https://phabricator.wikimedia.org/T235204 (Ejegg) Thanks for all the research and supporting links, @jgleeson!  So of all the workarounds me...
[16:06:19] <wikibugs>	 (CR) Jgleeson: [C: +2] "recheck" [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/546214 (owner: Jgleeson)
[16:07:16] <jgleeson>	 ah I don't think I needed to recheck that patch
[16:07:26] <jgleeson>	 the hold up appears to be with merging post +2
[16:07:53] <wikibugs>	 (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/546214 (owner: Jgleeson)
[16:09:11] <jgleeson>	 the jenkins gods heard my call
[16:24:55] <wikibugs>	 (PS1) Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/546225
[16:25:52] <wikibugs>	 (CR) Jgleeson: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/546225 (owner: Jgleeson)
[16:30:36] <wikibugs>	 (CR) jerkins-bot: [V: -1] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/546225 (owner: Jgleeson)
[17:04:43] <ejegg>	 jgleeson: oh shoot, that happens every time we bump the smash-pig packagist package version and haven't updated it in core yet
[17:05:11] <ejegg>	 if you want to roll a smash-pig version bump in to resolve that, this update should be safe as houses
[17:05:45] <jgleeson>	 ooohh I see
[17:05:47] * ejegg wonders if he's used the british-ism correctly
[17:06:00] <jgleeson>	 yep, that's on the mark! :)
[17:07:35] <ejegg>	 if we wanted to fix it in CI, we would either stop checking out the deployed version of the libraries during env setup, or not run composer update after.
[17:08:28] <ejegg>	 hmm, I guess we need composer install at least, since the deployed version of the libraries doesn't have all the testing libraries we need
[17:09:23] <ejegg>	 if we could just swap the composer update for a composer install, that would be ideal - same versions of libs as prod, plus the testing libs
[17:09:30] <ejegg>	 back shortly...
[17:38:06] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Have a way to import a list of languages or a list of wikis to target in CentralNotice - https://phabricator.wikimedia.org/T220386 (Elitre) (@JKatzWMF , this is one of the topics we discussed about today. Just an FYI since you were curious!)
[17:50:44] <wikibugs>	 Fundraising-Backlog: investigate preventing older paypal recurring from sending inaccurate cancel email - https://phabricator.wikimedia.org/T236506 (DStrine)
[18:05:45] <jgleeson>	 ejegg: how do I add smash-pig alone to mediawiki/core? I keep pulling in everything else which pollutes the composer autoloaders when trying to update it?
[18:06:05] <jgleeson>	 I feel like I'm missing something obvious here
[18:06:59] <ejegg>	 jgleeson you should be able to delete the vendor dir, git submodule update --init,
[18:07:02] <ejegg>	 then
[18:07:37] <ejegg>	 composer update --no-dev wikimedia/smash-pig
[18:12:53] <jgleeson>	 ahhh I was missing --no-dev so it was installing all those bits
[18:12:57] <jgleeson>	 thanks!
[18:14:51] <ejegg>	 yw!
[18:26:47] <jgleeson>	 fr-tech, I'm gonna postpone the paymentswiki release until Monday. I had to do some messing around locally to update the mw core vendor lib so I don't trust the files changes at this point and would like to test a few payments locally before deploying. The changes are here https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/546269/ but I need to drop off now so I'll pick it up on monday.
[18:27:19] <XenoRyet>	 Yea, sounds good
[20:08:08] <wikibugs>	 (PS1) Ejegg: End of year summary: remove test mode [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546286 (https://phabricator.wikimedia.org/T195907)
[20:10:20] <wikibugs>	 (PS1) Ejegg: End of year summary: Fix 'batch' param name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546287 (https://phabricator.wikimedia.org/T195907)
[20:21:47] <wikibugs>	 (PS2) Ejegg: End of year summary: add Civi activity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540468 (https://phabricator.wikimedia.org/T195907)
[20:28:09] <wikibugs>	 (CR) jerkins-bot: [V: -1] End of year summary: add Civi activity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540468 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg)
[20:35:43] <wikibugs>	 (PS4) Ejegg: Add new twig variable gift_source to thank you mail template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) (owner: Cstone)
[20:36:58] <eileen>	 ejegg: I see you aree just signing off - I was going to try to catch up about the dedupe changes at some point
[20:38:02] <ejegg>	 eileen: hi!
[20:38:55] <eileen>	 hey
[20:39:05] <eileen>	 it's hard to get overlap at the moment :-)
[20:39:14] <ejegg>	 yeah... :S
[20:39:48] <ejegg>	 5 days left of this time zone, then 7 in portugal-time, which i think is 1 hr closer to the team average
[20:39:49] <eileen>	 I really just wanted to check if there was anything I should explain on the 2 dedupe patches I have in there https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/543741/ & the on_hold one
[20:41:26] <ejegg>	 The one standardizing the resolvers looked good on first glance, but then I got a little sidetracked looking at Bjoern's version
[20:41:57] <eileen>	 yeah me too
[20:42:19] <eileen>	 but in the end I didn't come up with a good way to align
[20:43:06] <eileen>	 what I did think about was creating a class, like my 'MergeHandler' in core once it's kinda stdised & maybe passing that out with the hooks or similar - but still pondering & just doing tiny cleanups in core atm
[20:43:59] <eileen>	 I'm working on doing a resolver for Initials
[20:47:40] <ejegg>	 heh, three implementations might be enough to settle on a good interface
[20:48:02] <wikibugs>	 (PS3) Ejegg: End of year summary: add Civi activity [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/540468 (https://phabricator.wikimedia.org/T195907)
[20:50:10] <ejegg>	 eileen: I'll put a few hrs in tomorrow to make up for a bunch of time I've lost in transit, and I'll prioritize giving a good look to those commits!
[20:50:23] <ejegg>	 *at those commits
[20:50:36] <wikibugs>	 (PS5) Ejegg: Add new twig variable gift_source to thank you mail template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) (owner: Cstone)
[20:50:42] <eileen>	 ejegg: thanks - I don't want to put pressure on you but I'm just conscious you might need some input from me
[20:50:45] <wikibugs>	 (CR) Ejegg: [C: +2] Add new twig variable gift_source to thank you mail template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) (owner: Cstone)
[20:54:00] <ejegg>	 thanks eileen - I do need to at least pause for a bit now, as the lappy is about out of battery
[20:54:12] <ejegg>	 have a good weekend!
[20:57:01] <wikibugs>	 (Merged) jenkins-bot: Add new twig variable gift_source to thank you mail template. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/545121 (https://phabricator.wikimedia.org/T233374) (owner: Cstone)
[20:58:35] <AndyRussG>	 Hey Jeff_Green, dwisehaupt... I have another question about the old kafkatee logs... can you explain what the "sequence" field is, as it appears inthis template that assembles them? %{hostname} %{sequence} %{dt} %{time_firstbyte} %{ip} %{cache_status}/%{http_status} %{response_size} %{http_method} http://%{uri_host}%{uri_path}%{uri_query} - %{content_type} %{referer} %{x_forwarded_for}
[20:58:37] <AndyRussG>	 %{user_agent} %{accept_language} %{x_analytics
[20:59:06] <AndyRussG>	 Also, if you have any further insight into this bug, especially as regards landing page logs, that'd be fantastic! https://phabricator.wikimedia.org/T235284
[20:59:10] <AndyRussG>	 Many thanks in advance :)
[20:59:42] <Jeff_Green>	 i don't know what the sequence is, wild guess is that it's something added by the proxy, but it could also be added by kafka I guess?
[21:03:19] <AndyRussG>	 Jeff_Green: ah ok... I was imagining it was something like that... So it comes directly from the JSON on the kafka webrequests stream from Analytics? That is, from... outer space!!?!!!?
[21:03:42] <Jeff_Green>	 lol
[21:04:14] <Jeff_Green>	 yes, that template line is in the configuration for kafkatee itself
[21:10:52] <AndyRussG>	 Jeff_Green: ok cool yeah it looks like it's as described here: https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Webrequest#Current_Schema
[21:11:06] <AndyRussG>	 "Per-host sequence number"
[21:11:26] <Jeff_Green>	 cool
[21:11:27] <AndyRussG>	 So, probably nothing relevant for us, maybe just useful in tracking down front-end cache issues
[21:11:34] <AndyRussG>	 thanks much!!! :)
[21:12:45] <Jeff_Green>	 yeah, sounds like something useful for reconstructing the order of events if the log stream doesn't guarantee order
[21:26:27] <wikibugs>	 Fundraising-Backlog: Changes coming to Dlocal reporting to help reconciliation - https://phabricator.wikimedia.org/T236524 (EMartin)
[21:29:46] <wikibugs>	 Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Have a way to import a list of languages or a list of wikis to target in CentralNotice - https://phabricator.wikimedia.org/T220386 (Base) As a quick win probably a simple userscript can be created providing such a feature.
[21:31:38] <wikibugs>	 Fundraising-Backlog, FR-Q2-FY2019-20-cleanup-list, MediaWiki-extensions-CentralNotice, Operations, Traffic: Geoip lookup - Misidentifying country due to travelling - https://phabricator.wikimedia.org/T175691 (Volans) I can confirm this as it happened to me today. I'm seeing the fund raising b...