[02:59:21] (CR) Eileen: "OK - so I'm seeing more errors - ie" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546783 (owner: Eileen) [03:26:35] (PS2) Eileen: Remove db_switcher call. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546783 [03:26:37] (PS1) Eileen: Removed unused civicrm_get_state function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548570 [03:26:39] (PS1) Eileen: Use CiviCRM DB for civicrm query - this is tested via ImportTest among other things [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548571 (https://phabricator.wikimedia.org/T237350) [03:37:36] (PS1) Eileen: Patch db_switcher for RPOW [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548572 (https://phabricator.wikimedia.org/T237350) [14:30:20] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, donate.wikimedia.org: Up-to-date Safari users getting unsupported browser errors - https://phabricator.wikimedia.org/T236243 (MBeat33) Some donors are reporting successful retries using Safari, so maybe this was a transient bug? Will cont... [14:38:13] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Need to reset password for user silverpop-upload@wikimedia.org in IBM - https://phabricator.wikimedia.org/T237100 (KHaggard) Resolved→Open We received a response to why the password keeps expiring every 7 days: The password needs to... [14:50:46] ejegg: just looking over your patch to fix the iframe liberator code. Can you advise on how I can test that patch? I was thinking of maybe deleting some cookies to simulate a timeout maybe? [14:52:40] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Patch-For-Review: Donors being asked to log in during donation (INGENICO) - https://phabricator.wikimedia.org/T236803 (jgleeson) @Ejegg could you add some notes on how I can test your patch please? Thanks in advance! [14:54:52] jgleeson you know that url you mentioned in the ticket? [14:54:59] yep [14:55:18] just change the domain to your local payments wiki [14:55:38] and go there in a private window, no frame or anything [14:56:15] ok will give it a go! [14:56:35] with the old code you just sit there and see the login link [14:57:18] we could do this in a more sophisticated way [14:57:45] but it would be a bigger change than we should make in november [14:57:47] writing javascript in top hats? [14:58:00] :> [14:58:30] hehe [14:58:54] or feeding the liberator script a url via mw.config [14:58:55] ok that works, it redirected me! [14:59:03] ok, great! [14:59:43] i might put up a proof of concept of the other way just so i d9n't forget [14:59:57] but it would be to merge in jan [15:00:10] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Patch-For-Review: Donors being asked to log in during donation (INGENICO) - https://phabricator.wikimedia.org/T236803 (jgleeson) Tested out @Ejegg's patch and it now redirects to the thank you page fixing the issue. [15:00:10] good idea [15:00:29] I like using WIP patches as a todo list [15:00:51] a bit like my longstanding yarn patch [15:00:54] @_@ [15:01:09] maybe next year's campaign it will be ready ... [15:01:34] ahh, that one we can work on in freeze! [15:02:09] thanks for the attention to that patch [15:02:14] gonna grab some lunch [15:02:20] enjoy! [15:03:48] (CR) Jgleeson: [C: +2] Iframe liberator always reloads page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/548544 (https://phabricator.wikimedia.org/T236803) (owner: Ejegg) [15:05:27] (Merged) jenkins-bot: Iframe liberator always reloads page [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/548544 (https://phabricator.wikimedia.org/T236803) (owner: Ejegg) [15:40:04] Fundraising-Backlog, donate.wikimedia.org: Up-to-date Safari users getting unsupported browser errors - https://phabricator.wikimedia.org/T236243 (DStrine) [16:20:55] (PS1) Ejegg: EOY summary: independent from name/address from normal TY [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548777 (https://phabricator.wikimedia.org/T195907) [16:24:47] (PS2) Ejegg: EOY summary: independent from name/address from normal TY [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548777 (https://phabricator.wikimedia.org/T195907) [16:24:49] (PS1) Ejegg: EOY summary: update text to match final copy [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548778 (https://phabricator.wikimedia.org/T195907) [16:28:44] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/548780 [16:28:54] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/548780 (owner: Ejegg) [16:29:31] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/548780 (owner: Ejegg) [16:31:21] (CR) jerkins-bot: [V: -1] EOY summary: update text to match final copy [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548778 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [16:38:41] Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Civi: report 107 fritzing - https://phabricator.wikimedia.org/T237330 (MBeat33) Open→Resolved a:MBeat33 Sandra and I can use the report again, so I'm marking this Resolved as a one-off. [16:57:54] Fundraising-Backlog, fundraising-tech-ops: Capture metrics for success and failure of process-control jobs - https://phabricator.wikimedia.org/T235123 (Dwisehaupt) Have coded up the parsing of the state files. Just need to figure out how to best export this data that can be useful for metrics/alerts. [17:00:27] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (Ejegg) Aha, found it. The ones with NULL are all using newer payment methods. Something's broken in the way... [17:00:55] (PS1) Jgleeson: Upgrade bower to fix issues with missing packages [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548800 [17:01:38] (CR) jerkins-bot: [V: -1] Upgrade bower to fix issues with missing packages [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548800 (owner: Jgleeson) [17:05:28] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/548803 [17:05:31] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/548803 (owner: Ejegg) [17:09:55] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (EMartin) Excellent. Do you need anything from Dlocal to troubleshoot resolution here? [17:10:09] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/548803 (owner: Ejegg) [17:13:02] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Civi is not updated with actual Dlocal volume/$$ - https://phabricator.wikimedia.org/T235212 (Ejegg) Nope @EMartin, this is purely CiviCRM internals. I'll fix the existing records first, then see what... [17:26:46] (CR) Jgleeson: [C: +2] Update 2019 target [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548445 (owner: Ejegg) [17:28:54] fr-tech, I've updated out mw-vagrant fundriasing role so that we can run dash. It depends on another patch which upgrades bower (this is a temp solution until we move to yarn) but if anyone wants to try playing with dash locally it's here https://gerrit.wikimedia.org/r/#/c/mediawiki/vagrant/+/548805/ [17:29:22] I couldn't find a phab task relating to this which was a surprise [17:38:48] (PS1) Ejegg: Fix account relationships for new methods [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548809 (https://phabricator.wikimedia.org/T235212) [17:40:25] FR-tech ^^^ will fix the reconciliation reports for DLocal and all future donations using existing payment instruments [17:40:52] going to fix the way we add payment instruments before I move the ticket to review, but that patch is ready for CR right now [18:01:21] (CR) Jgleeson: [C: +2] "Ding ding for me!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:04:33] ejegg: ejegg I'm confused by why that ticket is called 'Egg doesn't break CI' [18:05:57] Ogg maybe? [18:08:33] (PS1) Ejegg: Fix payment method update fn to add account relationship [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548823 (https://phabricator.wikimedia.org/T235212) [18:09:17] (PS2) Jgleeson: Egg doesn't break CI [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:09:59] (CR) jerkins-bot: [V: -1] Egg doesn't break CI [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:10:30] (CR) jerkins-bot: [V: -1] Fix payment method update fn to add account relationship [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548823 (https://phabricator.wikimedia.org/T235212) (owner: Ejegg) [18:12:58] jgleeson: Egg as in Easter [18:13:01] ahhh ejegg I tried to push through your ding ding patch thinking it was failing due to the earlier fraud gauge patch but it looks like it needs those changes, even though the fraud gauge patch is failing CI @_@ [18:13:56] ah, yeah, i think gerrit lets things merge if the end product passes CI and all the intermediate ones have +2 [18:14:08] so we just need to re-stack them and approve 'em [18:15:00] is there a way to abandon a specific patch set of a patch? [18:16:32] (PS3) Jgleeson: Egg doesn't break CI [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:18:37] ok ejegg I fixed the ordering [18:19:18] although isn't the 'Fix validation on fraud gauge' waiting on the 'Egg doesn't break CI' fix? That's what I tried to separate out [18:20:14] ohhh it looks like two files are breaking the new rules [18:20:24] fraud-gauge.js and totals-earned-chart.js [18:20:30] which explains it [18:20:59] jgleeson yep yep. I think as long as one patch depends on the other, and both have C+2, that gerrit can merge both if the second one passes [18:21:40] so you're suggesting I +2 the first patch? [18:23:07] jgleeson: only if it looks good! [18:26:58] ah it looks like I don't have test data with that widget [18:27:30] !log updated payments-wiki from 0de9d96208 to aac3d93f70 [18:27:37] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:28:10] jgleeson: I think that patch doesn't touch any of the result display or what would be sent to the server to make the query [18:28:27] just the validation of the parameters in the settings modal [18:29:43] got it [18:32:08] (CR) Jgleeson: [C: +2] "Nice! Showing errors and not closing modal!" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548471 (owner: Ejegg) [18:32:19] (CR) jerkins-bot: [V: -1] Update 2019 target [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548445 (owner: Ejegg) [18:32:57] ejegg: was tricky to work out how to provoke the validation error, in the end I tried setting the ranges to '"£$%^&' :) [18:33:01] (CR) jerkins-bot: [V: -1] Fix validation on fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548471 (owner: Ejegg) [18:33:03] (CR) jerkins-bot: [V: -1] Egg doesn't break CI [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:33:05] (CR) jerkins-bot: [V: -1] Egg doesn't break CI [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [18:33:05] oh man [18:33:10] heh, yeah, anything but numbers there should work [18:33:14] CI still complaining [18:33:22] hmm, was I wrong about the stacked submit thing? [18:33:35] ah family here now, I'll see if I can push it through when I come back later [18:34:04] and then I can rebase this patch https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/dash/+/548800/ which just upgrades bower but then our vagrant roles should install dash as expected once that's in place [18:34:13] back later! [19:15:09] (PS1) Ejegg: Don't crash on new D*Local audit row types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/548843 (https://phabricator.wikimedia.org/T236524) [19:22:23] (PS2) Ejegg: Don't crash on new D*Local audit row types [wikimedia/fundraising/SmashPig] - https://gerrit.wikimedia.org/r/548843 (https://phabricator.wikimedia.org/T236524) [19:43:09] (CR) Ejegg: "The code looks good, but I'm on the fence about removing the '.' - thinking of H. Jon Benjamin and F. Murray Abraham for example. We don't" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546789 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [19:48:12] (CR) Eileen: "@ejegg that should only happen if the other contact already has only 'H' in the first name" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546789 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [19:59:10] (CR) Ejegg: [C: +2] "OK, I'm convinced. Looks good!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546789 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [19:59:14] (PS5) Ejegg: Move the uniformative characters resolution from wmf_civicrm.module to deduper. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/546789 (https://phabricator.wikimedia.org/T230954) (owner: Eileen) [20:02:24] (CR) Ejegg: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548480 (owner: Ejegg) [20:19:55] (CR) Ejegg: "I tried merging this by hand, but it looks like it'll need some careful conflict resolution. Note that all of the admin UI modules have be" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518449 (https://phabricator.wikimedia.org/T102848) (owner: Vedmaka Wakalaka) [20:22:03] (PS4) Eileen: Resolve repeated first name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/547071 (https://phabricator.wikimedia.org/T230954) [20:22:18] (PS4) Eileen: Resolve scenario where the other contact already has an inital but it's the same as the one extracted from the first name [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/547072 (https://phabricator.wikimedia.org/T230954) [20:22:32] (PS2) Eileen: Brain dump of where I see things going in future [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/547712 [20:26:25] (CR) Ejegg: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548471 (owner: Ejegg) [20:26:34] (CR) Ejegg: "recheck" [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548445 (owner: Ejegg) [20:27:07] (CR) jerkins-bot: [V: -1] Fix validation on fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548471 (owner: Ejegg) [20:48:28] fr-tech here are the two EOY email patches, both simple: [20:48:31] https://gerrit.wikimedia.org/r/548777 [20:48:34] https://gerrit.wikimedia.org/r/548778 [21:46:14] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Rework Jimmy language on Endowment donate page & update content - https://phabricator.wikimedia.org/T228773 (XenoRyet) Ok, I've added an appeal with the requested text to payments wiki. Set the appeal... [21:55:09] (CR) Mepps: [C: +1] "Just one clarifying question but otherwise it looks good!" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548777 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [21:56:16] ejegg are we going to use the eoy email for recurring and non-recurring long-term? [21:58:05] (CR) Mepps: "One question about how this will be used. Also the build failed.." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548778 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [22:37:10] Fundraising-Backlog: Apple pay spec for ADYEN stand alone integratoin - https://phabricator.wikimedia.org/T237478 (EMartin) [23:00:49] Fundraising-Backlog: Apple pay spec for ADYEN stand alone integratoin - https://phabricator.wikimedia.org/T237478 (EMartin) Open→Resolved [23:18:56] mepps the EOY email will only go out to donors who had a recurring donation during the year in question [23:19:21] but it will include all donations associated with that email address for that year, whether recurring or not [23:22:31] (CR) Ejegg: [V: +2] Fix validation on fraud gauge [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548471 (owner: Ejegg) [23:23:06] (PS3) Ejegg: Update 2019 target [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548445 [23:41:22] (PS2) Ejegg: Upgrade bower to fix issues with missing packages [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548800 (owner: Jgleeson) [23:41:31] (CR) Ejegg: [C: +2] Upgrade bower to fix issues with missing packages [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548800 (owner: Jgleeson) [23:46:12] (Merged) jenkins-bot: Upgrade bower to fix issues with missing packages [wikimedia/fundraising/dash] - https://gerrit.wikimedia.org/r/548800 (owner: Jgleeson)