[13:59:34] (CR) jerkins-bot: [V: -1] Localisation updates from https://translatewiki.net. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550179 (owner: L10n-bot) [14:03:59] (CR) Raimond Spekking: [C: +2] "false positive" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550179 (owner: L10n-bot) [14:54:44] Fundraising-Backlog, MediaWiki-Vagrant, Patch-For-Review: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (jgleeson) It looks like this stops working when updating PHP 7.2 to the latest php7.2 (Version: 7.2.24-1+0~20191026.31+debian9~1.gbpbbacde+wmf1) package f... [15:16:12] Fundraising-Backlog: Monthly convert: min/max logic - https://phabricator.wikimedia.org/T237775 (Pcoombe) @spatton It's not a bad idea to do it on donatewiki, but I really don't have the time to work on adding that feature before December. [15:24:04] Fundraising-Backlog: Monthly convert: min/max logic - https://phabricator.wikimedia.org/T237775 (spatton) Makes sense @Pcoombe, these are the days of hydra tasks, where every completion spawns two new possibilities. Thanks for the fast response! @Ejegg, I'm curious to get your assessment re: time to impleme... [15:54:07] Fundraising-Backlog: FRUEC: Empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) [15:54:27] Fundraising-Backlog: FRUEC: Empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) [15:54:29] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [16:09:09] ejegg|away: are you around ? [16:17:32] ohh I forgot it's a holiday! [19:38:35] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Civi dedupe: request to Move Related prospect tab data by default - https://phabricator.wikimedia.org/T232625 (LeanneS) @Eileenmcnaughton It seems that's not being applied unfortunately,... [20:20:50] fr-tech, I'm guessing we're skipping our meetings today? [20:20:59] (for the fr-tech not in the US :) [20:26:56] fr-tech hi! I'm around, but I'm fine with skipping meetingz ;p [20:27:12] jgleeson: ^ :) [20:27:38] yeah unless you want to catch up [20:28:08] (Abandoned) Eileen: Fix issue when ejegg's patch runs on a new install. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549239 (owner: Eileen) [20:28:26] eileen: jgleeson: mmm yeah I'm also avaialble if u wish :) [20:30:28] I'm ok to skip :) [20:30:39] hey im around too but also okay to skip [20:31:51] eileen: you're ok with skipping then? or maybe you're blocked on something that others could help with? [20:32:28] lol only if you want to review dedupe conflict resolution ..... [20:32:34] (hint you don't) [20:33:21] the next patch in the chain is a bit of a doozy too https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/549234/ [20:33:30] hehe oh hmmm [20:33:51] yeah I'm also digging into silly stuff here with the old vs. new data pipelines still [20:35:44] yeah that os restructuring to make follow on patches work but it does exactly nothing [20:40:45] Fundraising-Backlog: FRUEC: Empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) FRUEC currently accepts LandingPage events with no language property in the JSON input. However, if the property exists and its value is an empty stri... [20:40:57] https://phabricator.wikimedia.org/T237997 [20:41:06] eileen: fun! [20:43:09] I'm currently digging into why I can't install a civicrm extention. Looks like civi's internals try to create missing log_* tables during the enabling of an extention and the auto-generated SQL for log_civicrm_geonames_lookup is trying to set an index on an ID column which doesnt exist causing the whole process to bomb out :/ [20:43:39] this feels like it might be related to why the civicrm unittests dont work with geoip on vagrant [20:46:06] also fr-tech, little warning that updating php 7.2 to the latest in the apt.wikimedia.org repo on vagrant will break xdebug. I had to manually install a newer version of xdebug to get it back. beward of `apt upgrade or apt dist-upgrade` :) [20:46:29] bewardddd! indeed [20:48:17] jgleeson: there is a =hook that specifies NOT to create log tables for some things [20:48:20] some tables [20:49:39] geocoder_civicrm_alterLogTables [20:50:18] that code looks like it's there [20:50:27] Fundraising-Backlog: FREUC: Check that empty uselang URL parameter should default to 'en' language for Landing Pages - https://phabricator.wikimedia.org/T238023 (AndyRussG) [20:50:30] Yeah - maybe there is some order of events thing happening [20:51:00] Fundraising-Backlog: FRUEC: Empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) See also {T238023}. [20:51:34] Fundraising-Backlog: FRUEC: Empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) See also {T237997}. [20:53:51] Fundraising-Backlog: FRUEC: For legacy compatibility, empty language property should default to 'en' for LandingPage impressions - https://phabricator.wikimedia.org/T237997 (AndyRussG) [20:56:57] Fundraising-Backlog: FREUC: Check that empty uselang or missing URL parameter should default to 'en' language for Landing Pages - https://phabricator.wikimedia.org/T238023 (AndyRussG) [20:58:52] ooo eileen it looks like a backtick has crept in just before the name of the civicrm_geonames_lookup name causing it to be skipped https://github.com/wikimedia/wikimedia-fundraising-crm/blob/master/sites/default/civicrm/extensions/org.wikimedia.geocoder/geocoder.php#L176 [20:59:21] jgleeson: dang you are right!!! [20:59:35] sneaky! [21:01:26] when pushing patches to our civicrm extensions I push to wikimedia/fundraising/crm right? and not wikimedia/fundraising/crm/civicrm [21:01:49] I'm a little confused as I think they end up in the civicrm/ dir? [21:02:32] yep - just crm [21:02:45] they wind up in sites/default/... blah [21:02:50] not the civicrm folder [21:03:16] ah ok, it's sites/default/civicrm/extensions [21:08:18] (PS1) Jgleeson: Remove erroneous in alterLogTables tbl '`civicrm_geonames_lookup' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550364 [21:09:21] (CR) Eileen: [C: +2] Remove erroneous in alterLogTables tbl '`civicrm_geonames_lookup' [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550364 (owner: Jgleeson) [21:09:33] that was an easy review [21:09:34] (PS2) Jgleeson: Remove erroneous backtick in alterLogTables '`civicrm_geonames_lookup' val [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550364 [21:09:40] oops [21:09:51] I made a typo in the commit msg but nevermind [21:09:53] :) [21:10:24] actually it looks like the +2 moved to PS2 [21:14:39] thanks for the +2 :) [21:14:43] eileen: ^ [21:14:55] :-) [21:50:28] (PS1) Jgleeson: WIP: Added annual thank you emailer extention [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 [21:53:22] (PS2) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 [22:29:05] (PS2) Eileen: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 [22:29:07] (PS11) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [22:29:09] (PS5) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [22:29:11] (PS3) Eileen: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 [22:29:13] (PS2) Eileen: Fix typo & declare dependency (latter was an PR submitted to us) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549672 [22:29:15] (PS2) Eileen: Update Readme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549673 [22:29:17] (PS2) Eileen: Regenerated boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549674 [22:29:19] (PS5) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [23:23:00] (PS1) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 [23:25:40] Fundraising-Backlog: FREUC: Check that empty or missing uselang or language URL parameter should default to 'en' language for Landing Pages - https://phabricator.wikimedia.org/T238023 (AndyRussG) [23:28:47] (CR) jerkins-bot: [V: -1] Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (owner: Eileen) [23:44:07] (PS2) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378