[02:30:20] (PS3) Eileen: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 [02:30:22] (PS4) Eileen: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 [02:30:24] (PS3) Eileen: Fix typo & declare dependency (latter was an PR submitted to us) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549672 [02:30:26] (PS3) Eileen: Update Readme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549673 [02:30:28] (PS3) Eileen: Regenerated boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549674 [02:30:30] (PS12) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [02:30:32] (PS6) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [02:30:34] (PS6) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [02:30:36] (PS3) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 [02:36:04] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: ask 'force merge' script to prefer most recent contrib data - https://phabricator.wikimedia.org/T232152 (Eileenmcnaughton) [02:36:49] (PS4) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (https://phabricator.wikimedia.org/T232152) [02:37:54] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: ask 'force merge' script to prefer most recent contrib data - https://phabricator.wikimedia.org/T232152 (Eileenmcnaughton) a:Eileenmcnaughton [05:34:53] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines - https://phabricator.wikimedia.org/T236835 (AndyRussG) Here's a summary of the situation regarding discrepancies between the new and old pipelines for Landing... [05:46:21] (PS3) Fomafix: Remove redundant closure for all modules with packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) [06:06:43] (PS1) Fomafix: Add ESLint rule "no-implicit-globals": "on" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/550392 [06:09:22] (CR) jerkins-bot: [V: -1] Add ESLint rule "no-implicit-globals": "on" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/550392 (owner: Fomafix) [06:10:39] (PS2) Fomafix: Add ESLint rule "no-implicit-globals": "error" [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/550392 [06:22:20] (PS4) Fomafix: Remove redundant closure for all modules with packageFiles [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) [06:27:28] (CR) Fomafix: "Still succeeds although the parent adds "no-implicit-globals": "error". Strange." [extensions/CentralNotice] - https://gerrit.wikimedia.org/r/518951 (https://phabricator.wikimedia.org/T50886) (owner: Fomafix) [12:10:50] (PS1) Eileen: Revisit Omnimail timestamp misery. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550454 (https://phabricator.wikimedia.org/T236855) [12:16:17] (CR) jerkins-bot: [V: -1] Revisit Omnimail timestamp misery. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550454 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [12:17:46] (PS2) Eileen: Revisit Omnimail timestamp misery. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550454 (https://phabricator.wikimedia.org/T236855) [15:49:41] (CR) Jgleeson: [C: +1] "Nice work. Works as expected for me and tests passing." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [16:08:01] (CR) Jgleeson: [C: +1] "working for me and tests passing. I tried out 'blah wales' against 'jimmy wales' and it merged as expected." (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 (owner: Eileen) [16:08:56] (CR) Jgleeson: [C: +2] Fix typo & declare dependency (latter was an PR submitted to us) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549672 (owner: Eileen) [16:09:36] (CR) Jgleeson: [C: +2] Update Readme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549673 (owner: Eileen) [16:10:47] (CR) Jgleeson: [C: +2] Regenerated boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549674 (owner: Eileen) [17:48:12] fr-tech looks like we have the green light to turn the dedupe and omnimail jobs back on [18:38:23] PROBLEM - check_puppetrun on payments1002 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 6 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [18:39:25] !log re-enabled Omnimail and contact de-duplication jobs [18:39:29] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:41:23] PROBLEM - check_puppetrun on payments1003 is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 8 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[mariadb-client] [18:43:23] RECOVERY - check_puppetrun on payments1002 is OK: OK: Puppet is currently enabled, last run 2 minutes ago with 0 failures [18:46:23] RECOVERY - check_puppetrun on payments1003 is OK: OK: Puppet is currently enabled, last run 34 seconds ago with 0 failures [18:51:04] (PS1) Ejegg: Update SmashPig for dlocal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550530 (https://phabricator.wikimedia.org/T236524) [18:51:07] (CR) Ejegg: [C: +2] Update SmashPig for dlocal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550530 (https://phabricator.wikimedia.org/T236524) (owner: Ejegg) [18:56:27] (Merged) jenkins-bot: Update SmashPig for dlocal audit [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550530 (https://phabricator.wikimedia.org/T236524) (owner: Ejegg) [19:12:05] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Add elements to monthly convert thank you email - https://phabricator.wikimedia.org/T237578 (DStrine) These changes are ready to deploy. [19:25:52] (PS4) Ejegg: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [19:27:29] (CR) Ejegg: [C: +2] "As Jack says, this is nice and easy to follow. I appreciate the new comment as well. I think I get what's going on with the spaces, so I'm" (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [19:32:37] (Merged) jenkins-bot: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [19:34:39] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert: min/max logic - https://phabricator.wikimedia.org/T237775 (Ejegg) @spatton, @pcoombe, et al: should we change the variant name from 'upsell' to 'monthlyConvert' at the same time, or do you have 'upsell' coded in too many plac... [19:35:26] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert: min/max logic - https://phabricator.wikimedia.org/T237775 (spatton) Yes please, @Ejegg, I'd be happy to make this improvement (suggested by @mepps a while ago) and it's no big bother to update our banners. TY for remembering it! [19:43:44] (CR) Jgleeson: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [19:52:55] (PS1) Ejegg: Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) [19:53:15] (CR) Eileen: Resolve initials where there is punctuation in the middle_name but middle_name is not conflicted (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549639 (owner: Eileen) [19:53:37] (PS5) Eileen: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 [19:53:51] (CR) jerkins-bot: [V: -1] Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [19:54:49] (PS6) Eileen: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 [19:54:53] (CR) Eileen: "You have your trim" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 (owner: Eileen) [19:55:00] (CR) jerkins-bot: [V: -1] Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 (owner: Eileen) [19:55:34] (PS7) Eileen: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 [19:56:36] (PS4) Eileen: Fix typo & declare dependency (latter was an PR submitted to us) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549672 [19:57:15] (PS4) Eileen: Update Readme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549673 [19:57:49] ejegg: did you see this? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/550454/ [19:58:02] (PS4) Eileen: Regenerated boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549674 [19:58:38] oh man, hadn't seen it yet [19:58:45] i'll review that [19:59:10] yeah - it just gives me some tools to go into that misery again [19:59:39] (PS13) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [19:59:54] jgleeson: thanks for that review - I added the missing trim [20:00:22] (PS7) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [20:00:37] (PS7) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [20:00:40] hey eileen, thanks! just waiting for zuul to catch up and then I'll +2 away [20:00:55] (PS2) Ejegg: Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) [20:02:32] (PS5) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (https://phabricator.wikimedia.org/T232152) [20:02:34] (CR) jerkins-bot: [V: -1] Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [20:02:51] (CR) Jgleeson: [C: +2] Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 (owner: Eileen) [20:03:17] zuul is crazy [20:03:35] I guess i makes sense to retest before merging in case stuff has changed [20:08:20] (Merged) jenkins-bot: Add silly name resolver. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549640 (owner: Eileen) [20:08:22] (Merged) jenkins-bot: Fix typo & declare dependency (latter was an PR submitted to us) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549672 (owner: Eileen) [20:08:24] (Merged) jenkins-bot: Update Readme [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549673 (owner: Eileen) [20:08:26] (Merged) jenkins-bot: Regenerated boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549674 (owner: Eileen) [20:08:41] Fundraising-Backlog: Monthly convert pwk modal variant 004 (alt headline text) - https://phabricator.wikimedia.org/T238139 (spatton) [20:10:34] Fundraising-Backlog: Enabling VPAY debit card to avoid rejected transactions - https://phabricator.wikimedia.org/T237062 (EMartin) Evelyn Martin Fri, Nov 8, 3:22 PM (4 days ago) Hi Elliott, I put in a phab ticket for this to keep track of it. Turns out Ingenico doesn't support VPAY and know nothing about i... [20:10:36] (PS1) Ejegg: Update SmashPig [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550539 [20:10:43] (CR) Ejegg: [C: +2] Update SmashPig [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550539 (owner: Ejegg) [20:10:44] Fundraising-Backlog: Monthly convert pwk modal variant 005 (alt paragraph text) - https://phabricator.wikimedia.org/T238140 (spatton) [20:10:53] Fundraising-Backlog: Enabling VPAY debit card to avoid rejected transactions - https://phabricator.wikimedia.org/T237062 (EMartin) Open→Resolved [20:11:28] yay - those all merged - leaving this slightly more complicated one at the top of the list https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/549234/ [20:12:20] (CR) Ejegg: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [20:12:34] Fundraising-Backlog: Monthly convert pwk modal variant 006 (alt button text) - https://phabricator.wikimedia.org/T238141 (spatton) [20:14:28] Fundraising-Backlog: Monthly convert pwk modal variant 007 (alt "different amount" link text) - https://phabricator.wikimedia.org/T238142 (spatton) [20:15:53] (Merged) jenkins-bot: Update SmashPig [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550539 (owner: Ejegg) [20:16:08] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Patch-For-Review: Monthly convert: min/max logic - https://phabricator.wikimedia.org/T237775 (Ejegg) p:Triage→Normal a:Ejegg [20:24:46] Fundraising-Backlog: Monthly convert pwk modal variant 008 (alt paragraph text) - https://phabricator.wikimedia.org/T238144 (spatton) [20:28:35] Fundraising-Backlog: Monthly convert pwk modal variant 009 (COMBO! New headline, paragraph, button and link) - https://phabricator.wikimedia.org/T238145 (spatton) [20:34:36] Fundraising-Backlog: Monthly convert pwk modal variant 010 (alt headline text) - https://phabricator.wikimedia.org/T238147 (spatton) [20:35:49] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550542 [21:10:24] (CR) Eileen: [C: +2] "Yep - this makes sense to me" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549931 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [21:11:41] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26): New iframe failure issues (confirmed modern browsers) - https://phabricator.wikimedia.org/T235126 (XenoRyet) Open→Resolved [21:11:49] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05): Donors being asked to log in during donation (INGENICO) - https://phabricator.wikimedia.org/T236803 (Ejegg) Open→Resolved p:Triage→Normal [21:12:05] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: CentralNotice: Adapt impression event schema for campaign fallback - https://phabricator.wikimedia.org/T236627 (AndyRussG) Open→Resolved a:AndyRussG [21:12:07] Fundraising Sprint Asymmetrical Earth Theory, Fundraising Sprint Bermuda Rhombus (where things disappear then reappear), Fundraising Sprint Cottage Cheese isn't Made of Cottages, Fundraising-Backlog, Epic: [Epic] Fundraising kafkatee changes - https://phabricator.wikimedia.org/T183978 (AndyRus... [21:12:16] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Data Map Second Pass - https://phabricator.wikimedia.org/T237046 (DStrine) Open→Resolved [21:12:18] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Wikimedia-Fundraising-Banners: Problem with email opt-outs reaching Civi as unsubscribes - https://phabricator.wikimedia.org/T234925 (Ejegg) Open→... [21:12:20] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Fr-CiviCRM-dedupe-FY2017/18: Figure out a mechanism to 'reserve' contacts once they have been picked for dedupe - https://phabricator.wikimedia.org/T194701 (Eileenmcnaughton) Open→Resolved [21:12:22] Fundraising Sprint Junebugs prefer July, Fundraising-Backlog, CheckUser, Fr-CiviCRM-dedupe-FY2017/18: Restore live DB back to staging so I can test recovery of 'same moment merges' - https://phabricator.wikimedia.org/T194700 (Eileenmcnaughton) [21:12:44] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Rework Jimmy language on Endowment donate page & update content - https://phabricator.wikimedia.org/T228773 (XenoRyet) Open→Resolved [21:12:48] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe, FR-Q2-FY2019-20-cleanup-list: Add 'protection' to prevent 2 attempts to dedupe the same contacts at once - https://phabricator.wikimedia.org/T232039 (Eileenmcnaughton) Open→Res... [21:13:16] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: New dedupe blocking issue - on hold - https://phabricator.wikimedia.org/T221914 (Eileenmcnaughton) Open→Resolved [21:15:24] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05): Monthly convert: set hide cookie when modal loads - https://phabricator.wikimedia.org/T235209 (DStrine) Open→Resolved [21:15:47] (Merged) jenkins-bot: EOY summary: use Hawaii time zone [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549931 (https://phabricator.wikimedia.org/T195907) (owner: Ejegg) [21:16:01] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Review benevity import speed - can we turn off triggers until the end? - https://phabricator.wikimedia.org/T238152 (Eileenmcnaughton) [21:25:18] Fundraising-Backlog: Special Chartacters do not export well from civi - https://phabricator.wikimedia.org/T237564 (Eileenmcnaughton) @NNichols where on the server - just looking for it [21:28:18] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Monthly convert pwk modal variant 003 (alt headline text) - https://phabricator.wikimedia.org/T237779 (DStrine) [21:28:20] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Monthly convert pwk modal variant 002 (alt paragraph text) - https://phabricator.wikimedia.org/T237778 (DStrine) [21:28:22] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Monthly convert pwk modal variant 001 (no diff amt option) - https://phabricator.wikimedia.org/T237777 (DStrine) [21:28:24] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Add elements to monthly convert thank you email - https://phabricator.wikimedia.org/T237578 (DStrine) [21:28:26] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Audit & support for benevity import - https://phabricator.wikimedia.org/T236977 (DStrine) [21:28:28] Fundraising Sprint w 2019, Fundraising-Backlog: Special Chartacters do not export well from civi - https://phabricator.wikimedia.org/T237564 (DStrine) [21:28:30] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Patch-For-Review: FRUEC: Raise error when timestamp not found in filename - https://phabricator.wikimedia.org/T237736 (DStrine) [21:28:32] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines - https://phabricator.wikimedia.org/T236835 (DStrine) [21:28:34] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: FRUEC: Debug minor discrepancy in banner impression data between old and new pipelines - https://phabricator.wikimedia.org/T236834 (DStrine) [21:28:38] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: FRUEC: For CentralNotice impression counts, take into account client-side sample rate - https://phabricator.wikimedia.org/T235461 (DStrine) [21:28:40] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Get paypal to prevent older paypal recurring from sending inaccurate cancel email - https://phabricator.wikimedia.org/T236506 (DStrine) [21:28:42] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, FR-Tech-Analytics, Patch-For-Review: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (DStrine) [21:28:44] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: Recurring notification email text showing subsequent donation in USD when donation was submitted in GBP - https://phabricator.wikimedia.org/T235105 (DStrine) [21:28:46] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: FRUEC: Debug large discrepancy in data in initial test run. - https://phabricator.wikimedia.org/T235284 (DStrine) [21:28:48] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog: FRUEC: New SQL to modify existing pgehres database - https://phabricator.wikimedia.org/T234958 (DStrine) [21:28:53] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Automatic DAF thank you email - https://phabricator.wikimedia.org/T233374 (DStrine) [21:28:57] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, and 4 others: Prevent target smart data from being lost on legacy merge screen - https://phabricator.wikimedia.org/T235450 (DStrine) [21:28:59] Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, and 2 others: Restore target smart data lost on legacy merge screen - https://phabricator.wikimedia.org/T232636 (DStrine) [21:29:01] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, FR-Civi-Dedupe: Civi dedupe: request to Move Related prospect tab data by default - https://phabricator.wikimedia.org/T232625 (DStrine) [21:29:03] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, FR-Civi-Dedupe: Civi dedupe: if existing CID has email opt-out, ask script to keep that when merging new ones - https://phabricator.wikimedia.org/T232151 (DStrine) [21:29:05] Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, FR-Civi-Dedupe: Middle name and initial appearing in first or last name fields causing lots of manual dedupe - https://phabricator.wikimedia.org/T230954 (DStrine) [21:29:07] Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, Fundraising Sprint Visual Basic Instinct, and 4 others: Civi: create annual $ summary TY email button - https://phabricator.wikimedia.org/T221271 (DStrine) [21:29:09] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, and 3 others: We need merge handling for opt in - https://phabricator.wikimedia.org/T232037 (DStrine) [21:29:11] Fundraising Sprint Visual Basic Instinct, Fundraising Sprint w 2019, Fundraising-Backlog, Fr-cross-training, MediaWiki-extensions-CentralNotice: Rebase and finish Geotargeting (sub national targeting) - https://phabricator.wikimedia.org/T226438 (DStrine) [21:29:29] Fundraising Sprint A series of unfortunate event handlers, Fundraising Sprint Bert and Ernie's Excellent Adventure, Fundraising Sprint Land before Timeouts, Fundraising Sprint Men In Slack, and 19 others: Queries and maybe scripts to verify equivalence of d... - https://phabricator.wikimedia.org/T198752 [21:30:18] (PS8) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [21:30:29] Fundraising Sprint w 2019, Fundraising-Backlog: Special Chartacters do not export well from civi - https://phabricator.wikimedia.org/T237564 (NNichols) @Eileenmcnaughton I just moved it into the Tech folder - "Civi Names with Special Characters - Export" [21:45:11] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Special Chartacters do not export well from civi - https://phabricator.wikimedia.org/T237564 (Eileenmcnaughton) @NNichols I think I have it now but I think we need to jump on a screen share to compare what we are seeing [21:51:07] ejegg: can I maybe talk you through the omnirecipient one & get that merged so I can try running / fixing stuff [21:51:35] Also there are a few things in this deploy - any reservations ? https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/550542/-1..1 [21:52:43] Fundraising-Backlog: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (CCogdill_WMF) [21:52:56] Fundraising-Backlog: Dedupe suggestion: track down OG contact records for "new" donors - https://phabricator.wikimedia.org/T238156 (CCogdill_WMF) p:Triage→Normal [21:53:14] I guess the ones I don't recognise are "Add elements to monthly convert thank you email", "Use amount to match currency in recur notification" "Update SmashPig for dlocal audit" - that last one might need a not-done-yet vendor update [21:53:47] eileen yep that last one does need a vendor update [21:53:59] ejegg: ok I can do that if otherwise fine [21:54:01] and those should be ok to deploy [21:54:23] i can talk about the omnimail thing in 5 min [21:54:25] thanks! [21:54:39] cool - hangout me when you are ready? [21:55:01] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550542 (owner: Eileen) [21:58:58] (PS1) Eileen: Vendor update - smash-pig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/550560 [21:59:21] (CR) Eileen: [C: +2] Vendor update - smash-pig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/550560 (owner: Eileen) [22:05:01] (Merged) jenkins-bot: Vendor update - smash-pig [wikimedia/fundraising/crm/vendor] - https://gerrit.wikimedia.org/r/550560 (owner: Eileen) [22:06:22] (PS1) Eileen: Vendor update for Smash-pig [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550563 [22:08:02] (CR) Eileen: [C: +2] Vendor update for Smash-pig [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550563 (owner: Eileen) [22:10:15] eileen: so far that omnimail patch looks pretty understandable [22:10:29] ejegg: but awful :-) [22:10:30] mostly just parameterizing the existing fix [22:10:57] ohhh, just got to the awful bit [22:11:00] I'll need to do a cleanup on the rows coming in around now in order to remove any dupes once the tz gets forced to be right [22:12:30] right, there's no event id we can use to de-dupe them? [22:13:23] no - it's the combo - but that other script cleans them up [22:13:54] so there will be a handful created for wherever it's up to that I'll find & fix & from then on we should be forcing GMT & it will be OK [22:14:13] the combo of the 2 scripts + coffee & a bunch of sql queries & I can nail it [22:14:14] ok, thank you for the verbose comments on the ugly bit [22:14:25] It was therapy [22:14:33] i'll just pull the code down and take another look in my ide before +2ing [22:15:49] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550542 (owner: Eileen) [22:25:39] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550563 (owner: Eileen) [22:31:37] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for msaloky - https://phabricator.wikimedia.org/T237776 (Dwisehaupt) No longer working with us. Revoking the certificate. [22:32:55] !log civicrm revision changed from bfa53ee611 to 3c15db25bb, config revision is d678dbcaa5 [22:32:58] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [22:42:04] (PS1) Ejegg: Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) [22:42:46] fr-tech ok ^^^ is ready to review and test more. I've only tested with a few of the amounts available on the Ingenico test card list [22:43:53] (CR) jerkins-bot: [V: -1] Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [22:44:09] oops, let's see what's up with that [22:45:06] oh, file needs a rename [22:45:56] ejegg i was looking at the name change one and that was failing too [22:46:45] (PS3) Ejegg: Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) [22:46:47] (PS2) Ejegg: Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) [22:46:57] k, I think that should fix it [22:48:03] ok, back to the omnimail fix [23:00:18] Wikimedia-Fundraising-Banners: RML popup remains from large fr-banner after scrolling down and switching to nag - https://phabricator.wikimedia.org/T237699 (jbolorinos-ctr) Fixed by adding frb-rml-displayed class to frb-nag when the frb-rml-link is clicked. Banner preview of fix available here: https://met... [23:12:36] the omnimail jobs are failing with login failed. is it possible that our silverpop passwords got out of sync again? [23:29:56] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Get paypal to prevent older paypal recurring from sending inaccurate cancel email - https://phabricator.wikimedia.org/T236506 (XenoRyet) @MBeat33 setting the number of retries to unlimited is the...