[00:13:01] dwisehaupt: oh dang, I was pretty sure they matched. I'll check again [00:14:53] ejegg: coolthx. [00:15:47] well, they certainly look synchronized [00:16:05] and the nightly upload has been working [00:16:36] y [00:16:59] sorry, yeah. i'm not sure what's up with this. [00:17:37] Hmm, civi's got the same outbound IP as inbound, right? [00:17:47] that account does have IP restrictions [00:17:52] should..... [00:18:09] nothing should have changed in relation to that. [00:18:53] the upload account isn't blocked at least [00:20:18] I hit something yesterday with a concurrent api limit [00:20:40] hmm, did the errors come at login? [00:20:55] I can log in with the pw listed in the settings [00:21:22] I was running from the command line & yeah I saw them there - but it WAS working yesterday on the command line - I stopped because I need to repair some [00:22:00] i'm not sure. [00:22:16] and the ip list has the IP address that civi resolves to [00:22:38] the ones that are failing are: group member data and recipient data [00:22:51] ohh, so those are API, not screen-scrape [00:23:07] I just tested the UI login we use for screen-scrape [00:23:07] yeah - just trying now on the command line [00:23:12] but i see some that are succesful in those. [00:23:22] I think it might be what I hit yesterday- ie. them throttling us [00:23:28] like omnimail_groupmember_load-20191113-001601.log [00:24:16] oh yeah, the last 4 or 5 for that job seem fine, from the processcontrol logs [00:26:11] yeah recipientload is working at the moment [00:26:28] I think we can assume some sort of catch up happening [00:26:32] so, looking at these, they don't use any lock file. [00:26:59] so i'm thinking that maybe as we were catching up, a process ran long and we ran into concurrent login restrictions. [00:27:14] just a guess, but may be able to suss it out in log files. [00:27:18] yeah likely - probably still a bit of catch up on them [00:30:49] ejegg: once I get that patch out I'll need to re-run a couple of repair them anyway :-( [00:31:19] i'm not seeing it in the logs at least in terms of overruns. but i need to write things down and sort them out. bouncing between too many screens to keep track. [00:42:05] (CR) Ejegg: [C: +2] "Oy, that default fudging is unfortunate. Thanks for all the explanatory comments! Let's hope this is the last round of fixups." [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550454 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [00:42:29] thanks ejegg [00:46:20] looking at the logs, no process overrun. [00:46:56] and there were at least 1 instance of non failure in the middle of the recipient load failures. [00:47:24] (Merged) jenkins-bot: Revisit Omnimail timestamp misery. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550454 (https://phabricator.wikimedia.org/T236855) (owner: Eileen) [00:49:01] same with the group load. [00:49:16] at least a few successes sprinkled in. [00:49:52] so i think this wasn't a config issue on our side. possibly it's on their end or some connectivity issue inbetween. [00:50:35] ejegg: eileen: thanks for having a look. [00:51:09] yep [00:54:51] this just gives me a little motivation to wrap up that metric collection on process_control jobs i've been backburnering. [00:56:54] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550577 [01:06:38] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550577 (owner: Eileen) [01:32:41] (CR) Eileen: [C: +2] "recheck" [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550577 (owner: Eileen) [01:35:37] !log civicrm revision changed from 3c15db25bb to a3714003ff, config revision is d678dbcaa5 [01:35:42] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [01:36:45] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Sysadmin Kane, Fundraising Sprint Trojan Horse Wisperer, Fundraising Sprint Usual Subscripts, and 6 others: Annual totals receipt thank you email for recurring donors - https://phabricator.wikimedia.org/T195907 (Eileenmcnaughton) @Ejeg... [01:48:59] (PS14) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [01:49:01] (PS9) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [01:49:03] (PS8) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [01:49:05] (PS6) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (https://phabricator.wikimedia.org/T232152) [01:49:07] (PS1) Eileen: Comment block fixes - use right urls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550579 [01:49:09] (PS1) Eileen: =Comment updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550580 [01:49:11] (PS1) Eileen: Add boilerplate hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550581 [01:49:13] (PS1) Eileen: Good intentions boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550582 [01:58:00] Wikimedia-Fundraising-Banners: RML popup remains from large fr-banner after scrolling down and switching to nag - https://phabricator.wikimedia.org/T237699 (jbolorinos-ctr) Actually this issue has not been fixed yet, now the issue appears when clicking "Back". Will need to investigate this more [02:09:43] (CR) XenoRyet: [C: +2] Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [02:11:33] (Merged) jenkins-bot: Rename upsell to monthlyConvert [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550537 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [02:15:14] (PS1) Eileen: More missing boilerplate - api4 psr [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 [05:38:53] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, FR-Civi-Dedupe, FR-Civi-Prospect: Possible addition to the deduper tool? - https://phabricator.wikimedia.org/T229927 (Eileenmcnaughton) [05:39:57] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, FR-Civi-Dedupe, FR-Civi-Prospect: Possible addition to the deduper tool? - https://phabricator.wikimedia.org/T229927 (Eileenmcnaughton) @MBeat33 @NNichols @LeanneS @RLewis we had a poke at this form in fundraising backlog today and... [05:41:48] Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, FR-Civi-Dedupe, FR-Civi-Prospect: Possible addition to the deduper tool? - https://phabricator.wikimedia.org/T229927 (Eileenmcnaughton) @ejegg @cstone @andyRussG I took another look at this & it was that Partner.Partner needed quotes... [05:43:06] (PS2) Eileen: More missing boilerplate - api4 psr [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 [05:44:50] (CR) jerkins-bot: [V: -1] More missing boilerplate - api4 psr [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 (owner: Eileen) [05:52:59] (CR) Eileen: "recheck" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 (owner: Eileen) [06:25:18] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 8 minutes ago with 2 failures. Failed resources (up to 3 shown): Package[php7.0-redis],Package[php7.0-sqlite] [06:30:18] PROBLEM - check_puppetrun on frdev1001 is CRITICAL: CRITICAL: Puppet has 2 failures. Last run 13 minutes ago with 2 failures. Failed resources (up to 3 shown): Package[php7.0-redis],Package[php7.0-sqlite] [06:35:18] RECOVERY - check_puppetrun on frdev1001 is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [11:02:51] (PS3) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 [11:05:01] (PS4) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 [12:43:49] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert pwk modal variant 003 (alt headline text) - https://phabricator.wikimedia.org/T237779 (jgleeson) a:jgleeson [14:29:40] (CR) Jgleeson: "The ranges are working ok for me. The flash screen is a bit strange. Could we default to hidden and only show the popup if applicable?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [14:30:34] jgleeson: yeah, we should default to hidden. How about I do that in a separate patch set? [14:30:54] sounds good ejegg [14:50:46] i was getting tripped up trying to test because the second donation was showing as recurring. wondering if that could cause unintended recurring donations if ppl share a computer [14:51:15] lemme see if there's a better way to set the recurring flag just for the add-on donation message [15:38:05] ah about ^^^, I had actually used the wrong testing link :P no cause to worry [15:38:43] currently very puzzled why the simple solution to hide/show modal isn't working [15:38:51] suspecting it has to do with load order [16:20:29] PROBLEM - Host payments2003 is DOWN: PING CRITICAL - Packet loss = 100% [16:23:19] RECOVERY - Host payments2003 is UP: PING OK - Packet loss = 0%, RTA = 36.33 ms [16:23:36] (PS1) Ejegg: Hide monthly convert modal till we have an amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550712 [16:25:37] fr-tech, any news for scrum of scrums? [16:33:21] PROBLEM - Host alnilam is DOWN: PING CRITICAL - Packet loss = 100% [16:38:19] RECOVERY - Host alnilam is UP: PING OK - Packet loss = 0%, RTA = 36.30 ms [16:43:08] fundraising-tech-ops, DC-Ops, Operations, decommission: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Jgreen) [16:49:17] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert pwk modal variant 001 (no diff amt option) - https://phabricator.wikimedia.org/T237777 (Ejegg) p:Triage→Normal a:Ejegg [16:56:12] (PS1) Ejegg: Monthly convert: variant without alt amount link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550717 (https://phabricator.wikimedia.org/T237777) [16:58:45] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert pwk modal variant 002 (alt paragraph text) - https://phabricator.wikimedia.org/T237778 (Ejegg) p:Triage→Normal a:Ejegg [17:06:04] (PS1) Ejegg: Monthly convert: variant 002, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) [17:15:13] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:17:40] fundraising-tech-ops, DC-Ops, Operations, decommission, Patch-For-Review: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Jgreen) [17:20:10] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [17:20:50] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert pwk modal variant 004 (alt headline text) - https://phabricator.wikimedia.org/T238139 (Ejegg) p:Triage→Normal a:Ejegg [17:23:18] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frnetmon1001 - https://phabricator.wikimedia.org/T232137 (Cmjohnson) [17:27:07] fundraising-tech-ops, Operations, ops-eqiad: rack/setup/install frban1001.eqiad.wmnet - https://phabricator.wikimedia.org/T234068 (Cmjohnson) [17:28:17] (PS2) Ejegg: Monthly convert: variant 002, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) [17:28:19] (PS1) Ejegg: Monthly convert variant 004: restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) [17:28:59] (PS2) Ejegg: Monthly convert: variant 004, restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) [17:30:00] PROBLEM - Host bellatrix is DOWN: PING CRITICAL - Packet loss = 100% [17:30:16] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 558950 Threads: 3 Questions: 51568069 Slow queries: 362286 Opens: 8622 Flush tables: 1 Open tables: 200 Queries per second avg: 92.258 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [17:35:16] RECOVERY - Host bellatrix is UP: PING OK - Packet loss = 0%, RTA = 36.33 ms [18:10:10] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 41 failures. Last run 6 minutes ago with 41 failures. Failed resources (up to 3 shown) [18:10:10] PROBLEM - check_puppetrun on bellatrix is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 6 minutes ago with 29 failures. Failed resources (up to 3 shown) [18:12:16] PROBLEM - check_puppetrun on frmon2001 is CRITICAL: CRITICAL: Puppet has 39 failures. Last run 8 minutes ago with 39 failures. Failed resources (up to 3 shown) [18:12:30] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: Monthly convert pwk modal variant 003 (alt headline text) - https://phabricator.wikimedia.org/T237779 (jgleeson) a:jgleeson→None [18:15:10] PROBLEM - check_puppetrun on frauth2001 is CRITICAL: CRITICAL: Puppet has 41 failures. Last run 11 minutes ago with 41 failures. Failed resources (up to 3 shown) [18:15:20] PROBLEM - check_puppetrun on bellatrix is CRITICAL: CRITICAL: Puppet has 29 failures. Last run 11 minutes ago with 29 failures. Failed resources (up to 3 shown) [18:17:24] RECOVERY - check_puppetrun on frmon2001 is OK: OK: Puppet is currently enabled, last run 1 minute ago with 0 failures [18:20:13] RECOVERY - check_puppetrun on frauth2001 is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [18:20:23] RECOVERY - check_puppetrun on bellatrix is OK: OK: Puppet is currently enabled, last run 4 minutes ago with 0 failures [18:29:54] it looks like the UK labour party are hosting a mass video call inviting the public to join and listen in using zoom. I wonder how that will hold up? https://labour.zoom.us/webinar/register/WN_pAo9AIkgSXqA_32ukZj17w?utm_source=bsd&utm_medium=email&utm_campaign=GE19-novzoom&source=20191113_GE19-novzoom&subsource=bsd_email [18:50:13] fundraising-tech-ops, DC-Ops, Operations, decommission, Patch-For-Review: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Jgreen) [18:50:25] fundraising-tech-ops, DC-Ops, Operations, decommission, Patch-For-Review: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Jgreen) [18:50:43] fundraising-tech-ops, DC-Ops, Operations, decommission, Patch-For-Review: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Jgreen) a:Jgreen→Papaul [19:09:12] (PS3) Ejegg: Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) [19:09:14] (PS2) Ejegg: Hide monthly convert modal till we have an amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550712 [19:09:16] (PS2) Ejegg: Monthly convert: variant 001, no alt amount link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550717 (https://phabricator.wikimedia.org/T237777) [19:12:49] (PS3) Ejegg: Monthly convert: variant 002, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) [19:12:51] (PS3) Ejegg: Monthly convert: variant 004, restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) [19:18:09] (PS1) Jgleeson: Monthly convert: variant 003, restate donate title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) [19:18:53] (PS4) Ejegg: Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) [19:18:55] (PS3) Ejegg: Hide monthly convert modal till we have an amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550712 [19:18:57] (PS3) Ejegg: Monthly convert: variant 001, no alt amount link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550717 (https://phabricator.wikimedia.org/T237777) [19:20:49] (PS4) Ejegg: Monthly convert: variant 002, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) [19:20:51] (PS4) Ejegg: Monthly convert: variant 004, restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) [19:22:52] Fundraising-Backlog: Monthly convert pwk modal variant 005 (alt paragraph text) - https://phabricator.wikimedia.org/T238140 (Cstone) a:Cstone [19:22:55] Fundraising-Backlog: Monthly convert pwk modal variant 006 (alt button text) - https://phabricator.wikimedia.org/T238141 (XenoRyet) a:XenoRyet [19:23:22] Fundraising-Backlog: Monthly convert pwk modal variant 008 (alt paragraph text) - https://phabricator.wikimedia.org/T238144 (Cstone) a:Cstone [19:28:31] (PS2) Jgleeson: Monthly convert: variant 003, restate donate title [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) [19:32:28] well to my surprise zoom is holding up pretty well [20:06:21] Fundraising-Backlog: No fraud score for jibberish names in fraud filter - https://phabricator.wikimedia.org/T238254 (EMartin) [20:13:13] (PS1) Cstone: Monthly convert: variant 005, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550748 (https://phabricator.wikimedia.org/T238140) [20:15:13] PROBLEM - check_mysql on frdev1001 is CRITICAL: Slave IO: Yes Slave SQL: No Seconds Behind Master: (null) [20:20:13] PROBLEM - check_mysql on frdev1001 is CRITICAL: SLOW_SLAVE CRITICAL: Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 1333 [20:30:13] RECOVERY - check_mysql on frdev1001 is OK: Uptime: 569750 Threads: 4 Questions: 54483418 Slow queries: 362680 Opens: 9458 Flush tables: 1 Open tables: 200 Queries per second avg: 95.626 Slave IO: Yes Slave SQL: Yes Seconds Behind Master: 0 [20:49:44] (PS3) Jgleeson: Monthly convert: variant 003, restate donate amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) [20:51:12] fr-tech, I just realised I did need to add the js from ejegg's variant 004 patch as the donate amount wasn't being injected as expected. I've just pushed up the fix. cstone i think you should be able to rebase straight over it [20:51:53] this is the latest https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/550740/ [20:54:12] (PS4) Jgleeson: Monthly convert: variant 003, restate donate amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) [20:55:37] grrr sorry fr-tech that last commit was missing the updated extension.json file to make the new _003 js available. I just added it in so you _SHOULD_ be albe to just rebase over that in the event that you've started from an earlier version of the patch chain [20:58:19] cool, just testing now [20:58:57] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for msaloky - https://phabricator.wikimedia.org/T237776 (Dwisehaupt) Open→Resolved p:Triage→Normal [20:59:37] yep, looks good! [21:01:16] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (MBeat33) One nice-to-have on a preferences page: * Do you prefer in emails to be addressed formall... [21:02:12] jgleeson: oh hm, those js scripts are identical [21:02:39] Fundraising Sprint Princess Mongodb, Fundraising-Backlog, Epic: Investigation: Create Preference Center for donors to manage email subscription preferences - https://phabricator.wikimedia.org/T125272 (CCogdill_WMF) Cool suggestion! I like it. [21:04:24] jgleeson: yeah shameless duplication but I'm sure we can share that file due to the variants order. I could update 004 to use the file from 003 but that felt ugly? what do you think [21:04:26] jgleeson: just so the numbers make sense, i am going to rebase _004 past _003 [21:04:31] ejegg: * [21:04:34] and then I'll just point it at the _003 js [21:04:40] ha! [21:04:43] you read my mind [21:05:14] s/I'm sure/I'm NOT sure/ [21:05:58] also ejegg I'm still getting the monthlyConvert popup flashing when I donate below the min threshhold [21:06:04] on PS4 of that patch [21:06:19] this one right? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/DonationInterface/+/550570/ [21:06:41] oooo sorry [21:06:48] I see you added the fix in a separate patch [21:06:57] ah yeah [21:07:05] testing that one now [21:07:07] i guess I thought that fix would be bigger, so I split it out [21:07:26] * jgleeson note to self.. look up sometimes [21:08:41] thanks jgleeson I need to go bring this guinea pig back to the shelter but I'll be back in a bit to fix mine [21:09:24] np. hope he finds a good family! [21:09:27] he/she* [21:10:02] hah she and im sure she will shes so good, ive had much crankier fosters [21:11:18] (PS5) Ejegg: Monthly convert: variant 003, restate donate amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) (owner: Jgleeson) [21:11:20] (PS5) Ejegg: Monthly convert: variant 004, restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) [21:11:39] ok, rebased in order, and with the JS de-duplicated [21:12:10] (PS2) Ejegg: Monthly convert: variant 005, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550748 (https://phabricator.wikimedia.org/T238140) (owner: Cstone) [21:12:28] thanks ejegg, sorry for being lazy on that one I really should have done that [21:12:34] nah, no worries [21:13:01] (CR) Ejegg: [C: +2] Monthly convert: variant 003, restate donate amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) (owner: Jgleeson) [21:13:48] (CR) Jgleeson: [C: +2] "Looks good. Working for me across different amounts. The pop-up flash is glitchy but I know we fix that in a follow-on patch!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [21:14:03] thanks jgleeson! [21:14:12] (CR) Jgleeson: [C: +2] "Fixes the issue for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550712 (owner: Ejegg) [21:15:18] (Merged) jenkins-bot: Monthly convert: better suggested amount, skip on min/max [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550570 (https://phabricator.wikimedia.org/T237775) (owner: Ejegg) [21:16:01] (Merged) jenkins-bot: Hide monthly convert modal till we have an amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550712 (owner: Ejegg) [21:17:00] (CR) Jgleeson: [C: +2] "Nice! Workings as expected for me. no alt link visible." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550717 (https://phabricator.wikimedia.org/T237777) (owner: Ejegg) [21:18:24] (Merged) jenkins-bot: Monthly convert: variant 001, no alt amount link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550717 (https://phabricator.wikimedia.org/T237777) (owner: Ejegg) [21:19:44] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mbrent - https://phabricator.wikimedia.org/T238266 (Dwisehaupt) [21:20:30] (CR) Jgleeson: [C: +2] "Looking good. showing the expected new text for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) (owner: Ejegg) [21:21:29] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mhernandez - https://phabricator.wikimedia.org/T238267 (Dwisehaupt) [21:22:16] (Merged) jenkins-bot: Monthly convert: variant 002, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550719 (https://phabricator.wikimedia.org/T237778) (owner: Ejegg) [21:22:19] (Merged) jenkins-bot: Monthly convert: variant 003, restate donate amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550740 (https://phabricator.wikimedia.org/T237779) (owner: Jgleeson) [21:25:04] hmmm ejegg I'm getting some display weirdness on 004 since the reorder change [21:25:24] oh shoot, what's the weirdness? [21:26:19] it's just appending the html of the modal below the form [21:26:30] with no css? [21:27:08] I just went back to 003 to see if that was the same and that appears to still work [21:27:33] and you're looking at 004 on top of 003? not just cherry-picked 004 in isolation? [21:27:42] cause the rebased 004 depends on the 003 one being there [21:28:20] I did `git review -d 550723` [21:28:25] lemme try it again [21:29:50] (CR) Ejegg: [C: +2] Monthly convert: variant 005, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550748 (https://phabricator.wikimedia.org/T238140) (owner: Cstone) [21:30:07] now it works! [21:30:10] @_@ [21:30:27] hmm maybe it's my funky set up [21:30:38] but it worked that time [21:31:44] I saw the same thing earlier when I broke 003. It was failing to pull in the 003.js file and just showing the html elements appended to the bottom of the form and adding the 003.js file to the extension.json file fixed it [21:31:45] (PS1) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [21:32:15] I tried add &debug=1 but that doesn't work all the time on mw-vagrant for some reason. It shows lots of failed request to other jquery libs [21:32:31] oh weird [21:32:35] might me the multiwiki set up [21:32:47] i wonder if that has to do with its issue with images [21:32:53] yeah, exactly [21:33:04] how it looks on the main wiki for images included in extensions [21:33:21] i guess it probably does the same thing when trying to load resourceloader bits as files [21:33:28] (CR) jerkins-bot: [V: -1] Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [21:34:05] (CR) Jgleeson: [C: +2] "working as expected for me!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) (owner: Ejegg) [21:35:39] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert pwk modal variant 007 (alt "different amount" link text) - https://phabricator.wikimedia.org/T238142 (Ejegg) p:Triage→Normal a:Ejegg [21:35:52] (Merged) jenkins-bot: Monthly convert: variant 004, restate donated amount [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550723 (https://phabricator.wikimedia.org/T238139) (owner: Ejegg) [21:35:54] (Merged) jenkins-bot: Monthly convert: variant 005, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550748 (https://phabricator.wikimedia.org/T238140) (owner: Cstone) [21:36:26] (PS2) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [21:38:22] (CR) jerkins-bot: [V: -1] Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [21:42:21] (PS3) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [21:48:06] Ok, variant 006 should be ready for review. [21:48:36] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 006 (alt button text) - https://phabricator.wikimedia.org/T238141 (XenoRyet) [21:48:37] (CR) Ejegg: [C: -1] "Button text is vertically misaligned - a lot more space below than above. And the link in qqq.json is unhelpful in this case." (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [21:51:29] Actually looks like it needs a few other css fixes as well. [21:54:55] (PS1) Ejegg: Monthly convert: variant 007, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550760 (https://phabricator.wikimedia.org/T238142) [21:55:38] (PS2) Ejegg: Monthly convert: variant 007, change different amt link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550760 (https://phabricator.wikimedia.org/T238142) [22:03:31] (PS4) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [22:03:44] Ok, that one looks better [22:05:13] (CR) jerkins-bot: [V: -1] Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [22:07:01] (PS5) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [22:13:52] Ok, now that one should be good. [22:14:26] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert pwk modal variant 008 (alt paragraph text) - https://phabricator.wikimedia.org/T238144 (Cstone) [22:15:07] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert pwk modal variant 008 (alt paragraph text) - https://phabricator.wikimedia.org/T238144 (Cstone) [22:15:17] Gonna go grab some food, back in a while. [22:16:01] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26): Monthly convert pwk modal variant 005 (alt paragraph text) - https://phabricator.wikimedia.org/T238140 (Cstone) [22:16:07] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26): Monthly convert pwk modal variant 005 (alt paragraph text) - https://phabricator.wikimedia.org/T238140 (Cstone) [22:28:54] (CR) Ejegg: [C: -1] "Looks like most of that CSS is duplicated from the original file. Can you cut out all but the stuff that actually changes?" (3 comments) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [22:47:32] are you winning on Sam's last minute requests? [22:50:05] (PS6) XenoRyet: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) [22:50:09] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26): Monthly convert pwk modal variant 003 (alt headline text) - https://phabricator.wikimedia.org/T237779 (Ejegg) a:jgleeson [22:56:45] Ok, ready for another look. Probably shouldn't have tried to so quick and been more methodical instead. [22:56:59] hmph, now I'm hitting an edge case in tests where the same order ID is being seen on return and the result switcher thinks the frame is already busted [22:57:40] not a great user experience, and I can see it being possible to get there by mistake [22:57:51] anyway, I think that variant is fine [22:58:04] just going to clear the session to test again [22:59:18] oh dang, I was clearing the session by loading an adyen frame (since we reset the session on gateway switch) [22:59:41] and the Zip field sans city/state looks gnarly in the new top-labeled world [23:00:44] That it does [23:24:38] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix postal code field when not showing city or state - https://phabricator.wikimedia.org/T238278 (Ejegg) [23:27:54] (PS7) Ejegg: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [23:28:16] (CR) Ejegg: [C: +2] Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [23:28:23] (PS3) Ejegg: Monthly convert: variant 007, change different amt link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550760 (https://phabricator.wikimedia.org/T238142) [23:28:40] ok, that lines up 007 for review [23:28:49] 10-4, I'll take a look. [23:29:15] cstone rotation's come back around to you if you wanna take a crack at #8 now [23:29:27] yeah i was just gona say im finishing up eating and i can get back at it [23:30:19] (Merged) jenkins-bot: Monthly Convert: Variant 006, alternate button text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550757 (https://phabricator.wikimedia.org/T238141) (owner: XenoRyet) [23:35:20] (CR) XenoRyet: [C: +2] Monthly convert: variant 007, change different amt link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550760 (https://phabricator.wikimedia.org/T238142) (owner: Ejegg) [23:36:51] (Merged) jenkins-bot: Monthly convert: variant 007, change different amt link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550760 (https://phabricator.wikimedia.org/T238142) (owner: Ejegg) [23:40:14] (CR) Ejegg: [C: -1] "This looks great! There's just something a little fishy with the contact_source field name. It seems to be working in your tests, but it d" (4 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [23:44:07] (PS1) Cstone: Monthly convert: variant 008, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550772