[00:21:17] (PS1) XenoRyet: Monthly Convert: variant 009 New headline, paragraph, button and link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 [00:36:04] (CR) XenoRyet: "Does this make sense, given that this variant is just a combo of other existing variants, or should we let this one have its own messages " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [00:38:29] (CR) Cstone: "I like the idea of comboing them like this but are variants usually changed when they are being tested?" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [00:40:42] (CR) XenoRyet: "Possibly not, now that I think about it. They'd want to keep the existing variants around to A/B against. I think changes would go in a " [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [00:47:46] (PS1) Eileen: Reformat arrays to short-style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550775 [04:02:50] (PS1) Eileen: Add some indexes that are missing. * * These are on relatively small tables so haven't lept out but I hit a query * I couldn't due due to the missing index on civicrm_mailing_stats.mailing_id * and figured while I'm at it I should add to civicrm_group. The table is small so * I only noticed the lack of index when the server was on go-slow. Both tables are small * enough this should be near-instant. * * B [04:02:51] https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) [05:35:29] (CR) XenoRyet: [C: +2] Monthly convert: variant 008, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550772 (owner: Cstone) [05:37:18] (Merged) jenkins-bot: Monthly convert: variant 008, different appeal paragraph text [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550772 (owner: Cstone) [07:25:45] !log process-control config revision is d3ebeddcc1 (I renabled the old back fill job) [07:25:48] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [07:29:16] !log process-control config revision is 909108622d re-enable omnirecipient date repair job [07:29:19] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [07:41:28] !log process-control config revision is b7c2cf7227 - disabled backfill again - some error? [07:41:32] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [08:03:42] !log process-control config revision is 6adc66a20b re-enable backfill [08:03:45] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [13:40:27] Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix postal code field when not showing city or state - https://phabricator.wikimedia.org/T238278 (Pcoombe) {T236077} is something similar [14:38:46] (PS2) Ejegg: Monthly Convert: variant 009 New headline, paragraph, button and link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [14:39:13] (PS3) Ejegg: Monthly Convert: variant 009 New headline, paragraph, button and link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [14:39:28] (CR) Ejegg: [C: +2] "Combo looks good!" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [14:40:57] (Merged) jenkins-bot: Monthly Convert: variant 009 New headline, paragraph, button and link [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550773 (owner: XenoRyet) [14:50:41] (PS1) Ejegg: Monthly convert: variant 010, ask donor by name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550846 (https://phabricator.wikimedia.org/T238147) [15:01:50] hi fr-tech! [15:01:56] hey ejegg :) [15:02:04] how's your day been? [15:02:51] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 010 (alt headline text) - https://phabricator.wikimedia.org/T238147 (Ejegg) p:Triage→Normal a:Ejegg [15:03:02] fr-tech heads up, I'm going to reboot the eqiad bastion server in a minute [15:03:59] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, Patch-For-Review: Monthly convert pwk modal variant 009 (COMBO! New headline, paragraph, button and link) - https://phabricator.wikimedia.org/T238145 (Ejegg) p:Triage→Normal a:XenoRyet [15:04:10] ah not too bad so far just been finalising some house purchase stuff and speaking to agents who wanna show people round our current house to rent it to other folks :/ just looking at your latest variant patch [15:04:13] thanks for the warning Jeff_Green [15:04:15] how about you? [15:04:36] just getting started! but it's looking to be a sunny day today after a few gray ones [15:04:59] nice! still grey here :( [15:05:25] ah well [15:07:01] ejegg: I was checking out some failmail earlier and it looks like the 3 jobs filling up the inbox are all completing ok [15:07:17] so I'm not sure why they're sending back a non-zero exit code [15:07:20] the logs looks good [15:07:29] reboot is done! [15:07:46] I'm gonna try to run them locally to see if I can work out what's up [15:07:59] thanks Jeff_Green ! [15:10:56] jgleeson: I think the 'timeout' result on the dedupe job is just a matter of them running longer than the process-control job is defined for [15:11:16] which could be a problem if there are ever two jobs grabbing the same contact [15:11:47] so maybe we can configure the jobs to bite off smaller chunks? [15:12:27] process-control is designed to try to kill jobs at the end of their allotted timespan [15:13:07] but the drush wrapper actually spawns its own child job running under a different user, so process-control isn't able to kill it [15:13:18] and it does end up completing, even though it goes over time [15:21:11] (PS1) Ejegg: Ingenico: mark attempts processed by checkout ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550857 [15:23:30] (CR) jerkins-bot: [V: -1] Ingenico: mark attempts processed by checkout ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550857 (owner: Ejegg) [15:32:53] (PS1) Ejegg: Fix width of lone address fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550861 (https://phabricator.wikimedia.org/T238278) [15:38:49] (PS2) Ejegg: Ingenico: mark attempts processed by checkout ID [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550857 [15:44:45] hmmm fr-tech so now my local paymentswiki links have suddenly started working with correct port numbers ... :/ [15:48:01] (CR) Jgleeson: [C: +2] Monthly convert: variant 010, ask donor by name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550846 (https://phabricator.wikimedia.org/T238147) (owner: Ejegg) [15:48:21] jgleeson: woohoo? [15:48:40] I'm not sure why [15:48:47] @_@ [15:49:33] (Merged) jenkins-bot: Monthly convert: variant 010, ask donor by name [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550846 (https://phabricator.wikimedia.org/T238147) (owner: Ejegg) [15:52:53] (CR) Jgleeson: [C: +2] "Fixes issue for me. Tested Adyen and dLocal." [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550861 (https://phabricator.wikimedia.org/T238278) (owner: Ejegg) [15:54:42] (Merged) jenkins-bot: Fix width of lone address fields [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550861 (https://phabricator.wikimedia.org/T238278) (owner: Ejegg) [15:55:06] jgleeson: oops, I just noticed it makes a tiny offset for those fields when there are three of them [15:55:36] I'll deploy all the monthly convert stuff and then try to get the CSS fixed for that [15:58:28] hmm not just how to test your repeat attempts patch ejegg [15:58:39] I don't think I can refresh quick enough [16:02:30] jgleeson: that one can wait [16:03:40] I noticed that one when I was reloading on the monthly convert screen [16:56:26] mepps: I've assumed without asking that our call is off due to the childcare being sick? [16:56:48] I'm heading out to pickup oscar so just wanted to confirm in case that isn't the case [16:56:49] no i can make it jgleeson if you want to meet [16:56:57] oh okay [16:57:09] oh hmm maybe catch up after standup if that works? [16:57:15] sorry I should have confirmed [16:58:33] (PS5) Jgleeson: WIP: Added annual thank you emailer extension [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550371 [16:58:49] hey jgleeson i will be back on childcare duty then but no worries! [17:05:15] (PS1) Ejegg: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/550884 [17:05:27] (CR) Ejegg: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/550884 (owner: Ejegg) [17:07:48] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/550884 (owner: Ejegg) [17:11:53] (PS1) Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550886 [17:11:56] (CR) Ejegg: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550886 (owner: Ejegg) [17:16:01] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/550886 (owner: Ejegg) [17:19:14] fundraising-tech-ops, DC-Ops, Operations, decommission: decommission alnilam.frack.codfw.wmnet - https://phabricator.wikimedia.org/T238233 (Papaul) ` papaul@fasw-c-codfw# show | compare [edit interfaces interface-range disabled] member "ge-[0-1]/0/8" { ... } + member "ge-[0-1]/0/9"; [edi... [17:22:11] !log updated payments-wiki from bd907656fb to 30579d34d8 [17:22:14] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [17:36:43] fr-tech be right there [17:45:29] (PS15) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [17:46:12] (CR) Eileen: "Ah ejegg I went back & forth on how best to 'getfields' to avoid cruft - I've switched to a more active filtering & keying by uniquename -" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [17:49:33] (PS16) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) [17:50:13] (CR) Eileen: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. (3 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [17:55:47] (PS10) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [17:55:49] (PS9) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [17:55:52] (PS7) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (https://phabricator.wikimedia.org/T232152) [17:55:54] (PS2) Eileen: Comment block fixes - use right urls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550579 [17:55:56] (PS2) Eileen: =Comment updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550580 [17:56:00] (PS2) Eileen: Add boilerplate hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550581 [17:56:03] (PS2) Eileen: Good intentions boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550582 [17:56:05] (PS3) Eileen: More missing boilerplate - api4 psr [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 [17:56:07] The noise of rebasing :-) [17:57:51] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog, MediaWiki-extensions-DonationInterface: Fix postal code field when not showing city or state - https://phabricator.wikimedia.org/T238278 (DStrine) [18:26:57] Fundraising-Backlog: AVS score in fraud filters - https://phabricator.wikimedia.org/T238352 (EMartin) [18:27:42] applied research into random typing detection: http://bitboost.com/pawsense/ [18:33:29] the research we need [18:43:49] can we rename the filter to "cat-like typing fitler" [18:44:10] that looks like a vb6 app [18:44:13] even better [18:45:07] hang on a minute [18:45:14] you can actually pay for this today> [18:45:47] eileen: do you have a few minutes to talk through some civi extension questions? [19:05:38] (PS1) Ejegg: Fix width of lone address fields without going wiggly [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/550911 (https://phabricator.wikimedia.org/T238278) [19:25:54] (CR) Ejegg: [C: +2] "Looks good and works well!" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [19:31:17] (Merged) jenkins-bot: Introduce the concept of preferred contact, add ability to specify fields to be resolved that way. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549234 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [19:50:10] /ac/ac [20:29:15] Fundraising-Backlog: Ingenico iframe says Donate/Cancel Donation in US, Pay/Cancel elsewhere - https://phabricator.wikimedia.org/T238366 (Pcoombe) [20:45:28] (CR) Ejegg: [C: -1] "A couple of other changes snuck in to the PS8-PS9 rebase" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [21:06:27] (PS11) Eileen: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) [21:11:08] (CR) Eileen: "ejegg fixed - it's because I'm running rpow locally & have to keep hacking to run the tests. Not too sure about the cookies one but I have" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [21:21:07] (PS10) Eileen: Add name_pairs table and resolvers [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549693 [21:21:13] (PS8) Eileen: Update dedupe so that in force mode the details from the preferred contact are retained [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550378 (https://phabricator.wikimedia.org/T232152) [21:21:16] (PS3) Eileen: Comment block fixes - use right urls [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550579 [21:21:18] (PS3) Eileen: =Comment updates [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550580 [21:21:20] (PS3) Eileen: Add boilerplate hook [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550581 [21:21:22] (PS3) Eileen: Good intentions boilerplate [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550582 [21:21:24] (PS4) Eileen: More missing boilerplate - api4 psr [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550584 [21:43:28] Fundraising-Backlog, FR-Adyen: Apple Pay Specs - Adyen - https://phabricator.wikimedia.org/T229039 (DStrine) a:DStrine→None [21:45:02] Fundraising-Backlog, FR-Ingenico: Apple Pay Spec - ingenico - https://phabricator.wikimedia.org/T228944 (DStrine) [21:47:10] (CR) Ejegg: [C: +2] "Looks good. Another bit of ugliness handled in the MergeHandler." (2 comments) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [21:52:32] (Merged) jenkins-bot: Fix merge script to resolve opt in custom field on most recent donor. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [22:02:12] (CR) Eileen: "yay" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/549614 (https://phabricator.wikimedia.org/T232037) (owner: Eileen) [22:13:53] (PS1) Eileen: Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550957 [22:14:24] (CR) Eileen: [C: +2] Merge branch 'master' of https://gerrit.wikimedia.org/r/wikimedia/fundraising/crm into deployment [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/550957 (owner: Eileen) [22:14:56] Fundraising-Backlog, FR-Ingenico, MediaWiki-extensions-DonationInterface: Sending over-long first name field to Ingenico Connect - https://phabricator.wikimedia.org/T228094 (Cstone) This happened again with a 19 character long name on November 13th. Merchant ref 67291182.9 [22:16:24] (PS2) Eileen: Reformat arrays to short-style [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550775 [22:16:26] (PS2) Eileen: Add some indexes that are missing. * * These are on relatively small tables so haven't lept out but I hit a query * I couldn't due due to the missing index on civicrm_mailing_stats.mailing_id * and figured while I'm at it I should add to civicrm_group. The table is small so * I only noticed the lack of index when the server was on go-slow. Both tables are small * enough this should be near-instant. * * B [22:16:27] https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) [22:17:13] (PS3) Eileen: Add some indexes that are missing. * * These are on relatively small tables so haven't lept out but I hit a query * I couldn't due due to the missing index on civicrm_mailing_stats.mailing_id * and figured while I'm at it I should add to civicrm_group. The table is small so * I only noticed the lack of index when the server was on go-slow. Both tables are small * enough this should be near-instant. * * B [22:17:14] https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) [22:18:25] (CR) jerkins-bot: [V: -1] Add some indexes that are missing. * * These are on relatively small tables so haven't lept out but I hit a query * I couldn't due due to the missing index on civicrm_mailing_stats.mailing_id * and figured while I'm at it I should add to civicrm_group. The table is small so * I only noticed the lack of index when the server was on go-slow. Both tables are small * enough this should be near-ins [22:18:25] https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) (owner: Eileen) [22:19:26] (CR) Eileen: "This is the failing query without the index" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) (owner: Eileen) [22:20:15] (PS4) Eileen: Add some indexes that are missing. * * These are on relatively small tables so haven't lept out but I hit a query * I couldn't due due to the missing index on civicrm_mailing_stats.mailing_id * and figured while I'm at it I should add to civicrm_group. The table is small so * I only noticed the lack of index when the server was on go-slow. Both tables are small * enough this should be near-instant. * * B [22:20:16] https://gerrit.wikimedia.org/r/550783 (https://phabricator.wikimedia.org/T236955) [22:23:35] ejegg: I actually sneakily turned on 2 jobs last night without getting them checked - one is the old mailing recipient one & the other is the repair. The repair actually runs over time when it finds stuff - hence the fail mail but I don't want to add old entries without fixing any date double ups [22:24:35] the other failmail is a date thing that to need to patch - it's setting the timezone in the wrong order [22:24:59] which gives valid data but sometimes it concludes it can't run because the end date is before the start date. [22:25:06] I'll dig on that [22:27:49] ah right [22:29:30] !log civicrm revision changed from a3714003ff to ae9b3819cd, config revision is 6adc66a20b [22:29:33] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [23:45:20] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mhernandez - https://phabricator.wikimedia.org/T238267 (Dwisehaupt) Emailed into letter. Awaiting confirmation for regenerating cert. [23:45:38] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for mbrent - https://phabricator.wikimedia.org/T238266 (Dwisehaupt) Emailed into letter. Awaiting confirmation for regenerating cert.