[06:55:15] PROBLEM - check_puppetrun on mintaka is CRITICAL: CRITICAL: Puppet has 1 failures. Last run 9 minutes ago with 1 failures. Failed resources (up to 3 shown): Package[php7.0-redis] [07:00:15] RECOVERY - check_puppetrun on mintaka is OK: OK: Puppet is currently enabled, last run 3 minutes ago with 0 failures [16:28:00] (PS3) Ejegg: Simplify ternary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550996 (owner: Eileen) [16:28:06] (CR) Ejegg: [C: +2] Simplify ternary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550996 (owner: Eileen) [16:28:29] (PS4) Ejegg: Make command line running easier by setting defaults [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550997 (owner: Eileen) [16:28:43] (CR) Ejegg: [C: +2] Make command line running easier by setting defaults [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550997 (owner: Eileen) [16:33:26] (PS2) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [16:33:59] (Merged) jenkins-bot: Simplify ternary [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550996 (owner: Eileen) [16:34:37] (Merged) jenkins-bot: Make command line running easier by setting defaults [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/550997 (owner: Eileen) [17:09:57] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Civi to IBM export: Ensure CIDs ordered in reverse chronological order - https://phabricator.wikimedia.org/T238689 (DStrine) Open→Resolved a:DStrine I'm going to close this for now. Let us know if there are more reports or someth... [17:20:09] (PS2) Ejegg: Removed unused civicrm_get_state function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548570 (owner: Eileen) [17:20:16] (CR) Ejegg: [C: +2] Removed unused civicrm_get_state function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548570 (owner: Eileen) [17:21:24] (CR) jerkins-bot: [V: -1] Removed unused civicrm_get_state function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548570 (owner: Eileen) [17:26:48] (Merged) jenkins-bot: Removed unused civicrm_get_state function [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548570 (owner: Eileen) [17:51:29] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert: some display issues - https://phabricator.wikimedia.org/T238785 (DStrine) [17:52:10] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: First Batch of TY Emails Pushed to Gerritt - https://phabricator.wikimedia.org/T238736 (DStrine) [18:15:05] (PS2) Ejegg: Use CiviCRM DB for civicrm query - this is tested via ImportTest among other things [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548571 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [18:15:43] (CR) Ejegg: [C: +2] Use CiviCRM DB for civicrm query - this is tested via ImportTest among other things (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548571 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [18:21:21] (Merged) jenkins-bot: Use CiviCRM DB for civicrm query - this is tested via ImportTest among other things [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548571 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [18:30:49] Fundraising-Backlog, fundraising-tech-ops: Issue new SSL Client Certificate for tskaff - https://phabricator.wikimedia.org/T238761 (Dwisehaupt) Certificate revoked and recreated. Cert sent via email and password sent via SMS. [18:46:47] (PS1) Mepps: WIP: Added confirmation message and styling [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 [18:51:34] (PS2) Ejegg: Patch db_switcher for RPOW [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548572 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [18:54:30] (CR) Ejegg: [C: +2] "This shouldn't break things when rpow is off. I guess when rpow is on there's the possibility this could do some writes to master while co" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548572 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [18:59:36] cstone: ok, so now there's some undeployed eileen stuff in master [18:59:50] if you wanna just merge the email update feel free [19:00:04] and I think eileen said she'd put a few hours in this afternoon [19:00:14] (Merged) jenkins-bot: Patch db_switcher for RPOW [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/548572 (https://phabricator.wikimedia.org/T237350) (owner: Eileen) [19:00:19] ok thanks ejegg [19:01:42] (PS2) Ejegg: Fix Mailing.load to use UTC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552113 (https://phabricator.wikimedia.org/T238621) (owner: Eileen) [19:01:48] (CR) Ejegg: [C: +2] Fix Mailing.load to use UTC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552113 (https://phabricator.wikimedia.org/T238621) (owner: Eileen) [19:07:20] (Merged) jenkins-bot: Fix Mailing.load to use UTC [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552113 (https://phabricator.wikimedia.org/T238621) (owner: Eileen) [19:14:22] XenoRyet: did you see the response about changing the MAXFAILEDPAYMENT value with an API call? [19:15:02] we'd either have to build that into DonationInterface and use the weirdo integration to run it from Civi [19:15:21] or add the ability to make PayPal EC API calls to SmashPig [19:16:06] which might not be too bad, following the Ingenico model [19:31:04] do you want to give that a shot? [19:38:36] I did see that response. I've got some stuff I need to catch up on, and I think I want to finish out this fraud ticket first, but yea I might take a crack at it if nobody gets to it before then. I think mepps was also thinking about taking a look. [19:39:45] We should also probably think about if we're too code frozen to make that kind of change to smashpig [19:41:04] Actually should probably think about overall priority on that one, given that it's not something that will scale with en6c [19:44:26] If I'm understanding correctly, the only donors possibly affected are those with recurring PayPal subscriptions who's payment methods have been expired for the third month in December. I wonder if there's a good way to figure out how large that group might be. [20:00:12] XenoRyet: for the third month in December? [20:00:17] Fundraising Sprint A Wrinkle in Timezones, Fundraising-Backlog: Monthly convert: some display issues - https://phabricator.wikimedia.org/T238785 (Cstone) a:Cstone [20:00:43] They get the email on the third fail, yea? [20:00:55] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising-Backlog: FRUEC: Debug minor discrepancy in landing page data between old and new pipelines - https://phabricator.wikimedia.org/T236835 (Isaac) I'm not sure if this is at all pertinent, but we spent some t... [20:01:22] yep, but I think it's more like 5 days between retries [20:01:54] Oh, I wasn't thinking it'd retry multiple times in a month. [20:02:06] Just fail and retry on the next occurance. [20:02:13] I guess the only December connection would be that it's nice to get what we can off Donor Services' plate in December [20:06:14] I suppose we could ask DS how often they're seeing these lately. Give us an idea of the scope. [20:20:03] Looks like the first ticket in the chain says they've seen about 100 complaints about it. [20:37:42] (PS1) Mepps: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552331 [20:44:47] (PS2) Mepps: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 [20:48:26] (CR) Eileen: WIP: Added confirmation message and styling, and beginning of class (1 comment) [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 (owner: Mepps) [20:52:47] (PS3) Mepps: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 [21:01:49] (PS4) Mepps: WIP: Added confirmation message and styling, and beginning of class [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552320 [21:02:00] thanks for the comment eileen! [21:37:41] (PS1) Cstone: Add width to monthly convert modal and donate monthly button. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/552341 (https://phabricator.wikimedia.org/T238785) [21:38:50] (CR) jerkins-bot: [V: -1] Add width to monthly convert modal and donate monthly button. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/552341 (https://phabricator.wikimedia.org/T238785) (owner: Cstone) [21:43:42] hmm fr-tech any idea why there would be a smash-pig error for a missing .git directory. it sounds sort of familiar [21:46:55] I do feel like someone ran into that pretty recently, unfortunately it wasn't me though. [21:49:24] Although the last patch merged to DI didn't run into that problem. Maybe just try a recheck to start. [21:50:08] (CR) Cstone: "recheck" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/552341 (https://phabricator.wikimedia.org/T238785) (owner: Cstone) [22:17:55] cstone: oh shoot, it's this: https://gerrit.wikimedia.org/r/#/c/integration/config/+/504917/ [22:18:28] the workaround I've been using for now is just updating the dang vendor directory every time we make a new version of SmashPig [22:18:35] even if we don't need the features [22:37:59] ejegg did I do that before when I updated a lock file, or am I remembering something else? [22:41:55] cstone: yep, exactly that - the lock file and also the vendor submodule [23:19:20] (PS1) Cstone: Update thank you email text. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/552355 [23:19:51] hmm did I cherry pick that correctly [23:29:20] (Abandoned) Cstone: Update thank you email text. [wikimedia/fundraising/crm] (deployment) - https://gerrit.wikimedia.org/r/552355 (owner: Cstone)