[00:00:22] (PS1) Eileen: IDE code reformat to update array() to [] [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553216 [00:00:28] (Merged) jenkins-bot: Add with to .mc-edit-amount for smaller screen resolutions. [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/553211 (https://phabricator.wikimedia.org/T238785) (owner: Cstone) [00:04:06] (PS1) Eileen: Make peace with php storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553217 [00:35:56] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Citibank Import for International donations is not working - https://phabricator.wikimedia.org/T238783 (DStrine) [01:03:16] sorry eileen somehow broke my local civi [01:04:29] it did work the two times i exported before i broke it [01:10:05] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Citibank Import for International donations is not working - https://phabricator.wikimedia.org/T238783 (DStrine) a:DStrine→None [01:47:31] mepps: back online [02:10:29] cstone do you want to talk through the git issue or are you done? [02:10:42] hey I'm still around [02:11:00] cool - probably easier to talk through here than figure out on email [02:11:13] yeah i was just kind of idea barfing there [02:11:26] so your current state is that one of your branches has the wrong tracking branch and / or has commits in it you don't want? [02:11:57] so this commit https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/552900 [02:12:16] is on master but it should have been on deployment, i had the wrong tracking [02:12:29] ah I see [02:12:44] is it now merged to master? [02:12:48] yeah [02:14:35] Hmm - no I'm still confused - that commit is merging master into deployment [02:14:45] which sounds like what we normally do [02:15:14] oh - no it just looks like thatt - sigh [02:15:29] yeah I had the tracking wrong so I wasn't actually on deployment [02:16:51] ok -so if that commit shouldn't be in master then yeah - revert it [02:17:32] then master will be correct will it? [02:17:43] yeah then I can remerge actually onto deployment [02:18:09] ftvvvfvftvtfvf [02:18:16] that was Luke [02:18:26] btvfrvbgbgbtfvfbvfbfvtfvfhygbygnygvygtfvgbdrbnygvvngyvfntfgvvftb [02:19:02] cant tell if Luke or yubikey [02:19:15] Luke does more b's [02:20:11] he is very grumpy because when the power went off all the kids with good parents had working cell phones & got the call to pick up the kids from school [02:20:42] thats crazy that your whole area lost power [02:20:59] im going to head out now, thanks for talking through my git issues [03:15:34] (PS1) Eileen: Strip emojis from imported mailings to prevent fatal errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553234 (https://phabricator.wikimedia.org/T238620) [03:19:51] (CR) jerkins-bot: [V: -1] Strip emojis from imported mailings to prevent fatal errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553234 (https://phabricator.wikimedia.org/T238620) (owner: Eileen) [04:01:06] (PS2) Eileen: Strip emojis from imported mailings to prevent fatal errors. [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553234 (https://phabricator.wikimedia.org/T238620) [04:32:51] Fundraising-Backlog, FR-Smashpig: Amazon RecordPaymentJob is mangled on the way to the damaged table - https://phabricator.wikimedia.org/T239306 (Ejegg) [04:52:23] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, FR-Tech-Analytics: Re-pull old mailings - https://phabricator.wikimedia.org/T239307 (Eileenmcnaughton) [04:56:06] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) Sorry for the delay in responding. Because I was able t... [04:58:39] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM, Unplanned-Sprint-Work: Citibank Import for International donations is not working - https://phabricator.wikimedia.org/T238783 (Eileenmcnaughton) a:Eileenmcnaughton [05:06:13] Fundraising-Backlog, Wikimedia-Fundraising-CiviCRM: Follow up on slow-had-to-be-cancelled query - https://phabricator.wikimedia.org/T239308 (Eileenmcnaughton) [05:47:40] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline - https://phabricator.wikimedia.org/T236834 (AndyRussG) Just did one-to... [06:27:06] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (CCogdill_WMF) Thanks so much for all the digging, Eileen! Looking forward... [13:21:45] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (EYener) This is great! Thank you @Eileenmcnaughton! And thanks for diggin... [13:25:17] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June 2015? - https://phabricator.wikimedia.org/T101265 (Aklapper) [13:25:30] Fundraising Sprint Lou Reed, Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Few/no banners shown on 1 June 2015? - https://phabricator.wikimedia.org/T101265 (Aklapper) @AndyRussG: Hi! Do you still work on this, as you are the assignee of this task? (If you do not plan to work on this task a... [14:47:58] howdy fr-tech! [14:48:07] welcome back ejegg! [14:48:21] thanks jgleeson! Did I miss anything exciting? [14:49:16] ah not too much, the usual :) [14:49:23] ejegg: that's the same question I have for you, eh [14:49:33] i.e., how's the revolution goin'? [14:50:07] the silverpop import has had us scratching our heads a little if you catch up on that here https://phabricator.wikimedia.org/T239126 [14:51:46] wanna* [14:51:59] AndyRussG: well, folks are keeping up the pressure in the streets [14:52:35] I've been mostly watching from the sidelines after the first couple of days, since my dad did finally make it here [14:52:40] I did see some news items articles, and I think even the nyt too [14:52:47] oh glad it did make it ok! [14:52:58] jgleeson: oh wow, that looks alarming! [14:53:03] reading comments [14:54:16] did you check the timing? Was it still uploading when the import job started on the day that it ended up with missing records? [15:00:18] jgleeson: yeah, it looks like it's been finishing later than 9:00 since the 25th [15:01:03] do we have any zombie queries going on frdev1001? [15:04:12] hmm ejegg could it be because of the db restart last night? [15:04:20] we had a db lock going on [15:05:05] mepps they've been late since the 25th [15:05:20] was the lock caused by something that started then? [15:05:44] it was a user query, let me look at time [15:06:28] ejegg it happened around 5pm PT last night [15:06:37] but could restarting the server have stopped the job? [15:07:48] restarting the server could interrupt the queries that build the export, but if it started yesterday at 5 pm that doesn't explain why the job has run about 20 minutes longer than usual for the past 3 days [15:08:32] oh okay, i thought the other issue was that the imported list was too short [15:08:35] we need to look for something that changed on the 24th [15:08:56] mepps the working theory is that it imported a list which was still uploading [15:09:10] because the upload had been finishing around 8:41 UTC [15:09:23] and the silverpop processing job is scheduled for 9:00 UTC [15:10:10] then these last few days the file has been uploading late [15:10:36] ah [15:11:15] ahh, did anyone read the log of the uploader on the 25th? [15:12:09] it starts uploading the file at 8:50:55 [15:12:50] usually takes 10-15 min [15:13:30] at 9:03 it gets a permissions error, and I'm guessing the issue is that the processing job had started in on it at 9:00, had read in 16M rows by 9:03, and deleted the file [15:13:52] the upload process then restarted pushing the file [15:15:09] anyway, we need to either make the export build faster or start it earlier [15:15:28] ejegg: hmmm maybe but would the 16mln or so be read in within that 3 min window? [15:15:51] also, the file I looked at was ~3.7gb in size [15:16:07] jgleeson I'm not totally sure, but we do know that the file was still uploading when the import process started [15:16:45] ah okays, I couldn't see that from the logs at the time although I was just looking at the single days record [15:17:27] jgleeson take a look at 20191125/silverpop_emails_upload_files-20191125-085053.log.bz2 [15:21:38] I can see the permissions errors earlier on in the og [15:21:40] log [15:22:44] hmm, I see the first PermissionError at 09:03:46 [15:23:36] yeah me too, sorry I meant earlier relative to the time period covered in the log [15:23:50] and then the latest upload completes around 9:18 [15:24:42] sorry, i don't understand. when do you see other permissions errors? [15:25:15] I mean I can see the permissions errors in the log also [15:25:19] at 9:03 [15:26:05] oh, got it [15:26:46] looks like the first attempt to upload the file was 8:50 to 9:03 and then the 9:03 job ran until 9:18 [15:27:12] I guess that would make sense 13 mins first time round put up 16mln and then the full job took 15mins for the full 17mln [15:27:29] why is a job runing at 8:50? [15:27:33] I guess it my question [15:28:20] jgleeson there is a parent job that runs first the export generation, then the upload [15:28:53] so when the export generation takes longer than expected, the upload starts later [15:29:23] so we just need to move the start time back a little or move the silverpop console job forward? [15:29:28] the next step would be to figure out what made it start taking longer a few days ago [15:29:38] ah, we could just adjust timing [15:29:50] but I'd like to understand what happened to make it take longer [15:30:04] and speed it up if possible [15:30:05] do you know roughly how much longer we're talking about? [15:30:26] dstrine: is keen to put a plaster on this asap [15:30:51] sorry I'll stop being lazy and check the log from the day before! [15:32:24] hmm, looks like it jumped by 15 min or so on 11/18 and then another 25 min on 11/25 [15:32:46] looks like the daily job takes nearly 4 hours on a good day [15:33:13] so moving it back to a start time of 4am might give us some extra head rooom [15:33:16] -o [15:34:37] I'm using this command to check `bzcat /srv/archive/civi1001/process-control/2019112[0-5]/silverpop_daily*` [15:35:50] hmm it does seem to growing quickly [15:35:56] yeah, moving it back an hour would be a quick fix [15:36:11] but if we can speed it up that would be better [15:36:20] the same job took 3h:30mins the first of the month [15:36:30] so it's moved over 30mins in 25days [15:37:25] 40mins from the month before [15:37:28] :/ [15:38:09] when did we move to python3? [15:38:25] feels like that was summer [15:39:23] ejegg: it looks like we ran into the same problem in september when it was originally starting at 6am so it then got moved back to 5am [15:40:57] moving to python3 actually speed up writing the csv by a half hour or so [15:41:19] so what changed on the 24th? [15:42:39] no tools deploys since a month ago [15:42:44] there's a few commits to fundriasing-tools around that time [15:42:51] ah not deployed? [15:43:24] jgleeson: last tools deploy was on October 31 [15:43:30] ah [15:44:24] I've got nothing but guesses [15:44:44] so let's see what else in the environment has changed [15:44:52] looking at the process-control repo [15:46:10] looks like omnirecipient job loads have increased quite a bit starting on 11/24 [15:46:17] that could be it [15:46:57] does that run alongside other jobs inc the silverpop ones? [15:47:47] yep, looks like it runs every 9 minutes around the clock [15:48:02] it's running on the main db server, but all the changes it makes will be replicated across to frdev [15:48:22] so as all those changes are replicated, they are competing for the db with the silverpop export job [15:51:13] I'll write some of this up on the ticket [15:52:16] OK, so if this is just due to temporary interference, let's bring the import back an hour [15:52:21] err, export [15:58:55] sounds good to me [16:07:07] Fundraising-Backlog, MediaWiki-extensions-CentralNotice: Add category filter to campaign list - https://phabricator.wikimedia.org/T239346 (Ejegg) [16:19:45] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Huge decrease in contacts from the main database update - https://phabricator.wikimedia.org/T239126 (Ejegg) OK, the timing of the upload does seem to be the issue. It was finishing before 9:00 till the morning... [16:22:57] !log shifted daily silverpop export start time one hour earlier [16:23:01] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [16:23:11] thanks ejegg [16:30:58] fr-tech what's the word for scrum of scrums? [16:31:06] anything you need to tell other teams? [16:31:39] no news from the riddermark today :) [16:31:43] :) [16:36:02] ejegg: nothing here for now, thanks! [17:08:20] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog: FRUEC: Detailed comparison of events in old and new log files for banner impression pipeline - https://phabricator.wikimedia.org/T236834 (AndyRussG) Differences fou... [17:26:07] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Huge decrease in contacts from the main database update - https://phabricator.wikimedia.org/T239126 (KHaggard) Thanks @Ejegg I'll update this thread letting you know if the totals look healthy again tomorrow mo... [17:30:13] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Huge decrease in contacts from the main database update - https://phabricator.wikimedia.org/T239126 (Ejegg) @KHaggard since today's upload was late too, this morning's file might still be sitting there waiting... [17:32:09] (PS6) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [17:37:40] (CR) jerkins-bot: [V: -1] WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) (owner: Jgleeson) [17:54:36] Fundraising Sprint X-rays, Fundraising-Backlog: Updated Subject Lines: French, Dutch, Norwegian - https://phabricator.wikimedia.org/T239215 (DStrine) [17:57:52] (PS1) Cstone: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/553383 [18:04:51] (CR) Ejegg: [C: +2] Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/553383 (owner: Cstone) [18:05:29] ok, that first step looks good cstone [18:06:10] thanks ejegg ! [18:23:47] (Merged) jenkins-bot: Revert "Merge branch 'master' into deployment" [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/553383 (owner: Cstone) [18:48:54] ejegg: just turning off the repair job now [18:49:24] eileen: is it all done? [18:49:50] I already pushed the silverpop export an hour earlier [18:50:44] so we should be OK to keep the repair job on if it's still needed [18:50:45] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: First Batch of TY Emails Pushed to Gerritt - https://phabricator.wikimedia.org/T238736 (jgleeson) Hi Camille We've pushed the latest updates from this [[ https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraisi... [18:50:57] ejegg: the repair job is done [18:51:25] I don't know if any more backfills will need to run but the repair can be turned off [18:52:13] (do you want to check the commit - I just commented out the scheduled line so I don't know if we need to check things like that) [18:52:52] oh, great! [18:57:13] !log process-control config revision is b95355c0c0 - repair omnirecipient job off [18:57:17] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [18:57:34] ejegg: I wouldn't change the time back just yet though [19:01:28] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) OK here is the full ttable +-------+------------+----... [19:03:57] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) OK here is the full table +-------+------------+-----... [19:04:53] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) [19:10:10] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) | id | hash | scheduled_date | sent | n... [19:14:11] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) SQL for the above ` SELECT id, hash, scheduled_date, s... [19:22:00] dstrine where did we get to on CT team contract (I'm seeing them getting some extra funding for form builder & want to make sure they have our work scheduled) [19:22:52] eileen: mepps is processing the contract now. should be done soon [19:23:02] cool [19:30:24] fundraising-tech-ops, Operations, ops-eqiad: (ESCALATED Need By: 11/26/19) rack/setup/install frdb1003.eqiad.wmnet - https://phabricator.wikimedia.org/T239139 (Jgreen) [19:30:41] fundraising-tech-ops, Operations, ops-eqiad: (ESCALATED Need By: 11/26/19) rack/setup/install frdb1003.eqiad.wmnet - https://phabricator.wikimedia.org/T239139 (Jgreen) changed the IP from 10.64.40.100 to 10.64.40.118 [19:35:41] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) Notes - The ones in Apr 2018 & May 2018 are too earl... [19:37:03] fundraising-tech-ops, Operations, ops-eqiad, Patch-For-Review: (ESCALATED Need By: 11/26/19) rack/setup/install frdb1003.eqiad.wmnet - https://phabricator.wikimedia.org/T239139 (Jgreen) [19:39:39] (PS1) Cstone: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/553400 [19:43:07] dstrine: the updates to the thank you pages are on staging. I added a note for camille on the ticket. Once they're green lighted they can be deployed! https://phabricator.wikimedia.org/T238736 [19:53:45] (CR) Cstone: [C: +2] Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/553400 (owner: Cstone) [19:55:09] Fundraising-Backlog: Dynamic 3DS - https://phabricator.wikimedia.org/T239361 (EMartin) [19:58:20] (Merged) jenkins-bot: Merge branch 'master' into deployment [extensions/DonationInterface] (deployment) - https://gerrit.wikimedia.org/r/553400 (owner: Cstone) [19:59:28] is anyone able to review this - https://gerrit.wikimedia.org/r/#/c/wikimedia/fundraising/crm/+/553234/ (a couple of format PRs queued with it too) [20:00:01] (CR) Jgleeson: [C: +2] IDE code reformat to update array() to [] [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553216 (owner: Eileen) [20:00:36] (PS1) Cstone: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/553403 [20:01:14] eileen: just finishing off a test of my own then will take a look [20:05:21] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Huge decrease in contacts from the main database update - https://phabricator.wikimedia.org/T239126 (KHaggard) Hey @Ejegg I manually ran the import job again so it should be out of the way for the new file tomo... [20:06:01] (Merged) jenkins-bot: IDE code reformat to update array() to [] [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553216 (owner: Eileen) [20:08:05] (CR) Cstone: [C: +2] Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/553403 (owner: Cstone) [20:12:16] (Merged) jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - https://gerrit.wikimedia.org/r/553403 (owner: Cstone) [20:13:27] (PS7) Jgleeson: WIP: add contact_id filter to wmf_eoy_receipt module [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/552089 (https://phabricator.wikimedia.org/T238691) [20:14:34] !log payments-wiki revision changed from 2eb54fd6ef to 06a8c3cdff [20:14:38] Logged the message at https://wikitech.wikimedia.org/wiki/Server_Admin_Log [20:14:47] (CR) Jgleeson: [C: +2] Make peace with php storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553217 (owner: Eileen) [20:20:16] (Merged) jenkins-bot: Make peace with php storm [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553217 (owner: Eileen) [20:21:07] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10): Monthly convert: some display issues - https://phabricator.wikimedia.org/T238785 (Cstone) @spatton @EWilfong_WMF I just deployed an update to this. I didn't make... [20:23:08] eileen: I didn't even know you could have comments in patterns! [20:23:34] lol jgleeson I copied & pasted that code [20:26:22] hmm I was trying to test it here with the emoji icon https://regex101.com/r/jdiYTI/2 [20:29:22] actually I guess that isn't encoded [20:38:08] yeah - the test actually fails without the change so that was my check [20:38:41] but I don't know why it doesn't work there [20:39:05] I also don't see the emoji in phpstorm [20:39:11] did you see it? [20:39:21] eileen: [20:39:31] yep I do [20:39:58] did you change the encoding? [20:40:55] https://usercontent.irccloud-cdn.com/file/skq8W2f5/Screen%20Shot%202019-11-28%20at%209.40.40%20AM.png [20:41:09] I didn't do anything for ^^ - it just worked [20:41:16] spooky [20:42:03] so do you see it here though? https://usercontent.irccloud-cdn.com/file/GsXewoqP/Screen%20Shot%202019-11-28%20at%209.41.42%20AM.png [20:42:46] yeah I see it there [20:43:33] tricksy emojis [20:44:02] just xdebugging the test to see what that does [20:45:02] cool email \uD83C\uDF3B\uD83C\uDF3B\uD83C\uDF3B\uD83C\uDF3B\uD83C\uDF3B [20:45:15] that's what xdebug is seeing [20:45:53] looks like the utf for sunflower is U+1F33B \xF0\x9F\x8C\xBB sunflower [20:46:47] https://apps.timwhitlock.info/unicode/inspect/hex/1F33B [20:50:11] (CR) Ejegg: Add with to .mc-edit-amount for smaller screen resolutions. (1 comment) [extensions/DonationInterface] - https://gerrit.wikimedia.org/r/553211 (https://phabricator.wikimedia.org/T238785) (owner: Cstone) [20:59:58] eileen-eating: test is passing for me but I'm wondering what that's checking [21:00:23] I was expecting something to step into the _omnimailing_strip_emojis method at some point [21:01:37] it looks like the subject is being compared to the mock response [21:02:00] do we test that the replacement happens within this somewhere that I can't see? [21:03:43] I'll +1 the patch and let someone else just confirm as I have to jump off now. Sorry I couldn't be more help! [21:04:21] the test is passing for me, I just don't know why I don't see the emoji or whether or not the method which strips them is being called [21:05:12] (CR) Jgleeson: [C: +1] "Test passing for me but can't confirm _omnimailing_strip_emojis method is working (possibly not tested?)" [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553234 (https://phabricator.wikimedia.org/T238620) (owner: Eileen) [21:09:34] ah it's replaced on insert & that inserts gets a db error without the strip [21:09:56] ie the load test not the get testtt [21:43:04] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) request xml for above ` (PS1) Eileen: IDE code reformat - fix array() to [] [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553419 [22:12:44] (PS1) Eileen: Fix a bug in omnirecipient load on new jobs [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553420 (https://phabricator.wikimedia.org/T236855) [22:28:12] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Old donation with new Endowment appeal - https://phabricator.wikimedia.org/T238876 (Ejegg) Huh, yeah, I see some civicrm logs tagged with your client certificate for that day, but nothing right at that time. I'... [22:28:54] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Huge decrease in contacts from the main database update - https://phabricator.wikimedia.org/T239126 (Ejegg) @KHaggard confirmed, the upload directory looks empty via SFTP. [22:31:22] (CR) Eileen: "Just to clarify - the emoji strip-routine is tested in the LoadTest - the get action leaves the emjoi untouched but the Load action saves " [wikimedia/fundraising/crm] - https://gerrit.wikimedia.org/r/553234 (https://phabricator.wikimedia.org/T238620) (owner: Eileen) [22:32:02] So here is what I don't like about gerrit - the comment discussion is kind of the most important part & it's really hidden in the UI [22:32:57] a decent threaded discussion UI would make all the difference to my feelings for gerrit [22:40:03] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint X-rays, Fundraising-Backlog: Old donation with new Endowment appeal - https://phabricator.wikimedia.org/T238876 (RLewis) @Ejegg I do use the import function to import our Engage files, Benevity files, Citibank donations etc. Is that what y... [23:26:05] Fundraising Sprint A Wrinkle in Timezones, Fundraising Sprint Visual Basic Instinct, Fundraising Sprint X-rays, Fundraising-Backlog, and 2 others: Email Data Audit / Data Capture - https://phabricator.wikimedia.org/T236855 (Eileenmcnaughton) So I re-retrieved the date range between 25-Sep-19 & 28...